From: Jinjiang Tu <tujinjiang@huawei.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: David Hildenbrand <david@redhat.com>, <muchun.song@linux.dev>,
<akpm@linux-foundation.org>, <mel@csn.ul.ie>,
<lee.schermerhorn@hp.com>, <andi@firstfloor.org>,
<linux-mm@kvack.org>
Subject: Re: [PATCH] mm/hugetlb: fix set_max_huge_pages() when there are surplus pages
Date: Tue, 4 Mar 2025 21:44:35 +0800 [thread overview]
Message-ID: <c2c3d8b5-4b99-220e-20e0-e4a9dd8f5ecf@huawei.com> (raw)
In-Reply-To: <Z8AD4p4jVxbDtUbR@localhost.localdomain>
在 2025/2/27 14:19, Oscar Salvador 写道:
> On Thu, Feb 27, 2025 at 11:11:25AM +0800, Jinjiang Tu wrote:
>> The result with this patch:
>> Node 0 Node 1
>> Total 5 0
>> Free 0 0
>> Surp 5 0
> Why would node0 have any surplus pages?
>
> Also, this does not reproduce in my machine.
>
> Are you overcommitting? Are you using the hvo optimization?
> If so, it might be that we cannot allocate vmemmap pages and those
> hugetlb pages stay in a surplus state?
>
> >From bulk_vmemmap_restore_error():
>
> * If unable to restore a hugetlb page, the hugetlb
> * page is made a surplus page and removed from the list.
So surplus pages may be free pages and not reserved. In this patch, we
shouldn't subtract surplus_huge_pages from min_mount, otherwise these free
pages will be subtracted twice.
>
>
prev parent reply other threads:[~2025-03-04 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 14:19 Jinjiang Tu
2025-02-26 15:57 ` David Hildenbrand
2025-02-27 3:11 ` Jinjiang Tu
2025-02-27 6:19 ` Oscar Salvador
2025-02-27 7:06 ` Jinjiang Tu
2025-03-04 13:44 ` Jinjiang Tu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2c3d8b5-4b99-220e-20e0-e4a9dd8f5ecf@huawei.com \
--to=tujinjiang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=david@redhat.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=muchun.song@linux.dev \
--cc=osalvador@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox