From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 681D4C3DA6E for ; Thu, 28 Dec 2023 20:43:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA2B76B00F8; Thu, 28 Dec 2023 15:43:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E52CA6B00F9; Thu, 28 Dec 2023 15:43:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D41696B00FA; Thu, 28 Dec 2023 15:43:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C52106B00F8 for ; Thu, 28 Dec 2023 15:43:34 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 96F0A1C11D4 for ; Thu, 28 Dec 2023 20:43:34 +0000 (UTC) X-FDA: 81617402748.20.A4ED694 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf28.hostedemail.com (Postfix) with ESMTP id CE5ECC001E for ; Thu, 28 Dec 2023 20:43:32 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=sIhiuZdJ; spf=pass (imf28.hostedemail.com: domain of rientjes@google.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703796212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FuWAr1LFb8yGIvyDQdiCDLS5Dz8Fcnn8SIF/MmaVoyg=; b=PRnVxmPB2D0d5s9C2sx3f2ewt7dqYL4sPRUSHoex4P5vadBRswZ4GA4CqyKpSTAdWT/IVx Pw5hLoI/GDmnubSStmM0zeMhAa3ahl8fjTE2b8DQ6ynywK8DrllJ/LqqQx2xH0+29kYn4k +pkMyeTYq86rHJiiKa96mBDjmFqtzwU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703796212; a=rsa-sha256; cv=none; b=j9yERI0cva0MZh/dtdA/yMHmk4oMSOPmAN5HJSdFBzvNNG+2a5x2lY5sAdLMXqbcAH3fO1 1QSPaMZ2c3d6FtlCmdn5sYv78bJwfPRsejFGnRy056V95iDW1Uf6qnX2X/IfBcEyhdOhWU AuIjBkvdg6Rgi5urZxed2VV/zTK6YN4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=sIhiuZdJ; spf=pass (imf28.hostedemail.com: domain of rientjes@google.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1d42ed4cdc7so572865ad.0 for ; Thu, 28 Dec 2023 12:43:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1703796211; x=1704401011; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=FuWAr1LFb8yGIvyDQdiCDLS5Dz8Fcnn8SIF/MmaVoyg=; b=sIhiuZdJnt75gPRvwAUG6MS6ypzy6DgOzSqryuG4zHJPDgiUr2rkgfkIsil9Rs4VVu FkcU1Hi6ZUFW4j+/q2grJEys/e3D2iORpboRMXb8yZYVlY2Ta5kUEmhybxlHMuEejSpz JYm7y/LZZSj7TbdSCabWfSghqVkWce6l3MPls6czYIfFUQtYCwKt7HuJ32ZXgqmuUf8D +bUq0RX7pbCwJApkGhiFegZw8T0KDIZT9qCtZuNNF+X3x9bW8cbaFmZtquMNIBC+/3HX 8vbobuF6QKuyFmSPVgQAzCIduYHSI/k2nJL1306qFhYOt8YifgA1Ijl8+Qo+lIwjmXFD YDfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703796211; x=1704401011; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FuWAr1LFb8yGIvyDQdiCDLS5Dz8Fcnn8SIF/MmaVoyg=; b=LVUBxMXVCEBq21RQvkbSMF5xqMnqLtOA7ki4qzcGdiArwnS0BmePjaNDsnxWSoO39H gXb8vDi83sJG/HrYDxsDfm75oFiOz5beXrj4ctd60ATz5woM9I83mLtPC67Uqe13Encs yN9uF3sBaWET0tIhPvgDtd1d0B4k2ewlZM8LxBfxElK8uJDJ4TK50Ma/APC/k61cfBKE Zx9NkTX7DWvFuiqsL6iYGOdAvnP8QiOZhp/lAe+Zyj126eMxhv4K/29WmN6GZWYSJ1LJ x8OnwGrAWjHvhJHuuNWxjJo2s6oP2/9CqNNqS1YCtAEzb2HmJd8V8DV1qYWBRzfN/But LR7w== X-Gm-Message-State: AOJu0YzsJqFp3FPL0pqwZXyMV+c+VNx0ST/TpFwgJ84rCGy9/NYBo7XM qMyF0C29mEawa22yrGmmjQsAMknhqHSq X-Google-Smtp-Source: AGHT+IE9NYwxoWhXKOvsAaJeVvsMfZ5eSVNTx5QbyFf9LmfqhNBxrOnZWJtiCrJ++mVStkr/lkXTjA== X-Received: by 2002:a17:903:2094:b0:1d3:fd5c:4d63 with SMTP id d20-20020a170903209400b001d3fd5c4d63mr729722plc.1.1703796211447; Thu, 28 Dec 2023 12:43:31 -0800 (PST) Received: from [2620:0:1008:15:5eb6:dfb2:ff4b:8b64] ([2620:0:1008:15:5eb6:dfb2:ff4b:8b64]) by smtp.gmail.com with ESMTPSA id w2-20020a654102000000b005c21c23180bsm11305956pgp.76.2023.12.28.12.43.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Dec 2023 12:43:30 -0800 (PST) Date: Thu, 28 Dec 2023 12:43:30 -0800 (PST) From: David Rientjes To: Pasha Tatashin cc: Andrew Morton , Linus Torvalds , Greg Kroah-Hartman , rafael@kernel.org, surenb@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, souravpanda@google.com Subject: Re: Sysfs one-value-per-file (was Re: [PATCH] vmstat: don't auto expand the sysfs files) In-Reply-To: Message-ID: References: <20231211154644.4103495-1-pasha.tatashin@soleen.com> <3d415ab4-e8c7-7e72-0379-952370612bdd@google.com> <13e5fbd4-d84d-faba-47f1-d0024d2c572d@google.com> <20231227104244.824b0977ae6d4bb6b37f6f79@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: CE5ECC001E X-Rspam-User: X-Stat-Signature: zbnmgqqadz5rg5abifb4yktnxkbijjji X-Rspamd-Server: rspam03 X-HE-Tag: 1703796212-573249 X-HE-Meta: U2FsdGVkX1+8eg6HLCVHu+bsrkBdv4DrdE7aCvwr95AbP/41vjVtf0YOikKMO7MNGR3pclRzapyPqvaB1sIF5qUZai81WG1457TwjtbUi+tZKbyGmyTyquqvAQlNOsan54c4dhIFXwZOyx3BhgTpqH2LN4HEAqiPdt1EE/azDlcareu7BMo2ET05AeGtA0u3HX+7zAPMm5Y61tmBf1/ZHsaVHyT3dJ0GasYlZumuubxDAETe6og1In8hVVQAZaxU7r4CcQni6zBo69tqXAXkYHdW4iu7DZns0NyGYCHawM+PJxO4/SQ9gyYIW/KG+qZFJgKlzRB3XPcAfDxJwRIQN3bBCkgDcuWxccYB/nnQ7NBoKmTUu0mPDRfvtGNtZS7DdMTsc+0+oNnupXEaYwjw9nuSTkTXw6+B+dDkblKWDSWxJGw/nKUDlCze7PfB1qpuAdm/YuRbpJsBO21ZYwLhiCx22u6w9e+iYb5ECfyj6+UimnM7jEnflwsXip01ukn0n3C0Xx3thZlb9jz3ke7Zq5Sw/IsIppK1sAjtlZOy50sJGLM2c9+4OjTlUnsJzuzyOBzSskEZM+MDwAV8kzG0udX4YQeV46bxinO4gq4wYlP4XKo6eM8Sh9laAXXpM1J5hNFPHap/SJHhM4/os3RimkSAxNlwH5bCL9OQiCqhx82ZEszeVu3CDLrXAf1VCHyNwMf5qaFlHX7s2sNXDrYAEzz5gOtRQ7Q4AfUrfSqyYb9QMHGEdnz0Y7ujG5Bi5c1KMN4SaBuLZM3bNCx9+WvXd+Ocq3P2/7cl2iDGXKX2G2nHCdRyEAoPl3fcA0ltTIUjuqnEulXLr15HjwptEZCeewdQuVfxzz9hmv6tN62IAO2TCeR07PM0SvrhXn07Q3fBWzwNT9lpmDVvRIFjBUdHd2eWNU0OpDnja0B+IbXAy8ZbWTkfxc5t0LBRzJvSzocOEIP7OQXLDOWAX5QVbxU xoD1MIF3 b+fIMVurBS+tBI08HyUmH+UjeM5Vo7UY4YMxQJUwwudW1OCLVRjvRnpzmF6dF+tMAmr2KaoffnxdJNimJi5+wxxvb48Q4mnc3IrIh+PWyQwp4bL7iNGMKV/uKvhTq4SxrL+k20CrQcRj0Ch9qEjZhNY9GWyDB6MgHhbo1uRn1UsLFgGyJwuha6yAHjkUP/45YWd7sYjN8Rfepzmk1Oe7d0yuFe1sBL2c1Sv3H9twqoXfcloUUao0aq1e6iH+HwaFFPZdbo321uLKdTcUEY7mnZZOBLAhsYg8B7lPk4wnfvdL5kbTg84+y7ZUZsT3zmDSEtFx8pDBCYME8+IqnlbAHwntFwDZl0oPd5P1PLRIp7SwKuTbzL5RW2LOM1MvurcK0D1V0dYonfAp4HJzoVriiJC4/xw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 28 Dec 2023, Pasha Tatashin wrote: > > > But for existing files and conventions, I think we should settle it as > > > "keep doing what you've been doing for 13+ years" and don't force this > > > argument every time a kernel developer wants to just add one more stat. > > > > Absolutely. Let's do what makes most sense. For new things, one value > > per file. For stats which logically group with other existing stats, > > do whatever the existing other stats are currently doing. > > The intent of "[PATCH] vmstat: don't auto expand the sysfs files" is > to do exactly this: keep the current fields in > /sys/devices/system/node/node*/vmstat as-is, but prevent future fields > added to node_stat, numa_stat, zone_stat from showing in vmstat. > This is the opposite of what Andrew and I wrote above. There should be no need to start preventing future stats from being grouped together in vmstat if it logically makes sense. NAK.