From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41B6AC00140 for ; Fri, 5 Aug 2022 18:25:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB87D6B0071; Fri, 5 Aug 2022 14:25:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6C336B0072; Fri, 5 Aug 2022 14:25:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B31338E0001; Fri, 5 Aug 2022 14:25:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A64C86B0071 for ; Fri, 5 Aug 2022 14:25:42 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 81C8E1A06B5 for ; Fri, 5 Aug 2022 18:25:42 +0000 (UTC) X-FDA: 79766367324.08.889D120 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 5F88A40126 for ; Fri, 5 Aug 2022 18:25:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659723941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5gbZS7QF09rE8ScpjrsJlHIn7pEqxX+BCCZXbzG+bY8=; b=YKrYX+aB61cSWHog3odUPyOdrxA2Vh9xXeGtN8CoZHFAwOIk/w2B8t0/+daALrZfXaCS+9 SKCAEpMALNrE28y/RIYexWiRI85caU1MNqdy5EPb9ImkGTny6KOYS1s0V9IN6O7jPuvovB 7ZFkzs6FKrN619B/MN3IjB/0ziO9ZTI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-662-6CFMgArQOmGdPvs9O2eBQQ-1; Fri, 05 Aug 2022 14:25:40 -0400 X-MC-Unique: 6CFMgArQOmGdPvs9O2eBQQ-1 Received: by mail-wm1-f69.google.com with SMTP id n30-20020a05600c501e00b003a3264465ebso3586687wmr.1 for ; Fri, 05 Aug 2022 11:25:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc; bh=5gbZS7QF09rE8ScpjrsJlHIn7pEqxX+BCCZXbzG+bY8=; b=3ZT25oBtcR//FiZ7zU5xy1zEz1fyKz2EcD2orWQ34xB5it9PMF+bupW6KHgXdU/X12 N4q3Xak4Spz5d13yVtMhPUch81YTH0ODPl1VCHIKC67ycJr1R5xG2eWt5RSMSlig+gA7 ql6OfALYS2jQ3HLvP9qZjDG4BdoevD9DeJSsuBvQEuxAkuiTHhRlYRZKg5mB1Lgxp0wW N3mrLnPEkZDPuR8PgacZMIrz9wI04+k0EN5IA4OrhREQyYl47GRjVGaqk6jPXZ5aHnnk 8nGaV9cpZMABfOGwIsGUQn2aitzHlxcTgpbm1OXpqLmduapkXHnsac2Kv7q9nEEbyCkh 4JQA== X-Gm-Message-State: ACgBeo13S3r8et7o8fY1RPPIESiKF1mTpAuj0dmkldVdgOoQzz+C8MjE 2GSL6DOumXhx1d2fYCO6BDT1AAAtNYQNns/An3KGgZJSLzGlnmoqIfkfOt1MjznbFBXXF1GyKAg fO3tCGyAZjo0= X-Received: by 2002:a5d:595f:0:b0:220:619d:da07 with SMTP id e31-20020a5d595f000000b00220619dda07mr5039733wri.10.1659723939387; Fri, 05 Aug 2022 11:25:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR7LHyYXq3T7uBDEmcodrtgkrkt4qPFOx+H0sFCOo3qbsgD8PcEUXT31a6r/ZIVw1aJCZtgxIQ== X-Received: by 2002:a5d:595f:0:b0:220:619d:da07 with SMTP id e31-20020a5d595f000000b00220619dda07mr5039725wri.10.1659723939149; Fri, 05 Aug 2022 11:25:39 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:fb00:f5c3:24b2:3d03:9d52? (p200300cbc706fb00f5c324b23d039d52.dip0.t-ipconnect.de. [2003:cb:c706:fb00:f5c3:24b2:3d03:9d52]) by smtp.gmail.com with ESMTPSA id f5-20020a5d58e5000000b0021eed2414c9sm4409875wrd.40.2022.08.05.11.25.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Aug 2022 11:25:38 -0700 (PDT) Message-ID: Date: Fri, 5 Aug 2022 20:25:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 1/2] mm/hugetlb: fix hugetlb not supporting write-notify To: Mike Kravetz , Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Muchun Song , Peter Feiner , "Kirill A . Shutemov" , stable@vger.kernel.org References: <20220805110329.80540-1-david@redhat.com> <20220805110329.80540-2-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1659723942; a=rsa-sha256; cv=none; b=PcQ6NJ9DvecHsJJv+MesKkZ9YYNzIuvZ+KOnrxR/+NFpZy7NPXMziw1st5kU4rCtcpzloy hHL/U4//KLCGPRi1BpTPbxQHLf9yIFPLdJb4NB/3A6M/Nx31BasZBAntL+RRSdiYDG0yBl M6u7tCqIWQWUtazcF0WVRqM5TEKrX3Q= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YKrYX+aB; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1659723942; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5gbZS7QF09rE8ScpjrsJlHIn7pEqxX+BCCZXbzG+bY8=; b=6XugVYCnl0pqracB/pHF1FDyAEtv+pxHM9B7JcaU6WCz7sjrAr9tPYnHMxIN4N51BB0AaQ kFrxQ08nawGEp8D02z4vgrZK4JzuP5BflK8My9np+sYI4c88D49onHsn+oCWK8vZPhb9MK qVpH2fpwk9i1PiiuS7htPo8TeoZPnZw= X-Stat-Signature: x9ojwuh1z5c9jece9watwjk8urpxyr5q X-Rspamd-Queue-Id: 5F88A40126 Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YKrYX+aB; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1659723941-281270 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 05.08.22 20:23, Mike Kravetz wrote: > On 08/05/22 14:14, Peter Xu wrote: >> On Fri, Aug 05, 2022 at 01:03:28PM +0200, David Hildenbrand wrote: >>> diff --git a/mm/mmap.c b/mm/mmap.c >>> index 61e6135c54ef..462a6b0344ac 100644 >>> --- a/mm/mmap.c >>> +++ b/mm/mmap.c >>> @@ -1683,6 +1683,13 @@ int vma_wants_writenotify(struct vm_area_struct *vma, pgprot_t vm_page_prot) >>> if ((vm_flags & (VM_WRITE|VM_SHARED)) != ((VM_WRITE|VM_SHARED))) >>> return 0; >>> >>> + /* >>> + * Hugetlb does not require/support writenotify; especially, it does not >>> + * support softdirty tracking. >>> + */ >>> + if (is_vm_hugetlb_page(vma)) >>> + return 0; >> >> I'm kind of confused here.. you seems to be fixing up soft-dirty for >> hugetlb but here it's explicitly forbidden. >> >> Could you explain a bit more on why this patch is needed if (assume >> there'll be a working) patch 2 being provided? >> > > No comments on the patch, but ... > > Since it required little thought, I ran the test program on next-20220802 and > was surprised that the issue did not recreate. Even added a simple printk > to make sure we were getting into vma_wants_writenotify with a hugetlb vma. > We were. ... does your config have CONFIG_MEM_SOFT_DIRTY enabled? -- Thanks, David / dhildenb