From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C32EDC4345F for ; Thu, 25 Apr 2024 07:58:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CE4F66B0088; Thu, 25 Apr 2024 03:58:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6CBB6B0089; Thu, 25 Apr 2024 03:58:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B34036B008A; Thu, 25 Apr 2024 03:58:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9312B6B0088 for ; Thu, 25 Apr 2024 03:58:42 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 05931120437 for ; Thu, 25 Apr 2024 07:58:42 +0000 (UTC) X-FDA: 82047302484.17.542AD3C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf29.hostedemail.com (Postfix) with ESMTP id E08CE12000A for ; Thu, 25 Apr 2024 07:58:39 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714031920; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j+kgQAGyZ7byY0/IZKZVQ40YC7wWHjNWj4w9cCEzQXQ=; b=C9MyHV6n3mvc3vyvsVTEZPlDiXstjqTvhuKH0+lmQTo854BsQjkou89QZ2XPcF6wgClwAJ zkOJsmNV7mLPPL3xkFuBnCYVNkVbnLsMnzLMPuDL3+Q3FsGKIrbqAFu5V77yN0G03hN63Z Je6EFLkgsPLsmJ6PGfeF5O3yJ5dtvdU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714031920; a=rsa-sha256; cv=none; b=Zs/ZClay5faEPz/3sK9tSEiNBOpBRsDMl9UjtDzEZLvoQjrJ45tekWmlK+LV0ZJO/JBZmd He9i49hddWliMFYYbnI3Hr5oG+IloKTuuM1hlB2hisjx35N/Ey1dib50TgYfRFmigfOBSE lqJMIa9VkfvPi1O92KZI+XSTKtl5JJE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf29.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 071E62F; Thu, 25 Apr 2024 00:59:07 -0700 (PDT) Received: from [10.57.75.12] (unknown [10.57.75.12]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2CC9B3F64C; Thu, 25 Apr 2024 00:58:38 -0700 (PDT) Message-ID: Date: Thu, 25 Apr 2024 08:58:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: add more readable thp_vma_allowable_order_foo() Content-Language: en-GB To: Kefeng Wang , David Hildenbrand , Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org References: <20240425035108.3063-1-wangkefeng.wang@huawei.com> <5bf467d3-f596-4986-9e27-f2707efbe6a3@redhat.com> <8dc0a47d-0cb1-4e89-8b9a-083921b22f68@huawei.com> From: Ryan Roberts In-Reply-To: <8dc0a47d-0cb1-4e89-8b9a-083921b22f68@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: g5gpzqkt9djnwqm85o86ydx37ngouo8u X-Rspamd-Queue-Id: E08CE12000A X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1714031919-711828 X-HE-Meta: U2FsdGVkX18Bal/WQA01zm4wdH/MPbf46Z+qDuhcYBZFZvyvQ/5kpOuGM+rFULEQDCD3h1sp4EhN18ugmThOteKl/I8mAZTZOdISCJ0vmGJ3RKtPnXzsReKaDrXLDY5GE1W2M0j+Drx0nGgFI0BG5+D9slP6EuLx4hp2nDEAQP+s+OVqMgAnsrff90fCFzg71L3AZZu2ca+dcb0K/EZ+7nIlQM+05Z3OXVM6GcSm0qvGFa8BhFDZS+o9WTmQaJf7+TLAVIySkvqj5iBWrpUJ4Rgj8stSBzM6pjRhIFEwVUdgaAsL778GNLznTr4wqe+mnHr2bGTNhARv5PvFU/Pg+y4IK1LqJzLswvCO1Fn+XnimNPTxI6fKz+LDJylEM/ex2Vafj7buBT/Jaz7clJBVn2aoIAuzS4DXjfSFUorIa2odoDCA1JQStwchIbmywJmCG8hnt5vzxjIpZjijHzGsMJDasaHY+zWz/rc+goWY7woUKrg/WMKjALMa9J3jwKz2q9O1SMDJ+c8vES1P3jA/moMASS104EOj6Ene75Vn3jWRJ8IYpUrIgqsaVXZU3NiaYsJTsYaqIQlznX/tXq6lDO+qi8+Yo+IDZk/mL+qF23SLc6xoKuKN8KR1P4dIoegxJkbyoVhN/b0mvuJzeZUnhQo/Hros7UrfOKX3cA7zOGKN/jatY0WvpVfGGis7Of3ol0Ee6DRJfr2TwiYflUuGRfKfcovedWQgIAcojevQvNnL3013Zwd1LCZ7r8db7MFVyUjFG6XTr38T87gf0M9yssdcryvvtYx4NYZOJSu3oomm2utM9ZHYwtiszWeen2mSF+G8+s9OUc+ZOFBMRkuIKONAbtMYn9On1COWhCy33slJjpSFiBujlYXnidkUhKydcIFBew/LHVLdrSf/LG9jWZUsMpmLy1gGGpUodVtTmqmt9fIN+0UoWk8E9l1YOkWaDLwy9XNaIKoNEzmWCzR JUD3B6R7 Oj0BfsxXMXtrwbKvWruh5OQuPNAmcp11I5OLDRxcJDXM6l8i3wiQrCa+7jDTeTvzxNfiF4KUswXgiEI4yNg+KRaPLSFqXnPBpxFpIJM07d1mqhgm/rD5CZ1oz4+A9hFz/WfshBnmrKt+UD9/gAxAMZ/B4TYOeisKhRTO3GaZze1HOGX32Q3cq4oE2YopWlPh6Xedq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25/04/2024 08:37, Kefeng Wang wrote: > > > On 2024/4/25 15:22, David Hildenbrand wrote: >> On 25.04.24 09:18, Kefeng Wang wrote: >>> >>> >>> On 2024/4/25 12:00, Matthew Wilcox wrote: >>>> On Thu, Apr 25, 2024 at 11:51:08AM +0800, Kefeng Wang wrote: >>>>> There are too many bool arguments in thp_vma_allowable_orders(), adding >>>>> some more readable thp_vma_allowable_order_foo(), >>>> >>>> Here's an alternative approach I came up with and forgot to send out. >>>> I take no position on which is better. >>> >>> Always confuse, either way is fine, even combine the two way, let's see >>> Ryan/David's option. >> >> It's shocking how Willy and I sometimes create almost identical patches ;) >> > :) >> I played with the same flags idea during mTHP bringup. >> >> And I think I prefer the flags version. Yeah, FWIW, I prefer the flags approach too. >> > OK, wait for Andrew to pick it