From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 074ABC83F07 for ; Mon, 7 Jul 2025 07:30:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A24806B0324; Mon, 7 Jul 2025 03:30:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FC4C6B0325; Mon, 7 Jul 2025 03:30:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9126F6B0326; Mon, 7 Jul 2025 03:30:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 83AC76B0324 for ; Mon, 7 Jul 2025 03:30:17 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 517D5B945E for ; Mon, 7 Jul 2025 07:30:17 +0000 (UTC) X-FDA: 83636645274.18.6B32827 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id E6F0C40012 for ; Mon, 7 Jul 2025 07:30:14 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QecbfRfn; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751873415; a=rsa-sha256; cv=none; b=HERDE7lGfhCXatzUQ6qQK8LJueIE8pc23GL05V3Sf1AOxM22EnR7fTkEKTYoWhqeeBVlEs Q4amJFFIAbqLWrBU/SlPXhFJ3hEeDb3jIU2BxiGY26btLGUZ1h/5itE+4oCzLgyQwihU9L Z+tEqXgc8IDBV9PPveFroQfOO/Ofcys= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QecbfRfn; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751873415; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IEmUGUoP/avhzVo01ZX3tJQ9D8xg/B8atIijwjnlXi0=; b=gyUDJoagKzQVCuBHg4msAkAuJB6aYm36qJ97aLk94F6JldggPVsdIodbsUc2q+6xou6qMZ XF4uGY9tbKqH/Iutf9uWwrlZEyhQA05wNCxPMIekO/bdIqMbDu+pJVaWpjmCKimSA6FHmo wwcyOqYv1QRgECOZivxgmzlgfJPEsDE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751873414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=IEmUGUoP/avhzVo01ZX3tJQ9D8xg/B8atIijwjnlXi0=; b=QecbfRfnDVZBbFfCqzZ0kiGZosr6UDv28sGaejK9WLVLBiezJ8RadmOdrHHMvTm4aAktYS ubr482uPOK5C7WEBXJsfbhbZ87NayaaaCxv1fsjWgLObgYpbvyojFzkyEa57/MMHZkoNb7 XxcwYANg3/eRDlYeKB8c5zW0lMPVt7s= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-Efvx6WarOIOJ2aZ7wrukMA-1; Mon, 07 Jul 2025 03:30:13 -0400 X-MC-Unique: Efvx6WarOIOJ2aZ7wrukMA-1 X-Mimecast-MFC-AGG-ID: Efvx6WarOIOJ2aZ7wrukMA_1751873412 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-451ac1b43c4so15363075e9.0 for ; Mon, 07 Jul 2025 00:30:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751873412; x=1752478212; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=IEmUGUoP/avhzVo01ZX3tJQ9D8xg/B8atIijwjnlXi0=; b=eo941oiThJqbNWmNRpavowZDyHRJcwgbNr3XNci51BboUW6bVfll7EqikR6fKKG3JY /SoV0RhFSTWv+owP3yypxacfWby2wokp2624tO1RVpFw5wRgolwm4Qmj+vyCsuqcjkUF ztm8/newmrcJVtAK8I++6HfAjn9BDfZ1tljmHQQb6m5R+AEgE7kyYLSTnYm7yCZolog3 75qTef99tlKyMa2Mm29RvaicRKV3A0bxpVRXXx3/f7hSRePAy+LUrA03xz/NWwti/Caw BV+/lIiuzQ+sFoiKsQhWAFLc9BwGR84VBArAYoeV5bsYTp01Y0cdtOyzEIExpPMMHSw2 nCZQ== X-Forwarded-Encrypted: i=1; AJvYcCWRLiJg3MNTHiYZ50qxsvRB28mFr97pbB3X8GyiGsAb9qHL6UTXT5D94ubRkd1kUcN84S6GxvUv7g==@kvack.org X-Gm-Message-State: AOJu0Yxt50zlHVDdCJok9MN/V9roV1yQyXC8dy5llkkZd+pnB31clDdL x6vqDHNO94eg6V2kUNMyRmhQOeXkzIYN3Yyk7tUmpA0bDw7QyIATTVv1g5fqixUrd+D83ktIMUN zoM3aW7FfSuId9KIGjgWI99dKcafeq+qo4mwTwqNMIypBXj4Ci0Iu X-Gm-Gg: ASbGncvL0+miFpTDwebxJ9AEoxqvI56qxyqdFWwRr26eiHCiW3Kvx7WrlAUADVY34TC KHAU+Er2cN7JO0wFIBLfKw4a+Z9PUp6TQ44lOhYhYe1eac6kqk7BbRxfSbITy7IocgcAVocELaQ Hk9MeeEZhjzVH7Zz+92JuG6LnekoWRQsp9dixzrXAXV/iaaKSvTpQxeONi8+ndYuBzqWewSAOXM fzfLxeDM6f24xAhJgoowhyZomS9qz7lNDscDq+HpF9qfwshlKYYyT0CGHmG1jrhl8TNzAQaLszQ zKtbl6oFbsF/qtg/rB7/F/06oEONEjHFqO32DEG+IqZPY1EMYLcTcGsjHoXWa68flGrUFJwmC4l nQM/33UNMmlyvSOe4Dd9DIIXaJWYXQoBi+lB9x529tKX6HK6FMg== X-Received: by 2002:a05:600c:83c7:b0:454:aedd:96fb with SMTP id 5b1f17b1804b1-454bb8881d3mr59456615e9.29.1751873411781; Mon, 07 Jul 2025 00:30:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGANzkfEpkskqRvxDNn0Dc/JyBFAyOt8aPzL6q0SSinW8r5eRcBQDlAdYyFsiIqoTwO4ChXzg== X-Received: by 2002:a05:600c:83c7:b0:454:aedd:96fb with SMTP id 5b1f17b1804b1-454bb8881d3mr59456205e9.29.1751873411261; Mon, 07 Jul 2025 00:30:11 -0700 (PDT) Received: from ?IPV6:2003:d8:2f38:1d00:657c:2aac:ecf5:5df8? (p200300d82f381d00657c2aacecf55df8.dip0.t-ipconnect.de. [2003:d8:2f38:1d00:657c:2aac:ecf5:5df8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b9736bsm9494939f8f.60.2025.07.07.00.30.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Jul 2025 00:30:10 -0700 (PDT) Message-ID: Date: Mon, 7 Jul 2025 09:30:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/5] vfio/type1: optimize vfio_unpin_pages_remote() To: lizhe.67@bytedance.com, alex.williamson@redhat.com, akpm@linux-foundation.org, jgg@ziepe.ca, peterx@redhat.com Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250707064950.72048-1-lizhe.67@bytedance.com> <20250707064950.72048-6-lizhe.67@bytedance.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250707064950.72048-6-lizhe.67@bytedance.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ggoc2BexipldpKAm1vJIgDo0FfXo6F8d-AAaq1aQkvw_1751873412 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E6F0C40012 X-Stat-Signature: bfd6zu93dfa3qgogx1mxoqws8d3gdqfm X-Rspam-User: X-HE-Tag: 1751873414-481189 X-HE-Meta: U2FsdGVkX18dykRv4qVQgydGy9UGjUaAqKiAdPkAUSFjRzt2DjqEpMWOV+uPnYiLQPL+NIoTeutfWef6Bo2ADmVby+TWv0w7H7zB4kAU4CQfkenA0xsYgavEyL/y0REll704M+HVPYZ5vDXcn6YIFKh/XCWDrgY150wZ58hsOQt4Gw5+w/9tNYhU8/AkwuRCwkqj/dLZ3cWNuwWQYcNBmdWocUya8MIF2vvWGo6PqTtINUAAFJN4lMggTQ4w0VqqKKAOjq2AkaHq8KIOj51WEPrwsWt79L+trpwKvYbWzr/I0EAWbtLE9Viqnrbpx+ntWEfC0yP7aBb0XFCzgVmd4h2L+k5stpVkBUUb4WIB94n81AMzFlM7s5qQvHXNMDoPHOcPw5Nhiqg8arTjnj/+CCLGY6TGcUKeBmT2odTJvyYS8pvfYCJMJGneZK/tT0z5wJOJ01Dg4uUJ8O3MDsc2Y94Ik84dRttLv4CVv5545WhcmjTwOA7i3/FzDoKqKG3XADCdyW92zHpxwmzItA+pjGLdh02BVTkxO16a11KruwckGMIgTd+AHZD1G54FQ36VyJBKkGgKRATsoFtgVxosqhf6rqHsFuD94vovXD1ZeQvYxcHvIucKAUm4SbZH0NfdYPkVgIE8CkGiMf4eD29jWkrYg/11HeYYMV4uoQw44wccUDGljpcaJa8rU7RzJ2wXgaMCs1xCHXRbr4lndEwkVWgLWR9GypMkhaRr+Yzaj77RKeBO7n0v/5ygiV/8VlznRwI+MG/E1aHPjS6Q8784sP+BYxZeUCN1GlxmlRx5pjQC/jV3RL1BuEpWwX4gFGvdtLao6LJokOvltZmTM2uetKGRnZfOQMKJ1XIZIuDNVTYGVlecsryzqcqO8wnHweDfnFigzRrGZeYxSCaNiHSwYK64AD3pfWnLU3lJxhHeath0sX9H3pbEiriZgwR81A/6IchqmshESooYbe38Uii RmxQljRf yMoLVKSYK3YQI0/Zwgi8WqOf0kZ/DbRTHHK9sh8X39sLN0l4Q9Cijx7b++BG4NU1IRzG61CQYbXEtkn2y49tjzkzKN8XtLCakZxA4LOMxStTOfJGNjQCffRYBhT9Po/Rwdt4wG5MCysb9rYp3iBVvpegp+JEXljPu8q5MhJ87XcceJomoBNVASYESRcnFwg92D8ID92mbPMXENexLQkwz26rOq1uk/baetTmuSEqxrSuVf/lkTEFwm4fDb/KGhUMiL4+LZGFhUqafxR0h8usgk+Y7ufXkYtmitK3DKAj7vUR+WdIHzdpxnOyowJT55hhNyrVXwocqcFsPfYqNDAP2f3WKEi1rFLXjF1E0n6lCEn4DeEM4UhnTxTQD/+NhRAFiP0YSJBtaJ6X81Z9jfOblz6xtBYT0ubsoCGXrq1bVmnEjPHkYQHLb9NoN/Gbgpj/kPI/JMXlvr8XODCPx0Tu5BqiOvjmtQcTL6ueHU5WNI4m32qxdcMKS3KUSeMhweqKjNm3XqndmcFSNHdE4CDoxPrCYSBN0V8UcwYvazWSUnyVtkU48eYEFdB/utit7VkxQDhQO/l+Qe72JYw8PBhnTBBkgMVkcD3nKbW8xUsQ01YSFdh0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.07.25 08:49, lizhe.67@bytedance.com wrote: > From: Li Zhe > > When vfio_unpin_pages_remote() is called with a range of addresses that > includes large folios, the function currently performs individual > put_pfn() operations for each page. This can lead to significant > performance overheads, especially when dealing with large ranges of pages. > > It would be very rare for reserved PFNs and non reserved will to be mixed > within the same range. So this patch utilizes the has_rsvd variable > introduced in the previous patch to determine whether batch put_pfn() > operations can be performed. Moreover, compared to put_pfn(), > unpin_user_page_range_dirty_lock() is capable of handling large folio > scenarios more efficiently. > > The performance test results for completing the 16G VFIO IOMMU DMA > unmapping are as follows. > > Base(v6.16-rc4): > ./vfio-pci-mem-dma-map 0000:03:00.0 16 > ------- AVERAGE (MADV_HUGEPAGE) -------- > VFIO UNMAP DMA in 0.135 s (118.6 GB/s) > ------- AVERAGE (MAP_POPULATE) -------- > VFIO UNMAP DMA in 0.312 s (51.3 GB/s) > ------- AVERAGE (HUGETLBFS) -------- > VFIO UNMAP DMA in 0.136 s (117.3 GB/s) > > With this patchset: > ------- AVERAGE (MADV_HUGEPAGE) -------- > VFIO UNMAP DMA in 0.045 s (357.0 GB/s) > ------- AVERAGE (MAP_POPULATE) -------- > VFIO UNMAP DMA in 0.288 s (55.6 GB/s) > ------- AVERAGE (HUGETLBFS) -------- > VFIO UNMAP DMA in 0.045 s (353.9 GB/s) > > For large folio, we achieve an over 66% performance improvement in > the VFIO UNMAP DMA item. For small folios, the performance test > results appear to show a slight improvement. > > Suggested-by: Jason Gunthorpe > Signed-off-by: Li Zhe > --- > drivers/vfio/vfio_iommu_type1.c | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) > > diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c > index 13c5667d431c..208576bd5ac3 100644 > --- a/drivers/vfio/vfio_iommu_type1.c > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -792,17 +792,29 @@ static long vfio_pin_pages_remote(struct vfio_dma *dma, unsigned long vaddr, > return pinned; > } > > +static inline void put_valid_unreserved_pfns(unsigned long start_pfn, > + unsigned long npage, int prot) > +{ > + unpin_user_page_range_dirty_lock(pfn_to_page(start_pfn), npage, > + prot & IOMMU_WRITE); > +} > + > static long vfio_unpin_pages_remote(struct vfio_dma *dma, dma_addr_t iova, > unsigned long pfn, unsigned long npage, > bool do_accounting) > { > long unlocked = 0, locked = vpfn_pages(dma, iova, npage); > - long i; > > - for (i = 0; i < npage; i++) > - if (put_pfn(pfn++, dma->prot)) > - unlocked++; > + if (dma->has_rsvd) { > + unsigned long i; > > + for (i = 0; i < npage; i++) > + if (put_pfn(pfn++, dma->prot)) > + unlocked++; > + } else { > + put_valid_unreserved_pfns(pfn, npage, dma->prot); > + unlocked = npage; > + } > if (do_accounting) > vfio_lock_acct(dma, locked - unlocked, true); > Acked-by: David Hildenbrand -- Cheers, David / dhildenb