From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66606C021A9 for ; Tue, 18 Feb 2025 02:47:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6ED2A280076; Mon, 17 Feb 2025 21:47:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 69CC6280075; Mon, 17 Feb 2025 21:47:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58A86280076; Mon, 17 Feb 2025 21:47:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 36E50280075 for ; Mon, 17 Feb 2025 21:47:52 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 961751415B7 for ; Tue, 18 Feb 2025 02:47:51 +0000 (UTC) X-FDA: 83131530342.23.B90617F Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf26.hostedemail.com (Postfix) with ESMTP id 7FF97140007 for ; Tue, 18 Feb 2025 02:47:48 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739846869; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P11TV1OM2+yCWyjWWX1HRKs3I6ASbLk8e3p4mNkWaqQ=; b=VykQZi05a8xADGNUCWiJcEDGocbMcXx9VMeSin4bs/3k2hE4yf0x5Bnzh3IUxexT74bILJ 0xd71sRUoAmPkFqMzSG3eiALIFYUWNBJR5QQpCzW8GAtt0/i1bE5GLrZKJFCAxMWidgZZf RUcvu/FraSSM23Ik8sMU6RkcV4BJg0A= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739846869; a=rsa-sha256; cv=none; b=0JPCArK6lkOcsXJuxjkPoOCIykArwOf3WV2S19ID/mFdZWrKHQRF1PpsiBvRd+TG/dLHyB yRGHUMXJnz390P5xmvkVmKqj0FrhiiCANK1/31g5HE57k9vTgGgAm1k6ut8EUhB2yWzeVX LbQO0qFFmjsyBCJmbeK1TEVoxaA+H9U= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4YxkP22X9Zz2JYZk; Tue, 18 Feb 2025 10:43:50 +0800 (CST) Received: from kwepemk500005.china.huawei.com (unknown [7.202.194.90]) by mail.maildlp.com (Postfix) with ESMTPS id 6C9611A016C; Tue, 18 Feb 2025 10:47:43 +0800 (CST) Received: from [10.174.179.234] (10.174.179.234) by kwepemk500005.china.huawei.com (7.202.194.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 18 Feb 2025 10:47:41 +0800 Message-ID: Date: Tue, 18 Feb 2025 10:47:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Add Morton,Peter and David for discussion//Re: [PATCH -next] uprobes: fix two zero old_folio bugs in __replace_page() To: Masami Hiramatsu , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , "Liang, Kan" , Andrew Morton , Peter Xu , David Hildenbrand CC: , , , , , linux-mm References: <20250217123826.88503-1-tongtiangen@huawei.com> From: Tong Tiangen In-Reply-To: <20250217123826.88503-1-tongtiangen@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.234] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemk500005.china.huawei.com (7.202.194.90) X-Rspam-User: X-Stat-Signature: mnf1nmk9fejnauxbe1b8c5335twb3rm7 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7FF97140007 X-HE-Tag: 1739846868-225846 X-HE-Meta: U2FsdGVkX19MJC0uOxwZBWuifMsiWlBZp7wuYZ68WhUOdOr0BTtWJ5hBGzF/Ce0I3Cn3zrcByHyC07QCoxzqtboE9eMThYw9IgubSaTXHhN7sATSi2zwYCPimQBUqEo7aShzleoj/+7rZyYmpR9zziQIGaKvc7xO5WmJ/AqXb8x6SiKd1cZRJyXo1hJjOPwZhCoM1Egn62vjcXOKb7mwIeA1z3tfSoCkHUz7HYH9VBrdhT2SJMY4Q8OCBaW/Uq4nKkzXOAwioDh2DToFjD8F+esJgjZtQa/3NkyU6zWAFDLjRwNh25ssGF+f5G3rLysBO/N9fndSCr2TdbZKyR5OsUmYD/+pGIIPDqR4BQDu15GOQYmPTjfyj/YPM+KsGe3s7xpuBnRd3uVW/D/SqMFql6HWCNQO8QZRn01y6QG0dkyGvSDwwMpw8dOMwsp7GLbQIKpO2K+9MMJsl2vqhBMyeBMDKeEXXKp46IhFBtaOqNCjvikUevGV9o0md9rGWEwpsXWWsqE4VpJdFxPPcqTH//mdABpJsmmfhz00fN0kekoZfbo5ELrugDoXyGegR1NGGZmXmQd7JCO/UUo3UiRZ2C3B8EWHFPfSUiKmZHVz6g1h6JaZI90v/vPUC7YKPvJ1aXvUuSpV5J8sdiSLHeInTkgvcN0hoht8ySWCpEln6CcMT2LxHk+CH6GPpXNIuodGyMNiGv7dUPNj66+at9OsbpFw60+0RntU30cPkO+G6tdlJtAFCT6yCZXjkSz37qm0q7mEHAfTtBs52uyGjAoZr+0PR3J862ZacWJjzBczwXiMBntZW04mAeObgcKHimcPrMvwzY65IMMNNubaL3R4kvphOKOfQdU9U5iHegBY6OeLUc3bdDQE/iJCgH2ghUJwYf7byj1yGAgS7XrHC5RH1R2eSA1iMmLrLyQLGaagqCybl+UaX+mAvCKxsBR9GnPyaZ0p6JB7Urjf1qwjWhn 9/qUIBWd XQuv4OuaPchLCasoOOBmAQ2ALkQU5SnXoehdycS5DJZ2fj763PywnrtlPYMkTLWT6tCCr1ESaXym8wa17muUxvTB5m/jIvcqeXzxDOYEOcqgknlk7w8drukmePlegI0P3bfkFSULrksUDbYuFyBWx9CP2ILKQxoYpoKjufjCHsn2zA74pOkAvmm6C9hfZfZVlAlukomSbb14JaIvV7i+WzQVyv1MP8o1//VLG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/2/17 20:38, Tong Tiangen 写道: > We triggered the following error logs in syzkaller test: > > BUG: Bad page state in process syz.7.38 pfn:1eff3 > page: refcount:0 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1eff3 > flags: 0x3fffff00004004(referenced|reserved|node=0|zone=1|lastcpupid=0x1fffff) > raw: 003fffff00004004 ffffe6c6c07bfcc8 ffffe6c6c07bfcc8 0000000000000000 > raw: 0000000000000000 0000000000000000 00000000fffffffe 0000000000000000 > page dumped because: PAGE_FLAGS_CHECK_AT_FREE flag(s) set > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.13.0-1ubuntu1.1 04/01/2014 > Call Trace: > > dump_stack_lvl+0x32/0x50 > bad_page+0x69/0xf0 > free_unref_page_prepare+0x401/0x500 > free_unref_page+0x6d/0x1b0 > uprobe_write_opcode+0x460/0x8e0 > install_breakpoint.part.0+0x51/0x80 > register_for_each_vma+0x1d9/0x2b0 > __uprobe_register+0x245/0x300 > bpf_uprobe_multi_link_attach+0x29b/0x4f0 > link_create+0x1e2/0x280 > __sys_bpf+0x75f/0xac0 > __x64_sys_bpf+0x1a/0x30 > do_syscall_64+0x56/0x100 > entry_SYSCALL_64_after_hwframe+0x78/0xe2 > > BUG: Bad rss-counter state mm:00000000452453e0 type:MM_FILEPAGES val:-1 > > The following syzkaller test case can be used to reproduce: > > r2 = creat(&(0x7f0000000000)='./file0\x00', 0x8) > write$nbd(r2, &(0x7f0000000580)=ANY=[], 0x10) > r4 = openat(0xffffffffffffff9c, &(0x7f0000000040)='./file0\x00', 0x42, 0x0) > mmap$IORING_OFF_SQ_RING(&(0x7f0000ffd000/0x3000)=nil, 0x3000, 0x0, 0x12, r4, 0x0) > r5 = userfaultfd(0x80801) > ioctl$UFFDIO_API(r5, 0xc018aa3f, &(0x7f0000000040)={0xaa, 0x20}) > r6 = userfaultfd(0x80801) > ioctl$UFFDIO_API(r6, 0xc018aa3f, &(0x7f0000000140)) > ioctl$UFFDIO_REGISTER(r6, 0xc020aa00, &(0x7f0000000100)={{&(0x7f0000ffc000/0x4000)=nil, 0x4000}, 0x2}) > ioctl$UFFDIO_ZEROPAGE(r5, 0xc020aa04, &(0x7f0000000000)={{&(0x7f0000ffd000/0x1000)=nil, 0x1000}}) > r7 = bpf$PROG_LOAD(0x5, &(0x7f0000000140)={0x2, 0x3, &(0x7f0000000200)=ANY=[@ANYBLOB="1800000000120000000000000000000095"], &(0x7f0000000000)='GPL\x00', 0x7, 0x0, 0x0, 0x0, 0x0, '\x00', 0x0, @fallback=0x30, 0xffffffffffffffff, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x10, 0x0, @void, @value}, 0x94) > bpf$BPF_LINK_CREATE_XDP(0x1c, &(0x7f0000000040)={r7, 0x0, 0x30, 0x1e, @val=@uprobe_multi={&(0x7f0000000080)='./file0\x00', &(0x7f0000000100)=[0x2], 0x0, 0x0, 0x1}}, 0x40) > > The cause is that zero pfn is set to the pte without increasing the rss > count in mfill_atomic_pte_zeropage() and the refcount of zero folio does > not increase accordingly. Then, the operation on the same pfn is performed > in uprobe_write_opcode()->__replace_page() to unconditional decrease the > rss count and old_folio's refcount. > > Therefore, two bugs are introduced: > 1. The rss count is incorrect, when process exit, the check_mm() report > error "Bad rss-count". > 2. The reserved folio (zero folio) is freed when folio->refcount is zero, > then free_pages_prepare->free_page_is_bad() report error "Bad page state". > > To fix it, add zero folio check before rss counter and refcount decrease. > > Fixes: 7396fa818d62 ("uprobes/core: Make background page replacement logic account for rss_stat counters") > Fixes: 2b1444983508 ("uprobes, mm, x86: Add the ability to install and remove uprobes breakpoints") > Signed-off-by: Tong Tiangen > --- > kernel/events/uprobes.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c > index 46ddf3a2334d..ff5694acfa68 100644 > --- a/kernel/events/uprobes.c > +++ b/kernel/events/uprobes.c > @@ -213,7 +213,8 @@ static int __replace_page(struct vm_area_struct *vma, unsigned long addr, > dec_mm_counter(mm, MM_ANONPAGES); > > if (!folio_test_anon(old_folio)) { > - dec_mm_counter(mm, mm_counter_file(old_folio)); > + if (!is_zero_folio(old_folio)) > + dec_mm_counter(mm, mm_counter_file(old_folio)); > inc_mm_counter(mm, MM_ANONPAGES); > } > > @@ -227,7 +228,8 @@ static int __replace_page(struct vm_area_struct *vma, unsigned long addr, > if (!folio_mapped(old_folio)) > folio_free_swap(old_folio); > page_vma_mapped_walk_done(&pvmw); > - folio_put(old_folio); > + if (!is_zero_folio(old_folio)) > + folio_put(old_folio); > > err = 0; > unlock: