From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 486CCC433FE for ; Wed, 13 Oct 2021 11:20:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D58C861053 for ; Wed, 13 Oct 2021 11:20:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D58C861053 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 39DB56B006C; Wed, 13 Oct 2021 07:20:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34C96900002; Wed, 13 Oct 2021 07:20:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21F3E6B0072; Wed, 13 Oct 2021 07:20:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0216.hostedemail.com [216.40.44.216]) by kanga.kvack.org (Postfix) with ESMTP id 10B266B006C for ; Wed, 13 Oct 2021 07:20:38 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C9D6539481 for ; Wed, 13 Oct 2021 11:20:37 +0000 (UTC) X-FDA: 78691171314.08.5BAEBA1 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf26.hostedemail.com (Postfix) with ESMTP id 9A56E20019C6 for ; Wed, 13 Oct 2021 11:20:37 +0000 (UTC) Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4HTqpC28Spz9sSP; Wed, 13 Oct 2021 13:20:35 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kZcpVFyhFd8g; Wed, 13 Oct 2021 13:20:35 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4HTqpC0fNwz9sSN; Wed, 13 Oct 2021 13:20:35 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id EE53D8B77E; Wed, 13 Oct 2021 13:20:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id 3nizRho4O5jm; Wed, 13 Oct 2021 13:20:34 +0200 (CEST) Received: from PO20335.IDSI0.si.c-s.fr (unknown [172.25.230.103]) by messagerie.si.c-s.fr (Postfix) with ESMTP id B49778B763; Wed, 13 Oct 2021 13:20:34 +0200 (CEST) Subject: Re: [PATCH v1 06/10] asm-generic: Refactor dereference_[kernel]_function_descriptor() To: Kees Cook , Helge Deller Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Andrew Morton , "James E.J. Bottomley" , Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org References: <202110130002.A7C0A86@keescook> From: Christophe Leroy Message-ID: Date: Wed, 13 Oct 2021 13:20:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <202110130002.A7C0A86@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr-FR X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9A56E20019C6 X-Stat-Signature: kgixem8wfrubx54ossbretaeutq95fsq Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu X-HE-Tag: 1634124037-628480 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 13/10/2021 =C3=A0 09:02, Kees Cook a =C3=A9crit=C2=A0: > On Mon, Oct 11, 2021 at 05:25:33PM +0200, Christophe Leroy wrote: >> dereference_function_descriptor() and >> dereference_kernel_function_descriptor() are identical on the >> three architectures implementing them. >> >> Make it common. >> >> Signed-off-by: Christophe Leroy >> --- >> arch/ia64/include/asm/sections.h | 19 ------------------- >> arch/parisc/include/asm/sections.h | 9 --------- >> arch/parisc/kernel/process.c | 21 --------------------- >> arch/powerpc/include/asm/sections.h | 23 ----------------------- >> include/asm-generic/sections.h | 18 ++++++++++++++++++ >> 5 files changed, 18 insertions(+), 72 deletions(-) >=20 > A diffstat to love. :) >=20 > Reviewed-by: Kees Cook Unless somebody minds, I will make them out of line as suggested by Helge in he's comment to patch 4. Allthough there is no spectacular size reduction, the functions are not worth being inlined as they are not used in critical pathes.