From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C423C87FDE for ; Mon, 12 Jun 2023 09:56:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E668D6B0072; Mon, 12 Jun 2023 05:56:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEFCB6B0074; Mon, 12 Jun 2023 05:56:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C906D6B0075; Mon, 12 Jun 2023 05:56:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B65916B0072 for ; Mon, 12 Jun 2023 05:56:28 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 85D531201A6 for ; Mon, 12 Jun 2023 09:56:28 +0000 (UTC) X-FDA: 80893640856.24.3B9F7E2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 5F97F40021 for ; Mon, 12 Jun 2023 09:56:26 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a1fHLf+3; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686563786; a=rsa-sha256; cv=none; b=rnMqW0upnwqOuF7EPyaYZMz/oqvchpRKN/Kzp4Ad7LT5QZu/wb2CplWTfA+//xnvclZuqX XrtcrDiUeIlxIoz2vXopQ61HeLbGrpm6HhXOdhJoNJZ1FAsmr4/GHWYFCIU7tdrKsJqr5u 65Nm5oyrsKiEAF7r9qyRoKBV9FVQX3Y= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=a1fHLf+3; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686563786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7erq9mCXu6YfPjb1swyfCVbQPxq89IutQ/4dZgRd0RM=; b=Fci2YnvE5O/a+QNsrhPtq36k524gNhvYlsuelmAqdZDnQr6U6KlsM0F8nPAt3mFXSaD2K5 CFo4+04MWACmhFfTraQ98fA068LsETHaTJ12V9iU2ZBWyfF6eQbZkdgPoxbPwrMMSs4Trf m8WFfrL8JOzat/aRHmhwXLfbLdFAVmU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686563785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7erq9mCXu6YfPjb1swyfCVbQPxq89IutQ/4dZgRd0RM=; b=a1fHLf+3jIuGAO8wFufVYSseeWyfRodsRD7sdfaAMUAX4ss4HlfS0mqGWx+J0TIxODp6kh WpEOH9fCVGLZ5/eUyfiijlmmii8lyRMFjdZC0h0sEIq9U3f+N9GTfD4xl9SnDAb6vJWvDn /PX2H9Se7/smxxQf4wqAqUdz3l6YwuM= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-307-K9YHrmvuP8abO-VMbOx3XQ-1; Mon, 12 Jun 2023 05:56:24 -0400 X-MC-Unique: K9YHrmvuP8abO-VMbOx3XQ-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2b331755c96so1482411fa.0 for ; Mon, 12 Jun 2023 02:56:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686563782; x=1689155782; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7erq9mCXu6YfPjb1swyfCVbQPxq89IutQ/4dZgRd0RM=; b=ZflDCyp50EVALrxg8XEDnDLPs329dQ8VOt13jEKptV49xGILtpfiUPvahON7luyUyU /jyyKh3FmiGRvUSvmNwPhF8WdW6u0YBuauksS3Cizd6SD5YkVt3AUl00YnrY1iKEck/+ k1fcruUAoKCZFzXTX2lktl4d4q/qmQUDN8rhqgK7isqhVxfqqLVMJ5B/qTDwJucdiAQH +XN2pfgc1p+BcpJ8mrDFw6uzHEVIybL5uHxgYa2S4Hdl+HFMTZIniVie5LLfaCCuXY/u JrT9JZ8Kxlx7PooQCIL+UHeflsEed+Rq2pB+8t7sols0rCTi26R2s4py/ssJgAcQpCMH c1RA== X-Gm-Message-State: AC+VfDyCH6ill7viRGRrxLUJfIjpPbXlPAmXuq+qj1DXr1q44lNEsKxg nqddNubEanxaPvXqSXba/2mahSGwsNYCw5fDvjFz7Sw0JPELk06RHKQhS6mBGdN1CLqqRWzJbrB eSTU0Ml7Qh64= X-Received: by 2002:a19:4f4c:0:b0:4f3:b222:1eed with SMTP id a12-20020a194f4c000000b004f3b2221eedmr3525798lfk.2.1686563782586; Mon, 12 Jun 2023 02:56:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4U7pGmP/JxxfD47wW6q0zz8WCn++HEA7IpRLWH5Pgnbq09E9OG/AArBNmozy2NqofxEpwZXA== X-Received: by 2002:a19:4f4c:0:b0:4f3:b222:1eed with SMTP id a12-20020a194f4c000000b004f3b2221eedmr3525779lfk.2.1686563782187; Mon, 12 Jun 2023 02:56:22 -0700 (PDT) Received: from ?IPV6:2003:cb:c74e:1600:4f67:25b2:3e8c:2a4e? (p200300cbc74e16004f6725b23e8c2a4e.dip0.t-ipconnect.de. [2003:cb:c74e:1600:4f67:25b2:3e8c:2a4e]) by smtp.gmail.com with ESMTPSA id f9-20020a7bc8c9000000b003f8140763c7sm5747410wml.30.2023.06.12.02.56.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jun 2023 02:56:21 -0700 (PDT) Message-ID: Date: Mon, 12 Jun 2023 11:56:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/2] selftests: mm: remove wrong kernel header inclusion To: Muhammad Usama Anjum , Andrew Morton , Shuah Khan , Stefan Roesch Cc: kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230612095347.996335-1-usama.anjum@collabora.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230612095347.996335-1-usama.anjum@collabora.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5F97F40021 X-Stat-Signature: xww7b6xtam4djg1fgc7sg7efzoyefj4x X-Rspam-User: X-HE-Tag: 1686563786-599098 X-HE-Meta: U2FsdGVkX1+p0SghTsP3/YGwGm8QQTAqqH0XApxW52EQDnIUSx/S+PYo7mpmY6hCUbxSwt69WHO5Seipuht0or+2pii/HeUA1YuZYdoWahp/CmoWrEIZfJ6JApumEBVyE70wCFMEA5iFhBbiXFiSM0JMXTEQEp3GPFFfOtJ1cKXFvF/pwTTT4SCIX5K1apydZEg5wInWuikGjmrzk+g+Dh6SOvvsHOybJQqMGtCy2y/My/5qfupwdJE5nruf08Hj+qn55Qk0fmheDIUfZZzlNT7WPGHaFxiDwA3Ehy4AqREbpUKC485rFJOdOY+oZm9A3alM2zdZhsyhl212P94vQIQW4Ku4qWgoq7Z2Lq4ZuzcqergOna0R4TrGKlRBOzf0eik0xDSj4A+62b0erJgSjNQeIQc2MtcjhZn8v8YFmpsbZYL4EGRUTtF9Y69Bg2VUkVp1ESSN9dnL3CzdPLvQoqRbhP5vD6J8fR8gDDtTweg996r28cksNCn/QwxTjAJv4GhYjFWouoAcUVXllVINA1AVgzh6qL51EfgI/nKUDQI5G5y5bnWz55ruc6y1q2/6eROB4tQUbPqjBM7L28uyuQC6PgW6N8XGcC2p4lxnE/VaUKocTymXvU2sL3dzPV9BUDZD5uAhcA4eQPHh+VkVvO5D70N2/OUYSO0onXp3iWib11uyIDuMgFVt/exVm6eTboEXYGD4oNZNUYDwbcsrYBQsA/K21MDKQOfRxKXsLihv7c5Nl/PGZuaEn+cHUILSelpY5vXEuM2mg0gL3wZn52ozyBbLh2fME+Be4a2d+4PDccYX0v4IuQwlOFHxKXou5pYp9sDNpS5rv+SqkpUp0MVPHgTFQ+KdJSutKbP9TdE7Z0Y+0A+Gx/uYtNI0QKedo4e+hgolWppgVi8ZN4VZtkdFMrsO2JP2TQVrMRbOtq7Rrx51uY5asDWnaZleLTBD5pZG0Z57hNfcTxU6yTL 1U7Z4+Qh xFSwTErENUtFDe91986oz2PD9MaILUnNxD2Id8At4jXRytzDJ2SJydPlhgtpAvA4zpxnRZ29aKud6ROhJ2oI1unJ5desFUch7OlEvLFpPK42sRpgMqDAjHc7s+EjOx6QxB4TBfbIhmHocu0cBD1zja9mGJilK6HiHssO5wYwlXXWCiwuVe6v1/oDLWUvMCvfnjSfU9uJDuvlg8v/SRZXTM77meJxQZbbZYh7iIeIgUgUO4zPafdVGJC3Xdt+1So/eWHzUA0XzeDQlVLtAz2pUr3vx/ir7NoJHk6PLNU3YEw805G0l9BOzWg1A8+EweQMVyypttS7NJInNiAAVoXcansWMmEkqoHXnK1jlwgCOvt6SSmts5xOKUA/iUzll9eOcuCvPZEorvcsVvgXAUy78uF9ZTgNBKBYxtoqlfIyNxxC/9PXfuozq1FmALxK0tn4lHWfPVL6M4KonWZNicwP9v0PsSA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000029, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.06.23 11:53, Muhammad Usama Anjum wrote: > It is wrong to include unprocessed user header files directly. They are > processed to "/usr/include" by running "make headers" and > they are included in selftests by kselftest makefiles automatically with > help of KHDR_INCLUDES variable. These headers should always bulilt > first before building kselftests. > > Fixes: 07115fcc15b4 ("selftests/mm: add new selftests for KSM") > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/mm/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile > index 95acb099315e..e6cd60ca9e48 100644 > --- a/tools/testing/selftests/mm/Makefile > +++ b/tools/testing/selftests/mm/Makefile > @@ -29,7 +29,7 @@ MACHINE ?= $(shell echo $(uname_M) | sed -e 's/aarch64.*/arm64/' -e 's/ppc64.*/p > # LDLIBS. > MAKEFLAGS += --no-builtin-rules > > -CFLAGS = -Wall -I $(top_srcdir) -I $(top_srcdir)/tools/include/uapi $(EXTRA_CFLAGS) $(KHDR_INCLUDES) > +CFLAGS = -Wall -I $(top_srcdir) $(EXTRA_CFLAGS) $(KHDR_INCLUDES) > LDLIBS = -lrt -lpthread > > TEST_GEN_PROGS = cow Still compiles after "make headers", so Acked-by: David Hildenbrand -- Cheers, David / dhildenb