From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8B1DC2BD09 for ; Thu, 27 Jun 2024 19:46:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 398A36B0085; Thu, 27 Jun 2024 15:46:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 347526B00A1; Thu, 27 Jun 2024 15:46:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C11B6B00A2; Thu, 27 Jun 2024 15:46:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EC0BE6B00A1 for ; Thu, 27 Jun 2024 15:46:16 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 95F84141000 for ; Thu, 27 Jun 2024 19:46:16 +0000 (UTC) X-FDA: 82277699952.25.852DE19 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf16.hostedemail.com (Postfix) with ESMTP id 8E64218001D for ; Thu, 27 Jun 2024 19:46:14 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QPa4tnNs; spf=pass (imf16.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719517557; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=age6AsIuh5Rf9q7SxRHdgGO4kPFxXF4+7BpK4Tl2/mc=; b=f82GtYKvT/ZX5XZAy/X/+beo1n92ymITfwY8xvR/7vfHVdIHgeq9PWpZ3pRjrgEeEbyxdy RguPQUcJt+LhtpHCIsq3E1zpa3N9IMCQnq7RzHwu8PKDBaNiaGIQEsQiv38RCvvuGaLANU yXSYC+KZBEfHwsPshpwA5/ggay7sRDY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719517557; a=rsa-sha256; cv=none; b=eA7dPlsot25mawwCazoBJIw4JhyhKCyQjh1vmwypKmPtHaVXHXgjArRXfwu5D+goMGYSUX wOq+yAG1qujt/StoiDQ5iD1kZuu5yYlKgrlYWWA1EwARQoCFUWX0lp18WKSoHmF4MWuBEN 5ixS049SFddI71Eljb05X96JAInVvbg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QPa4tnNs; spf=pass (imf16.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4256aee6d4fso1409975e9.3 for ; Thu, 27 Jun 2024 12:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719517573; x=1720122373; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=age6AsIuh5Rf9q7SxRHdgGO4kPFxXF4+7BpK4Tl2/mc=; b=QPa4tnNsMp8SjLV31xUjK1iYEqoQsthfatacmpNHDFFdPge9lxmAj2fUxFfCH/OTug UzqhtxewfZji6ct0GUW8/RnXGh+8nt18nT8s0jYqO8PIrb63DZks1YEmBKypntEh5LYw N/17O2IrpnQoymlFKzNApP/WLY6ibR7qedvqwQmjh3eD01TJKXRirZkepQ9GN5/F2xFt 7X24R8TA9RKoaqHXPhVR3M1fwK2SKxroC5b5tR22qaN6WbjegGeuu7ydpbjFf5TawfQb rBD1xVFevRpjtYu06clrmf8wXF/FMz8B//f9E2McZobFqh2xvy9HOylyoJpFY7ZUHVUf wH6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719517573; x=1720122373; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=age6AsIuh5Rf9q7SxRHdgGO4kPFxXF4+7BpK4Tl2/mc=; b=tNKwYXjXGZrPNrCHU1wxI/5bkBZ+UBd/GqRvWxKeKpKQSIE4ZExH75JYrCrmn0CwRg JouJ6t8JQGEeAKZRAbLgyk92RLwKErR2F1bJnNRbPp3oWrAMZpvUJe8XbFGAJeYesSy4 9cOuXl8Tcq3HLkOAugwjvO6IfDwYtDOPZILCzFetMp0wYXKHOYKyi2wx4lr2UowPAsDV OAXRVVsFAnH3ib7bQ7MVPi/vE/TnLiaSQJ8cDuSY8r38HAtoBvpLPKiHenu75/YBYUJV dthuMO192Rm1OjxmOjqfJU44kSHEa8KRnwmU74xSxFpCIxZcjSDZAJbiJEOI8udOf4yJ MTJA== X-Forwarded-Encrypted: i=1; AJvYcCXPsjKrAFXY6Jw0JrnFk8U/RRIHVia2tiY8t+1FabzeQGR0hYvMJyZLPDUPollrKmWfZg3mokK2unABHD6SA5vI9so= X-Gm-Message-State: AOJu0YwYCQGcvMCexG71ez9ghgkR+ZFBOrv+o380NI2BP6zsqTHlrM7g aHQuxCeYeVl+lWTtS2pvNndlw2q6hXdr9H/03dSi2xVvy9oT8l3h X-Google-Smtp-Source: AGHT+IGJZFJUcoUIPSRfrEzTaFHGLZfdt34HEVKQhauu8tvQUZP9L+k1jNutgxqScms6dhGWFakNBA== X-Received: by 2002:a05:6000:2a7:b0:366:eb61:b45 with SMTP id ffacd0b85a97d-366eb610bc7mr11798347f8f.1.1719517572808; Thu, 27 Jun 2024 12:46:12 -0700 (PDT) Received: from localhost ([2a00:23cc:d20f:ba01:bb66:f8b2:a0e8:6447]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3675a0e12d7sm164182f8f.51.2024.06.27.12.46.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Jun 2024 12:46:11 -0700 (PDT) Date: Thu, 27 Jun 2024 20:46:11 +0100 From: Lorenzo Stoakes To: "Liam R. Howlett" , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Vlastimil Babka , Matthew Wilcox , Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Kees Cook , Suren Baghdasaryan Subject: Re: [RFC PATCH 6/7] tools: separate out shared radix-tree components Message-ID: References: <3kswdhugo2jmlkejboymem4yhakird5fvmnbschicaldwjwu7x@6c6z5lk4ctvy> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3kswdhugo2jmlkejboymem4yhakird5fvmnbschicaldwjwu7x@6c6z5lk4ctvy> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8E64218001D X-Stat-Signature: zw6x1cypzm3kt1st5tftr69fuexxyy3u X-HE-Tag: 1719517574-523743 X-HE-Meta: U2FsdGVkX1/c8m+R9LBxR6OF3LFDPidRimuZd2/uiKbdkIq5axT9njAOZTS1TOoO9LJtMc/Gi+Rw8fUizO473gmKGPRs/jX+6Iw/dd4JHX0E6RT8gAokLe8o4qVRP5UPaGtUVI4/OnEkkEOoD8OqCTRzsjVxE0HVE5bjeYyqw6uOufx2TQJr5ZLViTLUchrualSPDJQhH6zugQrkPSkrOk9O58xV3iYaucTF3EofXYsdwF929iZy5xwldQPvnWT2R6JQK11tlBxPdJjNyb+qBloHUS1C0/XXiCMky+jRSnGO+mVhXASFgZ6MfYC6GZqTjmC1P3QIIn0ULD1NP3O02VFG6VOFvQq7gIS/KX6F547bpPwxtAdLL9FLYqR2imxXPcBjha9kJvTgUNefYz/JtuHpeXQa9oY17Gnf7KK/G46YJbYG1J0ghiqvTdmPHoCvvg2EaNJ/JzG6udncwxosUYi6oMwgN/ona9HCFKGYDmYxIH4qKzSaSm3Er9OrZc/5vs4Jbxg2nYJKsDWLReCIIgORFotfeibLs3VQOzLMXJC0eEpvuvaJJSLqogfSpRC5p5Rkf3ACedN838ghpIYQ/zOWzVhAwiFdkjsBFCDAJPIXeH+7PXHH6FlhyHQRyRsFHZXFkdj9gK1+PkX/VBQWY7/7vpEH4rsWSe+1yh0KEVlXhJgoGz86DhSDTOhhJVI4cbEhb1vUEq+8Iubhi1sEPq0v6QF46jwxbW0cW/ig6UqARsT1dnNujVAZ+z6CzuHohN6raTjxRI+xK80VLw+doIDf1gnmxx8HmZi3kXRMnyaoQn0ONjYs17JUFEVz492K/BCnzQm4ngdJpIa81iUtMCSsObZ6x4hOun7moRoiBC07QnsWqrBjXqrvYlXtJAvokKh3lTRHcbFSQA1U+/kyaEfsEuCrs+tH4HWXc7mEt6EFHhMJC3/9i3cGcsa7p66CaapRXjeDVBfJaoKiJUJ OjdCSSvs 9UW9xvM1uHxwKBM0t7h1BUglUzcia03bRTZqhfu8MIApvm6eIPEfSD2SvOkzyxk17dj5kJtno5YYkEDtq+BGr6PwBt/GWBk/ZyJrjY4dYpxcXeQxO2/mlRVERGWp2dOn8rtTUf4YXaAeS74uRcU8LMOrGl9MZjN2N7IcdSDSbxMZD9fXWoc5ZBvpjtGANgAku/DjWN/Qk6nhFcIUF5O6F8x6LnoyoXJeNwlOrmpkcwLrm/YGL0ISu7O/ooBn3oH82pzD6Q90RQo3v6xYMBpqF3h+ZrPs4RNyr+gE88en8fJAoDmEbQf/0JHGtvf5yBt5QJPnJL6ARwcVSerW9tX7soHpwghyfDp9CkFr2WEcLwEl8HxzC7GssH4ZeedR5j9b30dfJKj9Udc6dWyf78eKssOOgavamNUGUDw84HBoxn4NrLI4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 27, 2024 at 01:59:18PM -0400, Liam R. Howlett wrote: > * Lorenzo Stoakes [240627 06:39]: > > The core components contained within the radix-tree tests which provide > > shims for kernel headers and access to the maple tree are useful for > > testing other things, so separate them out and make the radix tree tests > > dependent on the shared components. > > > > This lays the groundwork for us to add VMA tests of the newly introduced > > vma.c file. > > This separation and subsequent patch requires building the > xarray-hsared, radix-tree, idr, find_bit, and bitmap .o files which are > unneeded for the target 'main'. I'm not a build expert on how to fix > this, but could that be reduced to the minimum set somehow? I'm confused, the existing Makefile specified: CORE_OFILES := xarray.o radix-tree.o idr.o linux.o test.o find_bit.o bitmap.o \ slab.o maple.o OFILES = main.o $(CORE_OFILES) regression1.o regression2.o regression3.o \ regression4.o tag_check.o multiorder.o idr-test.o iteration_check.o \ iteration_check_2.o benchmark.o main: $(OFILES) Making all of the files you mentioned dependencies of main no? (xarray-shared being a subset of xarray.o which requires it anyway) I'm not sure this is a huge big deal as these are all rather small :) > > > > > Signed-off-by: Lorenzo Stoakes > > --- > > tools/testing/radix-tree/Makefile | 68 +++---------------- > > tools/testing/radix-tree/maple.c | 14 +--- > > tools/testing/radix-tree/xarray.c | 9 +-- > > tools/testing/shared/autoconf.h | 2 + > > tools/testing/{radix-tree => shared}/bitmap.c | 0 > > tools/testing/{radix-tree => shared}/linux.c | 0 > > .../{radix-tree => shared}/linux/bug.h | 0 > > .../{radix-tree => shared}/linux/cpu.h | 0 > > .../{radix-tree => shared}/linux/idr.h | 0 > > .../{radix-tree => shared}/linux/init.h | 0 > > .../{radix-tree => shared}/linux/kconfig.h | 0 > > .../{radix-tree => shared}/linux/kernel.h | 0 > > .../{radix-tree => shared}/linux/kmemleak.h | 0 > > .../{radix-tree => shared}/linux/local_lock.h | 0 > > .../{radix-tree => shared}/linux/lockdep.h | 0 > > .../{radix-tree => shared}/linux/maple_tree.h | 0 > > .../{radix-tree => shared}/linux/percpu.h | 0 > > .../{radix-tree => shared}/linux/preempt.h | 0 > > .../{radix-tree => shared}/linux/radix-tree.h | 0 > > .../{radix-tree => shared}/linux/rcupdate.h | 0 > > .../{radix-tree => shared}/linux/xarray.h | 0 > > tools/testing/shared/maple-shared.h | 9 +++ > > tools/testing/shared/maple-shim.c | 7 ++ > > tools/testing/shared/shared.h | 34 ++++++++++ > > tools/testing/shared/shared.mk | 68 +++++++++++++++++++ > > .../testing/shared/trace/events/maple_tree.h | 5 ++ > > tools/testing/shared/xarray-shared.c | 5 ++ > > tools/testing/shared/xarray-shared.h | 4 ++ > > 28 files changed, 147 insertions(+), 78 deletions(-) > > create mode 100644 tools/testing/shared/autoconf.h > > rename tools/testing/{radix-tree => shared}/bitmap.c (100%) > > rename tools/testing/{radix-tree => shared}/linux.c (100%) > > rename tools/testing/{radix-tree => shared}/linux/bug.h (100%) > > rename tools/testing/{radix-tree => shared}/linux/cpu.h (100%) > > rename tools/testing/{radix-tree => shared}/linux/idr.h (100%) > > rename tools/testing/{radix-tree => shared}/linux/init.h (100%) > > rename tools/testing/{radix-tree => shared}/linux/kconfig.h (100%) > > rename tools/testing/{radix-tree => shared}/linux/kernel.h (100%) > > rename tools/testing/{radix-tree => shared}/linux/kmemleak.h (100%) > > rename tools/testing/{radix-tree => shared}/linux/local_lock.h (100%) > > rename tools/testing/{radix-tree => shared}/linux/lockdep.h (100%) > > rename tools/testing/{radix-tree => shared}/linux/maple_tree.h (100%) > > rename tools/testing/{radix-tree => shared}/linux/percpu.h (100%) > > rename tools/testing/{radix-tree => shared}/linux/preempt.h (100%) > > rename tools/testing/{radix-tree => shared}/linux/radix-tree.h (100%) > > rename tools/testing/{radix-tree => shared}/linux/rcupdate.h (100%) > > rename tools/testing/{radix-tree => shared}/linux/xarray.h (100%) > > create mode 100644 tools/testing/shared/maple-shared.h > > create mode 100644 tools/testing/shared/maple-shim.c > > create mode 100644 tools/testing/shared/shared.h > > create mode 100644 tools/testing/shared/shared.mk > > create mode 100644 tools/testing/shared/trace/events/maple_tree.h > > create mode 100644 tools/testing/shared/xarray-shared.c > > create mode 100644 tools/testing/shared/xarray-shared.h > > > > diff --git a/tools/testing/radix-tree/Makefile b/tools/testing/radix-tree/Makefile > > index 7527f738b4a1..29d607063749 100644 > > --- a/tools/testing/radix-tree/Makefile > > +++ b/tools/testing/radix-tree/Makefile > > @@ -1,29 +1,16 @@ > > # SPDX-License-Identifier: GPL-2.0 > > > > -CFLAGS += -I. -I../../include -I../../../lib -g -Og -Wall \ > > - -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined > > -LDFLAGS += -fsanitize=address -fsanitize=undefined > > -LDLIBS+= -lpthread -lurcu > > -TARGETS = main idr-test multiorder xarray maple > > -CORE_OFILES := xarray.o radix-tree.o idr.o linux.o test.o find_bit.o bitmap.o \ > > - slab.o maple.o > > -OFILES = main.o $(CORE_OFILES) regression1.o regression2.o regression3.o \ > > - regression4.o tag_check.o multiorder.o idr-test.o iteration_check.o \ > > - iteration_check_2.o benchmark.o > > +.PHONY: default > > > > -ifndef SHIFT > > - SHIFT=3 > > -endif > > +default: main > > > > -ifeq ($(BUILD), 32) > > - CFLAGS += -m32 > > - LDFLAGS += -m32 > > -LONG_BIT := 32 > > -endif > > +include ../shared/shared.mk > > > > -ifndef LONG_BIT > > -LONG_BIT := $(shell getconf LONG_BIT) > > -endif > > +TARGETS = main idr-test multiorder xarray maple > > +CORE_OFILES = $(SHARED_OFILES) xarray.o maple.o test.o > > +OFILES = main.o $(CORE_OFILES) regression1.o regression2.o \ > > + regression3.o regression4.o tag_check.o multiorder.o idr-test.o \ > > + iteration_check.o iteration_check_2.o benchmark.o > > > > targets: generated/map-shift.h generated/bit-length.h $(TARGETS) > > > > @@ -32,46 +19,13 @@ main: $(OFILES) > > idr-test.o: ../../../lib/test_ida.c > > idr-test: idr-test.o $(CORE_OFILES) > > > > -xarray: $(CORE_OFILES) > > +xarray: $(CORE_OFILES) xarray.o > > > > -maple: $(CORE_OFILES) > > +maple: $(CORE_OFILES) maple.o > > > > multiorder: multiorder.o $(CORE_OFILES) > > > > clean: > > $(RM) $(TARGETS) *.o radix-tree.c idr.c generated/map-shift.h generated/bit-length.h > > > > -vpath %.c ../../lib > > - > > -$(OFILES): Makefile *.h */*.h generated/map-shift.h generated/bit-length.h \ > > - ../../include/linux/*.h \ > > - ../../include/asm/*.h \ > > - ../../../include/linux/xarray.h \ > > - ../../../include/linux/maple_tree.h \ > > - ../../../include/linux/radix-tree.h \ > > - ../../../lib/radix-tree.h \ > > - ../../../include/linux/idr.h > > - > > -radix-tree.c: ../../../lib/radix-tree.c > > - sed -e 's/^static //' -e 's/__always_inline //' -e 's/inline //' < $< > $@ > > - > > -idr.c: ../../../lib/idr.c > > - sed -e 's/^static //' -e 's/__always_inline //' -e 's/inline //' < $< > $@ > > - > > -xarray.o: ../../../lib/xarray.c ../../../lib/test_xarray.c > > - > > -maple.o: ../../../lib/maple_tree.c ../../../lib/test_maple_tree.c > > - > > -generated/map-shift.h: > > - @if ! grep -qws $(SHIFT) generated/map-shift.h; then \ > > - echo "#define XA_CHUNK_SHIFT $(SHIFT)" > \ > > - generated/map-shift.h; \ > > - fi > > - > > -generated/bit-length.h: FORCE > > - @if ! grep -qws CONFIG_$(LONG_BIT)BIT generated/bit-length.h; then \ > > - echo "Generating $@"; \ > > - echo "#define CONFIG_$(LONG_BIT)BIT 1" > $@; \ > > - fi > > - > > -FORCE: ; > > +$(OFILES): $(SHARED_DEPS) *.h */*.h > > diff --git a/tools/testing/radix-tree/maple.c b/tools/testing/radix-tree/maple.c > > index f1caf4bcf937..5b53ecf22fc4 100644 > > --- a/tools/testing/radix-tree/maple.c > > +++ b/tools/testing/radix-tree/maple.c > > @@ -8,20 +8,8 @@ > > * difficult to handle in kernel tests. > > */ > > > > -#define CONFIG_DEBUG_MAPLE_TREE > > -#define CONFIG_MAPLE_SEARCH > > -#define MAPLE_32BIT (MAPLE_NODE_SLOTS > 31) > > +#include "maple-shared.h" > > #include "test.h" > > -#include > > -#include > > -#include "linux/init.h" > > - > > -#define module_init(x) > > -#define module_exit(x) > > -#define MODULE_AUTHOR(x) > > -#define MODULE_LICENSE(x) > > -#define dump_stack() assert(0) > > - > > #include "../../../lib/maple_tree.c" > > #include "../../../lib/test_maple_tree.c" > > > > diff --git a/tools/testing/radix-tree/xarray.c b/tools/testing/radix-tree/xarray.c > > index f20e12cbbfd4..253208a8541b 100644 > > --- a/tools/testing/radix-tree/xarray.c > > +++ b/tools/testing/radix-tree/xarray.c > > @@ -4,16 +4,9 @@ > > * Copyright (c) 2018 Matthew Wilcox > > */ > > > > -#define XA_DEBUG > > +#include "xarray-shared.h" > > #include "test.h" > > > > -#define module_init(x) > > -#define module_exit(x) > > -#define MODULE_AUTHOR(x) > > -#define MODULE_LICENSE(x) > > -#define dump_stack() assert(0) > > - > > -#include "../../../lib/xarray.c" > > #undef XA_DEBUG > > #include "../../../lib/test_xarray.c" > > > > diff --git a/tools/testing/shared/autoconf.h b/tools/testing/shared/autoconf.h > > new file mode 100644 > > index 000000000000..92dc474c349b > > --- /dev/null > > +++ b/tools/testing/shared/autoconf.h > > @@ -0,0 +1,2 @@ > > +#include "bit-length.h" > > +#define CONFIG_XARRAY_MULTI 1 > > diff --git a/tools/testing/radix-tree/bitmap.c b/tools/testing/shared/bitmap.c > > similarity index 100% > > rename from tools/testing/radix-tree/bitmap.c > > rename to tools/testing/shared/bitmap.c > > diff --git a/tools/testing/radix-tree/linux.c b/tools/testing/shared/linux.c > > similarity index 100% > > rename from tools/testing/radix-tree/linux.c > > rename to tools/testing/shared/linux.c > > diff --git a/tools/testing/radix-tree/linux/bug.h b/tools/testing/shared/linux/bug.h > > similarity index 100% > > rename from tools/testing/radix-tree/linux/bug.h > > rename to tools/testing/shared/linux/bug.h > > diff --git a/tools/testing/radix-tree/linux/cpu.h b/tools/testing/shared/linux/cpu.h > > similarity index 100% > > rename from tools/testing/radix-tree/linux/cpu.h > > rename to tools/testing/shared/linux/cpu.h > > diff --git a/tools/testing/radix-tree/linux/idr.h b/tools/testing/shared/linux/idr.h > > similarity index 100% > > rename from tools/testing/radix-tree/linux/idr.h > > rename to tools/testing/shared/linux/idr.h > > diff --git a/tools/testing/radix-tree/linux/init.h b/tools/testing/shared/linux/init.h > > similarity index 100% > > rename from tools/testing/radix-tree/linux/init.h > > rename to tools/testing/shared/linux/init.h > > diff --git a/tools/testing/radix-tree/linux/kconfig.h b/tools/testing/shared/linux/kconfig.h > > similarity index 100% > > rename from tools/testing/radix-tree/linux/kconfig.h > > rename to tools/testing/shared/linux/kconfig.h > > diff --git a/tools/testing/radix-tree/linux/kernel.h b/tools/testing/shared/linux/kernel.h > > similarity index 100% > > rename from tools/testing/radix-tree/linux/kernel.h > > rename to tools/testing/shared/linux/kernel.h > > diff --git a/tools/testing/radix-tree/linux/kmemleak.h b/tools/testing/shared/linux/kmemleak.h > > similarity index 100% > > rename from tools/testing/radix-tree/linux/kmemleak.h > > rename to tools/testing/shared/linux/kmemleak.h > > diff --git a/tools/testing/radix-tree/linux/local_lock.h b/tools/testing/shared/linux/local_lock.h > > similarity index 100% > > rename from tools/testing/radix-tree/linux/local_lock.h > > rename to tools/testing/shared/linux/local_lock.h > > diff --git a/tools/testing/radix-tree/linux/lockdep.h b/tools/testing/shared/linux/lockdep.h > > similarity index 100% > > rename from tools/testing/radix-tree/linux/lockdep.h > > rename to tools/testing/shared/linux/lockdep.h > > diff --git a/tools/testing/radix-tree/linux/maple_tree.h b/tools/testing/shared/linux/maple_tree.h > > similarity index 100% > > rename from tools/testing/radix-tree/linux/maple_tree.h > > rename to tools/testing/shared/linux/maple_tree.h > > diff --git a/tools/testing/radix-tree/linux/percpu.h b/tools/testing/shared/linux/percpu.h > > similarity index 100% > > rename from tools/testing/radix-tree/linux/percpu.h > > rename to tools/testing/shared/linux/percpu.h > > diff --git a/tools/testing/radix-tree/linux/preempt.h b/tools/testing/shared/linux/preempt.h > > similarity index 100% > > rename from tools/testing/radix-tree/linux/preempt.h > > rename to tools/testing/shared/linux/preempt.h > > diff --git a/tools/testing/radix-tree/linux/radix-tree.h b/tools/testing/shared/linux/radix-tree.h > > similarity index 100% > > rename from tools/testing/radix-tree/linux/radix-tree.h > > rename to tools/testing/shared/linux/radix-tree.h > > diff --git a/tools/testing/radix-tree/linux/rcupdate.h b/tools/testing/shared/linux/rcupdate.h > > similarity index 100% > > rename from tools/testing/radix-tree/linux/rcupdate.h > > rename to tools/testing/shared/linux/rcupdate.h > > diff --git a/tools/testing/radix-tree/linux/xarray.h b/tools/testing/shared/linux/xarray.h > > similarity index 100% > > rename from tools/testing/radix-tree/linux/xarray.h > > rename to tools/testing/shared/linux/xarray.h > > diff --git a/tools/testing/shared/maple-shared.h b/tools/testing/shared/maple-shared.h > > new file mode 100644 > > index 000000000000..3d847edd149d > > --- /dev/null > > +++ b/tools/testing/shared/maple-shared.h > > @@ -0,0 +1,9 @@ > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > + > > +#define CONFIG_DEBUG_MAPLE_TREE > > +#define CONFIG_MAPLE_SEARCH > > +#define MAPLE_32BIT (MAPLE_NODE_SLOTS > 31) > > +#include "shared.h" > > +#include > > +#include > > +#include "linux/init.h" > > diff --git a/tools/testing/shared/maple-shim.c b/tools/testing/shared/maple-shim.c > > new file mode 100644 > > index 000000000000..640df76f483e > > --- /dev/null > > +++ b/tools/testing/shared/maple-shim.c > > @@ -0,0 +1,7 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later > > + > > +/* Very simple shim around the maple tree. */ > > + > > +#include "maple-shared.h" > > + > > +#include "../../../lib/maple_tree.c" > > diff --git a/tools/testing/shared/shared.h b/tools/testing/shared/shared.h > > new file mode 100644 > > index 000000000000..495602e60b65 > > --- /dev/null > > +++ b/tools/testing/shared/shared.h > > @@ -0,0 +1,34 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > + > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include > > + > > +#ifndef module_init > > +#define module_init(x) > > +#endif > > + > > +#ifndef module_exit > > +#define module_exit(x) > > +#endif > > + > > +#ifndef MODULE_AUTHOR > > +#define MODULE_AUTHOR(x) > > +#endif > > + > > +#ifndef MODULE_LICENSE > > +#define MODULE_LICENSE(x) > > +#endif > > + > > +#ifndef MODULE_DESCRIPTION > > +#define MODULE_DESCRIPTION(x) > > +#endif > > + > > +#ifndef dump_stack > > +#define dump_stack() assert(0) > > +#endif > > diff --git a/tools/testing/shared/shared.mk b/tools/testing/shared/shared.mk > > new file mode 100644 > > index 000000000000..69a6a528eaed > > --- /dev/null > > +++ b/tools/testing/shared/shared.mk > > @@ -0,0 +1,68 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > + > > +CFLAGS += -I../shared -I. -I../../include -I../../../lib -g -Og -Wall \ > > + -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined > > +LDFLAGS += -fsanitize=address -fsanitize=undefined > > +LDLIBS += -lpthread -lurcu > > +SHARED_OFILES = xarray-shared.o radix-tree.o idr.o linux.o find_bit.o bitmap.o \ > > + slab.o > > +SHARED_DEPS = Makefile ../shared/shared.mk ../shared/*.h generated/map-shift.h \ > > + generated/bit-length.h generated/autoconf.h \ > > + ../../include/linux/*.h \ > > + ../../include/asm/*.h \ > > + ../../../include/linux/xarray.h \ > > + ../../../include/linux/maple_tree.h \ > > + ../../../include/linux/radix-tree.h \ > > + ../../../lib/radix-tree.h \ > > + ../../../include/linux/idr.h > > + > > +ifndef SHIFT > > + SHIFT=3 > > +endif > > + > > +ifeq ($(BUILD), 32) > > + CFLAGS += -m32 > > + LDFLAGS += -m32 > > +LONG_BIT := 32 > > +endif > > + > > +ifndef LONG_BIT > > +LONG_BIT := $(shell getconf LONG_BIT) > > +endif > > + > > +%.o: ../shared/%.c > > + $(CC) -c $(CFLAGS) $(CPPFLAGS) $< -o $@ > > + > > +vpath %.c ../../lib > > + > > +$(SHARED_OFILES): $(SHARED_DEPS) > > + > > +radix-tree.c: ../../../lib/radix-tree.c > > + sed -e 's/^static //' -e 's/__always_inline //' -e 's/inline //' < $< > $@ > > + > > +idr.c: ../../../lib/idr.c > > + sed -e 's/^static //' -e 's/__always_inline //' -e 's/inline //' < $< > $@ > > + > > +xarray-shared.o: ../shared/xarray-shared.c ../../../lib/xarray.c \ > > + ../../../lib/test_xarray.c > > + > > +maple-shared.o: ../shared/maple-shared.c ../../../lib/maple_tree.c \ > > + ../../../lib/test_maple_tree.c > > + > > +generated/autoconf.h: > > + cp ../shared/autoconf.h generated/autoconf.h > > + > > +generated/map-shift.h: > > + @if ! grep -qws $(SHIFT) generated/map-shift.h; then \ > > + echo "Generating $@"; \ > > + echo "#define XA_CHUNK_SHIFT $(SHIFT)" > \ > > + generated/map-shift.h; \ > > + fi > > + > > +generated/bit-length.h: FORCE > > + @if ! grep -qws CONFIG_$(LONG_BIT)BIT generated/bit-length.h; then \ > > + echo "Generating $@"; \ > > + echo "#define CONFIG_$(LONG_BIT)BIT 1" > $@; \ > > + fi > > + > > +FORCE: ; > > diff --git a/tools/testing/shared/trace/events/maple_tree.h b/tools/testing/shared/trace/events/maple_tree.h > > new file mode 100644 > > index 000000000000..97d0e1ddcf08 > > --- /dev/null > > +++ b/tools/testing/shared/trace/events/maple_tree.h > > @@ -0,0 +1,5 @@ > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > + > > +#define trace_ma_op(a, b) do {} while (0) > > +#define trace_ma_read(a, b) do {} while (0) > > +#define trace_ma_write(a, b, c, d) do {} while (0) > > diff --git a/tools/testing/shared/xarray-shared.c b/tools/testing/shared/xarray-shared.c > > new file mode 100644 > > index 000000000000..e90901958dcd > > --- /dev/null > > +++ b/tools/testing/shared/xarray-shared.c > > @@ -0,0 +1,5 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later > > + > > +#include "xarray-shared.h" > > + > > +#include "../../../lib/xarray.c" > > diff --git a/tools/testing/shared/xarray-shared.h b/tools/testing/shared/xarray-shared.h > > new file mode 100644 > > index 000000000000..ac2d16ff53ae > > --- /dev/null > > +++ b/tools/testing/shared/xarray-shared.h > > @@ -0,0 +1,4 @@ > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > + > > +#define XA_DEBUG > > +#include "shared.h" > > -- > > 2.45.1 > >