From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB60C48297 for ; Mon, 12 Feb 2024 12:14:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35EBB6B0072; Mon, 12 Feb 2024 07:14:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 30E6D6B0074; Mon, 12 Feb 2024 07:14:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 187AC6B0075; Mon, 12 Feb 2024 07:14:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 095476B0072 for ; Mon, 12 Feb 2024 07:14:32 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A4BEC40177 for ; Mon, 12 Feb 2024 12:14:31 +0000 (UTC) X-FDA: 81783044742.27.C4833FD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 33F7240011 for ; Mon, 12 Feb 2024 12:14:29 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MWjTPFy8; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707740069; a=rsa-sha256; cv=none; b=O/vaQiBEYNaTU9nXxTL1Semi45ynB4oOAgyGwdkpjA0WWykYJReD5zHWpAw8/BUa4nxzIt mmImbK53X2mg/WXFmJA47slxmRNJncw8kq24ziLjrNWwcJAKk97Wv9Un6gDla1NgOrPWBv US6D/rcAk4qbu/9nvo5RBaeIeQeNBzo= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=MWjTPFy8; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707740069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pFmZN5D+FLkUR/TqfEmtJ0sttF3Ny0Zc/N855oN1DmU=; b=bFbgwocDLjkB392VgAXRaSZ3P+KKSAokOLDH5zFArfAR2cE6tiD2Qt1UzzfB+ZJ5FYmfUs OKvNRayw5C17z+NsAQvQkTowykWd3qdodRIGbw/HsUvvNjTccWakTxlJg0ptq7fgt64osU qbDrVwsnHtznDVWb6SUjuys6NtYqtfI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707740068; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pFmZN5D+FLkUR/TqfEmtJ0sttF3Ny0Zc/N855oN1DmU=; b=MWjTPFy8tyOxjDG7G6/KLw5Or3I+bK+qMmv2ZkM+oZly8LDAfKysm6llMixpIpbIGynx5j bph+UZX8cJfpPxHT3bJKc+ncRBpRe+5V6LiTsI9Agg7RNP7YYydxcaVxas1HSe+lUdh7SJ 3aovxi/UTR3e1+fMzMi2ustUDRUMy44= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-0E_X7LhgM5GVuzT2wvv_Mw-1; Mon, 12 Feb 2024 07:14:27 -0500 X-MC-Unique: 0E_X7LhgM5GVuzT2wvv_Mw-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-50ec9529001so3115812e87.2 for ; Mon, 12 Feb 2024 04:14:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707740065; x=1708344865; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pFmZN5D+FLkUR/TqfEmtJ0sttF3Ny0Zc/N855oN1DmU=; b=CuSEX15oE5jLk0aC1klMsvHRn+8T64uMj38ec3JbRC911frTqa9obqIIyCiHvrWJvM lgjMLLXQAaiaW+Yw99fHcGKhH0LUNDGtcz6iFOrj2UuBJabUl7BNShFSiZDgCKXsd7LL GMt3yyvMUwJIVyAdjbXPQcqcDqBKFsGK7Gr1FVLDL9MbiufmgUapYMjmSEcc/ounz1sw 02ckcYu1uA8TE0P//lCs5azl9yJILYiJhmBSrt+oUn9rcOQ3O/OzGaa3whjgENmugiGB ukRRIkc5wV0gHLRaFDZlVfBp4l9QKyeMc1tdgRUmolXkOE26YxmzshTPzYdMINBS2eDi wMOQ== X-Forwarded-Encrypted: i=1; AJvYcCWf4oRb2Ptl9QMxVsgHshDNeVJYcCFAvZlGxdjRT/uRGc1PtLxXUID0o8PhQ/M02OFxN2PsUAx80a7lLJ6KxDCCZ50= X-Gm-Message-State: AOJu0YyB99sviUOAsmJpY4gI6ecMuy6vDtmTymmL+IpcoHPDszXLsHkq pFEMuUjp7t0dMvLYzhuRulZQSldOMvrWzNj/6Mx1zP2ePOdRNGlAX2gEPWOYyVWdMCpA4CWcmeF 3j7TmAH00aL9l6ZwMFPD9gUtk02FzoyRbqI/gHgns1vFpnsQf X-Received: by 2002:a05:6512:39c9:b0:511:751c:7e8f with SMTP id k9-20020a05651239c900b00511751c7e8fmr4678235lfu.20.1707740065658; Mon, 12 Feb 2024 04:14:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IEfvRMFMBzLv20u7RK1sffSKRqvL876q4EvpSF1avR8GYZmBmJqkptYtg77nabHSr6SBVyRxw== X-Received: by 2002:a05:6512:39c9:b0:511:751c:7e8f with SMTP id k9-20020a05651239c900b00511751c7e8fmr4678188lfu.20.1707740065123; Mon, 12 Feb 2024 04:14:25 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWin1JcrzkSHrzXWn9NgERU1bRLCGCJmSYsfWUE1Od2oRRe6X1Bvd7ng1cs1dC1WVKDTfFn08/VMnSZDG0Mvx2X9Det59j0bGx41Nv6uj4UY71dgUvdLRhV/SLXp8xFc/1teR4RCtNkBRrYFgWZNNxvmID3326dbEcsOqwzumRnQSASEI0wYBi3PEBSNoStgvtbyNeWpzzBlvqkYjbOzoUJdBHvHBdeAE8jIgKcJ4qW+LRY4kwh+gPsVsss6PU97R866f2R/IragU//+z3eijNEkM4+n+ZwADmS4jvU73NJ6mauZui+QlX+jSe6Ld+T0AFs/rrQn2zAxWYBqlz2nP3FdPsIHwitRXQtN/UyzXyMc+BQ1Oo3cSkXtrs6M9HxVxzi2g+gv57LWHD7XVsOCOvDdnTPdZPN7crMZ5WWohiyyi5k2aPOQcdjFtRFEgqXzoBgVA/6Up29knbYbxje4Eixf96iuwaJ7GQ64S+z5+ZdNLu+18nTjDhfMFZmvmnzham9cxa9/U/rcUdRx7xvi4RlYlXqEsy/DvCBpFrYzMRt92NmvkQl+g6hKDXwxTW5UzlcKKixMaS7fHzEosfl3q9nm6SUk59RdzfOSew7Y0gd2RuNurV5j9tzuvBWCB9ssXeiUjyoBhdUdtmGFuDZns7usjCkgDVTh9DfBhJITZKUh/X1zE2EXw1wz6bxdZlIynR7grKLrWEOZSI6GNLC7V0CdBVdRj6xytotCrTVH+cH5HyAu49HNHbH3180mcDDx0blzsXmgJmMj+Tob6Qn9zURZdCxFwJyNUy3qVRJvuyBXiPOWzFDsu/v+s3j5AnAITgoS9mHgQFC0KqfiMwsEAbut24ZL93SsLjpsEcfCPte Received: from ?IPV6:2003:cb:c730:2200:7229:83b1:524e:283a? (p200300cbc7302200722983b1524e283a.dip0.t-ipconnect.de. [2003:cb:c730:2200:7229:83b1:524e:283a]) by smtp.gmail.com with ESMTPSA id g8-20020a05600c310800b00410cfc34260sm3105364wmo.2.2024.02.12.04.14.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Feb 2024 04:14:24 -0800 (PST) Message-ID: Date: Mon, 12 Feb 2024 13:14:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 03/25] mm: Make pte_next_pfn() a wrapper around pte_advance_pfn() To: Ryan Roberts , Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , Mark Rutland , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Cc: linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240202080756.1453939-1-ryan.roberts@arm.com> <20240202080756.1453939-4-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240202080756.1453939-4-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 33F7240011 X-Stat-Signature: iki7f4n5b6uxg7jkfcqfstfdtazzbzjs X-Rspam-User: X-HE-Tag: 1707740069-497190 X-HE-Meta: U2FsdGVkX1/DwouFRJzp6SsMzfrxCthe6FDlQWqQZe96sQ7wTYohfzd13dS0XOajfs+QHyKq+MQznscsFgKseE3byLRAOUE3LKW60flZ2sQuK8680Bw36NB77+S47qXzDW8ftcy18lZwr4XZrPrxjL8IKvTiXvsL6YUv/4I6+EaZsYyN5LL9Br4+QtW2AR0kZkTDG+zK9ESh1Ukhpf9T7xWsD0Xu21CVV+x5Hzye1XHyxzxqc+6v56OXMWToT3PvKEx/jDuiA8VPCHg3hIWH3Wci4sgPttAccBTQL3QjlA4jM8p486X3JlU9AOoRlHKe4j5mTngxnVHLscNROlz5Se3RZURElviogfw4QBbkdxm7YuLJMZqTRXo6VVbvJzgqwgWzjv1GEAE9pZt43dJXpLhjv732kzcukNdqMk90UfaZ+9FQQvAqRk5JnMtBIyqZ4GO1rdF1dWnMca1Eye4xs+JA9w00PdCdP7IPwJ0Kubp5rtqc2ANjRaEYDpjFXOAFsozmLmbl68u8/d0zf4CjEdvPLM3NOyPhiAStayHAbf2Hv/HhOaJjkEmlbha2v9LaETKx03hPrm8q2j9Q8mDFeGjSvf7Ep5uYQtPUyyZksw65toUgoH1FClbNi4RarFHQZh25nXNsU0/ESEDd2zobmuDO4WFXfpwO8xvVg4MbUgPSsRogTu1lx3iF8jBkizo0ZMqNRXEh/oLPzTaN+6+8GFII0ihHfm9xQGhQsGL8BAd6a74wfKqTwsYyLE5upn7X+Mj6SiqXLi1yS/K8G2Ftdys0S4IHm54DLp2PG8H4YvUzaf25Z8Z39yMgmN16bOm8E79C8NnLT1AvRYSAxuGW1eGuLt487IVPElLqSmGT8viTYSFmed2nO7u1/GOkDVpgnbZvj+p5OHG/KENGbyq3mS4ECrV/UHnTQuDx7KIfJC9OpqOiR6fwvoz2rJHpd3MDh853jL/wqZ2nhlG1zpy s5lQMTQ6 jap6HlTVQz7qjRBq61+N8EcprYxHqek7gucuUoMlC3Ch6/CkJSSvJm2gfbdDM/cQqhFoNxkrCTMcTqB5SLGpIgLZG2BMHSK9rgizHp0DM6IOtjKi9IwBLh+nhR2QZMlL2TxxtNpMLiMMtZ9ewLYceGSF34n8Nm8+tH45uA3nSoVM8voc3TRrEIlmXI7JlwtvhE/gvZu3Mf4B9Ht2WmpS3weH4oE739IQRgBYIaAQmFTXb9iNASjXV6khSAjKsyZAQBW0ulbm7+mJWQxEF+qwax8TYZzmRnb/kceUsvaXpAbunkb0aRqqd848Hwh4rJ3nYX4zBQaboC5kf+YOZJhZ/wzmJSRwD+wheCgQUApChrsi/uPpqfDYYxA2N7ofmBGRmf7fztkrxKaf3MY1f0gkVVpCfjdhkPqlrgYUN+Pa488oZ5gCT4U5c96+wAfp7AF1L3tyh8kSFob+6MEarRlVgywDEbCF6A6Wa7mauT55cEx9y3xbArw9zHw0+CLb5ZktdStscx96YQV9QdbxF+ziZIUS3OlDAfGB4oSL+18U9WHvbheyNaM9SrgmizJlfIdvnJt11dEsXWUhI7se3ZiUHofk9/IWWR259WATt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.02.24 09:07, Ryan Roberts wrote: > The goal is to be able to advance a PTE by an arbitrary number of PFNs. > So introduce a new API that takes a nr param. > > We are going to remove pte_next_pfn() and replace it with > pte_advance_pfn(). As a first step, implement pte_next_pfn() as a > wrapper around pte_advance_pfn() so that we can incrementally switch the > architectures over. Once all arches are moved over, we will change all > the core-mm callers to call pte_advance_pfn() directly and remove the > wrapper. > > Signed-off-by: Ryan Roberts > --- > include/linux/pgtable.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index 5e7eaf8f2b97..815d92dcb96b 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -214,9 +214,15 @@ static inline int pmd_dirty(pmd_t pmd) > > > #ifndef pte_next_pfn > +#ifndef pte_advance_pfn > +static inline pte_t pte_advance_pfn(pte_t pte, unsigned long nr) > +{ > + return __pte(pte_val(pte) + (nr << PFN_PTE_SHIFT)); > +} > +#endif > static inline pte_t pte_next_pfn(pte_t pte) > { > - return __pte(pte_val(pte) + (1UL << PFN_PTE_SHIFT)); > + return pte_advance_pfn(pte, 1); > } > #endif > I do wonder if we simply want to leave pte_next_pfn() around? Especially patch #4, #6 don't really benefit from the change? So are the other set_ptes() implementations. That is, only convert all pte_next_pfn()->pte_advance_pfn(), and leave a pte_next_pfn() macro in place. Any downsides to that? This patch here would become: #ifndef pte_advance_pfn static inline pte_t pte_advance_pfn(pte_t pte, unsigned long nr) { return __pte(pte_val(pte) + (nr << PFN_PTE_SHIFT)); } #endif #ifndef pte_next_pfn #define pte_next_pfn(pte) pte_advance_pfn(pte, 1) #endif As you convert the three arches, make them define pte_advance_pfn and udnefine pte_next_pfn. in the end, you can drop the #ifdef around pte_next_pfn here. -- Cheers, David / dhildenb