From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 289CEC4321E for ; Tue, 29 Nov 2022 13:56:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B0E426B0071; Tue, 29 Nov 2022 08:56:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ABE006B0074; Tue, 29 Nov 2022 08:56:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 985956B0075; Tue, 29 Nov 2022 08:56:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 880906B0071 for ; Tue, 29 Nov 2022 08:56:28 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 188DF806EB for ; Tue, 29 Nov 2022 09:08:53 +0000 (UTC) X-FDA: 80185904946.21.306C8CB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id A414418000C for ; Tue, 29 Nov 2022 09:08:52 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 82AE4615E9; Tue, 29 Nov 2022 09:08:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EBBAC433D6; Tue, 29 Nov 2022 09:08:43 +0000 (UTC) Message-ID: Date: Tue, 29 Nov 2022 10:08:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage Content-Language: en-US To: David Hildenbrand , Andrew Morton Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, Linus Torvalds , Jason Gunthorpe , John Hubbard , Peter Xu , Greg Kroah-Hartman , Andrea Arcangeli , Hugh Dickins , Nadav Amit , Vlastimil Babka , Matthew Wilcox , Mike Kravetz , Muchun Song , Shuah Khan , Lucas Stach , David Airlie , Oded Gabbay , Arnd Bergmann , Christoph Hellwig , Alex Williamson , Marek Szyprowski , Tomasz Figa , Mauro Carvalho Chehab References: <20221116102659.70287-1-david@redhat.com> <20221116102659.70287-17-david@redhat.com> <81fb0fa3-2e06-b765-56ac-a7d981194e59@redhat.com> <08b65ac6-6786-1080-18f8-d2be109c85fc@xs4all.nl> <9d0bf98a-3d6a-1082-e992-1338e1525935@redhat.com> <20221128145927.df895bf1966cfa125cae9668@linux-foundation.org> <22b1107b-0acc-5772-a883-8f3c4682eb1b@redhat.com> From: Hans Verkuil In-Reply-To: <22b1107b-0acc-5772-a883-8f3c4682eb1b@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669712932; a=rsa-sha256; cv=none; b=MBxP4Zve8mxC7NgG8WXa+dzOc/qeBaw4ftU2tkGRqsenZouiZAhQNEo77YlMJGe+HsOxUH V5RzS+KdFWMnK2HUBirTO4eJ/K68ev+FH7RCu8PCSjqbMnBTEKYZpYU2cVBpVxfy4XGd2g KGFYSJdEvcI2fRCsbKki8keoqyI0zSY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=xs4all.nl (policy=none); spf=pass (imf16.hostedemail.com: domain of "SRS0=crSJ=35=xs4all.nl=hverkuil@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=crSJ=35=xs4all.nl=hverkuil@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669712932; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X+JuwDpssPXiak/ZVsKl/I0/iubhygsb+K4uMB9YEMY=; b=auFNjIfa8CN8aRAE94TM+IRD84WYh3NEYA1E4UoytDFZc7NAfS0F0FxFJ5Apna5YU4EXuT aqYfhcqU8gF06ccyDyd1uEFm5FhVqXKXUJGKnyvFLpBBzsjU07vFu2+cq9nJBgh5/UlFDM Gc932acg5qiza1G21URSXOIcrDfeRqE= X-Rspamd-Queue-Id: A414418000C Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=xs4all.nl (policy=none); spf=pass (imf16.hostedemail.com: domain of "SRS0=crSJ=35=xs4all.nl=hverkuil@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=crSJ=35=xs4all.nl=hverkuil@kernel.org" X-Rspamd-Server: rspam12 X-Rspam-User: X-Stat-Signature: rau6rmxssj9hiwg7c48fcuipgd9g48h9 X-HE-Tag: 1669712932-10958 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29/11/2022 09:48, David Hildenbrand wrote: > On 28.11.22 23:59, Andrew Morton wrote: >> On Mon, 28 Nov 2022 09:18:47 +0100 David Hildenbrand wrote: >> >>>> Less chances of things going wrong that way. >>>> >>>> Just mention in the v2 cover letter that the first patch was added to >>>> make it easy to backport that fix without being hampered by merge >>>> conflicts if it was added after your frame_vector.c patch. >>> >>> Yes, that's the way I would naturally do, it, however, Andrew prefers >>> delta updates for minor changes. >>> >>> @Andrew, whatever you prefer! >> >> I'm inclined to let things sit as they are.  Cross-tree conflicts >> happen, and Linus handles them.  I'll flag this (very simple) conflict >> in the pull request, if MM merges second.  If v4l merges second then >> hopefully they will do the same.  But this one is so simple that Linus >> hardly needs our help. It's not about cross-tree conflicts, it's about the fact that my patch is a fix that needs to be backported to older kernels. It should apply cleanly to those older kernels if my patch goes in first, but if it is the other way around I would have to make a new patch for the stable kernels. Also, the updated changelog in David's patch that sits on top of mine makes a lot more sense. If you really don't want to take my patch as part of this, then let me know and I'll take it through the media subsystem and hope for the best :-) Regards, Hans >> >> But Linus won't be editing changelogs so that the changelog makes more >> sense after both trees are joined.  I'm inclined to let the changelog >> sit as it is as well. > > Works for me. Thanks Andrew! >