From: Randy Dunlap <rdunlap@infradead.org>
To: Kees Cook <keescook@chromium.org>
Cc: Rick Edgecombe <rick.p.edgecombe@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
kristen Accardi <kristen.c.accardi@intel.com>,
Dave Hansen <dave.hansen@intel.com>,
"Van De Ven, Arjan" <arjan.van.de.ven@intel.com>
Subject: Re: [PATCH 1/3] vmalloc: Add __vmalloc_node_try_addr function
Date: Wed, 20 Jun 2018 16:16:42 -0700 [thread overview]
Message-ID: <c26266cf-1f90-2688-d131-501dbaf9460a@infradead.org> (raw)
In-Reply-To: <CAGXu5j+TpZict=pSenHQ+_6V2fgoDrAGiB8sCd6bk-tb_Ec0zw@mail.gmail.com>
On 06/20/2018 04:05 PM, Kees Cook wrote:
> On Wed, Jun 20, 2018 at 3:44 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
>> On 06/20/2018 03:35 PM, Kees Cook wrote:
>>> On Wed, Jun 20, 2018 at 3:16 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
>>>> On 06/20/2018 03:09 PM, Rick Edgecombe wrote:
>>>>> +void *__vmalloc_node_try_addr(unsigned long addr, unsigned long size,
>>>>> + gfp_t gfp_mask, pgprot_t prot, unsigned long vm_flags,
>>>>> + int node, const void *caller)
>>>>> +{
>>>>
>>>> so this isn't optional, eh? You are going to force it on people because?
>>>
>>> RANDOMIZE_BASE isn't optional either. :) This improves the module
>>> address entropy with (what seems to be) no down-side, so yeah, I think
>>> it should be non-optional. :)
>>
>> In what kernel tree is RANDOMIZE_BASE not optional?
>
> Oh, sorry, I misspoke: on by default. It _is_ possible to turn it off.
>
> But patch #2 does check for RANDOMIZE_BASE, so it should work as expected, yes?
>
> Or did you want even this helper function to be compiled out without it?
Thanks, I missed it. :(
Looks fine.
--
~Randy
next prev parent reply other threads:[~2018-06-20 23:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 22:09 [PATCH 0/3] KASLR feature to randomize each loadable module Rick Edgecombe
2018-06-20 22:09 ` [PATCH 1/3] vmalloc: Add __vmalloc_node_try_addr function Rick Edgecombe
2018-06-20 22:16 ` Randy Dunlap
2018-06-20 22:35 ` Kees Cook
2018-06-20 22:44 ` Randy Dunlap
2018-06-20 23:05 ` Kees Cook
2018-06-20 23:16 ` Randy Dunlap [this message]
2018-06-20 22:26 ` Matthew Wilcox
2018-06-21 22:02 ` Edgecombe, Rick P
2018-06-20 22:09 ` [PATCH 2/3] x86/modules: Increase randomization for modules Rick Edgecombe
2018-06-20 22:09 ` [PATCH 3/3] vmalloc: Add debugfs modfraginfo Rick Edgecombe
2018-06-21 0:53 ` kbuild test robot
2018-06-21 1:17 ` kbuild test robot
2018-06-21 12:32 ` Jann Horn
2018-06-21 18:56 ` Edgecombe, Rick P
2018-06-20 22:33 ` [PATCH 0/3] KASLR feature to randomize each loadable module Kees Cook
2018-06-21 13:37 ` Jann Horn
2018-06-21 13:39 ` Jann Horn
2018-06-21 18:59 ` Edgecombe, Rick P
2018-06-21 21:23 ` Daniel Borkmann
2018-06-21 18:56 ` Edgecombe, Rick P
2018-07-07 0:35 [PATCH RFC V2 " Rick Edgecombe
2018-07-07 0:35 ` [PATCH 1/3] vmalloc: Add __vmalloc_node_try_addr function Rick Edgecombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c26266cf-1f90-2688-d131-501dbaf9460a@infradead.org \
--to=rdunlap@infradead.org \
--cc=arjan.van.de.ven@intel.com \
--cc=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=rick.p.edgecombe@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox