From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34380C433FE for ; Wed, 2 Feb 2022 13:45:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7BA28D00FC; Wed, 2 Feb 2022 08:45:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2B858D00FA; Wed, 2 Feb 2022 08:45:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CB9B8D00FC; Wed, 2 Feb 2022 08:45:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id 79D338D00FA for ; Wed, 2 Feb 2022 08:45:56 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 35079815A76C for ; Wed, 2 Feb 2022 13:45:56 +0000 (UTC) X-FDA: 79097963112.24.A5740D1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id A8D6E40006 for ; Wed, 2 Feb 2022 13:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643809555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YxruncnGKSYEtQADjLUNkNWhCcGBbzpK2sbDwkeQUpo=; b=IvlHLOIoAfjxqUryG5VtmgReaCtzLoMtgEAAKndnl8Lqi914pDdVatgXRntOsQovBp53GE EyeC3I9hFv8V8pRcIotB0VS/+D0GazCr7QtuFhOA16z9du7/fUdOXcleb1D3uDxp0yBjcv uKzYQh460kzzs7wa0ybeaECp/Y3LALQ= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-30-C7husQ3WOz6-sBz_mHGedg-1; Wed, 02 Feb 2022 08:45:54 -0500 X-MC-Unique: C7husQ3WOz6-sBz_mHGedg-1 Received: by mail-ed1-f72.google.com with SMTP id i22-20020a0564020f1600b00407b56326a2so10457187eda.18 for ; Wed, 02 Feb 2022 05:45:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=YxruncnGKSYEtQADjLUNkNWhCcGBbzpK2sbDwkeQUpo=; b=MBj/URRufWL6jDLrBiFpj0mmLGoW0mO5U6hzuoQDrbkTQ2Cles0SQnmI3HAJ7WrJvq g449qXN/3Y2zS2OZErMbFeHxMtKOsZJxAoCwAF/apUD61VNU+/vqoZR0Z/NiTCHiDvZ+ nIibhWK7crKbTzEzfHb6apVMi5W4mZNvdmIGqZjxyCcwFwYen8t8aCUtPH/k2dTUV4fP aBHL68HkuQYxlnuhhgZO3kCJySYaKNLFNjWItVzbguIdSmSj1b4mvbWdv2yfLwl5Nqln mFnZVUxNqUFhv8NZDPA8XvlQfjaSHIO9rJcRIAIU3qF8FCLjqPOm9mmv0xsOIxvU8Nz4 fGxQ== X-Gm-Message-State: AOAM530+0QpDyQIb7+1VMCEw70G/Skbc14q4o22v/CC1GXIaFMiIsBjO lkK+tvJQ92QR4gXDOB3YRvJqYmCcJkqBYFLySSohOFP+F52sw48WHo5TdGqe6Dv8zArTyNYYBRF WK8I4f/R16WY= X-Received: by 2002:a05:6402:5248:: with SMTP id t8mr30084290edd.14.1643809552858; Wed, 02 Feb 2022 05:45:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJxqE4L2UK0676VaeKIuCkwGMt3tw/zzsCSLR83dbtSZbWUp25WGEt3s5690JhdDTieh82ha0w== X-Received: by 2002:a05:6402:5248:: with SMTP id t8mr30084241edd.14.1643809552570; Wed, 02 Feb 2022 05:45:52 -0800 (PST) Received: from ?IPV6:2003:cb:c709:f800:a55c:e484:3cd9:3632? (p200300cbc709f800a55ce4843cd93632.dip0.t-ipconnect.de. [2003:cb:c709:f800:a55c:e484:3cd9:3632]) by smtp.gmail.com with ESMTPSA id z8sm15746580ejc.151.2022.02.02.05.45.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Feb 2022 05:45:52 -0800 (PST) Message-ID: Date: Wed, 2 Feb 2022 14:45:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH RFC v1] drivers/base/node: consolidate node device subsystem initialization in node_dev_init() To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , Greg Kroah-Hartman , Michal Hocko , Oscar Salvador , Catalin Marinas , Will Deacon , Thomas Bogendoerfer , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Yoshinori Sato , Rich Felker , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "Rafael J. Wysocki" , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org References: <20220128151540.164759-1-david@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220128151540.164759-1-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A8D6E40006 X-Stat-Signature: a9fezt6ciait4e1yrf15f6amnsjtbd5g X-Rspam-User: nil Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IvlHLOIo; spf=none (imf04.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-HE-Tag: 1643809555-84115 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.01.22 16:15, David Hildenbrand wrote: > ... and call node_dev_init() after memory_dev_init() from driver_init(), > so before any of the existing arch/subsys calls. All online nodes should > be known at that point. > > This is in line with memory_dev_init(), which initializes the memory > device subsystem and creates all memory block devices. > > Similar to memory_dev_init(), panic() if anything goes wrong, we don't > want to continue with such basic initialization errors. > > The important part is that node_dev_init() gets called after > memory_dev_init() and after cpu_dev_init(), but before any of the > relevant archs call register_cpu() to register the new cpu device under > the node device. The latter should be the case for the current users > of topology_init(). > > Cc: Andrew Morton > Cc: Greg Kroah-Hartman > Cc: Michal Hocko > Cc: Oscar Salvador > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Thomas Bogendoerfer > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Paul Walmsley > Cc: Palmer Dabbelt > Cc: Albert Ou > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: "David S. Miller" > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: "Rafael J. Wysocki" > Cc: x86@kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-ia64@vger.kernel.org > Cc: linux-mips@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-riscv@lists.infradead.org > Cc: linux-s390@vger.kernel.org > Cc: linux-sh@vger.kernel.org > Cc: sparclinux@vger.kernel.org > Cc: linux-mm@kvack.org > Signed-off-by: David Hildenbrand If there are no further comments, then I'll resend as !RFC with a slightly extended patch description, testing at least under arm64 and ppc64 as they are relatively easy to test for me. -- Thanks, David / dhildenb