From: Markus Elfring <Markus.Elfring@web.de>
To: "Karan Sanghavi" <karansanghvi98@gmail.com>,
linux-mm@kvack.org, "André Almeida" <andrealmeid@igalia.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Christian Brauner" <brauner@kernel.org>,
"Gabriel Krisman Bertazi" <gabriel@krisman.be>,
"Hugh Dickins" <hughd@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] mm: shmem: Fix variable type to int to evaluate negative conditions
Date: Sun, 24 Nov 2024 12:33:27 +0100 [thread overview]
Message-ID: <c249c855-aae6-4020-9ace-3b9528fd8422@web.de> (raw)
In-Reply-To: <20241111-unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com>
…
> ---
> Coverity Message:
> CID 1601569: (#1 of 1): Unsigned compared against 0 (NO_EFFECT)
…
Can such information become a part of the change description?
Would a summary phrase like “Use signed data type for version handling
in shmem_parse_opt_casefold()” be more appropriate?
Regards,
Markus
prev parent reply other threads:[~2024-11-24 11:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 17:10 Karan Sanghavi
2024-11-11 17:19 ` André Almeida
2024-11-11 18:37 ` Gabriel Krisman Bertazi
2024-11-24 8:02 ` Karan Sanghavi
2024-11-24 11:33 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c249c855-aae6-4020-9ace-3b9528fd8422@web.de \
--to=markus.elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=andrealmeid@igalia.com \
--cc=brauner@kernel.org \
--cc=gabriel@krisman.be \
--cc=hughd@google.com \
--cc=karansanghvi98@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox