From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07D9CC7EE23 for ; Mon, 29 May 2023 17:13:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 721956B0075; Mon, 29 May 2023 13:13:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6AAAF280002; Mon, 29 May 2023 13:13:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54BA8280001; Mon, 29 May 2023 13:13:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 46B036B0075 for ; Mon, 29 May 2023 13:13:03 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DAF961A02B6 for ; Mon, 29 May 2023 17:13:02 +0000 (UTC) X-FDA: 80843937804.21.6547DE5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf03.hostedemail.com (Postfix) with ESMTP id DF13620014 for ; Mon, 29 May 2023 17:13:00 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=IfKR3S49; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="lncwWhG/"; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685380381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rB9VfmOx0wBbizK583+OAKBFCiJju0fCCUZtBDpksf0=; b=w/y6bTTPS/JtQNq4fnGmPuKoV1cxxp2volrE24COUFS3Dx/qLoiGJf3WWKWxpn8kSbm2yF Dh7xjGsCSgpnDziE5LEdkQm98NmKg03C17E+plApbB8sLo+PPncNKARiiD0OzM4Uh/dhAa BIEPuDJJIFYZP0nrxAhEuM2UbgiDpaY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=IfKR3S49; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="lncwWhG/"; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685380381; a=rsa-sha256; cv=none; b=7AiFqVWpZS9a6hwK6mrIfBicI51YRgCBd8Pj/LAezKveBPS9T0KvqBAvQRC73pm22WV2+3 sAsR6rmTDwpfO/rMvaC0ryndFWIVhreJHL0GbCDcfxxjFHFk95zJQsPDCEjcJy8Fhu3CzB bnScyoJK23CAkYx1DpRgLeWFQS7ikHM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7FB1721A7A; Mon, 29 May 2023 17:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1685380379; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rB9VfmOx0wBbizK583+OAKBFCiJju0fCCUZtBDpksf0=; b=IfKR3S49D1e53xZzyj7oNKSFqsrS8eprPxkhez5rW5ouuGnSo/VbCitNGkF6GsKzXleW85 0NKyzYwwIXM65hgXAtTXTVJVcEenpNiov2PMKWiVeFLejO5kdZhUmjpCY9nhneZLXJyjpV wYROWMDSYRsyeArMPnkJeSU6rrlbDEc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1685380379; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rB9VfmOx0wBbizK583+OAKBFCiJju0fCCUZtBDpksf0=; b=lncwWhG/nHnwgOAJdvIeT2YDKUWV+8YX5uStXPxR0ZvC4EgoUPpw18wO2fe0EMBhArGge6 ntrGfZqhwaW6LNCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 318B11332D; Mon, 29 May 2023 17:12:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wqlqCxvddGQJXwAAMHmgww (envelope-from ); Mon, 29 May 2023 17:12:59 +0000 Message-ID: Date: Mon, 29 May 2023 19:12:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 5/5] mm: compaction: drop redundant watermark check in compaction_zonelist_suitable() Content-Language: en-US To: Johannes Weiner , Andrew Morton Cc: Mel Gorman , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com References: <20230519123959.77335-1-hannes@cmpxchg.org> <20230519123959.77335-6-hannes@cmpxchg.org> From: Vlastimil Babka In-Reply-To: <20230519123959.77335-6-hannes@cmpxchg.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: DF13620014 X-Stat-Signature: 3cmc5n6w1zxnhx18p89xm13nawhhtrq6 X-Rspam-User: X-HE-Tag: 1685380380-571404 X-HE-Meta: U2FsdGVkX18XwU0lJGUW/SiKEPw414uzm0+R3hPK7UM165V0JjCnTZckco3MtFFCY2Aru+88fSCVJPluBdCpPYndShy3BwG/dY3OAB30PnUix3TD1R5fms7IkBd3DcWTwbbuZbDr9tLOxnobptCE1cTZpTj3bh/I9OpmhUpLXCbgI4a/c3Gw0H3WuWZjacUoQ6rjC/bFgYj4fls1rZ9BVbMBUEqYPSRhMkgmWj7Zc8DoNbYRX+N2BDXFtD2k/WoeXjYeV+dhrxFjqDfYumCbF+BKOLiSU78zmshNbq7ZUoF8ACCbLet/tgGiXEo+YA41zEwnCQLXGKhGXXIF9PDeHrSREwrWuIh/lfVCS15eLQFbOwkBQPdQfbZ81uR21uu5Z2zKXqwySl9CeHfUw+wMA3UlH8m9M4qDygjLyFm5BMbi65oJnhMZcvajDtZheSGk8OB2PFpsQrD+eQQLcY7RQcZGyccYgWKpT0WfqGbJ8/6t1Dk/HSwXqW75MyD7NNu2kg+f5e8Sck0t8dRAl2AgiqX7oQ1+jZxzABkpOTZ4prUvijck+INI76kt3kqkcug1W69Ilf1fAe2OZABu/XIkGAtxzzWWFXH/DK9u2hNgfgAYGWmx1BCBuU2lnksfjoM0tiBhhlAt0FoUc5n9IWvYC2Vv4xS/u2j1ZLLei4lDyIiPdUR0qWHjwsYG4PFwRnRinFu5GsV+LFmG3KcJbb2bC2QXzLY3jhwxtxHBgxMPFLC8XNZC2Kmmu/91dX2fvNsR5YatyFnx054/ccZltJzToK0SVZ7QognYBelwdFr4s5cronF4vvjeDKj4i5hFRICpVWu1D/qlCzQb3WmRPaeGY8LfrulxRMdXZTHGoIQsocnmVZUENa97QWyp0jgmqeOjTX9fKD2/wJuLSHhM2B9b5frNNgb10y/KaQDcCwa8XhFDmC/VMOHp8dpClJCTsXwRHFGvGXSOFizWM2IdVJU kD2rleij Pk4ruM5xeLcgxUbTROhUmaiYMzfOu9GdpsQj/uaI6RaltAXmPr1cXaidRMdgqykCBBrYczqS49sr//AHvG0toYUtNbzFOaTxVwVKHFTE1cW4++Kl+kYaYaihHEx5NC12GKpg6QfgTbg8jPSwfSF3ECr270Fe+pKwlxwiHc/Tohhz8detSAHk2ri47iWEB5taMZYTM9QC/7XaImQJBl5ezCiA9N4J7olpNq45J1CRe3yxE4QNBrgeypbmUJZ7wlxjAn908ozld+aWmhG9Z97r21SMs6Q57OfPNAoXw3eZrgKzhXoDbJ5X64jTcw0+I1MLkcoT1ZFO7uo9b7nkBPeO7+BWK9ZBffwehInol X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/19/23 14:39, Johannes Weiner wrote: > The watermark check in compaction_zonelist_suitable(), called from > should_compact_retry(), is sandwiched between two watermark checks > already: before, there are freelist attempts as part of direct reclaim > and direct compaction; after, there is a last-minute freelist attempt > in __alloc_pages_may_oom(). > > The check in compaction_zonelist_suitable() isn't necessary. Kill it. > > Signed-off-by: Johannes Weiner Acked-by: Vlastimil Babka