From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F7A9ECAAA1 for ; Fri, 28 Oct 2022 14:16:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 050876B0071; Fri, 28 Oct 2022 10:16:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F1CE86B0073; Fri, 28 Oct 2022 10:16:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE4256B0074; Fri, 28 Oct 2022 10:16:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CC6A26B0071 for ; Fri, 28 Oct 2022 10:16:09 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7C6BF1C6E34 for ; Fri, 28 Oct 2022 14:16:09 +0000 (UTC) X-FDA: 80070557658.09.1696383 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf04.hostedemail.com (Postfix) with ESMTP id B65734000E for ; Fri, 28 Oct 2022 14:16:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666966567; x=1698502567; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=aEMuLa1b6x1jF2K/A81DVuq/EYef369Hcj1YRFD+GDo=; b=FniMGxvvtgIgCQ1rP2ljL6KU+AmPCGfSt5noZo1miX3ippUSKwbpCtoT dci9is9nUX4/Jv+gCiSBvQtio6qH39qPstPlaWJKBMo03kvppfP1x9g/I Vi2WIxKFJE4yRi9idmxmMSEMSwTfcPzoh/KGT7bAr+Rk//2PUizLzR4VR pQ9orPsKAHibRgvlKZmja/ZrGRyhwZu2pBv0X2hl5xG4V/YcQQLZoOH3G /xIvAuKsobVp+L1PqxRyPUlE8UzEDbPX/owaUx5aEPYYfcHBGzCHwlv2O yFRd7GEHf92OiUQNXMw8ilPgthlj0toTBQCaYRzqFO3Fh0boklq3lgyW9 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="310197163" X-IronPort-AV: E=Sophos;i="5.95,221,1661842800"; d="scan'208";a="310197163" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2022 07:16:06 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10513"; a="696230408" X-IronPort-AV: E=Sophos;i="5.95,221,1661842800"; d="scan'208";a="696230408" Received: from jbandiax-mobl.amr.corp.intel.com (HELO [10.209.126.71]) ([10.209.126.71]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2022 07:16:04 -0700 Message-ID: Date: Fri, 28 Oct 2022 07:16:04 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v6 21/21] Documentation/x86: Add documentation for TDX host support Content-Language: en-US To: Bagas Sanjaya , Kai Huang Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, seanjc@google.com, pbonzini@redhat.com, dan.j.williams@intel.com, rafael.j.wysocki@intel.com, kirill.shutemov@linux.intel.com, reinette.chatre@intel.com, len.brown@intel.com, tony.luck@intel.com, peterz@infradead.org, ak@linux.intel.com, isaku.yamahata@intel.com, chao.gao@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, sagis@google.com, imammedo@redhat.com References: From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666966568; a=rsa-sha256; cv=none; b=CFp62Ckkd8MzRkOCSduhS8KtnEbTcIal4g6HxsFF6ZU7MLNr5xlmuNio5SVAupBAQwF+Pp CsNVo8MvLQoBfpSwj9+/pqrznTFb+6gT9tC19gDy4z3/qbKFWc+Sb/SHcQ0bzaXoPKsYLp mxjnmW9P2WOV/dmLHraUR/JdIXfu8mI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=FniMGxvv; spf=pass (imf04.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666966568; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T6ciO6Mmk/+fNw5Mj/w3LEF/oGEcwceAvxHfj9Blwbc=; b=ehxULzRMX9vOdg/GVMHlxIgpZCOI7U/ekDDp2C3CbfL3/kt+k/H4MKcrX0CJl48fq7wOUd bAqP/Ckrr5DT5Tf/ItYTnFOiDP6dYzXJ8tklBxSmN/NrPF7LKdJbXvgHsVVghW5vjsWyCO V6Yc5mtbEjMCso1YFIf5Hk6K1/ES0nk= Authentication-Results: imf04.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=FniMGxvv; spf=pass (imf04.hostedemail.com: domain of dave.hansen@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B65734000E X-Stat-Signature: ff3nuas9pewhjt9dds5y1a7g183kpuen X-Rspam-User: X-HE-Tag: 1666966567-343951 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000801, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/28/22 05:52, Bagas Sanjaya wrote: > -architecture doesn't require the BIOS to load the TDX module, but the > -kernel assumes it is loaded by the BIOS. > +architecture doesn't require the BIOS to load the TDX module, however the > +kernel assumes that it is loaded by the BIOS. Hi Bagas, I just read the first hunk of your suggestions. What Kai had was fine. There's no reason to change "but" to "however". Both are, to my eye, perfectly fine. I appreciate that these suggestions are trying to improve things. But, I don't think they're an appreciable improvement. OK, I lied. I went and read one more random hunk: > -Currently the kernel doesn't handle hot-removal of convertible memory but > -depends on the BIOS to behave correctly. > +Currently the kernel that hot-removal but assumes that BIOS behaves > +correctly. This turns a perfectly good sentence into gibberish. It makes Kai's documentation demonstrably worse. To make matters worse, it's mixed in with those arbitrary changes like but->however to make it harder to find. Please stop sending these patches. They're not helping. In fact, they are consuming reviewer and contributor time, so they're actually making the situation _worse_.