From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF00C3DA4A for ; Tue, 30 Jul 2024 03:00:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93D726B007B; Mon, 29 Jul 2024 23:00:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EDC16B0083; Mon, 29 Jul 2024 23:00:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DCB96B0085; Mon, 29 Jul 2024 23:00:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 65BC16B007B for ; Mon, 29 Jul 2024 23:00:16 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D23DEA0206 for ; Tue, 30 Jul 2024 03:00:15 +0000 (UTC) X-FDA: 82394915190.26.53C3D60 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by imf16.hostedemail.com (Postfix) with ESMTP id 00882180013 for ; Tue, 30 Jul 2024 03:00:12 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=bRjvF600; spf=pass (imf16.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722308361; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MeDQ5q2eLqwizDxL98AFdYvON15VUTTwlbfkkWpDVdo=; b=C62YMShKDUzIZCB5GvRW/gAmwAGwbtMljCFukYqTMp1eses4eQ1RHNlasGcBmIWnXvc9tH TllMwWR/BnmunZFQ7WiEv9q2HDKl9qvsYuWN7CYbgKcgp9ejUzcJ5kP2mvRwM85NEe3Fe0 XfLIwst0pygH3kDSAzdKd3hhzHOxbOM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722308361; a=rsa-sha256; cv=none; b=POsAf0Gu7Pa8KDsizCwQOg21Ax6ExBy861m/Z8p9GD5J0JNjtKoMqJWAmsnEsiWifUYyYu 4zIb6157IW1N+QnKoGtpPhvL+cExPafTR4+AElegVUSA7YY2gmSQdQze1RvT+xewpHMYJR f6uZ8tOonekh7T0QukcNjckVKUSxLEQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=bRjvF600; spf=pass (imf16.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1722308409; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=MeDQ5q2eLqwizDxL98AFdYvON15VUTTwlbfkkWpDVdo=; b=bRjvF600x1QHP0x+Dp0rFGHxtK3W0W6pbGphekcy3kf3yKllG1HqGlk3ztcTsCHXTidHccRGDBbDZPFT0Iw/+2Y4/oxR25St3vZipJoqAcizztpkdAY4X9TSUFqNdOB6Rtf2b9gcj8AA5RwcMyt7CPk0DxOSihlEHpbXIIwqofI= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033037067109;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=23;SR=0;TI=SMTPD_---0WBe0bBR_1722308407; Received: from 30.97.56.73(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WBe0bBR_1722308407) by smtp.aliyun-inc.com; Tue, 30 Jul 2024 11:00:07 +0800 Message-ID: Date: Tue, 30 Jul 2024 11:00:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/4] mm: swap: introduce swapcache_prepare_nr and swapcache_clear_nr for large folios swap-in To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: ying.huang@intel.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, yosryahmed@google.com References: <20240726094618.401593-1-21cnbao@gmail.com> <20240726094618.401593-2-21cnbao@gmail.com> From: Baolin Wang In-Reply-To: <20240726094618.401593-2-21cnbao@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 00882180013 X-Stat-Signature: cyk6hfk5gjeud56gb3c65teshhfy9czt X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722308412-454217 X-HE-Meta: U2FsdGVkX1+or/aZJDIxeeaY13ACXuHhyt4J0ca1dBW8rbUv5DrYw5Zdl5gw6UU0QSXseYY5GlaFT6gT/jL5UaMWpYZW8/r1wfZGfN0b1tYi8QNDSFAmD9veamzNnRFx6bLZB0LHrfZa/xdIoHbwUYynOJU5P8lB/bh1eEBnXvim3tgn8l04he3shCKm2LCNTxxm0w5peHkdzKhrfB+nP6hcAtEIcwDXJL8nznXgn8qeWFldMBaSxDyQXqZTvHG15XT9ZmUWfuITGwxGg8RqUYxd2pGd6whETt/hzU5IrRDYXY3DUMPSsBUQY3htSGjHqHJX2mVu3lpVfyInDBjKRlbYhz8/q4XyBiLwR27lkx3HDZ5so60VqXBkLN8zHoCeqHIOc9ZKGhVhtRNv9eKgn5GrAjMyuTDKSjwrG9fnCoJ5TtseWko7Kt6cFqZaFCiopU3OSaZJGvJY1vRpSbjm38XIUfvCXoJ6hxu9C9aXVfIrdGMXmZxxZgFLr6DCdh30qvLTYIIz/r7w4dWWzcl/FRCLFviKyZb+C4ZV+nkGjDLkZ4U3Fs6BKXJx1imUwTkJ7NKCTYmjHGvL7nL7ty26mVJsMBFleVPIMr8QlParieCi2Ijpqd3HhgOi1pRA+bFmJdH5L2jXeAC1/dBf0YOoQnS3DmArFA6Pa3yrrsOdIl26scrd+Ut7VsGul+qnNr3BcTWumFMWO/qWvBaNocHCBB8brLXa2osDXG/XhcBuXFbKRrUNvp3shIOSRBG0rkrlpsKue+z5psRiV+a1KHjngj3HHI+M5/9QgzR6J6InkvUoCBPiY33QddHjxXALBsFeyeJIOeg2ImQsVq1VaXEyzM1rkIoFhtRztgMlIE+dadZfovXvU2OxRBGi9to8LuC2iZr84WiH0Fd5iOfA9XbPQleJDePsK9BuF0pOcashA/rZNEC8Tsy9+6y4CDSKi72THA9JeCB1rO5A5fRdBVA MTpPnEsi uTzSCmxmG2SQ3qXAjHyR16hx17blBBAJqKyTSVF01N49Uss8y4HOpb4P2lANZXo+fN1yM+rZ3zPuyQygLEerp3/ykoFNGbTyw+X1AgbBVxO8fbxPG6J4/luh1m2z7gDGY5I+gG6+qkdTVOQzWtBfqn9MirIaC2JntQGdbsJBRkgPUSxp86rug0TpI2W0S0DbK796ulo5xO53ZMOGLM1YrRfSETt4aDzJdDzreEGuPUty9gc3/zANSIPjcMdKUqg8Nz6blmE9XNjtZ5+jYcviakceu3mji0S2tVpg0I6vHtcNwIgZIdzwMFFBi5/DlmgnPCjun6rlmUBYtD43AJ8aJCe+fpcvi2E5e3uCObl861p1jSEJkRMVPjEh+sH44tgtmarq+pjcUCLdSjKCavwadC3YlYOy6K7Je209k9XMqZNoX/z/SddAQpGkl+UAJ+5dieNxS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Barry, On 2024/7/26 17:46, Barry Song wrote: > From: Barry Song > > Commit 13ddaf26be32 ("mm/swap: fix race when skipping swapcache") supports > one entry only, to support large folio swap-in, we need to handle multiple > swap entries. > > To optimize stack usage, we iterate twice in __swap_duplicate_nr(): the > first time to verify that all entries are valid, and the second time to > apply the modifications to the entries. > > Signed-off-by: Barry Song LGTM. Feel free to add: Reviewed-by: Baolin Wang By the way, my shmem swap patchset[1] also relies on this patch, so I wonder if it's possible to merge this patch into the mm-unstable branch first (if other patches still need discussion), to make it easier for me to rebase and resend my patch set? Thanks. [1] https://lore.kernel.org/all/cover.1720079976.git.baolin.wang@linux.alibaba.com/