From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C4AC3DA64 for ; Wed, 31 Jul 2024 10:48:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E21D6B0082; Wed, 31 Jul 2024 06:48:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5924D6B0083; Wed, 31 Jul 2024 06:48:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E50B6B0085; Wed, 31 Jul 2024 06:48:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 20AA16B0082 for ; Wed, 31 Jul 2024 06:48:35 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 906AF14026C for ; Wed, 31 Jul 2024 10:48:34 +0000 (UTC) X-FDA: 82399724148.02.E31B7CB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf15.hostedemail.com (Postfix) with ESMTP id 2475EA0003 for ; Wed, 31 Jul 2024 10:48:31 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cMPveeex; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6bsnWrcC; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cMPveeex; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6bsnWrcC; dmarc=none; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722422850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LWm6NqpI128Fe9rQr6DxlSBZfSh5ZjIQTsKszAFvCrw=; b=HLbADcvAiwLENaNHx7boMjFIIjdaRKRa9D+l3N/HipgXKusTNztnuahaBQiOVlvgF5YjMR IK0KoJ/khXHi4nGkrl7IeigvDQY3/x//GY+cNDOQ72kmPTnnGW0Z3/Svtu/OO92zO6MytT 93KYa4BPTCTuYkw4ytnwIJsXJXxbNe4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722422850; a=rsa-sha256; cv=none; b=NZFkTq7U/kQG/5TPxyK3BJJdhumgJoY8KsbD/c+8wgwOMtoVlfFiM1jXdqQs4usxIhuuxR GZv7zxwXgBCkl2zGdPJNs7psXpT2IF8FNSvg1EwEBzU6oHbZc1a0US6khKcBGCKJiUBnf5 uRBxHRImKTKm4UI143/O46iZ64iEBTk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cMPveeex; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6bsnWrcC; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=cMPveeex; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=6bsnWrcC; dmarc=none; spf=pass (imf15.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 619BA21CCD; Wed, 31 Jul 2024 10:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722422910; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LWm6NqpI128Fe9rQr6DxlSBZfSh5ZjIQTsKszAFvCrw=; b=cMPveeexWULuoQEqeBvx2zsaS2I51CycK9pdkFLGGf0y/bCx6QhAyBapIrgIzZyjlZJxrO 8/HcZlA6zWcVV05IqAoDMkSmZTv+lK+9wzApEb0+3Fiq3CGAF433GAu4kFVwfsahlytT6G cCq4vttjcS1Tl9c8Jp/xlWvaHFvH6D0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722422910; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LWm6NqpI128Fe9rQr6DxlSBZfSh5ZjIQTsKszAFvCrw=; b=6bsnWrcCnRtwyykllBlMshFzgriGFd0Zfr9avPDmUZ23DStljykDdm7RQg0NV6Yoh/fUmZ ZvStL18L/yDsrLDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1722422910; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LWm6NqpI128Fe9rQr6DxlSBZfSh5ZjIQTsKszAFvCrw=; b=cMPveeexWULuoQEqeBvx2zsaS2I51CycK9pdkFLGGf0y/bCx6QhAyBapIrgIzZyjlZJxrO 8/HcZlA6zWcVV05IqAoDMkSmZTv+lK+9wzApEb0+3Fiq3CGAF433GAu4kFVwfsahlytT6G cCq4vttjcS1Tl9c8Jp/xlWvaHFvH6D0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1722422910; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=LWm6NqpI128Fe9rQr6DxlSBZfSh5ZjIQTsKszAFvCrw=; b=6bsnWrcCnRtwyykllBlMshFzgriGFd0Zfr9avPDmUZ23DStljykDdm7RQg0NV6Yoh/fUmZ ZvStL18L/yDsrLDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2CF6713297; Wed, 31 Jul 2024 10:48:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id jm9tCn4WqmYRMgAAD6G6ig (envelope-from ); Wed, 31 Jul 2024 10:48:30 +0000 Message-ID: Date: Wed, 31 Jul 2024 12:48:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] mm: BUG_ON to avoid NULL deference while __GFP_NOFAIL fails Content-Language: en-US To: Tetsuo Handa , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: 42.hyeyoo@gmail.com, cl@linux.com, hailong.liu@oppo.com, hch@infradead.org, iamjoonsoo.kim@lge.com, lstoakes@gmail.com, mhocko@suse.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, torvalds@linux-foundation.org, urezki@gmail.com, v-songbaohua@oppo.com, virtualization@lists.linux.dev, Kees Cook References: <20240731000155.109583-1-21cnbao@gmail.com> <20240731000155.109583-4-21cnbao@gmail.com> <9f1d0f2b-ee22-48b7-ba60-d7b886572670@I-love.SAKURA.ne.jp> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <9f1d0f2b-ee22-48b7-ba60-d7b886572670@I-love.SAKURA.ne.jp> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2475EA0003 X-Stat-Signature: cx15w8zaut4jmyhfm5jxrrsqrjpxir5h X-Rspam-User: X-HE-Tag: 1722422911-120946 X-HE-Meta: U2FsdGVkX18sMwEs8CXaU68ZbvDCxM7ggOl4bgmwoeVYVCrVYvcDCFkIkzZcxDZw03ZaZGLAE5lBqdt8rrlSMOzKTol2ziL9UHjG/7EVIPsfXpbQZ6/ImxwCho6a5RYouA6NwBpVGeL9pOVbxM114fXObu+odRGK8qIAtuOLa/pOFiup8K3WC5GadSA7Mj8I+hVZ5q/ocIiLCTDWjyYhwvMZ2OCwyRJG9HLIYvzPOywADpdv+EocGTStBkWQjrvp3ZYgSpC1d6RrXy+vQL0VJ4WIC2Oz1m2njQmryzEql3PDXAa6djEn1ia2mOGD2Nsd88k9tauQs6yYUUUsE1M0VOC8BSbDihy01imhUiAaSLf7X6ahRmWEE7q1y9cCp3qudO1a8CFyWY4gBBjI0VM7fIcoraIlqghS48m8MxBOPO0fsish9LkNA4IIUT/Ev2vEqkIktFTxzq9Nbv3lW9puMpZITatXKdCmVs6XQt1Urg7JDau0MiISreCatb0mSZEaZ231+FlqMnLc/9J5X9GXeTu8JA2E3vAlF+N5FouhCFodzq52QLyplfxn3NR76COXGq0YMGZpzbGv5W8yxNJeXvRf9gv+mjln4SYrk6C27sLulAy1AqmeXtWWTDqy7g/XOdZi/lZ9zb3O8c+N/Xdv3dkjzuiqt/reR9O4Qxh5DqQ+4iuoHuBfpeXLWlMhRXrv3Mf8O3+U5EY335qo+nnI5b2AVyq4QaR79igOqdCX2h7bvAStVy1Eg0dTHskfXBPjOoqcDYnvIHqeQow4f6e5gBIN83iAwi18fDy0/d9UMAysUkBcZDVQXYhzHNaqZz0NEJdsK1pZk/0ryEMCp43+jNAY+sMfKW4sfRS45aOoFkylInt7jbRE72JJFM29QzvBMTXsKm0cPOODUTAHzexd8NqJGqggK7wH3PgaYV8VFQSCmV0iFDCEFHOnaUHHLck5vLCcZzKnCQs6FKPeePp dUZe0B3g vEx8uS+5ml8BhxDVNh5ekA36UzuNi1d+jWL2uGQoL3SQD2VoUD2Orgw2T8eOcEgT2suSp+JyhRav2Aupkpo6cNPu+gwkj6s5OfGHyTkVAUnw+uZvZcZgFL58vHeBTl1uN2WaCdj7DbWN4URrda8MzXC8OPPrUu5z2z64lFiyLvUrHy/yRmOpIRtoW2pckEgaErwKpsCwAPdz5XGDumtakL0zSnEZGiIncLBdV/8El3YkVFmw3rSOcdIScA+3dAN6hvLtlqizc2oxQV4lhBHbp1ikVQ1mIoriL04WQAhe4XXPQycD2l6fHD1S3yS4clztUjjP5JjnTgmOkiPZ12kp/5t+Yc3mGNLuGdXv23/M7kTEFcyP/+gC6NbvvoieTKp0nu1se X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/31/24 12:44 PM, Tetsuo Handa wrote: > On 2024/07/31 19:29, Vlastimil Babka wrote: >>> @@ -827,8 +827,10 @@ kvmalloc_array_node_noprof(size_t n, size_t size, gfp_t flags, int node) >>> { >>> size_t bytes; >>> >>> - if (unlikely(check_mul_overflow(n, size, &bytes))) >>> + if (unlikely(check_mul_overflow(n, size, &bytes))) { >>> + BUG_ON(flags & __GFP_NOFAIL); >> >> Shouldn't we produce some kind of warning also in the no-NOFAIL case? >> Returning a NULL completely silently feels wrong. > > Doesn't embedding macros like BUG_ON() into inline functions needlessly bloat > the kernel size? I think we can call a non-inlined function (that is marked > as EXPORT_SYMBOL()) for emitting warning. Hm yeah we could probably make the whole function non-inline as it results in a call anyway.