From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE996C7EE2A for ; Wed, 25 Jun 2025 15:33:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 735A48D000A; Wed, 25 Jun 2025 11:33:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70D808D0001; Wed, 25 Jun 2025 11:33:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 623668D000A; Wed, 25 Jun 2025 11:33:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 512358D0001 for ; Wed, 25 Jun 2025 11:33:57 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E822C140454 for ; Wed, 25 Jun 2025 15:33:56 +0000 (UTC) X-FDA: 83594318472.07.931CF7D Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by imf12.hostedemail.com (Postfix) with ESMTP id 075F640006 for ; Wed, 25 Jun 2025 15:33:54 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=hRrmAPNB; spf=pass (imf12.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.210.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750865635; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VZqhEcxBQhbzOh6JVaGxQL694yeYlxvz6oZqmaMRq08=; b=bQTZqDUybsjH120nKjSrYjxd7+B7xOVCFfXGmoz2ClnetaBdRu4pwGvZwkfpZtE3p14Fmv 4sWAwdxBaBVHq3oENbnvki0lj6tNnv7yBtk4td3XNuUkFG2iwdK4Z48dyAavrUgUM/dNxJ +ivILbq9XEJrhEx0N8eQ1pRu0gJiaHU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=hRrmAPNB; spf=pass (imf12.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.210.54 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750865635; a=rsa-sha256; cv=none; b=R8OexdzZbXVXQUSqTVwCloMpmB0dPskhejpt5adMzvjLAs7oe3p/4XaqCP2Mx7PMV2z71v MPblV28++XnJmU8XjfKb39Eul87HZC/IUUqBlrclvtxaFgu7W7rb3W4NHvxYzCtvG/IvyF wcq9AGFk0e339qT7BcqDR+0NfyzuAgw= Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-72c172f1de1so4250032a34.3 for ; Wed, 25 Jun 2025 08:33:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750865634; x=1751470434; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VZqhEcxBQhbzOh6JVaGxQL694yeYlxvz6oZqmaMRq08=; b=hRrmAPNBZA0s5EDk/GnoDE2/zXKB/SxbueKpogZ2XuW7q9zqIazpDzXFuhlbbDrrn1 K8QRinz2AQX0gtoUoTI7fuUC+dqIiXOEfnLh7ubjBRq7esKrWsxt1cfoLROcmfAffxsd yx3CiKKVS30/J4LtvmtqLrhh7ruhOTSBs7VrYee8DlVnlYXa4z7FC355KumErHcKrZeq cefpyoMsk7fF3O3OoR2JLMAJ9rYo+ojfgrBKWAoNevWDrT3dJ0xq4XOKvjnuJcnMn4Fx Xf8OYeArlyZVkCA6nrDEOJuNoAhH/k/LV8bSSf4bpNeK7DTGSWRxUXbXH5/2hCmmzAzy 2hFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750865634; x=1751470434; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VZqhEcxBQhbzOh6JVaGxQL694yeYlxvz6oZqmaMRq08=; b=F7XMr2Tz9uoXEOca2mqz7WX+FIfYYoQnh+tohL+gzdMm53y7ZWN0mNEeSCqLXp6PyW NhMtgzlRjqAePChtG1bPdGhw5Zz513wsV3l27+oPmnLBCcyQ4a0e3EosYFdFYh36exrH 1SbxOpuNRKoExgjr/OKch5uPNqnOeq6dE+CrHW4P7LgWrqO8HEkeYHDDuBMBiaa/3feO zE8SDLEdFCoagcozj5Up5JlPNCyP5SMpxGF+noCI+A41wYqSS6VBj10Ae3Wql9gkv6vU zTW5utSzA7eBJIM55FR7wBMrR8f6YP1NG0Qc95jzarBi4Y8T17+x/+MrDuLb+q8HANbs XRgQ== X-Forwarded-Encrypted: i=1; AJvYcCWOoHhaF1dz2/vZ89RJ3E6/+gyXXSgt24rGShxF/CEPaCz1U0aCsqmtY4a1Bmuho6hRZzhwBZzEGw==@kvack.org X-Gm-Message-State: AOJu0Yz2dBrN4YUR+KIJHYEW8pSjxV59IM5dpHC4O9CHUzefbaIMNJf0 iDROjrTa97Jy+feA1hp/CgUbDBfD3JN/1XxURJhIsjzxfxGU8Z5PMDPFAq22yNcOIu9Wq4mMYle hVQnT X-Gm-Gg: ASbGncstf6iPiNXHrreOeDmM+lVIkuA+dj4wtftGr0kRyTobMrhET5l0m21cTOpcCad yQepwMYXgiNoe/7g8JjstlpRLM/X3kjVQ4/X5U9C9H+U5tHf4NFR4PdOSx+BnkG20JMd9oYA43R targEl6crAElsgrvYPy+dQi8phxPa/J0Ghl9hSiMgEU0pxwo9UMkOAbCYyrqeGcV9uTJKl70bZR RhUeyirVq1hx+Osilm6c9kf2U+ueEGDUk1qdaHe1uQOZUXpdIpLGgktFzuNzlBlhvsarh0PxsNL Tp6n1CDuihikydo/FpQmjoU2Ws/H0lc8TV3S5qOlp9jNdZ1DE9MuomssaD3pnMuYXrg= X-Google-Smtp-Source: AGHT+IHocp2lWjY0ub02K97anAYnYNyxecSqopXbTvdpz/db5rpNAumtukQSZFEpei331ZTaZVEUDg== X-Received: by 2002:a05:6830:2112:b0:72c:3235:557d with SMTP id 46e09a7af769-73adc7b4318mr2366572a34.13.1750865634096; Wed, 25 Jun 2025 08:33:54 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:3ee4:904:206f:ad8]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-73a90aee8ecsm2293133a34.10.2025.06.25.08.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 08:33:53 -0700 (PDT) Date: Wed, 25 Jun 2025 18:33:52 +0300 From: Dan Carpenter To: David Hildenbrand Cc: Oscar Salvador , Andrew Morton , Harry Yoo , Jonathan Cameron , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] mm,memory_hotplug: set failure reason in offline_pages() Message-ID: References: <685c1428.050a0220.346d5e.eafa@mx.google.com> <2db18566-f864-44f4-bd0b-baa7cc4bebea@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2db18566-f864-44f4-bd0b-baa7cc4bebea@redhat.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 075F640006 X-Stat-Signature: neh5jozgyipjsjwmkiyaip3s3k88319r X-Rspam-User: X-HE-Tag: 1750865634-605066 X-HE-Meta: U2FsdGVkX1/umyHVIClc1i1ad3eKDd3h9+2UqFMJlhuA8Gtu1dcYH7t9bpPShAqa4Ic99yT/s2oCy7pwpaRxWoDyB8bff7lWR5nWajjJr+ZGueTHR0jIRzNfyH81lOP7VRr3mXLpBOA4PPssI0I/hZiRC33L4S1XC3PGpITQfQjPeeoP3mhnHTjZsIthfZTrARs5Cvp0Ay4h6f6WkyH/J8OZ1icQhSo/mik7ZcOE/blgp32JjXj6lxyIeJ5IA5OEgCg3UUo41u+2YyjGAkZ8goQA9a+5hMunngX68OYJphc+5TsovmhkpGTacDwP3t7e/6RgQ7sw8m6vVih3l6IOdx5JgGjOtB0KF1vJd2gOjCBrSsxOyEVFstGwCe925IiG7znN9RoFhrLxuF6hRHgApeU+qAmx52OcCAtJO47+YWwS7LrkV9nI26r47oBPAk4vvnd8Dmq5jHUt+7sh/uLVQWqFlwV+DCEYs+sVrf50H8eMnETqMPwlvT6r92h/P00VxQ3GS39/D2/pf11CzD89lUeULpssuJCZPbt8Sq2pKJsB0HR5LziuvoRLNaugAYLI7kphHvVTrzFUkFBQehfWX2R1RjYlaI+qLFXrQaFg0REuBj5EH4i4WVMp9fG8/slvfasQLMHy6DCoFk/2AtT8mN86n8Cf19xjC7sRPILE4A6BXHvYZK+AwdL12ZBgkHJnmDGnNev5C89EqnpNFSs9iwjMkFLM9ZXh8kCZDrtMeEDE5n8TsaKrwGdh/au28Ub5SNYIVRuG1M43UKY86XFTf8VJ+dKVfEn0lPioPRjcCCHZlmSu6e2WU5lJawM8Ll1nl3O20RhlNo+Od65Z6liLZdOHachrCcCM9LkIdu6UYCd+c0PRdjsGs/KUkl+EoGTPKbtCX2X4KtAPQYZVgqOHRvYJA5B/yVR2y/O8xzzMsjJI1so3XcerQEHKXsZ8VIZhbLS2+G2eEfID7JJs/NP cIcOvS33 1LfAnvFk69Supnw25N9Aiduh30CdpRD/ZyePodio9qrCEyt3ICOt7ZPU1aatUwzOklOn9ArxQRtMRcL+D86zy0lJCnV7JXSPuTWAyIesDcDnW5H+zfV9rRGnsK9jqPWkD0c6PQFyTZreRSKOnI4l6L4D0u495yE1/TEsMzaIQfM8uimi6mr3EyQjmKRcgTsJ1EGPKX2UCoGxiZvb1/FyNYpVGKPT882/b5jvPvvSDdADEjTWwotskW1o5cUmgQ6YkfzE0h+xxtdz3MlEbLiaCQrbV9XcR0sf8uyeswhABXPrTP4wRApJCSjlYAmGnvI29yLnr5OCuA+FkaJex/8/ftkiTMOELdqNYg/QrIaAErRgDK3QcwBqUndU9ZaKrX8j9Mh6wazI91HaR9R859NqLRnaBQdVhKfvg9cckkyQjVclmVrA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 25, 2025 at 05:24:01PM +0200, David Hildenbrand wrote: > On 25.06.25 17:22, Dan Carpenter wrote: > > The "reason" variable is uninitialized on this error path. It's supposed > > to explain why the function failed. > > > > Fixes: e4e2806b639c ("mm,memory_hotplug: implement numa node notifier") > > Signed-off-by: Dan Carpenter > > --- > > mm/memory_hotplug.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > > index 4d864b4fb891..e954f81b55a0 100644 > > --- a/mm/memory_hotplug.c > > +++ b/mm/memory_hotplug.c > > @@ -1977,8 +1977,10 @@ int offline_pages(unsigned long start_pfn, unsigned long nr_pages, > > node_arg.nid = node; > > ret = node_notify(NODE_REMOVING_LAST_MEMORY, &node_arg); > > ret = notifier_to_errno(ret); > > - if (ret) > > + if (ret) { > > + reason = "nr_pages more than present_pages"; > > "node notifier failure" > > With that > > Acked-by: David Hildenbrand > > (likely should be squashed because the commit it might not be stable yet) Oh, yeah. I misread the code. Thanks. I resent now. But, ugh, I forgot to add your Acked-by... But this is likely going to be squashed as you say so hopefully that's fine. regards, dan carpenter