From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C817C369CB for ; Wed, 23 Apr 2025 19:16:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 756396B0005; Wed, 23 Apr 2025 15:16:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 703226B0007; Wed, 23 Apr 2025 15:16:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57D6E6B0008; Wed, 23 Apr 2025 15:16:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3A8386B0005 for ; Wed, 23 Apr 2025 15:16:54 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 51A41141DCF for ; Wed, 23 Apr 2025 19:16:55 +0000 (UTC) X-FDA: 83366265990.30.D864BE7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id B9616160006 for ; Wed, 23 Apr 2025 19:16:52 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=baCFS5kK; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745435813; a=rsa-sha256; cv=none; b=f7GKEVZFX81/jrxvdXDVH6xm3UcJxLafi7gBrPZIVnMwqp8glcJGxprBTl0Cl0Tz/Sc/rB 0psoXpwGGhIVsXzdRVtEPganlhWJW6CHGoBC/RxjGyGjYlnQhzCbiMqYxi/QCJUDH2RJwy UpDfIdYxehF56FkcyXvrpeDOB8msg68= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=baCFS5kK; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745435812; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7zIUNWNp26moq7KsheJCfprvsR7MnxIB3N9LdHnr7/0=; b=kLin34QbYhcoSZW/hYakKJ3ZBNJWrAHOOOf5nIicHh2i3S2Ig6wnVhnruFaO9sgcaIo78t upGkJVQDl3QXQ2WjgJ6mASdz3XSbFWJEID3b+87bpjRIu0734u7SNf34s6TpsRYi5Be94k DhMrECCT7O6KJvfoK3PzCvVo4367B1k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745435812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7zIUNWNp26moq7KsheJCfprvsR7MnxIB3N9LdHnr7/0=; b=baCFS5kKlnvT6mQcpDszU9LEqzAzql2PmjvfDTWBEyIzPS1tc+6uuwuL1snDFYunRt06h8 BF5o6IO4ElfqvLTjHbZEdlYHHAuKxki8TDnI6IFN/meOYQBF9WdWYZtCf68vNz7uGpv1E+ NyyARnurnRbEfvkT1ePSaUsA0IcKCNs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-359-8nq6gMMWNZ2VtqJq4aEqDw-1; Wed, 23 Apr 2025 15:16:50 -0400 X-MC-Unique: 8nq6gMMWNZ2VtqJq4aEqDw-1 X-Mimecast-MFC-AGG-ID: 8nq6gMMWNZ2VtqJq4aEqDw_1745435809 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3913b2d355fso50905f8f.1 for ; Wed, 23 Apr 2025 12:16:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745435809; x=1746040609; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7zIUNWNp26moq7KsheJCfprvsR7MnxIB3N9LdHnr7/0=; b=VZPTa9+sSPUMz3FRHTKZmObk5u4T3F914pjMrr4EeVYC9tMUf2YBvKKt40sJCEAhDG QW9ZUCbU4egmFhSJDh251EPYHIpR+2MFJtiOq5ujk3S0EKleCVCZk7g5XxQAe7CqVdRr VO+lQFSd+TXX5CPVVTnpYtll+CskkQ2fMjmt6Zd2xzV9jU0xQZSu/R/yVZjR2rybLp9k akfNwWdHo1h0AjzPmhglvXPFf/K4I6tU1sZIfvl04tWKqIwqKulacqkIGIcx3vvsYF+C /GCyuYq09OlVUI5Ol10vvdZz9nSuPaPhpKQO1waDAR7ZNkw5UUueYxPcyzLPLHKNctZf mwRg== X-Forwarded-Encrypted: i=1; AJvYcCVRAuDnts17dLYSaOQCagH4Bh6BMHiv0i9Q+RKG7KG8SglHi/zBxyD4jWlZMH4m56l+RNbjODdNJg==@kvack.org X-Gm-Message-State: AOJu0YwzmsLUFHXRcPFQdBR6G2lGLCt3FNfCiUUc9VN+ZK15uWmNmBhf 8OAM6/xAZ9Hzw92rwzbwyUCgsAVWb0epcAyWpZzbvDOiiTRjIlBNm+etNG0QQwTM1rawcRGc+sH mDsie4yI6/HVTUT/uR+rC+mvwuRN3BEnWtDEMffX1F4nM2G5L X-Gm-Gg: ASbGncvnZR4mTbSf2iJVjlLwhBb8Amuyla/1fXPm7E0JMQ3HiDDF5YICZPgfa0JQaGM fbFBMtp0hEGAHFto0kFngmiAoL2ajo16c3PHGWNlsQs3q+/NBXoWmoSQFh3jQftNp+NtiuD9sHN 4tjUMkpv4nJRmoIgFp1NS4gEhv9IET35INSfKNaihrLPDWapLO0gdNtulOcg80+dJ0/X29GvzJt NuPzHtzzB/R3Plb9iwyuVFhSjjb4Zsa34g7AAoGV2mUFxYda/1jyTXZhY59ttbK4tgceZwlw1gm qPfuzkCRf243wRw/rW6E06z0fDWzHhGl2q2d/SvgDcJHkw0lnCiT7g6RA6Lv7uCgcKqO+t352eH FPVoJP5GtezOjn+zNMKlaFG/fSIzuwKAMOhfEnSE= X-Received: by 2002:a5d:5f4c:0:b0:39e:f89b:85d3 with SMTP id ffacd0b85a97d-39efb9538afmr18034912f8f.0.1745435809384; Wed, 23 Apr 2025 12:16:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFX7EfCQdzWKRNhZulEfBZnXBZvgTH/2QsdkN0/YbThfSXG0B99xSu5FCNt7O8i8os3Kvlq/w== X-Received: by 2002:a5d:5f4c:0:b0:39e:f89b:85d3 with SMTP id ffacd0b85a97d-39efb9538afmr18034891f8f.0.1745435808999; Wed, 23 Apr 2025 12:16:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c740:2c00:d977:12ba:dad2:a87f? (p200300cbc7402c00d97712badad2a87f.dip0.t-ipconnect.de. [2003:cb:c740:2c00:d977:12ba:dad2:a87f]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa4930f1sm19927871f8f.61.2025.04.23.12.16.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Apr 2025 12:16:48 -0700 (PDT) Message-ID: Date: Wed, 23 Apr 2025 21:16:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: Convert &folio->page to folio_page(folio, 0) To: Matthew Wilcox , Fan Ni Cc: muchun.song@linux.dev, mcgrof@kernel.org, a.manzanares@samsung.com, dave@stgolabs.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250409004937.634713-1-nifan.cxl@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ULRCMgJDK6JnUjEznLCzDLJuOysyz3TM1KjhjJoC9rI_1745435809 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B9616160006 X-Stat-Signature: tjsff9stzoapwtn3iezr3ortgiprmd5g X-Rspam-User: X-HE-Tag: 1745435812-866138 X-HE-Meta: U2FsdGVkX18MawgdnkZA9P1IukZhklVYma8iSDNIZE9czx0qm5HrkG7VeOOKRfQ4+Cox1/YcXoEYRzIKsxPBC1gJR9wd+Yo3Eaz+YB+xd+2UGFivUFHngdKxD7Ax4BBEvJB4myoovt1sh4L1bm/TVfH6XP1ilNiE3A1eDzvd0M4mBlduxG+f5zIEhBwSRzz3gT+1m4+VbMwUhUvXGZAgh+aUcvfEIzmVqEfnqRM+m6asDAd1t034wpALk/yi0f+jrrxUnB6uLc+uaUXhMLH7AZqxPNK7nXavgt8mFEPFWK98zE/MSuzcnHXASGrg7jZCL1MrMVVkkEFgMWFyeFfKmnfkYGoraGoYAtnq+ZUKWUy97vSAN/KSfmPv+gzDoUi3XDmu5Iv4BSfE2cGfQqa91m0o9uNVMKAvZljN9iInpVV6N0MGlBm1vPb7FMKq0c/InFRLfCZGz59Fnxt025psokhTxcxgoZezJaMJ6yoPoWikx0CwM8zSkR+P5MxQjS8TSGEfWyLqTwr5fjF7fPW0329ZT3gXK5TRIjX0W7aLva7VNV/0wwjq8KJ7Kc2LikNO/aic4+gJtx19cNBAbQDjkpN9nTiDsZV8FwpVu9w/Wz+NKG9P8PIPFIlLT/vtzz0xICWqkd5KKopKPKYiJvzrFt+RLVmUmh3y3fn5dIk2MHUVT4nFhubzzMZaRcIuSUL4gf/1P79v60Cj7k3mp8E97ueL1mQLn4z1Wxa7kd9k71b1UqGyDLWK2v+KjCQVWgvaKdHo+WBrITLpmGYjlMGHfEQGFooQ3aow2LNcssnog9jNFdbdiao/t6KuxOc8SQucNyR7QBk36ps1o1tz3VrumWu8lpk05lvdvNtUSBrsp9WbI5kd77RntBuJxl34F8fSLqUlXMS8s0qhDiydfr7/noo33fqZrmbmwC2vPy510sE54nTDDwRUuy5fFAZqee7vSbquIcwYuzd8M+1EzaN 0YCjSxOG 6nVYoPAq2xUeDRBFoDpNFgvpTymqO5qcbTgWXEAeI/xc6THF7LHxjI4ISsdIvqCMNbwLhD7P5GH9rq2P7uU/guY+UjJDSURZtW4b0QmnoXIiSh4hjQfxDcWXBD28JHeNftaIT9uTMMTrt36LERDLPPlA8Vr6acR18t7xdHZojdBN+e3ubskMim9GBArvMqcrrktN7Q76DvNP6eqY/lCZDk60JldLNg9plrWEpPWHn/vOmaExj+cEVsPmuKxVJsW1b31U2CmwFu6J6DQ7UgID++aQbYQmoBpUWOozpznQWA70ibOSiybbsUb+TRR9F70D8YLtmYJt9szjb5tYp+6zEtBG5la+RtRuCjnV+ZIOkdJs6BGAdOlkPlrYwXId6tFAhIvI18AArDwenUfjz5VUFyf/5tdMNUCa6InvcJtC7ze4GrTWqB0EvZGGaUh7q1iTyro37+nYgtBa3VgPYrePMC2TbFT4YGQzl+oWL9EqpUBdndUCHFDnqvM24hPiCcLHmktFv8pN8nIxNSJLtUu0lUwFjkyepeaRdhBu/3ntfO2PUQXUFNXcB2Iox2gckdD/jCNoa X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.04.25 20:50, Matthew Wilcox wrote: > On Fri, Apr 18, 2025 at 03:42:45PM -0700, Fan Ni wrote: >>>> result = install_pmd >>>> - ? set_huge_pmd(vma, haddr, pmd, &folio->page) >>>> + ? set_huge_pmd(vma, haddr, pmd, folio_page(folio, 0)) >>>> : SCAN_SUCCEED; >>> >>> I feel that set_huge_pmd() should take a folio. >> There is a patch on the mailing list for it, >> https://lore.kernel.org/linux-mm/20240817095122.2460977-5-wangkefeng.wang@huawei.com/ >> >> If the above patch is needed, do_set_pmd() should be converted to use folio. > > Maybe? I think we'll eventually want to support folios larger than PMD > size. So I don't want to pass in a folio here unless we can calculate the > precise PMD-size chunk we want to map from this folio given the > information available in vmf. I know that today the implementation > does this: > > if (folio_order(folio) != HPAGE_PMD_ORDER) > return ret; > page = &folio->page; > > but eventually we should do better than that. And I don't want to > lose the information about which page in the folio we really want > to map. So have a think about what the right interface should be > (passing in a page? folio + offset-in-number-of-pages? Something > involving the PFN?) > > The obvious hurdle is folio_add_file_rmap_pmd() which today takes both a > folio and a page. The interface is prepared for that use case: I decided to pass in folio + page to allow for folios that span multiple PMDs. (obviously, the internal implementation does not allow for that) We could later change it to folio + offset, but should do so for all rmap functions consistently. -- Cheers, David / dhildenb