From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FDD5C43334 for ; Mon, 13 Jun 2022 05:34:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A9B48D0151; Mon, 13 Jun 2022 01:34:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 032B18D0142; Mon, 13 Jun 2022 01:34:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E15A78D0151; Mon, 13 Jun 2022 01:34:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CC6BE8D0142 for ; Mon, 13 Jun 2022 01:34:52 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id A37A6120C0D for ; Mon, 13 Jun 2022 05:34:52 +0000 (UTC) X-FDA: 79572098424.10.50D6227 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf10.hostedemail.com (Postfix) with ESMTP id 44E89C0074 for ; Mon, 13 Jun 2022 05:34:52 +0000 (UTC) Received: by mail-lf1-f46.google.com with SMTP id a29so7141093lfk.2 for ; Sun, 12 Jun 2022 22:34:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvz-org.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:from:subject:to:cc :references:content-language:in-reply-to:content-transfer-encoding; bh=gx5BulmdWVt1E6J23Q6sWTUkZpDqVLFQzvPT6hFPLlw=; b=LHjwdf838XwqeAg8Nc229RaNa822fvU0tfolsDGvnGxgxaJJuYInYiO0Y1/se6H3N6 eSoUNfXTq9ViSfUVk2pQROnPmYKfyqjdabi2PzdI6GG3YDyJ5KbeVprN7xizrKfczl27 oOY7dL2b1sgAGsJuu4L85fjavdMcXTonfnkDG0f5Jzl1kQ0sCxoscdmXVUTlU68okhJ9 DA2ifBo1oc1LVvm7vn9bzJDoKJzCFuVoyuYtsarZnQ2xx/H/7LiOz4uBg3Y+Rt39vvxR KoGRxRNLkoNOToIZ57RKjPfuqae0oHimGFLyGLLEXdqDL//s5b3jDkGgcS6OD1N4fHA/ ob2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:from :subject:to:cc:references:content-language:in-reply-to :content-transfer-encoding; bh=gx5BulmdWVt1E6J23Q6sWTUkZpDqVLFQzvPT6hFPLlw=; b=IMnoHW5d92YB6nu9ul6yCvPjvJP7dDLm747rsQRxL2rvLxO73gXvWRC+lLaQ1JcAms aGxvvGDcBbDFrwHMVhjSTJ+KVcSZi1Fwf50M17isY4B7idJUxfKNBq9QOrLqPV6Lfm6t mLbbbVFqssTNK9kEQodbBaDdWdGocLfVJPGMGF2RwMdbtEzUsERDKKU0w5YhIO1xp8kg yiSEMzWjsdu99v9RMvgsxDHSFkONa2IRCtj1SR0WV6392ynaYGnNKozFXDP51STsmvn7 pN0Aitaz3qq6yR/YKE629ZjqnvZlVMHF5EnErr6rhh0on77l+fpoonv1oAFPVRS086f3 DYFQ== X-Gm-Message-State: AOAM53345QiudzCH9Y6xKTzc8XMSlI9EHgSUow8a+8Bdl1PSYaQG9+82 mhS6pVMQwEgutfejaOPchYbJ3dilddOaOQ== X-Google-Smtp-Source: ABdhPJxwvjjFC+nbS7k4Hx0PfOGges13cDVPl80sm9xEZjEmzUcmZNS/oNjeKVJPRMV+PlaFVGkQxw== X-Received: by 2002:a05:6512:130c:b0:477:e2ea:396e with SMTP id x12-20020a056512130c00b00477e2ea396emr78241747lfu.489.1655098490971; Sun, 12 Jun 2022 22:34:50 -0700 (PDT) Received: from [192.168.1.65] ([46.188.121.129]) by smtp.gmail.com with ESMTPSA id d22-20020a05651c089600b002553768424esm879156ljq.112.2022.06.12.22.34.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jun 2022 22:34:50 -0700 (PDT) Message-ID: Date: Mon, 13 Jun 2022 08:34:49 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 From: Vasily Averin Subject: [PATCH mm v4 2/9] memcg: enable accounting for kernfs nodes To: Andrew Morton Cc: kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=c3=bd?= , Vlastimil Babka , Michal Hocko , Muchun Song , cgroups@vger.kernel.org References: <3e1d6eab-57c7-ba3d-67e1-c45aa0dfa2ab@openvz.org> Content-Language: en-US In-Reply-To: <3e1d6eab-57c7-ba3d-67e1-c45aa0dfa2ab@openvz.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655098492; a=rsa-sha256; cv=none; b=wF4EQ9s+EhtQpMQmvOTGrjPlZVO3pBMydgwt/XDCZPru3YEyqpg/L6P/wF3zYPivUoaL3Y hPye+xexUwDma9w4ywkyb2RLePQ5FPS1juzlrUmGD7YTkrYig3L34vASTybL4DSsEjbTuJ nYosJx4qsFm1xbpBVidzjw85AStltpU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655098492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gx5BulmdWVt1E6J23Q6sWTUkZpDqVLFQzvPT6hFPLlw=; b=k9WXmXBEeZWeEQnzhW2uPQxRsdWNjUY+UBQsOVt//KCf18FKMTHUMVE2tyrOVsSXssfVuX xXw4HiTpRFJVSSxNOrX7koFs7hmJXuvQTuLFAKbh37ZZ4IGDFFG4ZUmrpbhVQl21Ep7Msj PhS4GwkMVWiJB9BjirERXzrleNWlqVo= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=openvz-org.20210112.gappssmtp.com header.s=20210112 header.b=LHjwdf83; dmarc=pass (policy=none) header.from=openvz.org; spf=pass (imf10.hostedemail.com: domain of vvs@openvz.org designates 209.85.167.46 as permitted sender) smtp.mailfrom=vvs@openvz.org Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=openvz-org.20210112.gappssmtp.com header.s=20210112 header.b=LHjwdf83; dmarc=pass (policy=none) header.from=openvz.org; spf=pass (imf10.hostedemail.com: domain of vvs@openvz.org designates 209.85.167.46 as permitted sender) smtp.mailfrom=vvs@openvz.org X-Stat-Signature: fsrryxcx1pbcfbpfa47ya5sktojt31wi X-Rspamd-Queue-Id: 44E89C0074 X-Rspamd-Server: rspam12 X-Rspam-User: X-HE-Tag: 1655098492-197818 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: kernfs nodes are quite small kernel objects, however there are few scenarios where it consumes significant piece of all allocated memory: 1) creating a new netdevice allocates ~50Kb of memory, where ~10Kb was allocated for 80+ kernfs nodes. 2) cgroupv2 mkdir allocates ~60Kb of memory, ~10Kb of them are kernfs structures. 3) Shakeel Butt reports that Google has workloads which create 100s of subcontainers and they have observed high system overhead without memcg accounting of kernfs. Usually new kernfs node creates few other objects: Allocs Alloc Allocation number size -------------------------------------------- 1 + 128 (__kernfs_new_node+0x4d) kernfs node 1 + 88 (__kernfs_iattrs+0x57) kernfs iattrs 1 + 96 (simple_xattr_alloc+0x28) simple_xattr, can grow over 4Kb 1 32 (simple_xattr_set+0x59) 1 8 (__kernfs_new_node+0x30) '+' -- to be accounted This patch enables accounting for kernfs nodes slab cache. Signed-off-by: Vasily Averin Reviewed-by: Roman Gushchin Reviewed-by: Michal Koutný Acked-by: Shakeel Butt Reviewed-by: Muchun Song --- fs/kernfs/mount.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/kernfs/mount.c b/fs/kernfs/mount.c index cfa79715fc1a..3ac4191b1c40 100644 --- a/fs/kernfs/mount.c +++ b/fs/kernfs/mount.c @@ -391,7 +391,8 @@ void __init kernfs_init(void) { kernfs_node_cache = kmem_cache_create("kernfs_node_cache", sizeof(struct kernfs_node), - 0, SLAB_PANIC, NULL); + 0, SLAB_PANIC | SLAB_ACCOUNT, + NULL); /* Creates slab cache for kernfs inode attributes */ kernfs_iattrs_cache = kmem_cache_create("kernfs_iattrs_cache", -- 2.36.1