From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E72B1C001DC for ; Mon, 31 Jul 2023 16:48:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1906A6B0156; Mon, 31 Jul 2023 12:48:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 118C46B0157; Mon, 31 Jul 2023 12:48:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EFAA628006E; Mon, 31 Jul 2023 12:48:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DCB5A6B0156 for ; Mon, 31 Jul 2023 12:48:55 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AC32A80222 for ; Mon, 31 Jul 2023 16:48:55 +0000 (UTC) X-FDA: 81072491430.04.017FD06 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 5BA912001C for ; Mon, 31 Jul 2023 16:48:52 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UFaRKspw; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690822132; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6TgwT38r7+YbyfH94qkF+Uv3IgMJq4zc27cr5GOz45w=; b=iXlXfqXx0oUi1/ZcrvVuTF6Oiz8+4ePlM//NNnNfhOZl8zsr/9QJyKmer6AxxhE8pnubgC uEE4lOtHPoiFDCw201lfbGPjevMSXrvk5WMHQlsMdRzOQ9BvQhPrqFJcrXJwVOD3tlPT9U O1fT0X8vAMy/rHqXMe8cnOfycWvm90U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690822132; a=rsa-sha256; cv=none; b=8eW1w1EdFx/vk0feLyuCS866FXdTR8uJ7szu3lrpP/q/sC0tfZsBhj3pm/iHLsxzU16fSO izta1EO0P1ePJE8xCKCxDAihHKTG5gKqxBhNV5hFEwti9+TMK16y0qZlKSjghJRZpHoyvL 7G7SCHVDlUJxh0YF5SUL3+zoyfl3x/A= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=UFaRKspw; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690822131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6TgwT38r7+YbyfH94qkF+Uv3IgMJq4zc27cr5GOz45w=; b=UFaRKspw8qS/wfvid8hl+4VfzGdLTbmNtDR+LReWAc2YzX97ScNrF85q1hBuq9D+xH8XJX vzDwvk6047/1bN2dv5ACa+n/m6lEnyEU5SbQCffvN183omcVHJG6+hQInDDjgNrbdL+ML8 RD4D+cKKJ9OUe9gYrp7JaDeTiwHJ5b4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-637-RT-w-SRbPjuw-58WPEEyxw-1; Mon, 31 Jul 2023 12:48:50 -0400 X-MC-Unique: RT-w-SRbPjuw-58WPEEyxw-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-317a3951296so632068f8f.2 for ; Mon, 31 Jul 2023 09:48:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690822129; x=1691426929; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6TgwT38r7+YbyfH94qkF+Uv3IgMJq4zc27cr5GOz45w=; b=JQa+XbehtrSDexHeqqJBMFjpxRmWDqGWE6RKrEWZiIhdj+Y1EuyIgPxR1xmN+JoZFJ dCF4K/fHvV/43o07Nh615gGpSrNQLhMcesvstLhscCeAxJKINLpebAAICjkR0+/Rcbcc UVdJsQMG0i1r8dXAMNxhpa47i5Ff6fB4c672HfJmBm2zMh8qjklZ7mpiXCwgTgQWtVso A4PPakFaZhYBL2pv1pQ+pYun94RetakoSedenEiEeWSHsXuIYR3yDF8bECa3FmtPjNSz 2OmdkzpzQtuqqTlicBPwuXSAfhlb9U8gaQvQBYXy1dFC66+bZ3glrhUM/xFbPahTEMny XBtQ== X-Gm-Message-State: ABy/qLbYFhlnPvrUTktnk+8O6t6l8wj8BxY3ewbIVtiMLFd/zD7l5mlw pXuSsQpCQ82bXNmvq6uxvWGDxhFAHJtQSuCCg23ap33V8LZz7yTrDu6J7jmh5ek0sub9SvgCbtv gwUigSPt8dJQ= X-Received: by 2002:adf:f7cc:0:b0:314:10d6:8910 with SMTP id a12-20020adff7cc000000b0031410d68910mr280808wrq.63.1690822128762; Mon, 31 Jul 2023 09:48:48 -0700 (PDT) X-Google-Smtp-Source: APBJJlHsulRPcR/7aCWwzmerrdvtLRirVZ/0lTim8W8Rly8QTe7pj1jyO8KSx+l6F7ppUQQ0Bq+k+A== X-Received: by 2002:adf:f7cc:0:b0:314:10d6:8910 with SMTP id a12-20020adff7cc000000b0031410d68910mr280792wrq.63.1690822128294; Mon, 31 Jul 2023 09:48:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c723:4c00:5c85:5575:c321:cea3? (p200300cbc7234c005c855575c321cea3.dip0.t-ipconnect.de. [2003:cb:c723:4c00:5c85:5575:c321:cea3]) by smtp.gmail.com with ESMTPSA id y18-20020a5d6212000000b003143c6e09ccsm13700276wru.16.2023.07.31.09.48.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jul 2023 09:48:47 -0700 (PDT) Message-ID: Date: Mon, 31 Jul 2023 18:48:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH RFC v2 0/4] Add support for sharing page tables across processes (Previously mshare) To: Matthew Wilcox Cc: Rongwei Wang , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, "xuyu@linux.alibaba.com" References: <74fe50d9-9be9-cc97-e550-3ca30aebfd13@linux.alibaba.com> <9faea1cf-d3da-47ff-eb41-adc5bd73e5ca@linux.alibaba.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: ijmm7bzk8afbwdcbzcgs7f4e4o3feesw X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5BA912001C X-Rspam-User: X-HE-Tag: 1690822132-897551 X-HE-Meta: U2FsdGVkX1/wrprfxF9lnqvpRZ1Ahi2Ptm5idK7h1pmChaJy9WEYOVVKfQF7AqPGtuq4YdeonJyyTh0UtHe6m+lx5c9A5YYhcUaE1xUBOq+RA/aWy7Fors0lztTOeaOmtM871eG6jYpdR5lK1+jh9wFszSGUsIwoyybWHzkUPNo3GrQK3il3hlQmdRNzVSneZjLG9M0K/wKxl0Vab4m2uS9eJiUdEJdHYdHvr9Y+cUiaFePlaKll1tZ+D20Sce4YoillKukV2jz0+d6vF8yG9sQ2DtV9cMXtbHsooaDjK3vp/rewZSWZeB/+e1jde8fpumcvJ3knsM6buH//SEMkKqtaB9FodfjVe73iOdU9kvslOY6rQfJMb/q30UqBHc1uF69yWv2oC1jWsoRsVqw33yInqZOnjmMYigtFxE1ufPvFMLeeIwhpyqXwUdoeUunBSoBayMQa5Uy0VnKZXHce3vmbQ+H3BhW5LA6RXWJsngYIrNvLKNjqmFDfXOPloKrSNcb/R51RcDkEGkn29GnsbKGtA2cB5OX49zC1c4rkg0W8bEp+ex9T2qX8kFZFY6rHozuZm9KNKndId4ss6I4F8WvTpUY1792Bv+F3keJu12oFyIAEdZiX2HH25f+pxGFCVZcRYaQA5uVgE6lZr6f/3gnybdjIhxaGXqAux7/ks6tF9/1sk73QZJlfl5FYizLkF9NCLHs6X0CiTNKqe8/l3c2X0wEW2HM50/RPPT15fhcdvnFGXhj4rCg6PoJgpinIsv9JYPnYt6aBrEtI5praWedye58bMb/TazMzHyY6EgOo2wZCfWSzPYVunNDyx972LyD3vQ+nDH4XgUj/t+VKifbr9J9G1fanavPRvCsUFRQBTw+eTmBthCf0Ta1AetPTBiW9FNB4dLJ1UuJDyVFX9LneIOtE2zranlVWxVx4HK9o+WXHiOqIxfP7QJYGRbhyIbbF2gsvdVzqKB+LR9p uC+qS9CH /4ktWxV5bt9LftrFb1/BITS+WzEn/650MM5OFkf+SjoXl4dvyjwWFQUOxNvxQBoWp9r+CNwnmyGQMAwdFZ2hES88o02T/Fxi5EnUUqjpDMO2mK37Pz02aNBZg0+aTXKdUnJsHR4tkjpAqZFb7geAvGehr0l10vJn3tm+b/pAitAsQVT3vgbCi7eEKY8FthOkdo+IZTDfaDYuBhM6DC7uiPIDAjckml/7rP7GjtdN3hQ8vGvfHydZipmEH4z2NdSbl/eloaMcxq0vDov8ZsVsyBBKImrS/N9oBJNrUvleTL96IHzVk39HMEEAic0/WidhwjHyxAeRhq6w+dV9CVlOxXTwhApIdRPHszeBm1+kwiMTfszHBxajInkI6lJSzzIpfdkVjxYFdlxyv6wS1c3ZN6XTfoH+Zua0OW/QnElXHZTKbU4w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.07.23 18:38, Matthew Wilcox wrote: > On Mon, Jul 31, 2023 at 06:30:22PM +0200, David Hildenbrand wrote: >> Assume we do do the page table sharing at mmap time, if the flags are right. >> Let's focus on the most common: >> >> mmap(memfd, PROT_READ | PROT_WRITE, MAP_SHARED) >> >> And doing the same in each and every process. > > That may be the most common in your usage, but for a database, you're > looking at two usage scenarios. Postgres calls mmap() on the database > file itself so that all processes share the kernel page cache. > Some Commercial Databases call mmap() on a hugetlbfs file so that all > processes share the same userspace buffer cache. Other Commecial > Databases call shmget() / shmat() with SHM_HUGETLB for the exact > same reason. I remember you said that postgres might be looking into using shmem as well, maybe I am wrong. memfd/hugetlb/shmem could all be handled alike, just "arbitrary filesystems" would require more work. > > This is why I proposed mshare(). Anyone can use it for anything. > We have such a diverse set of users who want to do stuff with shared > page tables that we should not be tying it to memfd or any other > filesystem. Not to mention that it's more flexible; you can map > individual 4kB files into it and still get page table sharing. That's not what the current proposal does, or am I wrong? Also, I'm curious, is that a real requirement in the database world? -- Cheers, David / dhildenb