From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CF40C2BD09 for ; Wed, 3 Jul 2024 16:03:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC5626B0088; Wed, 3 Jul 2024 12:03:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4E706B0089; Wed, 3 Jul 2024 12:03:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C7766B008A; Wed, 3 Jul 2024 12:03:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6A2AE6B0088 for ; Wed, 3 Jul 2024 12:03:02 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 8172880D2C for ; Wed, 3 Jul 2024 16:03:01 +0000 (UTC) X-FDA: 82298910162.06.A7E2E37 Received: from out0-216.mail.aliyun.com (out0-216.mail.aliyun.com [140.205.0.216]) by imf28.hostedemail.com (Postfix) with ESMTP id DCFECC0035 for ; Wed, 3 Jul 2024 16:02:56 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b=TWyzmTwC; spf=pass (imf28.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.216 as permitted sender) smtp.mailfrom=libang.li@antgroup.com; dmarc=pass (policy=quarantine) header.from=antgroup.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720022566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u8cIspOx+Kmuer/vpt0eeOp7L8p2EbLDnQLFewuL1rY=; b=69KDcmi0sHVGkAgRWXOiKD1s8/riAId3ORg9HsvPZwj5YK2SLYbNhuIVgEdOOFmq23zgv9 I+4jBaODVwoHasEMbDVLtfDdVN/fc4/mRJwITn/rnRO0HMTBlvRkBLm2FXOeuB3MtnvhrN SfB2dgvibjdoXSijKuKCsly/vON9OAk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b=TWyzmTwC; spf=pass (imf28.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.216 as permitted sender) smtp.mailfrom=libang.li@antgroup.com; dmarc=pass (policy=quarantine) header.from=antgroup.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720022566; a=rsa-sha256; cv=none; b=w4mHCA+DFsE2YP5UCH0ZjN+bUH3G6S3laVPe1EitxBp9dT/fmrL5QMBH8uAwo23x9Rj19f W+LP9UAwn6S1q47BMXxS03VzsSSjSM7T2Q81le//x1YsUR7IEx8MoL1QAWRB1/68zag8Xv U7I+0O6KqwFfjWMy5iVCPkyyOiM98yc= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=antgroup.com; s=default; t=1720022571; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=u8cIspOx+Kmuer/vpt0eeOp7L8p2EbLDnQLFewuL1rY=; b=TWyzmTwCwezpNMzaMBDgYSpFAPO4FzKMEK+la+C85azwmXtfIxOW3A0i5+MS40/wQd5NUrQNzGi81DvSUgpaMAf5v2cpDyfGnBTzoNVRwhOajzi2dRye1BGLoF5hRRvq6+qRBq1H88Y6EQbnL3ehguKH4xzhcdb4xMIfWmYLbyk= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R181e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033040106183;MF=libang.li@antgroup.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---.YGdjyw9_1720022569; Received: from 30.39.194.34(mailfrom:libang.li@antgroup.com fp:SMTPD_---.YGdjyw9_1720022569) by smtp.aliyun-inc.com; Thu, 04 Jul 2024 00:02:50 +0800 Message-ID: Date: Thu, 04 Jul 2024 00:02:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: thp: support "THPeligible" semantics for mTHP with anonymous shmem To: Ryan Roberts , ughd@google.com, akpm@linux-foundation.org Cc: david@redhat.com, wangkefeng.wang@huawei.com, baolin.wang@linux.alibaba.com, ioworker0@gmail.com, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240702023401.41553-1-libang.li@antgroup.com> <507da6d0-77c5-46ca-8351-53b405ecb131@arm.com> <8c018e06-74f1-46e9-bc32-b3870342cdc1@antgroup.com> <8d9e501a-0645-4b78-809a-7c9f49f2106d@arm.com> Content-Language: en-US From: "Bang Li" In-Reply-To: <8d9e501a-0645-4b78-809a-7c9f49f2106d@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: DCFECC0035 X-Stat-Signature: faxndcb48awu4tj6mmms8ioxo4by9etk X-Rspam-User: X-HE-Tag: 1720022576-524629 X-HE-Meta: U2FsdGVkX1+JoVYERwjogelYThgWfip55rWFaGXkvo3Hub+eKcX9Ml9UcWMY4vYdu7HcsB++iifzzjpUg87p12gInlh2JTugwouvkYe5R7vnHRIT71F670ffI5uOXDXpaD2SfIH2Q6AbBj/0eHc9/WgI1coNyJvLJeR/mYSd7p5vyqdqp4xCZHWdSgRj4pGrjL6eag7seaHlzpxReXsh6ivGEnojK80WmMO+TvvIrhARLQrJ9YY9I3ih7KRW/Fbjog2FUxUZOie0TvgTgLcnuto9spop/9ij/eUykckS+RYhbTM9QuYY0gahGbFjhh+V+kPCRKXOxVt3G4XWlM18rFQTL4e2BvEAiVFwJLEL9pvvkzyaQIZ9SSglo4HCjtSmVwBaNTl21uQDDhTtZ9XofQGI3bACIcjDnAX8KBnTrwzTcJ9cFWNx+AFZsBGcgJW6sisQg824KXoSsCj3IUkwM9G5Zq5Sjy0lheBtZZ10q0x/pSaCXvEJI3POFnS0rTVejEAyUg/u4k5V7chkzpECR1g6e3tCdzpRab0iWq869Bv4XcsSC3HfIsSBC9KocCT9JBY8Pv8+S2b93gxSklhbrwfMZ7foLjl6kEkEAZ2DwunzY106UKeVftWrzFJa6Qn3BRACOkTvrqFPQSGdXTYIBAJEYXxakxHcZgxM/bMhTH4BFjw5f2W38QTYLMJzwCjj2Z4QKR8OpDfZuBE/IMFvU2hDtHh0kzx25wnfOp/YcGXaw+q0atqnkb/tfeiBtxaxQN8mSkxID/FtR7iTxJFh49AWDNo620H4KQwFtqhDPKj2U0GBc4398wfjHNsafFMbanJFe5uvrOq7lrBwbTKqAS1eljtFSNK8ynBVK/qsUgeiwxNzhzNt0eZ0QZbtVDl9q0C//LCi39JdLCWcH47m+K32wcQPks1xMZginnXDPM/fc+w/6l2XFRwlgqmjQDcP7CWDv3OdOFiB81BJt5V 4QO+VgiX jbd34TxP8It1+rEnyquTYjLwTmolVCLr24jlYUxivhuvUlmFgQkmglav0d9eTbqhHyv4oAdHvIgqucS+ZKUo/FC1O6R9kjlAdQe293HTUw9uEVLuatXJd5cb9jYyapNORmkzJuuNv29lkvxc7qkUs72941u0MifpUC/rBwFRRxWSngn2wZ6BbDAKSZzlflCWtAud7Yn9UHS7/7W6DCBwWQx+D5CtraxHBL4ABy4TAROOGzg4kPq68YwLQ/PaqR0jZbG/HBySSodK0FRykYj7ZPxrVo3+CdF9bp5EVpZ0r2BH6qj4i57Qv97wlFxuXHBHiJo/J2Kc5L84l8fbRic1u6u715hxHvNcOUYdsWgEaCTeuJ8euXA38ryA7B61dzQSeR1rDPQeNXaXQ9nqra6UthBQ9I8QZwOhym04V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/3 18:25, Ryan Roberts wrote: > On 03/07/2024 08:33, Bang Li wrote: >> Hi Ryan, >> >> Thanks for the review! >> >> On 2024/7/2 16:18, Ryan Roberts wrote: >>> On 02/07/2024 03:34, Bang Li wrote: >>>> After the commit 7fb1b252afb5 ("mm: shmem: add mTHP support for >>>> anonymous shmem"), we can configure different policies through >>>> the multi-size THP sysfs interface for anonymous shmem. But >>>> currently "THPeligible" indicates only whether the mapping is >>>> eligible for allocating THP-pages as well as the THP is PMD >>>> mappable or not for anonymous shmem, we need to support semantics >>>> for mTHP with anonymous shmem similar to those for mTHP with >>>> anonymous memory. >>>> >>>> Signed-off-by: Bang Li >>>> --- >>>> Changes since v1 [1]: >>>>   - Put anonymous shmem mthp related logic into >>>>     thp_vma_allowable_orders() (per David) >>>> >>>> [1] >>>> https://lore.kernel.org/linux-mm/20240628104926.34209-1-libang.li@antgroup.com/ >>>> --- >>>>   include/linux/huge_mm.h | 11 +++++++++++ >>>>   mm/huge_memory.c        | 13 +++++++++---- >>>>   mm/shmem.c              |  9 +-------- >>>>   3 files changed, 21 insertions(+), 12 deletions(-) >>>> >>>> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >>>> index 212cca384d7e..f87136f38aa1 100644 >>>> --- a/include/linux/huge_mm.h >>>> +++ b/include/linux/huge_mm.h >>>> @@ -267,6 +267,10 @@ unsigned long thp_vma_allowable_orders(struct >>>> vm_area_struct *vma, >>>>       return __thp_vma_allowable_orders(vma, vm_flags, tva_flags, orders); >>>>   } >>>>   +unsigned long shmem_allowable_huge_orders(struct inode *inode, >>>> +                struct vm_area_struct *vma, pgoff_t index, >>>> +                bool global_huge); >>>> + >>>>   struct thpsize { >>>>       struct kobject kobj; >>>>       struct list_head node; >>>> @@ -460,6 +464,13 @@ static inline unsigned long >>>> thp_vma_allowable_orders(struct vm_area_struct *vma, >>>>       return 0; >>>>   } >>>>   +static inline unsigned long shmem_allowable_huge_orders(struct inode *inode, >>>> +                struct vm_area_struct *vma, pgoff_t index, >>>> +                bool global_huge) >>>> +{ >>>> +    return 0; >>>> +} >>>> + >>>>   #define transparent_hugepage_flags 0UL >>>>     #define thp_get_unmapped_area    NULL >>>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >>>> index c7ce28f6b7f3..ea377bb4af91 100644 >>>> --- a/mm/huge_memory.c >>>> +++ b/mm/huge_memory.c >>>> @@ -151,10 +151,15 @@ unsigned long __thp_vma_allowable_orders(struct >>>> vm_area_struct *vma, >>>>        * Must be done before hugepage flags check since shmem has its >>>>        * own flags. >>>>        */ >>>> -    if (!in_pf && shmem_file(vma->vm_file)) >>>> -        return shmem_is_huge(file_inode(vma->vm_file), vma->vm_pgoff, >>>> -                     !enforce_sysfs, vma->vm_mm, vm_flags) >>>> -            ? orders : 0; >>>> +    if (!in_pf && shmem_file(vma->vm_file)) { >>>> +        bool global_huge = shmem_is_huge(file_inode(vma->vm_file), >>>> vma->vm_pgoff, >>>> +                            !enforce_sysfs, vma->vm_mm, vm_flags); >>>> + >>>> +        if (!vma_is_anon_shmem(vma)) >>>> +            return global_huge? orders : 0; >>> >>> nit: missing space before '?' >> >> Yes, thanks. >> >>> >>>> +        return shmem_allowable_huge_orders(file_inode(vma->vm_file), >>>> +                            vma, vma->vm_pgoff, global_huge); >>> >>> What's the rationale for splitting these functions into shmem_is_huge() and >>> shmem_allowable_huge_orders()? Why not just have a single >>> shmem_allowable_huge_orders() that tells you the answer? >>> >> >> Currently, shmem_is_huge() is used for all shmem implementations to determine >> whether the conditions for using THP are met. And shmem_allowable_huge_orders() >> is currently mainly used for anonymous shmem's mTHP to obtain all orders that >> meet the conditions. In my opinion, there is no problem in separating these two >> functions. In the future, when mTHP of other shmem types is also implemented, >> will shmem_is_huge() be unnecessary? > > Personally, I consider shmem_is_huge() to be superfluous; If you have one > function, shmem_allowable_huge_orders(), that gives you all the information you > need. If the inode only allows PMD-size, then only return that bit in the field. > IMHO removing shmem_is_huge() would make things more readable. Thank you very much for your opinion. I think there is no big problem in keeping the current interface status quo. In my opinion, when we implement mTHP for all shmems, it may be better to remove shmem_is_huge() and use shmem_allowable_huge_orders() uniformly. I believe that it won't be long before someone proposes a non-anonymous shared mTHP patchset. Anyway, thank you for your suggestion :). Thanks, Bang > > Thanks, > Ryan > >> >> Thanks, >> Bang >> >>>> +    } >>>>         if (!vma_is_anonymous(vma)) { >>>>           /* >>>> diff --git a/mm/shmem.c b/mm/shmem.c >>>> index d495c0701a83..aa85df9c662a 100644 >>>> --- a/mm/shmem.c >>>> +++ b/mm/shmem.c >>>> @@ -1622,7 +1622,7 @@ static gfp_t limit_gfp_mask(gfp_t huge_gfp, gfp_t >>>> limit_gfp) >>>>   } >>>>     #ifdef CONFIG_TRANSPARENT_HUGEPAGE >>>> -static unsigned long shmem_allowable_huge_orders(struct inode *inode, >>>> +unsigned long shmem_allowable_huge_orders(struct inode *inode, >>>>                   struct vm_area_struct *vma, pgoff_t index, >>>>                   bool global_huge) >>>>   { >>>> @@ -1707,13 +1707,6 @@ static unsigned long shmem_suitable_orders(struct >>>> inode *inode, struct vm_fault >>>>       return orders; >>>>   } >>>>   #else >>>> -static unsigned long shmem_allowable_huge_orders(struct inode *inode, >>>> -                struct vm_area_struct *vma, pgoff_t index, >>>> -                bool global_huge) >>>> -{ >>>> -    return 0; >>>> -} >>>> - >>>>   static unsigned long shmem_suitable_orders(struct inode *inode, struct >>>> vm_fault *vmf, >>>>                          struct address_space *mapping, pgoff_t index, >>>>                          unsigned long orders)