From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC108C19F2E for ; Thu, 27 Feb 2025 16:12:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1999D6B007B; Thu, 27 Feb 2025 11:12:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 149CC6B0082; Thu, 27 Feb 2025 11:12:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0552280001; Thu, 27 Feb 2025 11:12:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D14396B007B for ; Thu, 27 Feb 2025 11:12:42 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7FB121418E9 for ; Thu, 27 Feb 2025 16:12:42 +0000 (UTC) X-FDA: 83166217764.13.6C4F4F1 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf16.hostedemail.com (Postfix) with ESMTP id 2287F18000A for ; Thu, 27 Feb 2025 16:12:39 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=oI3y+H5S; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="zyR1mjE/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=oI3y+H5S; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="zyR1mjE/"; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740672760; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XXuMgPrLUYOokEa/u76ShCXa5pQmd7tZ8j8UwtE0mp4=; b=pbf7gJSAPfKX+PVizhcZpZP79nl3zuVK7nGxKNfAtaEvlUNDsqUB4hnBEzAIgbZFjtary0 zK3gbM0ICv3z0Px/XyQ7UmoTN7Fy/VlAC/STMrwtvG3v+GUx5JXhVro8AUojZZQ0R5mnXu FCJSaJC8FeFpgd23/FkFuoxpVISOQTg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=oI3y+H5S; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="zyR1mjE/"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=oI3y+H5S; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="zyR1mjE/"; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740672760; a=rsa-sha256; cv=none; b=iEDO8Y71LMMCyX3JyX9fsAJ1GvbP7pO5EUN/V1Cvw7aRtLMpHhtWGKtILxwjjfm4/uZGQZ eRggEzTnLTqRDvb5s0Mi6btcL7wNwYJomznVnNURKx1OuJNpv4yzt67rOvQCQTBTr11oGO 5D3LLTm7fESBCZYdczAzBDHh0Wu5jlQ= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 93A3F21179; Thu, 27 Feb 2025 16:12:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740672758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XXuMgPrLUYOokEa/u76ShCXa5pQmd7tZ8j8UwtE0mp4=; b=oI3y+H5SwfxEvQbqLWLBHgZyBUZqMD60ZeYuNqjFcqCSiNuWFmanpz3fm95w3U7wQLODf5 n2F3Gku03k43uX69QzosXYzBxQv/dU6GbzFtIFmvVlxse+Ea5YKCFX8cLtcu9hkPNFa/9L /CJCsxJ7Qj/aiadSkTOW+koOrvn5ogQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740672758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XXuMgPrLUYOokEa/u76ShCXa5pQmd7tZ8j8UwtE0mp4=; b=zyR1mjE/5XRV2KYHCXvAX+iksUU2reuGHwdSQ1CEWi8GS8KyITP/R/rxK3jzAgM4uChsac NrM6gf6uEFq9eYAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1740672758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XXuMgPrLUYOokEa/u76ShCXa5pQmd7tZ8j8UwtE0mp4=; b=oI3y+H5SwfxEvQbqLWLBHgZyBUZqMD60ZeYuNqjFcqCSiNuWFmanpz3fm95w3U7wQLODf5 n2F3Gku03k43uX69QzosXYzBxQv/dU6GbzFtIFmvVlxse+Ea5YKCFX8cLtcu9hkPNFa/9L /CJCsxJ7Qj/aiadSkTOW+koOrvn5ogQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1740672758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XXuMgPrLUYOokEa/u76ShCXa5pQmd7tZ8j8UwtE0mp4=; b=zyR1mjE/5XRV2KYHCXvAX+iksUU2reuGHwdSQ1CEWi8GS8KyITP/R/rxK3jzAgM4uChsac NrM6gf6uEFq9eYAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 75F3C1376A; Thu, 27 Feb 2025 16:12:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ZexzHPaOwGcZHAAAD6G6ig (envelope-from ); Thu, 27 Feb 2025 16:12:38 +0000 Message-ID: Date: Thu, 27 Feb 2025 17:12:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/2] mm: slub: Enhanced debugging in slub error Content-Language: en-US To: Hyesoo Yu Cc: janghyuck.kim@samsung.com, harry.yoo@oracle.com, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250226081206.680495-1-hyesoo.yu@samsung.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20250226081206.680495-1-hyesoo.yu@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: h9idszdim5rydnub4gcjdj63tb9jyg81 X-Rspamd-Queue-Id: 2287F18000A X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1740672759-313663 X-HE-Meta: U2FsdGVkX1/mH8DWs1yJYDy6R7Ow6SFrjW/J6CI447GII1Sxb7tjQha/EPMy0v7bIZt5vT1+MAcD2AlXJfPVhxwDA3vK2sbdhZR/GiVoqZ1RH/aqzT1vA+VftYLKdS1jUcFZfvFmD93vx51mKAlryG3aj3jTNTNd3jE5jOFCiyWZ8dreiMGuj/gwWWs1vmndRdDEgjuu/Ec1mpBwMzlxlmwnQUNX5EF3/DQO4Wo/8UQHirf585ZFwm/5re4OSeUVAJ2gWE+oxvHCzj3g3YSd/kLlbAb2ZYYWBEOIxwVCwT0kopjEg1Fl9ZjyWzzUpvDaRQplzWKKjBPtEjNHWOvV93due0WE/KLV7nBl3Il6brg+Pt2Z9TYxDIejE16JtFVA/plgvDJA3Qu2gvJQCnXdTCa/q9/eL6tN/JtXQs2+DLW1tB846kUxiTS7uIKuSGpw07t7UoEPNWmJAAhM+sUWMS670+6KB4NJPrrd58gfqC4+sD/dtHv+BMYpvLhxporXpPGp3EMlElrSyF5q3neroP7A4F/7p+MCSpj1y9egAiy6QE0OA3n8kkAhhSD8vMPXT+uBIFx2vm0zb/ByLZ4tgf4UokWjRVeAv7ln7BI4FW7nslQEOzjcSRJ8tBdmHCtcXsRoe26z4O0uF0d87UmYg/arxMjHuEapM8/1rOmzXomcdVAoxVzmk5W03iS0UWwn+VIHZgXjB4qOzFNlVuXScV2A8vE3y04JQiFmkwm2Vh5N1ZmsTFyg4Xe11zb9MRb5g+EdxwIhtW0+1vGP+4jUGYOgGtqepGE5stsVmaoSmkokKB7gylTvtIN1pANYFYXERB/Dit3NkNi4ExXyr2NA7wzLYIEAM3COUBNYL0Guni1FWU0oy6PmFXzWKiMV/PQkTWK+zsKMWHfmvUk1eGJ5ToYXLB9VUTKgzui5g+clHwV7xiUp/uDSfXNukZkN02Dj/PcGXZ0ZBFNXxajQ1vU CmmU4uLl nT3X/Cm8+Cy3GP6fWwksSUahTgDec8W9TbP3nMtp3mvgO/mc6QFmV2qFLcf2ZlrXCcLCTAxwcOMmlNQUvAoI/3blHNBh5FJgUu4H5IqLF7YWAfsIk9wwelAFHGAeqZIrRluBJadW1J2LTjtANnSw4ZsUTOYEDew5JdhrFhpFa10RSkLEHvATnEJ6BCACzS/hVKtWR/4wGftKe8AtbKGpLwmFevz87X7Rzftv30W/ZIDcxUCaMba1zDaQC1YSUo0hfSKZsWKZkROlgaXd+OB+IlesKhz49UKHFqlrfpNtatgu8v+hqeNlGU1gSvAYVolfo3KL8gb5WJmF4lJQohCkuLOLrBoMbLxSpeY5Zg4S9aSUmC+knI4fPVLi+t5ZnT9pitrByURvOHkrGgP6MENr5pgkZAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/26/25 09:11, Hyesoo Yu wrote: > Dear Maintainer, > > The purpose is to improve the debugging capabilities of the slub allocator > when a error occurs. The following improvements have been made: > > - Added WARN() calls at specific locations (slab_err, object_err) to detect > errors effectively and to generate a crash dump if panic_on_warn is enabled. > > - Additionally, the error printing location in check_object has been adjusted to > display the broken data before the restoration process. This improvement > allows for a better understanding of how the data was corrupted. > > This series combines two patches that were discussed seperately in the links below. > https://lore.kernel.org/linux-mm/20250120082908.4162780-1-hyesoo.yu@samsung.com/ > https://lore.kernel.org/linux-mm/20250120083023.4162932-1-hyesoo.yu@samsung.com/ > > Thanks you. Thanks. On top of things already mentioned, I added some kunit suppressions in patch 2. Please check the result: https://web.git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git/log/?h=slab/for-6.15/fixes-cleanups