From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19401C433FE for ; Wed, 19 Oct 2022 12:33:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 991A46B0071; Wed, 19 Oct 2022 08:33:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9432F6B0073; Wed, 19 Oct 2022 08:33:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80AC46B0074; Wed, 19 Oct 2022 08:33:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 715136B0071 for ; Wed, 19 Oct 2022 08:33:24 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1C12A120C59 for ; Wed, 19 Oct 2022 12:33:24 +0000 (UTC) X-FDA: 80037639528.06.A12CDE4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id C122C16003C for ; Wed, 19 Oct 2022 12:33:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666182803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/mboaMe9gaID9QBKkicmcYb6FMJMHWN52iMVH+ykHQY=; b=SrzrdtZdw/sxO7WgvSG8B+X7PCZcjOfd4hWWmC1DIOz6Zr3mXuIDB1ooc6QvkC7AR7uBUD 4FkRGi4LtnHprDgKFHI6owSjOX/FnD6t/NRxhJ3N0pN8d6GfC5Hnol2UGk+SJmUu2k4a2m aczSRvAw7h/Kd/YwzrIuk6q28jO48kk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-227-9J0YeQnqPiyAQfq1-9XURQ-1; Wed, 19 Oct 2022 08:33:22 -0400 X-MC-Unique: 9J0YeQnqPiyAQfq1-9XURQ-1 Received: by mail-wm1-f72.google.com with SMTP id t20-20020a7bc3d4000000b003c6bfea856aso7857445wmj.1 for ; Wed, 19 Oct 2022 05:33:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/mboaMe9gaID9QBKkicmcYb6FMJMHWN52iMVH+ykHQY=; b=CHqQLwHugMujmcptBm1KfO0A9dHZddUmTzyYwssFXHWps28EhE7F/8tFtI/3ouLpaX PQbf9qBtrUXShJg+BCPtXgbjp1QIcu7rIwL4KD2AH8I1glX9VDtJ1Yhco9T5Cuijc2hx GgcFPX+pc5PnowrjEd/hdij/RE78vd9hdAbjZiARRNv3jDT60Ln3Yx7QXuJYaQw643xV byteAy15xuKt9FQs2H9VVekA4ZhLuCiGObQH5Odx4rIsmo480WpDkhhu/ZuKDLSvPB83 gWaAsq8iRzouSOLpWnJX9HGceKahBOg9kmDblqVgWz6eEGfTjpltubK0oFI4bjSPlVs1 a7EQ== X-Gm-Message-State: ACrzQf1T9rS6m+r3ylyvJE8vwSIFCZOOvZQ65TLVfEN5SFBKI7vu3EqN 0GBybEnIedacSrf9IO+zUW8Mx7zLONKRQcdRv5EV2FWlXdENWZzwMbeS27y32xq4N48ID0Fi/i+ E7Sn7SkeFLt0= X-Received: by 2002:a5d:4748:0:b0:22e:32c1:d11e with SMTP id o8-20020a5d4748000000b0022e32c1d11emr5097434wrs.672.1666182799548; Wed, 19 Oct 2022 05:33:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4ZCpAtby+E6unN5Wy+u9IszQTZYL2BSwB5rLUNO2OIQj+D41SXgbcnflDb4tj98oOc8cmhlQ== X-Received: by 2002:a5d:4748:0:b0:22e:32c1:d11e with SMTP id o8-20020a5d4748000000b0022e32c1d11emr5097411wrs.672.1666182799220; Wed, 19 Oct 2022 05:33:19 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:2c00:d4ac:d2c:4aee:dac1? (p200300cbc7072c00d4ac0d2c4aeedac1.dip0.t-ipconnect.de. [2003:cb:c707:2c00:d4ac:d2c:4aee:dac1]) by smtp.gmail.com with ESMTPSA id j30-20020adfa55e000000b0021e51c039c5sm14342243wrb.80.2022.10.19.05.33.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Oct 2022 05:33:18 -0700 (PDT) Message-ID: Date: Wed, 19 Oct 2022 14:33:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v1 7/7] selftests/vm: anon_cow: add R/O longterm tests via gup_test From: David Hildenbrand To: linux-kernel@vger.kernel.org, Andrew Morton Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Shuah Khan , Jason Gunthorpe , John Hubbard , Nadav Amit , Peter Xu , Andrea Arcangeli , Vlastimil Babka , Mike Rapoport , Christoph von Recklinghausen , Don Dutile References: <20220927110120.106906-1-david@redhat.com> <20220927110120.106906-8-david@redhat.com> <74adbb51-6e33-f636-8a9c-2ad87bd9007e@redhat.com> Organization: Red Hat In-Reply-To: <74adbb51-6e33-f636-8a9c-2ad87bd9007e@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666182803; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/mboaMe9gaID9QBKkicmcYb6FMJMHWN52iMVH+ykHQY=; b=JB/imsxCQh6CXeYmxR40G6tSEzEZuAp+cjxpKN4XsLJ9eYUL0W644F63PuLQYh9l/OGTen +dERJahXxvkyDteM1+7y7jr82hJIpFUfLakGuzqT+Emxpg92E3en+9V1GTqqokMeKvRBmW lBOCf7O0ShUshqdSFxk5N+KemtqgCOE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SrzrdtZd; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666182803; a=rsa-sha256; cv=none; b=idod0grSnLbJy12D0YIyQvmn8iZpq5ldbn/SKhTIRvHMTqRdYR0C2XPSfZi5kKIEM/hzRq Vv2lWyDE9GRVKHnzzP/DOLZsFpqEOkTjW7W2B+U3kV8BLdRTaLRrJSVr+vEYWdID0xoQsB kK5K/690wpURxxr4sIlPJHKg6/6t2Hg= Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SrzrdtZd; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Stat-Signature: j5xqoyeyg3aaoix7f1fpki9nza1jq3yo X-Rspamd-Queue-Id: C122C16003C X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1666182803-903246 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.10.22 14:31, David Hildenbrand wrote: > On 27.09.22 13:01, David Hildenbrand wrote: >> Let's trigger a R/O longterm pin on three cases of R/O mapped anonymous >> pages: >> * exclusive (never shared) >> * shared (child still alive) >> * previously shared (child no longer alive) >> >> ... and make sure that the pin is reliable: whatever we write via the page >> tables has to be observable via the pin. >> >> Signed-off-by: David Hildenbrand >> --- > > The following on top should silence the warning on 32bit: > > https://lore.kernel.org/all/202210182101.XOyPZEQV-lkp@intel.com/T/#u > > > diff --git a/mm/gup_test.c b/mm/gup_test.c > index 2bbfacd31f5a..57c343f2dc51 100644 > --- a/mm/gup_test.c > +++ b/mm/gup_test.c > @@ -299,7 +299,8 @@ static inline int pin_longterm_test_read(unsigned long arg) > for (i = 0; i < pin_longterm_test_nr_pages; i++) { > void *addr = page_to_virt(pin_longterm_test_pages[i]); > > - if (copy_to_user((void __user *)user_addr, addr, PAGE_SIZE)) > + if (copy_to_user((void __user *)(unsigned long)user_addr, addr, > + PAGE_SIZE)) > return -EFAULT; > user_addr += PAGE_SIZE; > } > > Ehm, wrong patch, it actually belongs into #6/7 https://lkml.kernel.org/r/20220927110120.106906-7-david@redhat.com @Andrew, if your confused, I can just resend the whole thing. -- Thanks, David / dhildenb