From: David Hildenbrand <david@redhat.com>
To: Michal Hocko <mhocko@kernel.org>,
Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Qian Cai <cai@lca.pw>,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] mm/page_isolation: fix potential warning from user
Date: Mon, 20 Jan 2020 10:42:52 +0100 [thread overview]
Message-ID: <c1a1e398-7f5b-3cb5-1c1b-41cf7d56486c@redhat.com> (raw)
In-Reply-To: <20200120074222.GF18451@dhcp22.suse.cz>
>>> + } else {
>>> + if (isol_flags & MEMORY_OFFLINE)
>>> + WARN_ON_ONCE(zone_idx(zone) == ZONE_MOVABLE);> +
>>> + if ((isol_flags & REPORT_FAILURE) && !IS_ERR(unmovable))
>>> + /*
>>> + * printk() with zone->lock held will likely trigger a
>>> + * lockdep splat, so defer it here.
>>> + */
>>> + dump_page(unmovable, "unmovable page");
>>> + }
>>> +
>>> + return !!unmovable;
>>> }
>>>
>>> static void unset_migratetype_isolate(struct page *page, unsigned migratetype)
>>
>> set_migratetype_isolate() gets called from CMA as well as HugeTLB
>> allocation paths, so its not only during offline. Hence the commit
>> message should be changed to reflect this.
>
> We should just report for all those cases I believe.
>
+1
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2020-01-20 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 3:42 Qian Cai
2020-01-20 4:20 ` Anshuman Khandual
2020-01-20 7:42 ` Michal Hocko
2020-01-20 9:42 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1a1e398-7f5b-3cb5-1c1b-41cf7d56486c@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=cai@lca.pw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox