From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D74EC433DB for ; Tue, 29 Dec 2020 16:35:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2F57721D94 for ; Tue, 29 Dec 2020 16:35:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F57721D94 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3A1DE8D0030; Tue, 29 Dec 2020 11:35:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 379DE8D002C; Tue, 29 Dec 2020 11:35:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28F9B8D0030; Tue, 29 Dec 2020 11:35:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0124.hostedemail.com [216.40.44.124]) by kanga.kvack.org (Postfix) with ESMTP id 13FBD8D002C for ; Tue, 29 Dec 2020 11:35:04 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CE12B3624 for ; Tue, 29 Dec 2020 16:35:03 +0000 (UTC) X-FDA: 77646869286.23.trick99_1d109df2749d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id ACD9737609 for ; Tue, 29 Dec 2020 16:35:03 +0000 (UTC) X-HE-Tag: trick99_1d109df2749d X-Filterd-Recvd-Size: 3630 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Tue, 29 Dec 2020 16:35:02 +0000 (UTC) IronPort-SDR: V3fRIuwgmxJHbKSsuqSM6nNvYGY4XMXbvs2jXeHcokK9z3eapPxT1bo0UxwznaPvy0tfptTtZf E9MbghiJHfPA== X-IronPort-AV: E=McAfee;i="6000,8403,9849"; a="240593794" X-IronPort-AV: E=Sophos;i="5.78,458,1599548400"; d="scan'208";a="240593794" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2020 08:34:55 -0800 IronPort-SDR: Wl5EDOps++Sos5Yh78VcJcwz2qfJFTwjnoTuS6PxulCuZ2H6XYQEqKjNjZ5w+VQZcz+Mv3rcID +GA8BBRxgBKA== X-IronPort-AV: E=Sophos;i="5.78,458,1599548400"; d="scan'208";a="347442009" Received: from yyu32-mobl1.amr.corp.intel.com (HELO [10.251.0.43]) ([10.251.0.43]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Dec 2020 08:34:51 -0800 Subject: Re: [PATCH v16 02/26] x86/cet/shstk: Add Kconfig option for user-mode control-flow protection To: Borislav Petkov Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu References: <20201209222320.1724-1-yu-cheng.yu@intel.com> <20201209222320.1724-3-yu-cheng.yu@intel.com> <20201229123910.GB29947@zn.tnic> From: "Yu, Yu-cheng" Message-ID: Date: Tue, 29 Dec 2020 08:34:51 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201229123910.GB29947@zn.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/29/2020 4:39 AM, Borislav Petkov wrote: > On Wed, Dec 09, 2020 at 02:22:56PM -0800, Yu-cheng Yu wrote: >> Shadow Stack provides protection against function return address >> corruption. It is active when the processor supports it, the kernel has >> CONFIG_X86_CET_USER, and the application is built for the feature. > ^ > enabled. > >> This is only implemented for the 64-bit kernel. When it is enabled, legacy >> non-Shadow Stack applications continue to work, but without protection. >> >> Signed-off-by: Yu-cheng Yu >> --- >> arch/x86/Kconfig | 22 ++++++++++++++++++++++ >> arch/x86/Kconfig.assembler | 5 +++++ >> 2 files changed, 27 insertions(+) > > Rest looks good, thanks. > Thanks! I will re-base to v5.11-rc1 and send out a new version. -- Yu-cheng