From: Jeff Layton <jlayton@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Alexander Viro" <viro@zeniv.linux.org.uk>,
"Christian Brauner" <brauner@kernel.org>,
"Jan Kara" <jack@suse.cz>, "Steven Rostedt" <rostedt@goodmis.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Eric Biggers" <ebiggers@kernel.org>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
"Muchun Song" <muchun.song@linux.dev>,
"Oscar Salvador" <osalvador@suse.de>,
"David Hildenbrand" <david@kernel.org>,
"David Howells" <dhowells@redhat.com>,
"Paulo Alcantara" <pc@manguebit.org>,
"Andreas Dilger" <adilger.kernel@dilger.ca>,
"Jan Kara" <jack@suse.com>, "Jaegeuk Kim" <jaegeuk@kernel.org>,
"Chao Yu" <chao@kernel.org>,
"Trond Myklebust" <trondmy@kernel.org>,
"Anna Schumaker" <anna@kernel.org>,
"Chuck Lever" <chuck.lever@oracle.com>,
NeilBrown <neil@brown.name>,
"Olga Kornievskaia" <okorniev@redhat.com>,
"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
"Steve French" <sfrench@samba.org>,
"Ronnie Sahlberg" <ronniesahlberg@gmail.com>,
"Shyam Prasad N" <sprasad@microsoft.com>,
"Bharath SM" <bharathsm@microsoft.com>,
"Alexander Aring" <alex.aring@gmail.com>,
"Ryusuke Konishi" <konishi.ryusuke@gmail.com>,
"Viacheslav Dubeyko" <slava@dubeyko.com>,
"Eric Van Hensbergen" <ericvh@kernel.org>,
"Latchesar Ionkov" <lucho@ionkov.net>,
"Dominique Martinet" <asmadeus@codewreck.org>,
"Christian Schoenebeck" <linux_oss@crudebyte.com>,
"David Sterba" <dsterba@suse.com>,
"Marc Dionne" <marc.dionne@auristor.com>,
"Ian Kent" <raven@themaw.net>,
"Luis de Bethencourt" <luisbg@kernel.org>,
"Salah Triki" <salah.triki@gmail.com>,
"Tigran A. Aivazian" <aivazian.tigran@gmail.com>,
"Ilya Dryomov" <idryomov@gmail.com>,
"Alex Markuze" <amarkuze@redhat.com>,
"Jan Harkes" <jaharkes@cs.cmu.edu>,
coda@cs.cmu.edu, "Nicolas Pitre" <nico@fluxnic.net>,
"Tyler Hicks" <code@tyhicks.com>,
"Amir Goldstein" <amir73il@gmail.com>,
"John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
"Yangtao Li" <frank.li@vivo.com>,
"Mikulas Patocka" <mikulas@artax.karlin.mff.cuni.cz>,
"David Woodhouse" <dwmw2@infradead.org>,
"Richard Weinberger" <richard@nod.at>,
"Dave Kleikamp" <shaggy@kernel.org>,
"Konstantin Komarov" <almaz.alexandrovich@paragon-software.com>,
"Mark Fasheh" <mark@fasheh.com>,
"Joel Becker" <jlbec@evilplan.org>,
"Joseph Qi" <joseph.qi@linux.alibaba.com>,
"Mike Marshall" <hubcap@omnibond.com>,
"Martin Brandenburg" <martin@omnibond.com>,
"Miklos Szeredi" <miklos@szeredi.hu>,
"Anders Larsen" <al@alarsen.net>,
"Zhihao Cheng" <chengzhihao1@huawei.com>,
"Damien Le Moal" <dlemoal@kernel.org>,
"Naohiro Aota" <naohiro.aota@wdc.com>,
"Johannes Thumshirn" <jth@kernel.org>,
"John Johansen" <john.johansen@canonical.com>,
"Paul Moore" <paul@paul-moore.com>,
"James Morris" <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
"Mimi Zohar" <zohar@linux.ibm.com>,
"Roberto Sassu" <roberto.sassu@huawei.com>,
"Dmitry Kasatkin" <dmitry.kasatkin@gmail.com>,
"Eric Snowberg" <eric.snowberg@oracle.com>,
"Fan Wu" <wufan@kernel.org>,
"Stephen Smalley" <stephen.smalley.work@gmail.com>,
"Ondrej Mosnacek" <omosnace@redhat.com>,
"Casey Schaufler" <casey@schaufler-ca.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Eric Dumazet" <edumazet@google.com>,
"Kuniyuki Iwashima" <kuniyu@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Willem de Bruijn" <willemb@google.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Simon Horman" <horms@kernel.org>,
"Oleg Nesterov" <oleg@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Namhyung Kim" <namhyung@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Jiri Olsa" <jolsa@kernel.org>, "Ian Rogers" <irogers@google.com>,
"Adrian Hunter" <adrian.hunter@intel.com>,
"James Clark" <james.clark@linaro.org>,
"Darrick J. Wong" <djwong@kernel.org>,
"Martin Schiller" <ms@dev.tdt.de>,
"Eric Paris" <eparis@redhat.com>,
"Joerg Reuter" <jreuter@yaina.de>,
"Marcel Holtmann" <marcel@holtmann.org>,
"Johan Hedberg" <johan.hedberg@gmail.com>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
"Oliver Hartkopp" <socketcan@hartkopp.net>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"David Ahern" <dsahern@kernel.org>,
"Neal Cardwell" <ncardwell@google.com>,
"Steffen Klassert" <steffen.klassert@secunet.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Remi Denis-Courmont" <courmisch@gmail.com>,
"Marcelo Ricardo Leitner" <marcelo.leitner@gmail.com>,
"Xin Long" <lucien.xin@gmail.com>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev,
fsverity@lists.linux.dev, linux-mm@kvack.org,
netfs@lists.linux.dev, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org,
v9fs@lists.linux.dev, linux-afs@lists.infradead.org,
autofs@vger.kernel.org, ceph-devel@vger.kernel.org,
codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org,
linux-mtd@lists.infradead.org,
jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev,
ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org,
linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com,
linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org, selinux@vger.kernel.org,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
netdev@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-hams@vger.kernel.org, linux-x25@vger.kernel.org,
audit@vger.kernel.org, linux-bluetooth@vger.kernel.org,
linux-can@vger.kernel.org, linux-sctp@vger.kernel.org,
bpf@vger.kernel.org
Subject: Re: [PATCH v3 01/12] vfs: widen inode hash/lookup functions to u64
Date: Fri, 06 Mar 2026 07:03:15 -0500 [thread overview]
Message-ID: <c1845a4b8d35d367953ac6cbfcf91ac36958ba51.camel@kernel.org> (raw)
In-Reply-To: <aamSFgXhrORAJLBC@infradead.org>
On Thu, 2026-03-05 at 06:24 -0800, Christoph Hellwig wrote:
> > extern struct inode *ilookup5_nowait(struct super_block *sb,
> > - unsigned long hashval, int (*test)(struct inode *, void *),
> > + u64 hashval, int (*test)(struct inode *, void *),
> > void *data, bool *isnew);
> > -extern struct inode *ilookup5(struct super_block *sb, unsigned long hashval,
> > +extern struct inode *ilookup5(struct super_block *sb, u64 hashval,
> > int (*test)(struct inode *, void *), void *data);
>
> ...
>
> Can you please drop all these pointless externs while you're at it?
>
I was planning to do that, but then Christian merged it!
I'll do a patch on top of this that does this in the range of fs.h that
the patch touches. Christian can throw it on top of the series, and
that shouldn't be too bad for backports.
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for the review!
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2026-03-06 12:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 15:32 [PATCH v3 00/12] vfs: change inode->i_ino from unsigned long " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 01/12] vfs: widen inode hash/lookup functions " Jeff Layton
2026-03-05 14:24 ` Christoph Hellwig
2026-03-06 12:03 ` Jeff Layton [this message]
2026-03-06 13:28 ` Christian Brauner
2026-03-04 15:32 ` [PATCH v3 02/12] audit: widen ino fields " Jeff Layton
2026-03-06 3:09 ` Paul Moore
2026-03-04 15:32 ` [PATCH v3 03/12] net: change sock.sk_ino and sock_i_ino() " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 04/12] vfs: widen trace event i_ino fields " Jeff Layton
2026-03-05 9:43 ` Jan Kara
2026-03-04 15:32 ` [PATCH v3 05/12] cachefiles: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 06/12] ext2: " Jeff Layton
2026-03-05 9:44 ` Jan Kara
2026-03-04 15:32 ` [PATCH v3 07/12] hugetlbfs: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 08/12] zonefs: " Jeff Layton
2026-03-04 21:41 ` Damien Le Moal
2026-03-04 15:32 ` [PATCH v3 09/12] ext4: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 10/12] f2fs: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 11/12] nilfs2: " Jeff Layton
2026-03-04 15:32 ` [PATCH v3 12/12] treewide: change inode->i_ino from unsigned long " Jeff Layton
2026-03-04 15:49 ` Chuck Lever
2026-03-04 21:41 ` Damien Le Moal
2026-03-05 9:57 ` Jan Kara
2026-03-05 14:25 ` Christoph Hellwig
2026-03-06 9:09 ` [PATCH v3 00/12] vfs: " Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1845a4b8d35d367953ac6cbfcf91ac36958ba51.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=acme@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=adrian.hunter@intel.com \
--cc=airlied@gmail.com \
--cc=aivazian.tigran@gmail.com \
--cc=al@alarsen.net \
--cc=alex.aring@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=amarkuze@redhat.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=amir73il@gmail.com \
--cc=anna@kernel.org \
--cc=apparmor@lists.ubuntu.com \
--cc=asmadeus@codewreck.org \
--cc=ast@kernel.org \
--cc=audit@vger.kernel.org \
--cc=autofs@vger.kernel.org \
--cc=bharathsm@microsoft.com \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=casey@schaufler-ca.com \
--cc=ceph-devel@vger.kernel.org \
--cc=chao@kernel.org \
--cc=chengzhihao1@huawei.com \
--cc=christian.koenig@amd.com \
--cc=chuck.lever@oracle.com \
--cc=coda@cs.cmu.edu \
--cc=codalist@coda.cs.cmu.edu \
--cc=code@tyhicks.com \
--cc=courmisch@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=david@kernel.org \
--cc=devel@lists.orangefs.org \
--cc=dhowells@redhat.com \
--cc=djwong@kernel.org \
--cc=dlemoal@kernel.org \
--cc=dmitry.kasatkin@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsahern@kernel.org \
--cc=dsterba@suse.com \
--cc=dwmw2@infradead.org \
--cc=ebiggers@kernel.org \
--cc=ecryptfs@vger.kernel.org \
--cc=edumazet@google.com \
--cc=eparis@redhat.com \
--cc=eric.snowberg@oracle.com \
--cc=ericvh@kernel.org \
--cc=frank.li@vivo.com \
--cc=fsverity@lists.linux.dev \
--cc=glaubitz@physik.fu-berlin.de \
--cc=hawk@kernel.org \
--cc=hch@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=hubcap@omnibond.com \
--cc=idryomov@gmail.com \
--cc=irogers@google.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=jaharkes@cs.cmu.edu \
--cc=james.clark@linaro.org \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=jlbec@evilplan.org \
--cc=jmorris@namei.org \
--cc=johan.hedberg@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=john.johansen@canonical.com \
--cc=jolsa@kernel.org \
--cc=joseph.qi@linux.alibaba.com \
--cc=jreuter@yaina.de \
--cc=jth@kernel.org \
--cc=konishi.ryusuke@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=lucien.xin@gmail.com \
--cc=luisbg@kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=marc.dionne@auristor.com \
--cc=marcel@holtmann.org \
--cc=marcelo.leitner@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mark@fasheh.com \
--cc=martin@omnibond.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=miklos@szeredi.hu \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=mingo@redhat.com \
--cc=mkl@pengutronix.de \
--cc=ms@dev.tdt.de \
--cc=muchun.song@linux.dev \
--cc=namhyung@kernel.org \
--cc=naohiro.aota@wdc.com \
--cc=ncardwell@google.com \
--cc=neil@brown.name \
--cc=netdev@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=nico@fluxnic.net \
--cc=ntfs3@lists.linux.dev \
--cc=nvdimm@lists.linux.dev \
--cc=ocfs2-devel@lists.linux.dev \
--cc=okorniev@redhat.com \
--cc=oleg@redhat.com \
--cc=omosnace@redhat.com \
--cc=osalvador@suse.de \
--cc=pabeni@redhat.com \
--cc=paul@paul-moore.com \
--cc=pc@manguebit.org \
--cc=peterz@infradead.org \
--cc=raven@themaw.net \
--cc=richard@nod.at \
--cc=roberto.sassu@huawei.com \
--cc=ronniesahlberg@gmail.com \
--cc=rostedt@goodmis.org \
--cc=salah.triki@gmail.com \
--cc=samba-technical@lists.samba.org \
--cc=sdf@fomichev.me \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=sfrench@samba.org \
--cc=shaggy@kernel.org \
--cc=simona@ffwll.ch \
--cc=slava@dubeyko.com \
--cc=socketcan@hartkopp.net \
--cc=sprasad@microsoft.com \
--cc=steffen.klassert@secunet.com \
--cc=stephen.smalley.work@gmail.com \
--cc=sumit.semwal@linaro.org \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=tytso@mit.edu \
--cc=v9fs@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
--cc=willemb@google.com \
--cc=wufan@kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox