From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA475C3ABB6 for ; Mon, 5 May 2025 09:57:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4EEE6B0089; Mon, 5 May 2025 05:57:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9FE016B008C; Mon, 5 May 2025 05:57:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 850C56B0092; Mon, 5 May 2025 05:57:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 67A766B0089 for ; Mon, 5 May 2025 05:57:44 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D4C88161E06 for ; Mon, 5 May 2025 09:57:45 +0000 (UTC) X-FDA: 83408402490.09.F8B9062 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 89121C0004 for ; Mon, 5 May 2025 09:57:43 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LNLgFbr8; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746439063; a=rsa-sha256; cv=none; b=vldP6rSyNe1T+d7qNZ1QFddNsSH7NfPz15GWuoOEMK+pyKlRbz7RrGb2xMHgiFLy1qryre ABm85tBwwqC6p2QRPqx/felgwvwjVp8HVZR6rZMXk2eK7EaQJtIQSE/SKEyxetpx3v+rqI Z7kyTvBIKcdqM3SqIqJSVHXuOkrmiyQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LNLgFbr8; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746439063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PKpVQKr8dLLUpoWrktCT6IWgKKoHWqB8wx1c+ST3NKI=; b=S2pGKsuBZ7oEqKo7bFVNOTeqNDuu8Lsxlkdcgqc+HeW7KrmqXSuhDQ6pgH/a5wmGQYF8+7 h6D1nole9q8bcLH1EsHVOdrZARz2dzAzb2PwTpHT/1F4Dl7W3y2lRatZlwo8qzpuqFYWPx 92TztlJYCbuWafotJcMmbXi89Z80jog= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746439063; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PKpVQKr8dLLUpoWrktCT6IWgKKoHWqB8wx1c+ST3NKI=; b=LNLgFbr8sC36w0BgPIghfEtqzj36ghx7Qy9tbIJOrps3Tx4sKGU11xlGeg0CWsxfPJHYRH DIW2LBQEvXvBotmblWD7sEUym1J6uJ9mWACrCZCEg7jldsLe8kJVJTwLHXiDEAZVgoJGVn HpkLO5YQdkIGpo2/cVYpZFMZ+C2U7F8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-45-uUK32h8PO6q7urfdElbIFg-1; Mon, 05 May 2025 05:57:41 -0400 X-MC-Unique: uUK32h8PO6q7urfdElbIFg-1 X-Mimecast-MFC-AGG-ID: uUK32h8PO6q7urfdElbIFg_1746439061 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-44059976a1fso18010075e9.1 for ; Mon, 05 May 2025 02:57:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746439060; x=1747043860; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=PKpVQKr8dLLUpoWrktCT6IWgKKoHWqB8wx1c+ST3NKI=; b=L5WSq0NNMVtrw6HLpkgBL22IHyCg0Zn3DW0sG8HchNqdTGgcRf/IAwD13wU5m3eOFk IGdSl1ZlBk6WZwfRwoIfPmNj2S62FwwHEmgS/J27YHL4hWWyc64HeJXpqdRRJ80hoOZl NucyLqbgRpZmwyBUG2mxZR4HV6mVfJ+UBCDCFgiAWVwiNS66gORqIJkFDlXJB5HvvO+v gJ5RT0zLs8EnT9YyOfkVJrIUyTG2Y5KFYM4fbx1yJ+2l7v8vcHMhrkPxvcY+68GI2Bd7 B/hVAKbvj20wl8pqMbwUkkk39nFyLsnSyIzu5dYfnGKCVJSxIDemd7FVErRHJPtI5TG2 BEww== X-Forwarded-Encrypted: i=1; AJvYcCUuHRrEsmOY6HKeWpdJMOrRJAQoE4iGQ9a80zRmONtieMCUtgzTOd+pehPEidJafwPwAzfCCrcJLA==@kvack.org X-Gm-Message-State: AOJu0YydO8aoY7G4iQaB1t0ZG2d0p2rGlu20HMJYKKxBhoQ4ein13P96 UQIt7t+A8Z70Hbr38qOk9HwyxWH7PZw/tpR+Ie7K8IvjWCsXZ71zjWs2LYHz6q30Bx7grjLYTKO vvc2bjiotV/z4IkJiUH1aTOy5+NdMN9KgVZ5T8heyNRrpWOFj X-Gm-Gg: ASbGncu2Xcm6T6a6+vJKca6WGbh5WTJwepYLr1qwWYBBlrI5RLoM2K9laIoWlrXDvT7 +SbJsunjuQNC1J4n3LkWdMYLMgFlakj1z6D+YNl5EtO01cxvzszYuZMhvOYvl/EfhbslLth0ZKW Ok+8LnpHabMdVSAEN+YGptSs5GsjDdr4PTKFQz+hE8X3UB/lDAK+TWJtQI5dioiR/Q+CUiZyTJR DciS44bZzSxrmid675l6GbtBxjTpP/uws/PFB6mymLnGRrNsfQSPFz+OZQivMpGQXeOdO9Ho+vB p1F5ff90jegOUFC/4eck3lMDqUctiDOMtCTEXHNaODBl2Lpclq82grVDVB/aFVeoq+Euv8P4xwk 3j2xWRJOj8vgMCRIPaEaAp+hqdnPJ0ZkKNc9ygfE= X-Received: by 2002:a05:600c:500d:b0:43d:ed:ad07 with SMTP id 5b1f17b1804b1-441bbf3b4b3mr97989895e9.29.1746439060708; Mon, 05 May 2025 02:57:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtIwxUjQXL2NSzan5novyjnrfpVxfypUeKQ35LMvAEv1T/4y5tjxEbs+pfQSDQVTpPSGypnw== X-Received: by 2002:a05:600c:500d:b0:43d:ed:ad07 with SMTP id 5b1f17b1804b1-441bbf3b4b3mr97989615e9.29.1746439060337; Mon, 05 May 2025 02:57:40 -0700 (PDT) Received: from ?IPV6:2003:cb:c73d:2400:3be1:a856:724c:fd29? (p200300cbc73d24003be1a856724cfd29.dip0.t-ipconnect.de. [2003:cb:c73d:2400:3be1:a856:724c:fd29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b2aed5e8sm172833335e9.16.2025.05.05.02.57.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 02:57:39 -0700 (PDT) Message-ID: Date: Mon, 5 May 2025 11:57:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v4 3/5] mm/readahead: Make space in struct file_ra_state To: Ryan Roberts , Andrew Morton , "Matthew Wilcox (Oracle)" , Alexander Viro , Christian Brauner , Jan Kara , Dave Chinner , Catalin Marinas , Will Deacon , Kalesh Singh , Zi Yan Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20250430145920.3748738-1-ryan.roberts@arm.com> <20250430145920.3748738-4-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250430145920.3748738-4-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zgyJ58Mwy45UzqCEhLqP0JbqZKcIIMTXolmlpKtyTHs_1746439061 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 89121C0004 X-Stat-Signature: u1u1b6cqsw697pad4j4fj8iqrkkfpup7 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1746439063-141545 X-HE-Meta: U2FsdGVkX19cZpLhoHIq77InpL+l5MrplNQKfsWTq3h4N6KKPVCEVOkkZrN0P5LhsTQJh6jLX+sSVeJIoGnPypy9RhjIB2VcAzEq0RZQWq6akzSdDev/q0s5/nbyLGPRzehtDKJQYlmV+JYDMEslp5NKmZMyeivyj7g2o0Ajd47eTL3b6K58otwHGpKPE+hjQ5tqg1BYjVtVFvU6w2XEulqPLG9KQqGchKwgPtxYUc7y5coUdyOXRvQTevxakBQK6EwkaWJuS0laSK9qiRpt9Kk1j1s9Kj6SWtTUL5IekJz5LspXiH2wTH7ZQhVBwiLZ/48brumRXlKiy97QaH0nUe+49oFSIrFfvtiZXg/UXLg2r615GAFuVOVceK5QzXnwQ/R/2fEEzLOK+/CmoaStped1v7Ar/OdYslIzLZI/XfZvh/PdvrDvmcTKLM7+l1wb4xGTkQRof5zwyzunHcJUT+u2MzEEdpz5Q2v7NoRKjytMV6lnC3evcHYrVXvbfhA2NLoF8KTuhFuCqC77ok6TT9WrNqEiFObDOzYGQLCc7wAsjxdKddsJWw075BvlmD0bJMoGzdo/v0g//I+otrvj+SLK2yK63G8ygXpv8dO0WHj3Eyz7wlRX6yBLfdNIxFyDBPXd/0A7ugpQ0t6dF/PR/H6b4X9O6sgqbIFM6MEYAWFYAgwrI+IJtBSs9jXsvjYkFNXvNCoT5GOzfaCGwi8z1NvweK/R6sQxtYM87S+nZsWv0gPysR0k9Ef0/v6GxzHc49yxhUcCc95Dk+JTg+YZV4NWOIkFZ9H632ErPXI0p7K0lgQxuCWW2jkIrkf+mtrHMUFijeNad0df2cf9kvkwGTt9MeSDNdEW5oDWxaxYSYX6AA5inm5RtPB8MEKvAk5rSz3x/ZmrAophaVU9g0vx2kK2pa5O2cCz9gcPJNnduzQkfZG2U0ow/OiuN7bcXLXyChNIA9pcEsklp6JYVZn R0G5/x5m +GL/DdPJppmbeP4XBgof3qwt25Gbj369o7v5+Wqp6pck0XbOrgYsIqttr+unbCQwTRjtWIGqo3mgnBncHMkPvqOMKfRU39nAKg2Bn8dYEDeBiV/1qWtuZqMCNk6ccYozXZq9Hjrw0yQagM017DztLLsmMnzLLMSdKQtvuQv3gkkkRxXnOv36pRaT3IuhZrtJBGwmYTiY9cKO6Shvy2Em1FG4dc45nJbQ7QusjO0M1iDZE9HVi1Wpw5CbzzxYSsLwdJGVypRCg1bfCm+JgoWcLetOu4e3ZBPg7JBEogT6fvcLjgnbAnDr9sGF8cAPcigL9bX5IcCdbqPHNPP/Nrplb+poCoyAZPgX1Ozoqbnwo0Mhnvm1LBSnt2whte351TJfSwIUMDa+5Kw/YzUnOqaebZHSJwk1seNx0ni7zDrp7IWo6ex29OLqpf3Im2DPUPkhdzgpQVXFwdskqrhsKKMprw3x5C2AbGNYEjKPk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.04.25 16:59, Ryan Roberts wrote: > We need to be able to store the preferred folio order associated with a > readahead request in the struct file_ra_state so that we can more > accurately increase the order across subsequent readahead requests. But > struct file_ra_state is per-struct file, so we don't really want to > increase it's size. > > mmap_miss is currently 32 bits but it is only counted up to 10 * > MMAP_LOTSAMISS, which is currently defined as 1000. So 16 bits should be > plenty. Redefine it to unsigned short, making room for order as unsigned > short in follow up commit. Makes sense and LGTM Acked-by: David Hildenbrand -- Cheers, David / dhildenb