From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE262C4828D for ; Fri, 2 Feb 2024 02:44:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 371526B0075; Thu, 1 Feb 2024 21:44:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3210D6B0078; Thu, 1 Feb 2024 21:44:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 243646B007D; Thu, 1 Feb 2024 21:44:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 17D396B0075 for ; Thu, 1 Feb 2024 21:44:51 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CB152A0EF1 for ; Fri, 2 Feb 2024 02:44:50 +0000 (UTC) X-FDA: 81745321140.09.2C5DD77 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf09.hostedemail.com (Postfix) with ESMTP id B2140140004; Fri, 2 Feb 2024 02:44:46 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf09.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706841888; a=rsa-sha256; cv=none; b=7kWUe3BPqoXSjSokY67KNAxhOhelmfY+YKZJcBPTfn46c7BgsndvFXEClTVQCx50zioFkh K+WHphCQHkd/S4iBmW+VNq0MV6mZ16dCqRTflZtpjfUgrkVW/aRvHsJZWtFOobs5qcTQmf jA6FfNVRGcqoXclCAZzTTknJZ9uvQrY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf09.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706841888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D66wxr3yWbwW3FYS1urHJJ1iuv4W6MNgpqZJKRp3+6E=; b=Dglp7wb5UhURr9EGKf/DxcfrmDaIJlKMRsZwPqjHpvConiQtAnMHs3m2M1bhNd9UmKcwJ3 LLpNIk+1i16v08+idV/q00wy9CP/l9XBrvKqvAVCMFy3Ky3VHmfolS8b4i08f+ySRtrAAI LtyONkw3f10SHYzmCAG5hEMIKte8u1E= Received: from mail.maildlp.com (unknown [172.19.88.214]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4TR0S91L6fz1Q8YQ; Fri, 2 Feb 2024 10:42:49 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id 6B3071A016C; Fri, 2 Feb 2024 10:44:41 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 2 Feb 2024 10:44:40 +0800 Message-ID: Date: Fri, 2 Feb 2024 10:44:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH rfc 2/9] mm: migrate_device: use more folio in __migrate_device_pages() Content-Language: en-US To: Matthew Wilcox CC: Andrew Morton , , Tony Luck , Naoya Horiguchi , Miaohe Lin , David Hildenbrand , Muchun Song , Benjamin LaHaise , , , References: <20240129070934.3717659-1-wangkefeng.wang@huawei.com> <20240129070934.3717659-3-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B2140140004 X-Stat-Signature: ts3kryf97gigc6qrm3jqqpfx4pgax3kw X-Rspam-User: X-HE-Tag: 1706841886-785117 X-HE-Meta: U2FsdGVkX1+49QQYJ3LvJWGlWUh6cMgoBcPgc6lEObMQXXM/FvWG+jG7hNmUeYZE57cD7vimjRKDjkBbA0ZDbGONh0WCEw9EcO8QDojqloFZz7fZcM9mlSsFPlf7SJtk6aPufWc5dIr9Qdvhwxc6xACTkqs/A4kTsmsG9U6dEL1d8SRn9gDiKaAJjGgML4znKFeffanc3/2kM6I88utzl/wLUKdWi+Kul1LOI7W5GCMcr7aVOJMhRhUdatbdPhOX3h8OpxMA509lR2NMOazA+XLb+XGdytsXTfPgMCP4B76nSNpJUkuv9cFhKTWsCdFOQ4Wftz6nSEczjFH3kT+nPLZwvwcVw8d5oRIlJl+6w7uiz2WSB506ut/GOgYM65iBZzDGA2ktRZ1GaemQYeD/dEcadML7SVGp5er4dmqhjAHBgp2brjbIrRGxohoAAnufFuCX3cLV72SFdw6pV4zC4HnYyGay3ZGqS6W8KpMQRxyNpAdBR/g6eUXatSMLsdrRRu3uzuzx7S+u1IIb3CU1xD3fCWleSdKQfoIdsugbaRDm/gMtAAk8iZ/c2Mw3y3+pVYMjEWlla79NkWoAADRb9vWTP/MLKqx/58Y39eUrjWacvmTAksI+k8BeUNLGQnriQ+9rWKQK2bwJL+b5cLsSLGUPT6uXfENXTFx1TxqB8v31OWWOHERQIXeB/gB5s3xncx5laf/gGe8LGIQoLj+Salq/qy78LEbb8EhBRwcWcVWcinGLOGB/4JQXjlF5BccD7r3wttHRxmJUwRZNJWb9zODYy1x2CtMwXS+R7GufbFljqP5ZG8hYnWTzwZ/hBPhVrWoiOwA2TNl16uLCQbyeP0J3UpL7l0q8gZB/KbxLIg3VzgyY+9ZjXoMFZXssGieqsRo3A9VzenT5w5TTIdlt+lZ1NiQwujU55t7r+YIrnQpH7sc0joLCY2NP+PES8iULg8igWp9qLyjlOPi/KhC lJETFqxf SqegVkRqoZQEaOFfnyUMruEvuQRO/kF233xfTo+mlpcAUP0MLq4X6xlTZknnflJ37ueV24idkkZLzfEMBv8a5ezydproM1gzOxgIdM3D+lO68h5JKtT8PN+S3+O0QZ4K0Ql6dk08CUdV9RRb9RSbhYJWwF2Nxk3SBjEksSC6Js/Z64J1oGevdt0p2MhdgcyrPR9QvCctrG0mXt2NKh4sUj7kKomf08/3Da0yqb2+EsNYB6uoOcC99oy7/75Rk0UX3D6GSVVTjVhXRu80kovVa6G50iw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/2 3:27, Matthew Wilcox wrote: > On Mon, Jan 29, 2024 at 03:09:27PM +0800, Kefeng Wang wrote: >> Use newfolio/folio for migrate_folio_extra()/migrate_folio() to >> save three compound_head() calls. > > I've looked at this function before and I get stuck on the question of > whether a device page truly is a folio or not. I think for the moment, > we've decided that it is, so .. > > Reviewed-by: Matthew Wilcox (Oracle) > > Although ... > >> @@ -729,13 +730,12 @@ static void __migrate_device_pages(unsigned long *src_pfns, >> } >> >> mapping = page_mapping(page); >> + folio = page_folio(page); >> + newfolio = page_folio(newpage); > > you should save one more call to compound_head() by changing the > page_mapping() to folio_mapping(). Missing this one, will update, thanks. >