From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EE2CC2BD09 for ; Tue, 9 Jul 2024 10:49:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A8C96B009C; Tue, 9 Jul 2024 06:49:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 757CE6B009D; Tue, 9 Jul 2024 06:49:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D0486B009E; Tue, 9 Jul 2024 06:49:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3DDD66B009C for ; Tue, 9 Jul 2024 06:49:54 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 923BA141801 for ; Tue, 9 Jul 2024 10:49:53 +0000 (UTC) X-FDA: 82319893866.20.6138C60 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf23.hostedemail.com (Postfix) with ESMTP id 3F551140008 for ; Tue, 9 Jul 2024 10:49:50 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=oV559RVW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VIAGM8cv; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=oV559RVW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VIAGM8cv; dmarc=none; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720522166; a=rsa-sha256; cv=none; b=HnNmMjvt/xa/oikFIYukt5kyORyhUrIBwP7FtYQgOT18ksaICyiEqAdhZf9K5Qi1n1kIbB Vqx9g6M+uGZvvQFq4W0KI9XQdmfAaOn3mL6Aykaj0rLrucbQE4pupa+cpG2L8zHNADl7tU XbEn1SNHMrAw5V8JdrSa/d7WvkJDlCE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=oV559RVW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VIAGM8cv; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=oV559RVW; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=VIAGM8cv; dmarc=none; spf=pass (imf23.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720522166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KNET36NYtbI0sQiYMIP2mAavdQmVJO4sIajw2H3DKko=; b=vOa3Ys10rTtXtj1QBHbymzQWm4JI6xJo6FY2OKsFpwi3UjdW9LNLRjmkuO32WU8B6QIIk8 KyunmNFkuCmV3kNamLve5MpLTZX+fghy8DdE2yO2xjQ2qAaeoMRNTTaILEx3BSJaDTomiv /Of6TNzpWJ540shen+s5d2LOXU4Tku8= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A3FF6219A9; Tue, 9 Jul 2024 10:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720522189; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KNET36NYtbI0sQiYMIP2mAavdQmVJO4sIajw2H3DKko=; b=oV559RVWg1N9Fk3NfBYx2Xu++jLgj3wY08ZunWYF/JJIceyR/8m0XnLOFPXmeOtUB8sa37 vzAhARSCY+5SLY4xpuBuzylV6950S/kdv8VkFGQMp6UmrhkF2wE+gQo/0jDrSWPGVHMVjQ iZ7ErkP1X8SaMbZeymxaxAlbXw0jpqM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720522189; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KNET36NYtbI0sQiYMIP2mAavdQmVJO4sIajw2H3DKko=; b=VIAGM8cvbCGYUN+Ej8+weVNuLAGAH0+nWI6TfBY1Bo1wxX9TAsbWMDpnKefWNkQK47Fttr hxs04HzV+8S+GeAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1720522189; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KNET36NYtbI0sQiYMIP2mAavdQmVJO4sIajw2H3DKko=; b=oV559RVWg1N9Fk3NfBYx2Xu++jLgj3wY08ZunWYF/JJIceyR/8m0XnLOFPXmeOtUB8sa37 vzAhARSCY+5SLY4xpuBuzylV6950S/kdv8VkFGQMp6UmrhkF2wE+gQo/0jDrSWPGVHMVjQ iZ7ErkP1X8SaMbZeymxaxAlbXw0jpqM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1720522189; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KNET36NYtbI0sQiYMIP2mAavdQmVJO4sIajw2H3DKko=; b=VIAGM8cvbCGYUN+Ej8+weVNuLAGAH0+nWI6TfBY1Bo1wxX9TAsbWMDpnKefWNkQK47Fttr hxs04HzV+8S+GeAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7AC111369A; Tue, 9 Jul 2024 10:49:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id hd+WHc0VjWatVQAAD6G6ig (envelope-from ); Tue, 09 Jul 2024 10:49:49 +0000 Message-ID: Date: Tue, 9 Jul 2024 12:49:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/7] mm: move vma_shrink(), vma_expand() to internal header Content-Language: en-US To: Lorenzo Stoakes , Andrew Morton Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Liam R . Howlett" , Matthew Wilcox , Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Kees Cook , Suren Baghdasaryan , SeongJae Park , Shuah Khan , Brendan Higgins , David Gow , Rae Moar References: <2182710009e222ee0a57ad975ed560edf965f5ee.1720121068.git.lorenzo.stoakes@oracle.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <2182710009e222ee0a57ad975ed560edf965f5ee.1720121068.git.lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3F551140008 X-Stat-Signature: aobr8wsqg35u3ajtg7sw6r7ftbtsrshn X-Rspam-User: X-HE-Tag: 1720522190-298371 X-HE-Meta: U2FsdGVkX1/P8EvCwHUdQOFWjo6/M9UW/y3Soh8AVt393biMXJe0dvVtEZxFEBvYXE4no00MNd+0uhxWc0O2zj50QB+wEMO3So43GzZ5QqJBwSPqyuXnioRUGU0aX0aHcllCsa55bH5pv+auNk8x5owKd71Rqn3Zc7dTa/uD8YEX7OjXt6f0y5RRSjYx543Sl60ph7hJ1j4D+BQW5wAIA3b09dlyNML8VqqiCpSKTW1YLQQFB5t1MVJmPh6wNCMnaOvkCdr7BSOQHWkXP1ajSwc3ZJInPOBxddblQ3kUbw8pfTwGnHmB4dzg7Giy7hyraZaE2gFljZUYwcLx7LdAsTaRiJQbmhKj5HGoDULgzGlfGlUWZFDh7hS/qmw9Vv0tMyU7LOGULgOmehChpmZKu97YbtnosxdBAGjRTwbH9DVOw+9S9rovWzPXOLfrRgx809eMwJdK0yEpZHKZPmB660/VaU0bXo9iihDM+QMc2r3WQH/gaR4Jl3nA8VBMoRZJBeScfxV9KC4sL+AYZ+r6WvmPnRNjcH+Vy6Ff3iS3ObvBxoL9SW0aYf6XJJRS0zuWkK4aU6VB1D6ubSUK/UZTAVSrDS9ej6pyWF2Hvczrx6RJqik9MoAHNEJkqwCMbH20jrDDt1SNR9G8HGIDfh/r5F4NoduvTvkjTH56DAXX0fy73YxSa1BmVObsvDo/S3CwUZZHl5eIHR5f6X2kSIkDRrNtHyyYaV8nDU3qC0MkwYq1WmY6lhyQj57vYfLmnjRp3MaDA0+hxdVwiW9sR7fZAlFXUWreDc4k9DQI6yYwzwzBaAg/5+EXt43PI5bQk8SIN/0DPSVQpfubEiZJei8sExPFNB8/Aka1It3IaIQWaeVVsn1BV/ag8Ern/UlEpKCHB9AxttKwcjGA0KeuYt/qzxwF8AMhA89hy+MTQSSEvnvoFdVnqf0oFwzjPkaAz+e4DKvWUs9zQUW14x30+Ix qHP+s7e5 nmTgxDsBb85PiMbm1zByACSrbRtyjI9FvfvvrOZU0id6sFDNb8H3jYQZAnP0Ncy3E7/L9L8EW8jSstYEemAbdbwJCHMb8jUcD66rfKXVLGRBMRNZ3BbwVO1YO0QtEK1Kic/Q1F0sh1IpkO0R0zFW9+FVGkWyk4+S0cgGjMsXn5jI7ZhjJOIXlmD/+7ZdVp1W5fVsYUuKgGT7OppDxI128Y7zpMD64WvduLIv1GUo6/vfW0xe92ciksKwyMemngL3arRr3FfcX+pRCeoE3diRzG2/t7e7opOytTFfD39uBQYm0Tdp1OZbtOXUV8blDAf+vKyAOAndiej6wLvo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/4/24 9:27 PM, Lorenzo Stoakes wrote: > The vma_shrink() and vma_expand() functions are internal VMA manipulation > functions which we ought to abstract for use outside of memory management > code. > > To achieve this, we replace shift_arg_pages() in fs/exec.c with an > invocation of a new relocate_vma_down() function implemented in mm/mmap.c, > which enables us to also move move_page_tables() and vma_iter_prev_range() > to internal.h. > > The purpose of doing this is to isolate key VMA manipulation functions in > order that we can both abstract them and later render them easily testable. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka Same nits about some "extern"s that could be removed in the process.