From: Vlastimil Babka <vbabka@suse.cz>
To: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, "Liam R . Howlett" <Liam.Howlett@oracle.com>,
Matthew Wilcox <willy@infradead.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Eric Biederman <ebiederm@xmission.com>,
Kees Cook <kees@kernel.org>,
Suren Baghdasaryan <surenb@google.com>,
SeongJae Park <sj@kernel.org>, Shuah Khan <shuah@kernel.org>,
Brendan Higgins <brendanhiggins@google.com>,
David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>
Subject: Re: [PATCH v2 3/7] mm: move vma_shrink(), vma_expand() to internal header
Date: Tue, 9 Jul 2024 12:49:49 +0200 [thread overview]
Message-ID: <c163cdb3-a950-4a61-b125-2f9086ca95ec@suse.cz> (raw)
In-Reply-To: <2182710009e222ee0a57ad975ed560edf965f5ee.1720121068.git.lorenzo.stoakes@oracle.com>
On 7/4/24 9:27 PM, Lorenzo Stoakes wrote:
> The vma_shrink() and vma_expand() functions are internal VMA manipulation
> functions which we ought to abstract for use outside of memory management
> code.
>
> To achieve this, we replace shift_arg_pages() in fs/exec.c with an
> invocation of a new relocate_vma_down() function implemented in mm/mmap.c,
> which enables us to also move move_page_tables() and vma_iter_prev_range()
> to internal.h.
>
> The purpose of doing this is to isolate key VMA manipulation functions in
> order that we can both abstract them and later render them easily testable.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Same nits about some "extern"s that could be removed in the process.
next prev parent reply other threads:[~2024-07-09 10:49 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 19:27 [PATCH v2 0/7] Make core VMA operations internal and testable Lorenzo Stoakes
2024-07-04 19:27 ` [PATCH v2 1/7] userfaultfd: move core VMA manipulation logic to mm/userfaultfd.c Lorenzo Stoakes
2024-07-09 10:40 ` Vlastimil Babka
2024-07-09 14:14 ` Lorenzo Stoakes
2024-07-09 13:07 ` Liam R. Howlett
2024-07-04 19:27 ` [PATCH v2 2/7] mm: move vma_modify() and helpers to internal header Lorenzo Stoakes
2024-07-09 10:45 ` Vlastimil Babka
2024-07-09 13:09 ` Liam R. Howlett
2024-07-04 19:27 ` [PATCH v2 3/7] mm: move vma_shrink(), vma_expand() " Lorenzo Stoakes
2024-07-09 10:49 ` Vlastimil Babka [this message]
2024-07-04 19:27 ` [PATCH v2 4/7] mm: move internal core VMA manipulation functions to own file Lorenzo Stoakes
2024-07-09 11:09 ` Vlastimil Babka
2024-07-09 13:12 ` Liam R. Howlett
2024-07-04 19:28 ` [PATCH v2 5/7] MAINTAINERS: Add entry for new VMA files Lorenzo Stoakes
2024-07-09 11:11 ` Vlastimil Babka
2024-07-09 13:13 ` Liam R. Howlett
2024-07-04 19:28 ` [PATCH v2 6/7] tools: separate out shared radix-tree components Lorenzo Stoakes
2024-07-09 11:14 ` Vlastimil Babka
2024-07-09 13:13 ` Liam R. Howlett
2024-07-04 19:28 ` [PATCH v2 7/7] tools: add skeleton code for userland testing of VMA logic Lorenzo Stoakes
2024-07-05 18:28 ` SeongJae Park
2024-07-08 13:14 ` Lorenzo Stoakes
2024-07-09 11:29 ` Vlastimil Babka
2024-07-09 13:16 ` Liam R. Howlett
2024-07-10 19:32 ` [PATCH v2 0/7] Make core VMA operations internal and testable Lorenzo Stoakes
2024-07-11 2:54 ` Andrew Morton
2024-07-11 18:00 ` Liam R. Howlett
2024-07-19 10:52 ` Lorenzo Stoakes
2024-07-19 20:49 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c163cdb3-a950-4a61-b125-2f9086ca95ec@suse.cz \
--to=vbabka@suse.cz \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=ebiederm@xmission.com \
--cc=jack@suse.cz \
--cc=kees@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=rmoar@google.com \
--cc=shuah@kernel.org \
--cc=sj@kernel.org \
--cc=surenb@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox