From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7D95C388F7 for ; Fri, 13 Nov 2020 12:15:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4F4B72085B for ; Fri, 13 Nov 2020 12:15:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F4B72085B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 839E96B00DC; Fri, 13 Nov 2020 07:15:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E8F06B00DE; Fri, 13 Nov 2020 07:15:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B06C6B00DF; Fri, 13 Nov 2020 07:15:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id 39D196B00DC for ; Fri, 13 Nov 2020 07:15:48 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D2437181AEF10 for ; Fri, 13 Nov 2020 12:15:47 +0000 (UTC) X-FDA: 77479291134.22.soap98_2d1472d2730e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id AFCF518038E67 for ; Fri, 13 Nov 2020 12:15:47 +0000 (UTC) X-HE-Tag: soap98_2d1472d2730e X-Filterd-Recvd-Size: 1930 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Fri, 13 Nov 2020 12:15:47 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id CD998ABD1; Fri, 13 Nov 2020 12:15:45 +0000 (UTC) Subject: Re: [PATCH v3 3/5] kernel/power: allow hibernation with page_poison sanity checking To: David Hildenbrand , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alexander Potapenko , Kees Cook , Michal Hocko , Mateusz Nosek , Laura Abbott , "Rafael J . Wysocki" References: <20201113104033.22907-1-vbabka@suse.cz> <20201113104033.22907-4-vbabka@suse.cz> <751f6a7b-afa3-fe8f-5df2-5a604b762d6a@redhat.com> From: Vlastimil Babka Message-ID: Date: Fri, 13 Nov 2020 13:15:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <751f6a7b-afa3-fe8f-5df2-5a604b762d6a@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/13/20 1:10 PM, David Hildenbrand wrote: >> @@ -1186,12 +1194,12 @@ void clear_free_pages(void) >> if (WARN_ON(!(free_pages_map))) >> return; >> >> - if (IS_ENABLED(CONFIG_PAGE_POISONING_ZERO) || want_init_on_free()) { >> + if (page_poisoning_enabled() || want_init_on_free()) { > > Any reason why not to use the static version here? It's a single check per resume, so not worth live-patching this place. > Reviewed-by: David Hildenbrand > >