From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBDF0C6FD1F for ; Wed, 3 Apr 2024 08:22:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CDC66B0089; Wed, 3 Apr 2024 04:22:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67E606B008A; Wed, 3 Apr 2024 04:22:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 51EEA6B008C; Wed, 3 Apr 2024 04:22:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 351816B0089 for ; Wed, 3 Apr 2024 04:22:55 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EBFAF40DE0 for ; Wed, 3 Apr 2024 08:22:54 +0000 (UTC) X-FDA: 81967529868.01.18563E8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id B594610000A for ; Wed, 3 Apr 2024 08:22:52 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DLK2owcg; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712132572; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l7u8tXW4utn0JsOOtKWveA4kDBOGZJgLUr1tavVudlg=; b=HS6TgxZ2gfK0bM+7If6G/ATzbXLtEpnaKI0s4jDO6mzWigb10/8hL7gwg0z5syJlJsvURp znYkaHv6XqRdXAV+1AAEL/lKGVpFO2s8nqjKHZbQbFVgYCBg3bfLldtmSyTSw46LMX3/m2 l0WGNhRghK36MjO9WXb6IiBcnPs8AGc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DLK2owcg; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712132572; a=rsa-sha256; cv=none; b=CAzYJzxgQnNmIBFvkweQUC18kXns2nauOuiDhDELmTCVpBz3StdT4ffZEA4FVCnK0TWH0e jroO3PQB0TnrsBIoAlDbtA6HDorb72kJWLI+X9q1TAT2DvzxBAM1c4nt+f+utD0tn6XRXq kmH1E9bKiJrKcZGrINA+Y4PfyZqLiiA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712132572; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=l7u8tXW4utn0JsOOtKWveA4kDBOGZJgLUr1tavVudlg=; b=DLK2owcg1UQMxb6JUryU7Wj+vmZxxV/qir9ejzOo9ZuF62sjKRo9SS7WZYQlkWfah13Pvl 2R9L6Ot/PBKX8pakR5BwEPYtv1KDUS9nK8u0n7sbOEJpIzDZbBuHAtaDTv6J6Zdo7xslxx gLm7S7sJSMhRdyhfcIxWRakgYx4DqHE= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-142-K7S1njwCO66AqS_YK8L1wA-1; Wed, 03 Apr 2024 04:22:49 -0400 X-MC-Unique: K7S1njwCO66AqS_YK8L1wA-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3439d4b5e54so137600f8f.1 for ; Wed, 03 Apr 2024 01:22:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712132569; x=1712737369; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l7u8tXW4utn0JsOOtKWveA4kDBOGZJgLUr1tavVudlg=; b=wkPjHnpHdJAVoPjJOmrB/nV15+kGMo1+Awp1mIJ9WHbopKHaKPKAs+r2ul6AYw/vKJ Qms9KSzjYRdanvWfQ7yDfqiC3oTEavBuSkwQNOXkdMvrSUk2zAsRYBTbr4J/nG6BJ/3n ywfdWPNcE5JsVQ5JeKV5IsGepPxiLBoUVYec4MYezrlBYT0M8ZPtht+NdSXSXT7WTAqq lEW7C08NjvO3m6umb0nrKoFx2m4gvlIRBAhXZi0eDAvkjoFgrVZkEm0uHokbpDyvJxQR bo3Aum7xLNHMsCU0jRiiLywZog4TPuv4tmJ9fyFihuQsYqk6ho9ImDZSZt9XDB1zucsT i+xw== X-Forwarded-Encrypted: i=1; AJvYcCWKJrwQZTbXFn5+snc8kV4zXECk9fPQaADT57g7CI/rcf1+5SAguLj1vL8nziYSkw57SiHLl9R05LBo1Xsepek0zmU= X-Gm-Message-State: AOJu0YwAh2plqH9xf5Hcg9ujw0OXSGU/fLI0XdwnesIC47rFUg9fz7yj 90NtMOF6mYwlEn17lfmf31G0s7bRyTt+hsuZ9AXbSdhiSAovvRJR1vtiWHUx3PZoYe6t7RftO/g 6YZIBqVMgMT3BB2NTJVX/iL9HRcJnBO0mXkaexIo4nsg2jdqu X-Received: by 2002:a5d:6ac8:0:b0:343:7ae5:5e47 with SMTP id u8-20020a5d6ac8000000b003437ae55e47mr2441532wrw.25.1712132568815; Wed, 03 Apr 2024 01:22:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9oqHBrSH7kogHuvjnNAjdKZ/SbtUdV2jBIg5wPvH8N9gwNaNKzN7Io6Ll40iwtFrMtYL98A== X-Received: by 2002:a5d:6ac8:0:b0:343:7ae5:5e47 with SMTP id u8-20020a5d6ac8000000b003437ae55e47mr2441508wrw.25.1712132568319; Wed, 03 Apr 2024 01:22:48 -0700 (PDT) Received: from ?IPV6:2003:cb:c73b:3100:2d28:e0b7:1254:b2f6? (p200300cbc73b31002d28e0b71254b2f6.dip0.t-ipconnect.de. [2003:cb:c73b:3100:2d28:e0b7:1254:b2f6]) by smtp.gmail.com with ESMTPSA id bk20-20020a0560001d9400b0033fc06f2d84sm16574606wrb.109.2024.04.03.01.22.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 01:22:47 -0700 (PDT) Message-ID: Date: Wed, 3 Apr 2024 10:22:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: add per-order mTHP alloc_success and alloc_fail counters To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: cerasuolodomenico@gmail.com, chrisl@kernel.org, kasong@tencent.com, peterx@redhat.com, ryan.roberts@arm.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, yosryahmed@google.com, yuzhao@google.com References: <20240403035502.71356-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240403035502.71356-1-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B594610000A X-Rspam-User: X-Stat-Signature: q4kewuqzqb3docu18epkja4rabyrsaxt X-Rspamd-Server: rspam01 X-HE-Tag: 1712132572-284907 X-HE-Meta: U2FsdGVkX1/a8zHpo7F6NHd7NjLPHt4UoTA+5oE5ztC9XHXBLzzyNU91ZvAFMLILoafYQO2LlP/Dc9VcbXqXeJ7MegoNwtoymMZhCBdoW0A8JY8Y8aL89j/Vo97HrbMAvymZ8O3y0hLN/+dF+4rdB8GaDmP0RPmmNzgxaRmkTtJ+WzeaaoDad1TwdcPBAp9JTEMY2T7DvJFJLSv8icfGhatkvrZTR07rgOvT8ghc+aE7cTYDUfHO489t0OB8BlJMlnqt+MyfhVONh2YORHL0EG8cfJlr/o1gxaX0Xzd5xyoAngT0cKEjWS3vDtJyklWdqPLsyvWo4ejT3KAuwUBFhjeOSUadMbG+BG2pXRmjxVZP9ATLs3nJAKvr12LCMEk/opcbw4fPpwcQMl3pchNBXc8o6g8V2be9a9H+Foz+bXYG+GuYG51RQhNjVQElGQflGvcz5DMs2AZsXrqRyv5/iHXQ0aYCrOByN4oQ/VO7uIN8p2ioh9w6pY19lJ6q62q6mg3reAJ10ZZztdIsnWgTvzBaKs1cBkY3/HksdHgoW6GDyYt+Xj4rJvHYw1pI28k6RtXdsBijBVpolZ+GruWCHgFVSQWXPQwA6Gh/pea0cSSqh5mq/OD8/a79QWGTa0k8f08+ehXUVEUcUEMIae3mf3sWjxhnFNQQu+N2I8HKHS6wSq23b5ZVnoCBqIUkZks/VEbLC/uUtNxcfhCbCrUVm8hfWoWF7YDHvieoLv+M+ZBzzPrkj/GlvemgUtW8uo5nQiK9gCF18c2Gozaj+QZwMTHA74bWacNdR+q3I5Tr/mMwUb8oLwx1TpZ+4bg46u7m8iRvWdhBjW6VRu74JHFnvbEiLQ7S2FhvCVEnkTGsodwpZN5n5XRNLLEvWaR5R/GyEr81BBfEMS4c9E1qRWfrWUVMQmhpGD/5PYYBJU3dRh90Ooo5ljDUKzznWlM55RSfEnzyEVgHhw6DnXXwS3M L/Q/vbKc EFfCx31J/Pnlqm47Sxs8/4lp3BWq0EpqPkiEUh0O++87BHQPVnr80hm33UQIpgFjBnBNkjA8yThDLudQoP60FdKtgFALWwuKiJKyixcdWsgK7rKR04p/AA8sHhgRZ2Xm1rGEw5JJm1WSGJ304DHDNWEJyBoBzcZklszHAFRZoXYqSdMuz8XcEV+2JCX6Mb3A0uMCf8y4snQc/Sch8cC2GDrFqraWk0hTKFLdiYPnSk3VF6cJwJ70R5yb3V5bvmA9+TQmeMoP5EhxKoLuciwImS9se2JajJTVYzBvYCdoUwLfEjONiT2Bu+0GYBVjPWvgr8grAI1/pU6hFuhMIhDnZroQRNRsFrYjOfxTtI2OpoBxxJSMHo2pFiHKfv/g8X//Qu2F/94exog3UK6cNn0avj/ZXs1WDO8QwdoDlrh2J9+b4UjlUnDpvejWIXQduBGEu44qWz4hN622VQJJgeOUnHjhW+p/5+OcOsIPhG6ZrSFh4W7NaH0rRH8ZauOxwZ4ej4X7nxwnqPCG+5DV0L/zk+RIOwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.04.24 05:55, Barry Song wrote: > From: Barry Song > > Profiling a system blindly with mTHP has become challenging due > to the lack of visibility into its operations. Presenting the > success rate of mTHP allocations appears to be pressing need. > > Recently, I've been experiencing significant difficulty debugging > performance improvements and regressions without these figures. > It's crucial for us to understand the true effectiveness of > mTHP in real-world scenarios, especially in systems with > fragmented memory. > > This patch sets up the framework for per-order mTHP counters, > starting with the introduction of anon_alloc_success and > anon_alloc_fail counters. Incorporating additional counters > should now be straightforward as well. > > Signed-off-by: Barry Song > --- > -v3: > * save some memory as order-0 and order-1 can't be THP, Ryan; > * rename to anon_alloc as right now we only support anon to address > David's comment; > * drop a redundant "else", Ryan > > include/linux/huge_mm.h | 18 ++++++++++++++ > mm/huge_memory.c | 54 +++++++++++++++++++++++++++++++++++++++++ > mm/memory.c | 2 ++ > 3 files changed, 74 insertions(+) > > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > index e896ca4760f6..5e9af6be9537 100644 > --- a/include/linux/huge_mm.h > +++ b/include/linux/huge_mm.h > @@ -70,6 +70,7 @@ extern struct kobj_attribute shmem_enabled_attr; > * (which is a limitation of the THP implementation). > */ > #define THP_ORDERS_ALL_ANON ((BIT(PMD_ORDER + 1) - 1) & ~(BIT(0) | BIT(1))) > +#define THP_MIN_ORDER 2 > > /* > * Mask of all large folio orders supported for file THP. > @@ -264,6 +265,23 @@ unsigned long thp_vma_allowable_orders(struct vm_area_struct *vma, > enforce_sysfs, orders); > } > > +enum thp_event_item { > + THP_ANON_ALLOC_SUCCESS, > + THP_ANON_ALLOC_FAIL, > + NR_THP_EVENT_ITEMS > +}; Maybe use a prefix that resembles matches the enum name and is "obviously" different to the ones in vm_event_item.h, like enum thp_event { THP_EVENT_ANON_ALLOC_SUCCESS, THP_EVENT_ANON_ALLOC_FAIL, __THP_EVENT_COUNT, }; -- Cheers, David / dhildenb