From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Shakeel Butt <shakeel.butt@linux.dev>,
Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Dennis Zhou" <dennis@kernel.org>, "Tejun Heo" <tj@kernel.org>,
"Christoph Lameter" <cl@linux.com>,
"Martin Liu" <liumartin@google.com>,
"David Rientjes" <rientjes@google.com>,
"Christian König" <christian.koenig@amd.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Sweet Tea Dorminy" <sweettea@google.com>,
"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
"Suren Baghdasaryan" <surenb@google.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Christian Brauner" <brauner@kernel.org>,
"Wei Yang" <richard.weiyang@gmail.com>,
"David Hildenbrand" <david@redhat.com>,
"Miaohe Lin" <linmiaohe@huawei.com>,
"Al Viro" <viro@zeniv.linux.org.uk>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, "Yu Zhao" <yuzhao@google.com>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Mateusz Guzik" <mjguzik@gmail.com>
Subject: Re: [RFC PATCH v2] mm: use per-numa-node atomics instead of percpu_counters
Date: Fri, 4 Apr 2025 12:02:05 -0400 [thread overview]
Message-ID: <c14de67b-d644-4e6a-83f4-610fbf9bc43a@efficios.com> (raw)
In-Reply-To: <55c89f03-6120-43d1-a620-46d8ca8aba4e@efficios.com>
On 2025-04-03 13:59, Mathieu Desnoyers wrote:
> On 2025-04-02 20:00, Shakeel Butt wrote:
>> On Mon, Mar 31, 2025 at 06:35:14PM -0400, Sweet Tea Dorminy wrote:
> [...]
>> I am still not buying the 'good performance' point. To me we might need
>> to go with reduced batch size of existing approach or multi level
>> approach from Mathieu (I still have to see Mateusz and Kairui's
>> proposals).
>
> Here is an initial userspace prototype of my hierarchical split counters:
>
> https://github.com/compudj/librseq/blob/percpu-counter/include/rseq/
> percpu-counter.h
> https://github.com/compudj/librseq/blob/percpu-counter/src/percpu-counter.c
>
I've updated my branches to use unsigned long counters rather than
signed. This eliminates tricky 32-bit/64-bit overflow corner-cases and
should not have significant impact in practice.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
next prev parent reply other threads:[~2025-04-04 16:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 22:35 Sweet Tea Dorminy
2025-04-01 3:26 ` Kairui Song
2025-04-03 14:31 ` Mateusz Guzik
2025-04-04 16:51 ` Kairui Song
2025-04-08 7:46 ` Mateusz Guzik
2025-04-03 0:00 ` Shakeel Butt
2025-04-03 17:59 ` Mathieu Desnoyers
2025-04-04 16:02 ` Mathieu Desnoyers [this message]
2025-04-03 16:39 ` Mateusz Guzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c14de67b-d644-4e6a-83f4-610fbf9bc43a@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=christian.koenig@amd.com \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=dennis@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=liumartin@google.com \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhiramat@kernel.org \
--cc=mjguzik@gmail.com \
--cc=richard.weiyang@gmail.com \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=rostedt@goodmis.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=sweettea-kernel@dorminy.me \
--cc=sweettea@google.com \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox