From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAA2BECAAA1 for ; Mon, 24 Oct 2022 13:32:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31AE98E0002; Mon, 24 Oct 2022 09:32:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CB3A8E0001; Mon, 24 Oct 2022 09:32:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 145888E0002; Mon, 24 Oct 2022 09:32:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 007FC8E0001 for ; Mon, 24 Oct 2022 09:32:57 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CFB3D160C1D for ; Mon, 24 Oct 2022 13:32:57 +0000 (UTC) X-FDA: 80055933594.20.3C1E68E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 75F7A2002D for ; Mon, 24 Oct 2022 13:32:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666618376; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EmWmTkMoJsoEVALl9wy+YXRPF7l0NRbRGxqJeQt3D1w=; b=RuWwGOTACLlGW8N2EhbT/nA0pn/KM63SxBfAjfA/ovKFNTy6oGCdnnlcdz/EoQ+4fdBzoo n9bPAbpKP4kNjE2nCLaufSkYb9mnBVTb3f/Kh6KMACzsxqyg1+9ro3hPFXfm1r5VRgua9+ e5Ged6qrdbROd68uVxyF8V4Y/pfjtuA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-62-U0KvPB7eO9ejZt_d1s8JFg-1; Mon, 24 Oct 2022 09:32:55 -0400 X-MC-Unique: U0KvPB7eO9ejZt_d1s8JFg-1 Received: by mail-wm1-f72.google.com with SMTP id k34-20020a05600c1ca200b003c706e17799so4148815wms.9 for ; Mon, 24 Oct 2022 06:32:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:organization:from :references:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EmWmTkMoJsoEVALl9wy+YXRPF7l0NRbRGxqJeQt3D1w=; b=AddL4cD0wE/zu1DkJw0qa0YdAyZ1m7sIAtFKlIM3h3Jlb630clsnVRFxesoTNAwUps F0aMaP/NWG+PgPVTr1hQSkfhDneaeMTJ2nMtmP6J41ueOecqILaXExKL/fdvObo3dnFG K/ndSU5/nEg+ULOL4n2Kn2Y/UNcBIGcgKsi+te7iJYtp7rLKpKtBigHCYjP02zH8tG8v p1+EhYRZU2H0o/aNoqLQyXP1fxd8eTi3qnMS9NVvPuDpY/DCmYkGRT2ID9xqN4H52kuH uRQUF46hRljtsvfMyBAlzmGkZWm1nECMw3VpqdsyuinLM+f6eHhTayDFkAhoCSvJ6VKJ xiJg== X-Gm-Message-State: ACrzQf1C/k42R6RsfiR34aL7+b4rA5/SM3UwqcHdHElnmcsn8fTFvGwn ONAyZpzlKBFY5SKPlhd/blrgkRDo7kFCd2JR5qw4tQw7+rdrPQ9RVXcSv9Lo/Pa+oy87cCrAb25 eO7PyV1lMMgM= X-Received: by 2002:a05:600c:a05:b0:3b9:cecc:9846 with SMTP id z5-20020a05600c0a0500b003b9cecc9846mr42424847wmp.3.1666618374111; Mon, 24 Oct 2022 06:32:54 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6cL1e1sL/077dBTDCluX2MmyW8nmK9GM4RgH8uNgnfIETcBEk9GgLo7C6+FEvUqbj6uWuw5A== X-Received: by 2002:a05:600c:a05:b0:3b9:cecc:9846 with SMTP id z5-20020a05600c0a0500b003b9cecc9846mr42424822wmp.3.1666618373813; Mon, 24 Oct 2022 06:32:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:f100:6371:a05b:e038:ac2c? (p200300cbc704f1006371a05be038ac2c.dip0.t-ipconnect.de. [2003:cb:c704:f100:6371:a05b:e038:ac2c]) by smtp.gmail.com with ESMTPSA id d4-20020a05600c3ac400b003c64c186206sm10958540wms.16.2022.10.24.06.32.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Oct 2022 06:32:53 -0700 (PDT) Message-ID: Date: Mon, 24 Oct 2022 15:32:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Hugh Dickins , Vlastimil Babka , Peter Xu , Andrea Arcangeli , "Matthew Wilcox (Oracle)" , Jason Gunthorpe , John Hubbard References: <20221021101141.84170-1-david@redhat.com> <20221021125724.0bc29fdad1c696b8fe92f7f9@linux-foundation.org> From: David Hildenbrand Organization: Red Hat Subject: Re: [PATCH v2 0/9] mm/ksm: break_ksm() cleanups and fixes In-Reply-To: <20221021125724.0bc29fdad1c696b8fe92f7f9@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RuWwGOTA; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1666618377; a=rsa-sha256; cv=none; b=GNTFUYSLaW7RVXoxHfTxQg+BjyP+Q3E3y/4qTA1oxxAntcHUCNEa9SFhRfa5Mv7ZOTucvS YVuQTXVQytkaDhK6i4+GBrw6KFk5xqNC3UKLhslxn1ThkcchNui1CWLWIars64mvxfkSWz La6MSKNRztaR+PQ7G5T34PllfJ53d4k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1666618377; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EmWmTkMoJsoEVALl9wy+YXRPF7l0NRbRGxqJeQt3D1w=; b=IXztYv0HjdFu+ZONUUo8rQ/M6F74YPBwVJuTurkiDzRK0Hm6SnQ/R0cndAyjz6R1czunFo TzdlV1OlxkzM66qbcTkMgCfeMQC+BTgnaXnNmY6Tquy9rafwvZNMl5L0zQe3Xejifw3SqX ySaTNPuKH+X50/BDJB6FxiQz2r3oPSs= X-Rspamd-Queue-Id: 75F7A2002D Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=RuWwGOTA; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam09 X-Stat-Signature: z8w6iawyp44nzjgc46xw8ortz5u4r7om X-HE-Tag: 1666618377-360343 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 21.10.22 21:57, Andrew Morton wrote: > On Fri, 21 Oct 2022 12:11:32 +0200 David Hildenbrand wrote: > >> This series cleans up and fixes break_ksm(). > > Quite a lot of fixups were needed merging this. I guess you couldn't > develop against mm-unstable because the v1 series was already in there. Nowadays, I tend to send against mm-stable (I remember that was the suggestion). Usually it works because there are no conflicts -- this time there are probably quite some kvm unit test conflicts. Feel free to ask me next time to rebase on XYZ so I can make you life easier ;) > > For this reason I'll henceforth be more inclined to drop serieses when > I know a full resend is coming out. Yes, good idea. While the fixup-patch process works for small adjustments, it's not a good fit for bigger changes, especially once involving new patches. > > So please do let me know when a full resend is coming out. Will do; I kind-of did that [1] but I should have been more clear ("Please drop the current series, I'll send a new version."). > Or, of > course, send little fixes against the current version. I prefer a full resend when there are bigger changes that involve modifications to multiple patches ... which also makes life easier for reviewers. [1] https://lore.kernel.org/all/87104912-6615-4917-eae1-6ae0a80677e1@redhat.com/T/#u -- Thanks, David / dhildenb