From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18457CD128A for ; Sun, 7 Apr 2024 08:59:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 836806B0085; Sun, 7 Apr 2024 04:59:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E6BA6B0087; Sun, 7 Apr 2024 04:59:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D3526B0088; Sun, 7 Apr 2024 04:59:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4F9C76B0085 for ; Sun, 7 Apr 2024 04:59:04 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AE0968062F for ; Sun, 7 Apr 2024 08:59:03 +0000 (UTC) X-FDA: 81982136166.07.D697888 Received: from mail-40131.protonmail.ch (mail-40131.protonmail.ch [185.70.40.131]) by imf10.hostedemail.com (Postfix) with ESMTP id D7145C0006 for ; Sun, 7 Apr 2024 08:59:01 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=proton.me header.s=pqs54sg6ifhbtj7unmv7pp4qau.protonmail header.b=W4KM894T; dmarc=pass (policy=quarantine) header.from=proton.me; spf=pass (imf10.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.131 as permitted sender) smtp.mailfrom=benno.lossin@proton.me ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712480342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=APMjPK8g5pOGPv0dwlk1KSseSXNGp/4m07t8x/ixSo0=; b=A37wfEH8Y//3edNhmPpPdRzUitIfgpq05TPo+jUCjbEuUnpHowvuGIYSWmromMWRht0Qyr szop9sBy+Cyt9FEC7EN2xgk6OAU6rr83gZtQWFVJ3VDJF/v5BWghoXx5JrMJ4lap9lJpPP 7Y/iVjiZhuuf2XjRGUPPkhwciPVpiM8= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=proton.me header.s=pqs54sg6ifhbtj7unmv7pp4qau.protonmail header.b=W4KM894T; dmarc=pass (policy=quarantine) header.from=proton.me; spf=pass (imf10.hostedemail.com: domain of benno.lossin@proton.me designates 185.70.40.131 as permitted sender) smtp.mailfrom=benno.lossin@proton.me ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712480342; a=rsa-sha256; cv=none; b=oltoUIpZfo3nmRqEWiJ85fSgzVURSVTHMANxjRZWc6XObLWXEqAUGpGnX2ux4N3AzrakXa K0sAW6HIiGUXa2RJwwolIsR4gvZM06Tkd+kPcDI7A9L1Bg4rGpcNnoN1uJ+oa9haCfHwAu KHOs5rgtvv7eLiKT98HXKk06l2TBX3Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=pqs54sg6ifhbtj7unmv7pp4qau.protonmail; t=1712480338; x=1712739538; bh=APMjPK8g5pOGPv0dwlk1KSseSXNGp/4m07t8x/ixSo0=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=W4KM894T30Nvu/5Jg8f5a0pedkYEE9Ylz9e18LTSxXUYXznis8BometXs7Yrf7al6 SU7+lWst6jQZdOOyRDFBM4ps0WD/pkIt0cuSbgU/hFttyxhj/p200c9O7D+XSdfb2S uBHSq2l8JFwrOVb0vV5qUJJBwELvvFxrP+TIly1xKnw+TtGeonf4Nbe6+WS5Hbxw+K yUf4ubNEklQZ6OhSeku5G9NqwLaSOlliVdOFsQfQ9jMqApNkCEYE6SaYH1ys5XNRdZ QWtDcR6Vmwyy/qSS+nnNS6xXzmjxAq4y124thVRZB8Agf5UZkjV6GOdNCMWsht4a4D caZhhArNRMktA== Date: Sun, 07 Apr 2024 08:58:50 +0000 To: Alice Ryhl From: Benno Lossin Cc: Miguel Ojeda , Matthew Wilcox , Al Viro , Andrew Morton , Kees Cook , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Greg Kroah-Hartman , =?utf-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Subject: Re: [PATCH v4 4/4] rust: add abstraction for `struct page` Message-ID: In-Reply-To: References: <20240404-alice-mm-v4-0-49a84242cf02@google.com> <20240404-alice-mm-v4-4-49a84242cf02@google.com> Feedback-ID: 71780778:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: D7145C0006 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7yuf9147gowecumc6rjk4b83bktn8tau X-HE-Tag: 1712480341-199302 X-HE-Meta: U2FsdGVkX189FGZz3y7ZWbAiLRBnDw3zaE7rhAOfqd2EJiR3abIFaGqjcH3W8lfunYJXlZWr6OXSoWPQOVoAjQf1+ONpu7PTabO5pgQoL35r2SvkTFbHae1BIwN6WxwJW4hAWYsz0rjnZZDPyPsDTGZ17fOAEDSBkoaJSzolQIK8DcFKje5s7es9SKzLnEDVm5tUKk6LZAYP77KwqP2hY1ef2oBP05VVjhPbCr1+LAJlZG6qVG9r6FpCcuEHZilSZLMkTwRvw+aQ1Ap9QXLeNwmDG0j8NfDzLGUKqwR1SEXwHCQ2OX1yTkjsgs1yRK/UnDHg/rNH7i5kMVv26PHZA7vv4rdWjwUD/Abx1LcBbUZyVg2EYFm9iwUMo17ZVOVE/bckcykSwwNDerv6oxP7Tm9DMUYOSs5ds0WVOby4eM00UiFP9/4TqGHljx4Lo5XkGDl09bhcHKUADZarLaU089U5VRaBGGR2ChRb/faPmlxUaSqAcqxj7Iv29GPN+f5BamdAxj4GqMC3V8TCavxJ3mRZMuta0K5f99N/Mp+yj6z9kIPY1X1+iCECK4bsl5F7tkcek3qOWDVDBCTPfhFLh6ZDZSvXyxYEdr3cr/XUjej4tyx+NX9rW8R09hs5vk9h2LGbW48MS4ovVYh86v0RmIxi0odHDhhsSXfnm3SpmZxDHXbmsVidA5jfuUKpBYWmCJTBLvWryQgYAsk9Ims7cm1WUZOKavqpfIfJWeq98vFVGW+/LA4ICf7ZD5Yxu5wot6+/Vv0schlWabNDUYdEdHi7nE/wIr51iqG9wWHIwgfQEt9Nm+bSDxSnljdWlVYarQa+VwIqtV5OMfYQo9A9///VWBgcZugckQA9F5AftzvQM1vBBVXXodZK5zEmHCaBXQ59n2aSa1u5lVOtE/GINh8vUkFMj9nYYi8nwcX+fTBO2OkWmLFGnRmQDuY3yQyBOqtnqw0hF3MGM2EaXuk s8iuPVjp t4WEjOqF2YuxNRov43Wtoax9bVAhE/1F4gH1dsmIIHerhJSg46UYEfq+C8FeWkdyLLpMgRz0NIbkvRTqtbx348fu0RO5iOlDArHphLOSXmkmLIpv/edJ+tpnFQZIi/7SUgH36wM/P8/RHTTRsRyvgjeAazRazKVpcYKIaFSowGO+QbmcKmge1jCoXPCXEpkoiAjgU0AKWHcFwclPnuUkA+6ma3Drldy5gY4YdSRPNHy0r6O2yCjf/LSSh+DnQIYyOLkc+3puFIu3QQXxMMLMZGH5VYLh8oKsAxwzRo+7Lf75Q31Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.04.24 09:44, Alice Ryhl wrote: > On Fri, Apr 5, 2024 at 12:33=E2=80=AFAM Benno Lossin wrote: >> >> On 04.04.24 14:31, Alice Ryhl wrote: >>> +/// A bitwise shift for the page size. >>> +#[allow(clippy::unnecessary_cast)] >> >> Why can't you remove the cast? >=20 > Bindgen could decide to use a different type in the future or on > different platforms. Did that already happen? I think that we might want to know if the type changes, since then the value might change? --=20 Cheers, Benno