From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D8B6C77B73 for ; Fri, 5 May 2023 01:09:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2AEB6B0075; Thu, 4 May 2023 21:09:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BDBB06B0078; Thu, 4 May 2023 21:09:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7C9F6B007B; Thu, 4 May 2023 21:09:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by kanga.kvack.org (Postfix) with ESMTP id 5E8376B0075 for ; Thu, 4 May 2023 21:09:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683248985; x=1714784985; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=0zQ9lO7tIQvJHktD+lIBOSH2NnSlWAgh/+i+hqKVKCg=; b=S9QXVwSowBX9BZ8j15+ze5uEyQfv+UAyUhaAXh7ieLmnIa5UHlUBtnbe gQnG+bmWpC2UVhUjBBCreCiJX2jYrMoEpqgmcwNt3fjLwAlTWlKjgov0A O7z8X2eXV/oDp3no90zg6MnILX/7bGHO+P7Hv6ZeF2vv3HhP4mCm9XvIL dqooyQ5uTes9GzAjFp1M8Yrs1N2pDNkPIczZXisJFd0Cs9fpg+2d4W9vg Qd/JheAHo9dloJSFGrbV4gbW/iK25zmkD/k/W7A6Vut9ZLjNNNWu14xgL DFoXeiYPqEx1GabA2lBcJ4M3ZptT63tuGKwJLFqigF5DazqNlZTWsxvza w==; X-IronPort-AV: E=McAfee;i="6600,9927,10700"; a="414626254" X-IronPort-AV: E=Sophos;i="5.99,250,1677571200"; d="scan'208";a="414626254" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 May 2023 18:09:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10700"; a="674799919" X-IronPort-AV: E=Sophos;i="5.99,250,1677571200"; d="scan'208";a="674799919" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga006.jf.intel.com with ESMTP; 04 May 2023 18:09:44 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 4 May 2023 18:09:44 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 4 May 2023 18:09:43 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 4 May 2023 18:09:43 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 4 May 2023 18:09:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T8ppYSLWFoVGDbdt7TqO2okn7oalUnHuU4PqhGFzfngjOsOQuaSPYEX15a05IEJJRN9LsYeI4n6AxFZCmwc5Q+DjUWjme1RaoTaX9EKYGyktKHdyMK6xtnK1WljoT7U/8e6Y0zZawGOt6dpmOd0sSWw/5r6sqsCEOWlOp/zgbJzHdZ0mNP7ECg33INX0ljaarSzxE+QJQIkeR2KMWt59tqQjSeuOwFef7Qf4EMv2Af5HW6c69vEWYH4PF+w4+iqxwPvxRRacvafY0VnVGgutFiqkSOzGIMUO9rwaLf3ICssMu86egZNBzkUiVp9tdn9V36XqW2Z1JwiOXeg/kBucpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a4sy1PLnJ+M9JzkkcoSRkJtXkH/K2I5GOZC0JCuqsus=; b=l2UhS5KwsN6OgNsd3R94o2Y/wXAVOcKhEVmjI2bAUx7Mo4D+FQHNs6iBGmKb//HnnfDKzBKYzDDATULDdrjUykV4mXYPQtMwG8XpwnpIiGlMJjKjrgHvLHkHKiksTu13HERRfa+UUnqxGQgIK/NslLuZlBxVTrEvRpJ9mJBTx5OJ+dlAM8fYpM/XlpHkHgd4QWb2huTcbpl60X/NNvL1gO+J4Z4FMC8NboIefGVuUA2eQNLq25JWvJR0oddAKlgUPvGYu4v+FosTPGA2F9zrq8USvKexzv8j4E8gVT+cbV3KecIxmres3lUnBWKIX17NLiNZGbfYotOVE9eMG9ZGhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by PH8PR11MB6928.namprd11.prod.outlook.com (2603:10b6:510:224::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.22; Fri, 5 May 2023 01:09:41 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::d1a0:743b:4659:b72]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::d1a0:743b:4659:b72%7]) with mapi id 15.20.6363.027; Fri, 5 May 2023 01:09:40 +0000 Message-ID: Date: Fri, 5 May 2023 09:09:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.10.1 Subject: Re: [PATCH v3 1/2] THP: avoid lock when check whether THP is in deferred list To: CC: , , , , , References: <20230429082759.1600796-1-fengwei.yin@intel.com> <20230429082759.1600796-2-fengwei.yin@intel.com> <20230504114827.tkvvlmpo33p2jpc4@box.shutemov.name> Content-Language: en-US From: "Yin, Fengwei" In-Reply-To: <20230504114827.tkvvlmpo33p2jpc4@box.shutemov.name> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR02CA0029.apcprd02.prod.outlook.com (2603:1096:3:18::17) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4820:EE_|PH8PR11MB6928:EE_ X-MS-Office365-Filtering-Correlation-Id: 5975a00e-799d-487d-37f3-08db4d0565e2 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: udqnpXUFoPIUqwdSGLZ9wt0SVa5Xpte3GcqOFfSQUekdnFw5I1F8QP+ZC8x2LIXyFt00a2C7dRCT/Tsntn3CXzLM8J7qH0DBq6D5+jlbC9Szc9dwZ8ZEqUY7oPEhUWzCDhFTly9I70EiqjjSIRaVjvH+xVF2fi3DoxBRcuoXPVqIInU3w6NYCZZkGXtFSA7W3aqR/U5WHxGdIpVOyWoxhlvm/CFiKOyZnSIRtEk+CXRkiEdSeQG7Da2Qzy0PgAEOUo649CB8hKB+evVK3c1zqg4+e/fOiETqGMERA7LRs7dRU4hxXHATrd5GTF1VSdgW0msQg6OXs0Yyr0ErL7SW1GSRpLB6s/FaHQhIMfF5w3yfW7BSLG3N2h2nspatkLhPCTizPtn5eh2yiuvnTOS7LOjkdINAeXSFzmX3JOeKEAWVFUOyjYQulqS7m8j3qzy3y1FPdYbXjTm/fXWmC1G2vpx6cGrmgpSY+ZWZHpQduMoK+o6AXcXP28bDzQVrDmDfO9baW1AveAidZ1BqQfRixsbTZiJoGb3IIPRGcEryfls9kz2hYLUOuhaJ66k/k0YlDwCG2cqGPqYZUfOvc/UC+f+URMt+gLwhlJQh9IWYa6Onv/49rNeeSEMfzkzg3UJAJ8w78ytKtlXRrM1q+lflBQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(376002)(136003)(366004)(346002)(396003)(451199021)(5660300002)(8936002)(6486002)(6916009)(6666004)(36756003)(31696002)(86362001)(316002)(66556008)(41300700001)(66476007)(4326008)(66946007)(82960400001)(8676002)(478600001)(38100700002)(31686004)(2906002)(53546011)(6512007)(2616005)(6506007)(26005)(83380400001)(107886003)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUN3U0UvOUYxajl2TFMyODN5R3MwMWtPbllDNWUwWjJZOUQ2eW56K2tORWxW?= =?utf-8?B?dkxpalBURlFQK3l0NVN1ek1zdUFobndzeFg5NTNHMWNlcHZMS2NGRytQejk2?= =?utf-8?B?MWw0NExKOEgwa3JrQTI4UWZ2d0JZdmMyanAwaitmaGRNNFdqQWxwVmZwMHFm?= =?utf-8?B?aU1RWVZ6TWZMWnM4ZUd5c2crMGlFUWFxL09GVktqYStMUi9TODNNWk5qZ2JJ?= =?utf-8?B?NXhRcXc1YzJDekc0RThQbXJvendhZlZpa2s5TkxPWGpyUW1XcE84NnJQaFpI?= =?utf-8?B?NVk1ZUNmY2loYWRMV3FadXVwcWE5SlVJSHVOSlFYM2Y4YnQybHpScUZwMWxl?= =?utf-8?B?SDBEOGhjYWhieS9IbVNBTTlpaElUVkx4eEpJWGRldFRZRGlLeldmbHVidVZL?= =?utf-8?B?SW8zQjNUazYwcG1GNEdjNjJaZGhlY0xDaS9IdWk5aWpxZWFoMTVyNzFMQlIw?= =?utf-8?B?NWoyUnhUendMUThkSFJYcFNrYmpNTWRCWTBzL0FMenMyT1NRNDhZbDN5anVU?= =?utf-8?B?OGlpLzkvTWFzM3lyd1I5WFhNdHRLaXh2Z3pLeWVrVUxISGIrc3pHaElNZzlJ?= =?utf-8?B?TGwvaHRQR0lmSDUvZ2o2YVVWMUZGc3hybC8xcUxlenEyVjk4RmExQ3hQSUZ1?= =?utf-8?B?dVZJTUhIdmpvR0IyYldhcWo2aW5CU3ZzL2dJUWVNZUVrY1Y2RWJLaldXWnJs?= =?utf-8?B?WTlDV05sc1c0UExtS1oyd0JCbDIvc054NTBldFJzNFhhVkNESktMNlJUVXJt?= =?utf-8?B?aFVRa2lsS0JBcFlDT005QkdCQlRWY3B0bmFZd255NTVoU3o1bGZCYXRGSm4y?= =?utf-8?B?VXBCTnV6Zy82WU1VUmwxcjBqdzhZa2pGdGs5blFLTTUrdStrVVFiTDkrNlN4?= =?utf-8?B?bHZGbzh1VVo2RWdnalU0emZSM29LTHk1cnJVRExKY0ZEcFhhK0RscmdqYVJo?= =?utf-8?B?SEczZzhJbWxWR0xSL2l1SS9wekVaR3BKcERFeU83NGVYb01zSHVaVXovZkJl?= =?utf-8?B?dFZqZVJyRnFScTNMSG5laFdjcjlwSE1GakI2REZMa2czRTdSc05nNURxa3RQ?= =?utf-8?B?S1JTSkhqM1ZKUzJEZ1dicHdJdm5BbHBKV3czUEdkaGk5WVQ3UVpON3hobzI5?= =?utf-8?B?T1lGSXVVMUlNMjgydUJwdE9IeDBQWEZITHBjZE5BakF1akljZTI0dXFBYjdn?= =?utf-8?B?cXg3SDF5RWdmaDdNWFNScWJxL3pZSTh2QjdJSzJUK3dPL3NsaWxjaE80SzR3?= =?utf-8?B?NDhtblRGRWdZSG1QZStuR1VtaEh2TVdiQjhUN1dGMkFMSVJIdUJOSDlHU3h6?= =?utf-8?B?ektYUEJqVkFOQTRwQStMNGluUkx3ZWVhdm5HVS94WDdSZFlQRzRCeHk5N016?= =?utf-8?B?aVp3WnVhRXhnSTRQdGNBUEx5SUdEZURhZE1OSW1ybFZKN0xtUitLeE1zT3Rt?= =?utf-8?B?TytqUzl2WTBnQ1dNaEllL1JrUDRuS0RzM2s3U1pIbUJTdXhMTGE3RTRFV1pY?= =?utf-8?B?Y0dqMUk2Lzk5L21KTkNnb0lYcEE4VzYxWHhvTkdxcytoVFdmRWlhN0x5ajhj?= =?utf-8?B?dnhSNmR6ODFGdmVuL1VNY0RSeTZpSzBxSTcrdkdLT211YmJ1cVlCQXM2bnpI?= =?utf-8?B?NTdrTFMrWWtKQ3p4OWN2SnI2SG1qUGFwNDJldllmQTNYenlHZzltYkNFSVA1?= =?utf-8?B?U3RCQVlXQnZ6MDl3VEE1bk14Nkc0MDgxd0VnRGhQM3lydmpldlh6akFFVjB3?= =?utf-8?B?ZWFGU3cxYVBsWHZTc3JFS3NBaFNPcUY1bTNVOXFicXYrZWl6cllOdUFEMWlu?= =?utf-8?B?WlFUekdTYW45OHp3QW9CZkl4T1FsekRqa2pOZkR0akR3ZjZraTJhOHlmMUxE?= =?utf-8?B?V3NFOE5ieUYzYithMkc1d2lOZk9lc05kRmFYdGVseFprR0dlc0dIY3JzVWo0?= =?utf-8?B?WXg5Tkl3LzJ0b1BqWW5iSEs4QTQreGNPYjMzY1h1ejhKNE4vTHVDZ0dNcm9C?= =?utf-8?B?cldab2RkcnduQzlOTFQwNXI5NG5lNUQycUxPaFI2UnNmWFV2emprQnZyNzQ4?= =?utf-8?B?VmxoY2h4T3FhM2JRZUNkcUJ2MFZ6RERXMnNhR0NKWjJlOVRtME1Ray9wV0do?= =?utf-8?Q?RTgrw82QWBHvInyRKDjuXQIkp?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5975a00e-799d-487d-37f3-08db4d0565e2 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 01:09:39.9205 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b1OjO7uhwLgiYDFJPT21zh3SiIOMhciDxTt++YCCORr8IzXLg23pwjsYnu9vwKfWGYjbV2gkKyNBH1QBXiXXAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6928 X-OriginatorOrg: intel.com X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kirill, On 5/4/2023 7:48 PM, kirill@shutemov.name wrote: > On Sat, Apr 29, 2023 at 04:27:58PM +0800, Yin Fengwei wrote: >> free_transhuge_page() acquires split queue lock then check >> whether the THP was added to deferred list or not. It brings >> high deferred queue lock contention. >> >> It's safe to check whether the THP is in deferred list or not >> without holding the deferred queue lock in free_transhuge_page() >> because when code hit free_transhuge_page(), there is no one >> tries to add the folio to _deferred_list. >> >> Running page_fault1 of will-it-scale + order 2 folio for anonymous >> mapping with 96 processes on an Ice Lake 48C/96T test box, we could >> see the 61% split_queue_lock contention: >> - 63.02% 0.01% page_fault1_pro [kernel.kallsyms] [k] free_transhuge_page >> - 63.01% free_transhuge_page >> + 62.91% _raw_spin_lock_irqsave >> >> With this patch applied, the split_queue_lock contention is less >> than 1%. >> >> Signed-off-by: Yin Fengwei > > Acked-by: Kirill A. Shutemov Thanks a lot for the reviewing. Regards Yin, Fengwei >