From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA1DCC47DDB for ; Mon, 29 Jan 2024 10:07:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3697F6B0095; Mon, 29 Jan 2024 05:07:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 31A056B0096; Mon, 29 Jan 2024 05:07:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 192B06B0098; Mon, 29 Jan 2024 05:07:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 081246B0095 for ; Mon, 29 Jan 2024 05:07:05 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 95DE3140693 for ; Mon, 29 Jan 2024 10:07:04 +0000 (UTC) X-FDA: 81731920368.13.FF0069C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 53CD11A0011 for ; Mon, 29 Jan 2024 10:07:02 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=E4CRvIwz; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706522822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TJ+kpLO8S2nJ/FNOmYT0qOoCSDg7N4DFgt/5cBfrEsI=; b=LQxFVqpH8ACS7Ygx8yQ0H00kG+qEYq/uP5+VEYEAIK2VPUDV0TeMLKfmtZVUSNNwAAsec1 cPzFTQHZvf1fx6Ts27LsPrFiP2u7Xl9JqnKvE6UbaQPlRmyBjTQWYQDrNrOccHZ+3kyHgR jEDd4i9XOGyXLgTIAyi6eVx2UJ9TCdc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706522822; a=rsa-sha256; cv=none; b=hC1Yu6a6boa2kRUPW+US5JZRDYEUJSn3K403OT0j0rQW05uqVmQWC1XHWG6qpKJ8tBRoKd bWU+sMU5jr15Z90tfV4lJU7DSyXAtRKpuTiDb6FZxbNjnBqcA3gdZxMp+9u1xwLpdT1cIl lMr11jZOIGJcQZGb7IeGu6E1Z2Fs6f8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=E4CRvIwz; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706522821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TJ+kpLO8S2nJ/FNOmYT0qOoCSDg7N4DFgt/5cBfrEsI=; b=E4CRvIwzhCKprdRSzhembotTd4uZlauxVVhLI5JgqXn6eXFSCnodILQqotVbrWovBu9+cZ BncuwIEac1WHZa5YxEWZq1fp3RppEPSNegvsRgXsNKFMq+nMN0m0X3s9zYAGYZ/fack98c qzXyikGftfVM/2o0BvQXgMJHr1mTlgg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-wmEvXzf0OwSzTHlhRJBcIQ-1; Mon, 29 Jan 2024 05:06:59 -0500 X-MC-Unique: wmEvXzf0OwSzTHlhRJBcIQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40d62d3ae0cso22283415e9.2 for ; Mon, 29 Jan 2024 02:06:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706522818; x=1707127618; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TJ+kpLO8S2nJ/FNOmYT0qOoCSDg7N4DFgt/5cBfrEsI=; b=HT/iHg2PYdLX8EMjNSdYOt7ACDVQ6HI4IPZ+lsmaZWEKmvSkdjrT0/cBmkSN3T/Oi7 O3yBry3CtTAqFbzEjvBrIXqJVZIGqMUu0VI7rQbRufRK7B+jPNcuA5a5ihO/LgTwl1m9 LtlLF9RXMVNg8UkXzyjNJ8VXT0bRjf3iJkuPUtqyRBOIC8xkxFPhevLTKhwC0crE1oV1 G2UWA+4YDzSBRtqzoRvPcHFzcypkY/cw8nSYQzQynrviA0pGA/c/akQte8mJKqUNJ8cp 4zzOe+M4/mAcJi+dCVVtBJiJWFfNQxz841r3Qm5Q0aJ4E/ITBvAtnqoAc5ha80eMwWFH ExOg== X-Gm-Message-State: AOJu0YxxrECWuxHgIfCrcws+pbZsVKqhop7b46g8i/y9rgPr5zwNyvG0 owHRzth/SYn0+YzcT2S2erloGiuCod4vIDSqf8JF198L0ogN3BX2VLfXJS4fegaG165HR/UndbO SI4TTxVqiS3iE4XC+qLQEGDLwyhDd5R9FxDSo1IEw6GEo+Tfp X-Received: by 2002:a05:600c:3b28:b0:40d:92c4:c2da with SMTP id m40-20020a05600c3b2800b0040d92c4c2damr4130074wms.31.1706522818642; Mon, 29 Jan 2024 02:06:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IH+1pe4fgzt0UKvDoFCiJ1bx3S/bnNig5L+BMeoboh/4aautE6eZ1WeKq1IVcZ790bv9NoWbA== X-Received: by 2002:a05:600c:3b28:b0:40d:92c4:c2da with SMTP id m40-20020a05600c3b2800b0040d92c4c2damr4130056wms.31.1706522818269; Mon, 29 Jan 2024 02:06:58 -0800 (PST) Received: from ?IPV6:2003:cb:c721:aa00:3221:f685:1200:6d03? (p200300cbc721aa003221f68512006d03.dip0.t-ipconnect.de. [2003:cb:c721:aa00:3221:f685:1200:6d03]) by smtp.gmail.com with ESMTPSA id je16-20020a05600c1f9000b0040ec66021a7sm9738537wmb.1.2024.01.29.02.06.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 02:06:57 -0800 (PST) Message-ID: Date: Mon, 29 Jan 2024 11:06:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 5/6] mm: rmap: weaken the WARN_ON in __folio_add_anon_rmap() To: Chris Li , Barry Song <21cnbao@gmail.com> Cc: ryan.roberts@arm.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mhocko@suse.com, shy828301@gmail.com, wangkefeng.wang@huawei.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yuzhao@google.com, surenb@google.com, steven.price@arm.com, Barry Song , Chuanhua Han References: <20231025144546.577640-1-ryan.roberts@arm.com> <20240118111036.72641-1-21cnbao@gmail.com> <20240118111036.72641-6-21cnbao@gmail.com> <58efd8d4-28aa-45d6-b384-7463568b24bb@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 53CD11A0011 X-Rspam-User: X-Stat-Signature: 6ztskudhj4idkckcpp4444it5ckr71dg X-Rspamd-Server: rspam03 X-HE-Tag: 1706522822-641116 X-HE-Meta: U2FsdGVkX1/AUSXd6NIAl88SNDLTci++rJtmwTfzBH1hbMcw696RYUeqa0aaRRQymIZX3NSVYJfk/e6FqRQSvx2I0kjzaZ6OgfohyVTlfznkGRjzqQDBF6pE6awNFT78UGZ2gJ601rlH0L3KRxobxwPv62YdSs/CxmiHEjGNrQJL0Wz+FhRmX8xNOrPJ8va/uC4nNxB91YcCnR/njxnckatcTStRmjQtBAiYhzbYWR7F/eCYm2D9ZvU0/iSgwan8NzpKnZ7SAV6Pxg81hqLh4Wty29N1cQc2Plg4I2RfPcAy71Z3ZccWQMg8ZYiLbXCYpQh6JG5gnJgvkZaTk9I0kiGlJQdlIBqyOydUwuvCc1+vBtNXFa/jcgDGmWC5/QxqK8MG2mpDv3Z91NhXWK22UWNWWYTt1dsglYkAR+xL+NHRAoqu3ldvTI3ATDCyF3tAYFl2lPnR9ecYYowvIPnx+7QILIG9LNMveuQg/jszTJxBbxD/6GKOd9Jt8wS7sYSZevkVDtesPXRoFYCvxK3z5a3+gH7weiICzEbIcYvs/YcLwEBGSPvU4TFvDeymU9WgvO6g2NrkuFemKYG12B4JbT/8oHomu6Ob/FQ9AzspO9KcosCUgaHY0bcPM5uqh+PwoH9+HVnaIAR8mV+pLAkeoqhITFzWeoHmxPz4p8scUwvLtToxxNOEpMjRYq7IH2JfE+vDOouNcicYkp4FpH9LjtEIS5Xr8OgjlkQp+Q4kAGMyKJcyhe2Ycpi9H2lliJKiuZP+EeXUuOZnxpGJeABfwXvdMdhyJ8VkNlK5yBfMWHCLhrCZLuCYsek7/PVPlPPwOAtP1cpOYyhJwL8MHY0jFlpXdNpR6e8pPm9PAvl2uwfN2J5NDgqPoIPmTb1mENojisUwU4lOr6lEhzJZA95u0WaPJQSGtkJ/4fW7rhWjaSy9q3yX9J2RMXC0Op+CcQ8qP+2i/f7YCn15XfYH7as EoDHZq05 5nBoyc+v4z/rR23Qn0atjdAdQa9sQhSsvYnpR9elCV8ds7lERytzhNxEkGwzd1/MmKRsIdQeZgB1zp1fyiDtRfqzkGXL5V0gcT841GyD1Ci+TXAXDqewbxSTNdePlTyLC9JDCreSvpYARpaqwnup5LYtynRW3lBrqkkOzk8xWH8q6Td3AVqNOJnMCJQzzXz+DWB6IlFJYGH0R46vCqKtA45XpSU78OG0+pAxQ2vxQKQ26o2ZQ2Qh051/yE9UnIqL64mCN/FbrDSn/YETLjXFOUpe7bCXJ5xvdvDpu04VISbzSEWteBjg7OpU+WPSfMMGpVCqmLzFB9Zx+z68X0yrFa9TG3cxsq3tfKKnkD8VCo/fJu0DaWf80baWSf+nxxKzJSl0rdzg6U/kSR6USggCg3yGDlTd9orqMh+GnUoqeeaYJ2bXYiVQrT31yzeCG3SwRsrVAEzOASygSi9KQUGVZpOZVyT4jInBK6Fi6mHo2y0Lyq860r7Obm5qzRou1++gqXwTb7i+5rSfSknfZfIavzkmmLw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.01.24 04:25, Chris Li wrote: > Hi David and Barry, > > On Mon, Jan 22, 2024 at 10:49 PM Barry Song <21cnbao@gmail.com> wrote: >> >>> >>> >>> I have on my todo list to move all that !anon handling out of >>> folio_add_anon_rmap_ptes(), and instead make swapin code call add >>> folio_add_new_anon_rmap(), where we'll have to pass an exclusive flag >>> then (-> whole new folio exclusive). >>> >>> That's the cleaner approach. >>> >> >> one tricky thing is that sometimes it is hard to know who is the first >> one to add rmap and thus should >> call folio_add_new_anon_rmap. >> especially when we want to support swapin_readahead(), the one who >> allocated large filio might not >> be that one who firstly does rmap. > > I think Barry has a point. Two tasks might race to swap in the folio > then race to perform the rmap. > folio_add_new_anon_rmap() should only call a folio that is absolutely > "new", not shared. The sharing in swap cache disqualifies that > condition. We have to hold the folio lock. So only one task at a time might do the folio_add_anon_rmap_ptes() right now, and the folio_add_new_shared_anon_rmap() in the future [below]. Also observe how folio_add_anon_rmap_ptes() states that one must hold the page lock, because otherwise this would all be completely racy. From the pte swp exclusive flags, we know for sure whether we are dealing with exclusive vs. shared. I think patch #6 does not properly check that all entries are actually the same in that regard (all exclusive vs all shared). That likely needs fixing. [I have converting per-page PageAnonExclusive flags to a single per-folio flag on my todo list. I suspect that we'll keep the per-swp-pte exlusive bits, but the question is rather what we can actually make work, because swap and migration just make it much more complicated. Anyhow, future work] > >> is it an acceptable way to do the below in do_swap_page? >> if (!folio_test_anon(folio)) >> folio_add_new_anon_rmap() >> else >> folio_add_anon_rmap_ptes() > > I am curious to know the answer as well. Yes, the end code should likely be something like: /* ksm created a completely new copy */ if (unlikely(folio != swapcache && swapcache)) { folio_add_new_anon_rmap(folio, vma, vmf->address); folio_add_lru_vma(folio, vma); } else if (folio_test_anon(folio)) { folio_add_anon_rmap_ptes(rmap_flags) } else { folio_add_new_anon_rmap(rmap_flags) } Maybe we want to avoid teaching all existing folio_add_new_anon_rmap() callers about a new flag, and just have a new folio_add_new_shared_anon_rmap() instead. TBD. > > BTW, that test might have a race as well. By the time the task got > !anon result, this result might get changed by another task. We need > to make sure in the caller context this race can't happen. Otherwise > we can't do the above safely. Again, folio lock. Observe the folio_lock_or_retry() call that covers our existing folio_add_new_anon_rmap/folio_add_anon_rmap_pte calls. -- Cheers, David / dhildenb