From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CF6EEB64DC for ; Mon, 17 Jul 2023 15:43:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CD7156B0072; Mon, 17 Jul 2023 11:43:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C87D06B0075; Mon, 17 Jul 2023 11:43:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B4F538D0001; Mon, 17 Jul 2023 11:43:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A5FDD6B0072 for ; Mon, 17 Jul 2023 11:43:48 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 73D5C120417 for ; Mon, 17 Jul 2023 15:43:48 +0000 (UTC) X-FDA: 81021524136.22.6677EC9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 2F47040024 for ; Mon, 17 Jul 2023 15:43:45 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ipSL6Ah0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689608626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yTfaOQJnDoIo46jfQT0QTGsg6WC2cCAaqYgqomxj/I8=; b=jKcHSQMaA142o8oKxUwZ7QGIqKFLu1pyoksxI8rjquM5RTtxGZPfwsuuOdlsf2n0TzXKDi 2RDIAAvw7o28ebfAbWEyqcoaYoo28DIXqyc0YMlGVsCRGwctXcFjWXVSSuzaiU7C3IbLDl Ge2h/+9eQBL+kxvE3M3GdzWQiNavyRs= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ipSL6Ah0; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689608626; a=rsa-sha256; cv=none; b=cbpcG/tQ+IYO+C+axhiT73k+7ppTQAMJMV10XD/X7nIPkKyNo1oBae1eNqhk7wYfa3ATz5 rxtUaQx2yEt1E2fgbIitBbVJX0fCMgpuftsuejCT+GsWSxN1JoWLSVBjqjpYt9+w04G8ei OlM6nme4zLG6WRkx0Ys/tOaquHyY/jk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689608625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yTfaOQJnDoIo46jfQT0QTGsg6WC2cCAaqYgqomxj/I8=; b=ipSL6Ah0H/LUwoprgGJv5oQj7SLX9Xn+uziDA47PZFdwwWTGClEX0t18Z52x0EcduG4Ezi 7ZvEC0zmYBNFahwWLnqQBt2LR6hvZLfurXDN4rkm+xn/JdZkUJn46JpjlswyIoPSLgyG+6 80SPmZf2u3qEaxxzbwzRJuM8lk7FfdY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-490-TRaP9ifwNkC7XOYWHE04EA-1; Mon, 17 Jul 2023 11:43:44 -0400 X-MC-Unique: TRaP9ifwNkC7XOYWHE04EA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-31701b27d19so543614f8f.1 for ; Mon, 17 Jul 2023 08:43:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689608623; x=1692200623; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yTfaOQJnDoIo46jfQT0QTGsg6WC2cCAaqYgqomxj/I8=; b=Lm8BX1+ZKUxBXbunV+T4SonlMgp5JLmkL93guzlZNaAFFoCC4UuXAQTnFiELIVwtbX fDH05OAAuue/R7fkPH85uwmec8R+kuDwhjpo4cev5c5QvqcWEWdx/tCzXcHk4JWwegz6 6KzRtPDdfJoDIKpDP9Yz/0GD8babwG8/pRTgtsS7W9qkUR/hPNAaZFsIYoElTucrQtAT Ekksztc3y+UUkOsu7OaQQyHO7RgXWdTT3LLBrpJVgG6mPXOA2gTRx6ifQlF2dRF+EKec cpnn0rt9Ec/RBTC+PQ2q2eo7WgPiK0BrZSOKwOgzR094qWkoe/EjRhC7IoZc7dSE0vSN BlhQ== X-Gm-Message-State: ABy/qLZJ02qRntkHn1XOFt9E+K16tal9VAyda9zOxJvj83usCfT3EXzg GmVQgdHNyvW2nQ7bde66Y1P0o2JwKWc7+8MUFN4hzOv0/7H33SlbbHoZhQ79LwLmIVj3f+JxlyN xjEYMR+ncv6I= X-Received: by 2002:adf:fac6:0:b0:314:9dc:4c4 with SMTP id a6-20020adffac6000000b0031409dc04c4mr8391930wrs.2.1689608622829; Mon, 17 Jul 2023 08:43:42 -0700 (PDT) X-Google-Smtp-Source: APBJJlFn7xWZG6zHHkr919W29E/ngGyIe9MVhHMeGxe27ydQRjoWZqWe+1yvNtr+FqnkpJ41AWzmnA== X-Received: by 2002:adf:fac6:0:b0:314:9dc:4c4 with SMTP id a6-20020adffac6000000b0031409dc04c4mr8391915wrs.2.1689608622491; Mon, 17 Jul 2023 08:43:42 -0700 (PDT) Received: from ?IPV6:2003:cb:c735:400:2501:5a2e:13c6:88da? (p200300cbc735040025015a2e13c688da.dip0.t-ipconnect.de. [2003:cb:c735:400:2501:5a2e:13c6:88da]) by smtp.gmail.com with ESMTPSA id h3-20020a5d4fc3000000b0031272fced4dsm19657379wrw.52.2023.07.17.08.43.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jul 2023 08:43:41 -0700 (PDT) Message-ID: Date: Mon, 17 Jul 2023 17:43:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 1/3] mm: Allow deferred splitting of arbitrary large anon folios To: Ryan Roberts , Matthew Wilcox Cc: Andrew Morton , Yin Fengwei , Yu Zhao , Yang Shi , "Huang, Ying" , Zi Yan , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20230717143110.260162-1-ryan.roberts@arm.com> <20230717143110.260162-2-ryan.roberts@arm.com> <283e4122-c23f-35a1-4782-fddde32f4ad4@arm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <283e4122-c23f-35a1-4782-fddde32f4ad4@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2F47040024 X-Stat-Signature: did3rd7pgtwaqk5b9rztkw65ypskkoyw X-Rspam-User: X-HE-Tag: 1689608625-946695 X-HE-Meta: U2FsdGVkX1/uP89zh3Mmn8uLEIdZds+NqEdqFvszpBw4yXYsPYFxByiqoao62qnrmY/kSOjZkuEHWj6OjUCzInBrCSHlEzJF+UbEa/XUhAdWQva33KkOj5P2pY7f3lEuKWebOtgpRhcDHkw1yhMRvXgyZaT6tanXeshxXg+aDz8PYNytrVGibuBivDa0P9lAS03Q3mYBY5c50E5enHKco1ce4E2fu7MrTapiaD6FpzkwqBsZmn6wqOePYqLiXsu1yv5HQOtjXomca73jOQ0HFG/4YNcGDj91/LlQsDv/vl8g72bgxISJjP1JpQHen5SoEkfwtMbrZcCvrbZ8x7ehyVjf9J31HteZd8aEOlqnsn25S8I3d21Zt8XdHm2eXD6YHkn/N88xBTRUyqgU+wu9wF/0hESHeCoAc8ZQiAWf7cZtKmtGwISgAs+75oiX/YCMW8fsR8sbsZevXp0keEKQzMzGhcZY8+Fjp1faDKc7di44qoH2pTyLwdWi4+NujOneFl5r5NxIe6c4OsuRFI/bt1zmSHyYWEyfdDickgDqmtU60JRljEIw2+7eH+/7IIjEkLOh/3gV5s27oYWGvDJfaxSyVEnPqCwI9qulqMavcDYZK17rDvy+eRTycWeraMevRJfUCvWtxTsy/ZCMCKOCfHT0Hn2vXhvXUaNS8WwX0hYrMQh5orqwPF6nuGbtatHCV5k97Nq3lDxp5Mj3dZAg0hpPwqpDsaSEtMRDkNI/2Vk1690hEy33yr07fxwBdmBFeD4Cliavny54q18/5pOnCPqymRqqcjlNLoJANWGpPgOc3q4zWuf1HnRornPU+pl8T9uroMdl2eM/ovDIKVtXGdhAXgFS3/Gv18StZH5Lw5HvlbkEc5U4z6shKx/WiguLW5nFIVqfpN/91Cy01whOA8iKgr36YypHBCT+3OucaM0fRWOTqMJ68uHokx+KWQCL0cTfyju37o9bEKXKYS0 ZL+iQaSo H3JR0BEBKLl9VNWSRcCa7qhztctC3lnSBOhvhr7tpwPUT2KAXzGQ5NR84txohdCmVYIO7Xn+sa4jQyRt7XXVIf52E+GMRl+DqTpABQiPsge27HjyoT7YrznfBrhmPfQvYCazrQKBrs0s8Y52ZT4IsWSY0MiBX7FuBUmMfkGQYI6LWJFR08IvI056zDCa/a1nOFo8r5exZ897UZi1pGk9OjSusMc3Zo1F8tHdLhFUyjV5qmNQEM20awzQnEMCEq1LS+Umg9vqc1RElslRelSl58ltwi1XQc9aTb3Kyu3HIlFaBoxt7Mump4MpBSZ/s+3SWnIQyc4hR22JOxO5nhFIffrng49NueuPWxFtQGOGJSpo4wlBLofzW78qwbuaarc/XtmqDk8s1xMyn3oEm4sKF3MfhJff4cYHZSTgk2YAhDHnP/JseqAxTT7mdaxwaH7VLp157BHDPxLAR8Zg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.07.23 17:41, Ryan Roberts wrote: > On 17/07/2023 16:30, Matthew Wilcox wrote: >> On Mon, Jul 17, 2023 at 03:31:08PM +0100, Ryan Roberts wrote: >>> In preparation for the introduction of large folios for anonymous >>> memory, we would like to be able to split them when they have unmapped >>> subpages, in order to free those unused pages under memory pressure. So >>> remove the artificial requirement that the large folio needed to be at >>> least PMD-sized. >>> >>> Signed-off-by: Ryan Roberts >>> Reviewed-by: Yu Zhao >>> Reviewed-by: Yin Fengwei >> >> Reviewed-by: Matthew Wilcox (Oracle) > > Thanks! > >> >>> */ >>> - if (folio_test_pmd_mappable(folio) && folio_test_anon(folio)) >>> + if (folio_test_large(folio) && folio_test_anon(folio)) >>> if (!compound || nr < nr_pmdmapped) >>> deferred_split_folio(folio); >> >> I wonder if it's worth introducing a folio_test_deferred_split() (better >> naming appreciated ...) to allow us to allocate order-1 folios and not >> do horrible things. Maybe it's not worth supporting order-1 folios; >> we're always better off going to order-2 immediately. Just thinking. > > There is more than just _deferred_list in the 3rd page; you also have _flags_2a > and _head_2a. I guess you know much better than me what they store. But I'm > guessing its harder than jsut not splitting an order-1 page? > > With the direction of large anon folios (_not_ retrying with every order down to > 0), I'm not sure what the use case would be for order-1 anyway? Just noting that we might need some struct-page space for better mapcount/shared tracking, which might get hard for order-1 pages. -- Cheers, David / dhildenb