From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CE9DC4332F for ; Tue, 12 Dec 2023 11:49:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A67966B02B0; Tue, 12 Dec 2023 06:49:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A17846B02B1; Tue, 12 Dec 2023 06:49:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DEEC6B02B2; Tue, 12 Dec 2023 06:49:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7E1BF6B02B0 for ; Tue, 12 Dec 2023 06:49:16 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 48282A1E63 for ; Tue, 12 Dec 2023 11:49:16 +0000 (UTC) X-FDA: 81557995512.21.15E14D7 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf21.hostedemail.com (Postfix) with ESMTP id 8205B1C001A for ; Tue, 12 Dec 2023 11:49:14 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EGzaVSoH; spf=pass (imf21.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=adobriyan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702381754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=qGo6VQ1GH3r8vh3FHA5skwhCVAe71E+aOwZCWSOJx4Q=; b=4DAcIgNrJEoScaMnvTYzeukiXWxR6iQnfF1WkxPA9OGVrvFfdEM12AQ3cmfefP0RW4tlxz s47Yd27LvF42/57MtDWgUqImI1drAZO2vv4fYa0mWwoH3+Sp725GBZAlFfPhDEbzRI41Bb BgWvvLizu4St4xdg5YIWQ5rQjPr7kzI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702381754; a=rsa-sha256; cv=none; b=Ct3T2i7L8ntNzeYnHG9bG0AA9HCgx/emuU3BKX4x6L6OGQsSXQ6h6D0dj3etdMshHvxqRt zc1zMy+FtbKlWxP70A5cg13inpc2GRMXrjZNI0yYRfA0cGq1DDTpWLhxq4nP+jEKWHuniX 1fAvmyhWZPe0pLm55437+YkzKHUg6Lg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EGzaVSoH; spf=pass (imf21.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=adobriyan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-50bfd3a5b54so6313035e87.3 for ; Tue, 12 Dec 2023 03:49:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702381752; x=1702986552; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=qGo6VQ1GH3r8vh3FHA5skwhCVAe71E+aOwZCWSOJx4Q=; b=EGzaVSoHtiUoWr5zKabjMyKQTGTOVnvlceAgXnoYNxl/1z4zB7ZzEyRNDg1olk8deU eONMAlpVZCNNhj9XScCXXcu3RmyXNwYUwL7TnBEmZEApbPZLXJHGAVR4vqPc+X6n+Cj1 DueOO1KtfmP0W68X0shicLsjggOn8rUTJDfg8b3ONpS++Nt5HpCRGt2BmrC7pnZJiP9E VKg8yq8dA5kGQQaLg36XXvy0RZ3Gs0i+YkhLQ+8LRzberx9o+PqEFJYU+mR2JLRXWMSz mdX68q2bDQhZfUdrXqnHwL4sXSNYWWoPm6qBQI2f3QtUNkxSLV000bZ9y/4pzAT/+8rF zOSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702381752; x=1702986552; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qGo6VQ1GH3r8vh3FHA5skwhCVAe71E+aOwZCWSOJx4Q=; b=Z3BCquMb/YfSr9wxewxXCS1EPRhSRALxyvInLKuNm9H7b4udcOT68V5I8cRAuP+Rrz IVM7JEmqMTfbSe30sg9I3Ri7GapcqkS7MmSzS26UmxbvZWbwon90Ym1hDcRuBuSpWYi2 aA/vTqnry77km9Bv6mbNNqWkJlv68BjJ1V+QhJ5ED1oklwTPITzHyZrkOb7UAcYVk9ae hmtMf9SFI/WrHrOo8+X/QqLnDfkLVQpaWUWgaw9NlIdsWYFP6kyhzAmrQVA7cReh//D3 NT0YL+a5NK1jFmmNUODTPBimDcAPxnJICjPOBpHYk0F0SywwmgUHJ1iHjj5bcpGGIaWG gaJw== X-Gm-Message-State: AOJu0YwkZjZ59iGYTMYPjAfa8YS76aD5T8UtAEkcT3UVF1SW9kBhmeXb TBlw5PTo0ufSjAhwd0WS/w== X-Google-Smtp-Source: AGHT+IGbPbbFefIk1k+odfvS6l0CnYSHd5dXKAtSwwJxDsoFE3kFXefh2WlOFxIwaoXcYUnUkK8TZg== X-Received: by 2002:ac2:4d91:0:b0:50b:ee87:eeb4 with SMTP id g17-20020ac24d91000000b0050bee87eeb4mr2859443lfe.54.1702381752342; Tue, 12 Dec 2023 03:49:12 -0800 (PST) Received: from p183 ([46.53.250.155]) by smtp.gmail.com with ESMTPSA id vs6-20020a170907a58600b00a1fa6a70b8dsm2530499ejc.133.2023.12.12.03.49.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Dec 2023 03:49:12 -0800 (PST) Date: Tue, 12 Dec 2023 14:49:10 +0300 From: Alexey Dobriyan To: Brian Gerst Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Dennis Zhou , Tejun Heo , Christoph Lameter , x86@kernel.org Subject: cast inside __pcpu_cast_1 macro Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 8205B1C001A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: er8tqm5we7kh3w7pd8mhyfq9guxj14ut X-HE-Tag: 1702381754-492771 X-HE-Meta: U2FsdGVkX1/esATX9SuTxkFI6NLZrymSEK2ukTe2LXuWvgfgi4Zty+gFz+KOsf1N69jRV3FMPjLo9lQwPC8titAkczNRe72C2aea1s0TQtlgRCgWgqZnROfFXN0PJluD8CIPYgEzDhPNXLQoV9lZ6y6lOVEwkLibY4hIsmVIMxV4yw8Y9uyt93ro8O7D55XccXH9YTKShLYjiNL4D6tIaZ/6O4JnlHA2oWm0mS/+zAhoPZbnqNY0YAQC8OoRRPnay2kNuLR3qhuP2pgJJWDzPWiDFnVjFP73OwS2uykOqj0zaY0o/mnXPxrEYdNr0YlQEh9HgMPLdvdBHKokJQGktFQCJXBqTZHlFE1inpsrBROk2p+54AG9ldEy1SJbkFUtqv4AlAU/An5o8+fQxyw1WLbTETELhgUZvkdnV7EBFdhqITJ38HByJklD50FqzFXjieky9ZAa+ZUoDc8cBKfpVrot+keQgqo0kPJB5raWNoBtZq34HLxD0to/5sUti2anemoLDfH3NZAGIJzQZnmTwCbgFEIe3KmSFVHDs7f2cq/H2uy9pk3AnMCjkHrvIGiOFIy18AclKvXqIHqy1KKZQd7T0yTSlyww9bOKzxBcWFSGwQaDMlfkRCQ6ac/WnM+HDyzxp1QRbgEkPENqKnaU9Hcr3xraIFdBa1dgy6BzM1uVsw7CKvvD2pRpJndkZ/coZsv6BLPiAFW3ZuDAY9hM0qJaW0btUNxuwv7O8KHheJB5QDJJjcS+LvTX+8FjBOGW9cLcUArc9P9wxsk5xDThKrfuvVOtpksM/sFfY4UEn86YDWeCo7QRn4VcPXe0HUlGbVBEA+GflevH0DVVh9mzxKyochOsTTIJBygMb+f1LQ0RK0YBc/UxHIzbjKHf75mCZNH1DjsA6FuL2oY/rU57P0Z8i5MxmBHvYf+XSZ2Xvl3r103+Wv4GOZRFyo7kuRJDqvNtla9GZxN9gna8E/+ bTk32cCR Z1de61qcb2lUpfL2FaOwrbQr7kUUY7NA7Hn4SbXoxVeGsuo2iPKYY2D5ofCNfwsrzRJVc7isClUZm8ZRiP/PhoRzpfmJPGcqwBn/tllNncMaqgbZ4qffghptQ9Suo6aic6QN3qx408KCD8CPO6sqL4It3b3JQT+5ZpKYI9dPwvLsJnlZJSh8emg7lUzpFTT8yv6Tj9wFKftJ2e2GuS6k0isCHWNg+iv4k8gLET9IdWkOhxgHEvyUxQcODoS7tt1PcJQZDx9GGY5Z82qhH/pT9FxYpbjA19OsXNiNed2iN+1b9fU0XmKXLRUD9LE3CxOyMnpdqThjZtPcI+lmDm47U61lEY0oeT+pqgo7xBUweTyrJSoat8Ob5OKtfRnTwb8/OGP5wncDMUbbqgb3XLqaXq8gLfc3PmUZor9Z2n+0iMzCnw+r9C7QW2vBECWoUyG7yWT9ZIbX/rIofguHj/4FHMhOn/BNqSq2TaRFY X-Bogosity: Ham, tests=bogofilter, spamicity=0.001169, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, Brian. You've added the following macros in commit 6865dc3ae93b9acb336ca48bd7b2db3446d89370 x86/percpu: Introduce size abstraction macros +#define __pcpu_cast_1(val) ((u8)(((unsigned long) val) & 0xff)) +#define __pcpu_cast_2(val) ((u16)(((unsigned long) val) & 0xffff)) +#define __pcpu_cast_4(val) ((u32)(((unsigned long) val) & 0xffffffff)) +#define __pcpu_cast_8(val) ((u64)(val)) They break complation if "val" is something complex like this_cpu_write(pcp, *x = 1); Only __pcpu_cast_8() is correct in this regard. "val" should be in parenthesis at least. Is there a reason for casts to "unsigned long"? Why not just #define __pcpu_cast_1(val) ((u8)(val))