Re: [PATCH] mm/migrate: check for null vma before dereferencing it

[Colin Ian King <colin.king@canonical.com>]

On 11/04/17 22:26, Andrew Morton wrote:
> On Tue, 11 Apr 2017 13:51:02 +0100 Colin King <colin.king@canonical.com> wrote:
> 
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> check if vma is null before dereferencing it, this avoiding any
>> potential null pointer dereferences on vma via the is_vm_hugetlb_page
>> call or the direct vma->vm_flags reference.
>>
>> Detected with CoverityScan, CID#1427995 ("Dereference before null check")
>>
>> ...
>>
>> --- a/mm/migrate.c
>> +++ b/mm/migrate.c
>> @@ -2757,10 +2757,10 @@ int migrate_vma(const struct migrate_vma_ops *ops,
>>  	/* Sanity check the arguments */
>>  	start &= PAGE_MASK;
>>  	end &= PAGE_MASK;
>> -	if (is_vm_hugetlb_page(vma) || (vma->vm_flags & VM_SPECIAL))
>> -		return -EINVAL;
>>  	if (!vma || !ops || !src || !dst || start >= end)
>>  		return -EINVAL;
>> +	if (is_vm_hugetlb_page(vma) || (vma->vm_flags & VM_SPECIAL))
>> +		return -EINVAL;
>>  	if (start < vma->vm_start || start >= vma->vm_end)
>>  		return -EINVAL;
>>  	if (end <= vma->vm_start || end > vma->vm_end)
> 
> I don't know what kernel version this is against but I don't think it's
> anything recent?

I should have said it was against linux-next
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>