From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CBA1C4363D for ; Fri, 2 Oct 2020 08:23:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1E55B206B8 for ; Fri, 2 Oct 2020 08:23:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="pQUo4jkb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E55B206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 69EBA6B0068; Fri, 2 Oct 2020 04:23:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 64EA56B006C; Fri, 2 Oct 2020 04:23:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 563686B006E; Fri, 2 Oct 2020 04:23:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id 293696B0068 for ; Fri, 2 Oct 2020 04:23:58 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id AF2183631 for ; Fri, 2 Oct 2020 08:23:57 +0000 (UTC) X-FDA: 77326297314.26.push90_2a0b63e271a2 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 83BDF1804B667 for ; Fri, 2 Oct 2020 08:23:57 +0000 (UTC) X-HE-Tag: push90_2a0b63e271a2 X-Filterd-Recvd-Size: 3809 Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Fri, 2 Oct 2020 08:23:56 +0000 (UTC) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 02 Oct 2020 01:23:03 -0700 Received: from [10.2.56.62] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 2 Oct 2020 08:23:55 +0000 Subject: Re: [PATCH] selftests/vm: fix: make check_config.sh executable From: John Hubbard To: Stephen Rothwell CC: Andrew Morton , Linux Next , LKML , References: <20201002064811.435769-1-jhubbard@nvidia.com> <20201002175931.5317ef64@canb.auug.org.au> <2bd44214-ff9c-0333-9525-3db29b9a3ff1@nvidia.com> Message-ID: Date: Fri, 2 Oct 2020 01:23:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <2bd44214-ff9c-0333-9525-3db29b9a3ff1@nvidia.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601626983; bh=hzeEWrUnnyq53wbqtk9/0M8fM/9LD/Z1zo+ELWApx+s=; h=Subject:From:To:CC:References:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=pQUo4jkbLg1wnxcAqAam7H+igCKIOsIxjsBoXd7G6JF5dC2oTDC32MVRUa+9wy5gf /UwQNsiCRKZ025hicOnzFyzWi0pbot0njV+HoyomHsYGKZ9q66b3uktU5R8ZGHuUCI qzXVOckOyPProRFXwJ0EgCKuRxLZaOaIujfeOu8KVeV5zn7ff7vzwyoHCInW+5iIaA IJLKabhWuwwmT5AlqV/VjG4gwrNW5VtQzTqpRXGjdZYJokODeudRt5+I5/m4jlOUHO /V6FkbSjKY1a+0BxPn1A1fbATftVGxFsWQTkqky+Raa2416id8B4sUVuzRzy4CL1Sz lndJzB1HzQlAg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/2/20 1:10 AM, John Hubbard wrote: > On 10/2/20 12:59 AM, Stephen Rothwell wrote: >> Hi John, >> >> On Thu, 1 Oct 2020 23:48:11 -0700 John Hubbard wro= te: >>> >>> commit 30fb9454ab23 ("selftests/vm: hmm-tests: remove the libhugetlbfs >>> dependency") created the new check_config.sh file without the execute >>> bits set. This is a problem because the Makefile runs it with "./", so >>> now "make" is failing in that directory. >>> >>> The posted patch [1] does seem to have it as an executable file, so I'm >>> not sure how this happened. But in any case, make check_config.sh >>> executable again, so that "make" in selftests/vm works once again. >> >> The correct fix is to make sure that the Makefile runs it explicitly >> with a shell because is such a patch is applied with patch(1), the >> execute bit will not be preserved. >> >> See e.g. in the top level Makefile: >> >> =A0=A0=A0=A0$(CONFIG_SHELL) $(srctree)/scripts/gen_autoksyms.sh $@ >> >=20 > OK...we should also fix it anyway, seeing as how the run_vmtest.sh also n= eeds > the execute bit re-set, yes? >=20 ...and I should add that I'm stuck in a non-Kbuild system, here. So $(CONFIG_SHELL) is not available, sigh. > So I guess I should send a patch that does: >=20 > * chmod +x on both run_vmtest.sh and check_config.sh, plus >=20 > * invoke check_config.sh via $(CONFIG_SHELL) from the Makefile. >=20 > Does that sound about right? >=20 > thanks, thanks, --=20 John Hubbard NVIDIA