From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73D94E7717F for ; Thu, 12 Dec 2024 20:19:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C16296B00A5; Thu, 12 Dec 2024 15:19:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC4776B00A6; Thu, 12 Dec 2024 15:19:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8D816B00A7; Thu, 12 Dec 2024 15:19:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 883906B00A5 for ; Thu, 12 Dec 2024 15:19:36 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 406F41A084C for ; Thu, 12 Dec 2024 20:19:36 +0000 (UTC) X-FDA: 82887421386.13.637F414 Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by imf02.hostedemail.com (Postfix) with ESMTP id E60118000D for ; Thu, 12 Dec 2024 20:18:46 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=bozwXMnz; dmarc=none; spf=pass (imf02.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.170 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734034751; a=rsa-sha256; cv=none; b=A1O7HZhvkwNpb1SKTxHrvzfMxNAG3uomchlRsnLHRqgyyK8ahjELMAd7gB2Vziw61d0xhW PdUbV9rhTvaQs3bQuPNdcnOZv7x6mFucYqXBz3MLhMSTBmM6LuwPTWNwpP48nW7DQsHpMZ s3ZmCoLCrQ/9qgjtkauMqt2xKk4XX0g= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=bozwXMnz; dmarc=none; spf=pass (imf02.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.170 as permitted sender) smtp.mailfrom=axboe@kernel.dk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734034751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=amQilKkF88h59kyKbvwGPPw4Lr0cJFGcTEeJ1cmutA0=; b=j3vQyGjuxdUOpIf1DqQtDAxF2CcTDbXoybqTK6XutLAXnZAmdd/cDkgGlrdMTbe+IX1P/b mTilQ0d/yGXuTctYTZ92RHcnshnMwhWe+ElqwysZat2kLBroLFHVrZL7dr67Wzl/iOdDri CDyCWR6zUzjzLXaYf160tjecmMo9Z+s= Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-3a813899384so3730185ab.1 for ; Thu, 12 Dec 2024 12:19:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1734034773; x=1734639573; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=amQilKkF88h59kyKbvwGPPw4Lr0cJFGcTEeJ1cmutA0=; b=bozwXMnzNM23md9fjwDHgX8rEPHTt5pzTSU3LR1ItfP+2wL3HR2gYjgf+QmBbtqHEU lNnp5ym0ua1lzpVTjj5cLu1+10rrPonNHCv0M0iLTMbBeutpSNdTQqf5/pNqeYM2VHRY KzwLv6kmKqoHxkDRlVBKdvVltWzuzTIZquytgYgyRclOu3yI1CkgA0YgMLFm2ENaZp/V ye2AsyGlu35r8p+O1Dhwns2uP8eVMUE432rkHQWh73Wll5nDo7LcduILTNrs4P255ORR bMlq7ULP3/d6OL6zAmqfntaq6UsnqUDHE0Fah07TYfl5fBR9fnWVoQ/Wb3KX6sMnAdpf U7Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734034773; x=1734639573; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=amQilKkF88h59kyKbvwGPPw4Lr0cJFGcTEeJ1cmutA0=; b=dShEt+nzy1T/tVH6TC3UvDpEvzuJIy6D03sMwXGbaZSxCYNuSN3wCJ7xCY31tY46oO HGDFVz5pi9vvsvMd8aN9cpk0FM3MjERAUFMFKfRn7WlRjpO3xshz2Yo2/paiOS5XWlFL LRuaOXOsyut90TlqVOsbQu4WfwTFB9ZJRdAyYaXiXz7SON3yzvWk+kOADKKJQZrdJFqC WtcIsSNx991dYw/VAxtkZI1az7Y1ZbeEDm6/0YhR/p0nY2OgXLtcubphYC6RKdXlRCoL qeUvRlOVFVvbbOq7zBz8eCeiYBKrK8fnzE/UX1iSAloxMr6+igI4VlL2XOB22VqFNqzO J35A== X-Gm-Message-State: AOJu0YxYCdAgkPcxMEgDKOE5tOO1VxY0mavAiWn8SvOqIK8hkik1QLEy AhVINZB6m/crri5HXdnAe43Pb8vjt/ozbOpHvyXiGLvnQg5alV8JppPc0x360Zo= X-Gm-Gg: ASbGncsFyXGzw5vfGRqLmMFSTT4MCpVFR6iMavXPu8+v07T9t4HOn4poeFFSho7T8vc OUsvgPii9nznb5uUXmbZdm7NIvfTGyHtmLNN3A/uaiTyNs0jciDuIN4eU5UIr9ewL0m31laP1P4 Sh+ub9ixh/a5dj9Sf+u/15fSJX/d70cqjJmRw4sWavfdlrbVhT74mG7wo67tZniwszsRwrXFlvz YRNEZFNraX1UMofACy9xI4fqnJGnYZecBrz0a/NlHs9AXge7/rE X-Google-Smtp-Source: AGHT+IFYch7UbRH6nqpKWr2p6Fzhmge00pAqGBgdIHbczzkzMGdbctA/OntbbR3AfoqtbufuALu+LA== X-Received: by 2002:a05:6e02:1d03:b0:3a7:c3aa:a82b with SMTP id e9e14a558f8ab-3aff62132bcmr2335035ab.1.1734034773169; Thu, 12 Dec 2024 12:19:33 -0800 (PST) Received: from [192.168.1.116] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3a9ca03ae11sm31018885ab.41.2024.12.12.12.19.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2024 12:19:32 -0800 (PST) Message-ID: Date: Thu, 12 Dec 2024 13:19:31 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/12] mm/truncate: add folio_unmap_invalidate() helper To: Christoph Hellwig Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, kirill@shutemov.name, bfoster@redhat.com References: <20241203153232.92224-2-axboe@kernel.dk> <20241203153232.92224-8-axboe@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 7b6two48pznzp6p3nadi8ff87qftrfkp X-Rspam-User: X-Rspamd-Queue-Id: E60118000D X-Rspamd-Server: rspam08 X-HE-Tag: 1734034726-730345 X-HE-Meta: U2FsdGVkX1/IwJP8V5mjuh/dd1Gg7s+nSbX7p8+zfeexoz7BhteIdllFe8ADQ3CVWcNXxFFwJvo+w+B5xDTY3aoc8AhflNW1aiJLxXVpZYeATt9JBid0uWt7ooBPQnWa+5H+QQdeM/gla0PpPpyuOEWQ3xP7ZLBkiItc2fqbIQYy/IrWfxj+s/bzp9DTy8Ioq8E70KL2NQGyKuuRmfNI91gnWMQikBMm0lC/wN049H8d2sjKBir5O6HUgkMrgEkxWl1e6Frjg4Pm/f2doS6zD0k5J2bd0+JyQMAuX5m11NPWFoWljy3o/rgcP/hHXPoq+GWzVGig46JHBXDRy7ODARbgr1ToBB+xgDOmX9xiYFR1ACdcnsW+slPRZdBccAdxTuJmA8qSO2NvgusZUcY7EiUdf0eYPvBoFqskBDhurqZzx/N2gCKbfW40ZxJmuCqdrLYK7TR0hbdf9VTT5zobrcDMisFs2P6VaX73QZb3k/VrwqSW4DBYZ9LFokQNztLUmSofs/XSLekF7yZnj6YxtQmctCxgsCRC8v9s/jrnRWHTUXhTl4ibP9J4Slnj66N5kel/I5Q69N9KWDg9Kcd0XWUmghbsvRFSuDgUUC6QNxfDBaMEDCx3UjqT6+6uU335zDQds0N3bJo45z2n83goGDPOdPgH0Fx7uwCp93JSNuu/BSZAl8iU548szeR1LKqPE5dzzt0aMRlsK3CIy8AQawvH1pf4Cojxg+JGV+UC80hml8TTNoYmrCKPW79lk/jxBDy0YgHE61x8CsbDJYzve9nd2L5yGk0wlSts8RujOOZr7FXBD8v43Qdb0g2yyt+lR51FLrl91Ab0LMkIb5/9gdo8cHT+lKQI0JwZuTWz+IwsZxfnb6q33GrD6EKAqp01r1Y0fQm649Z8Z2gmALQJJsGUZ2seAmqQkwTwnyyUoa1wKd6tIlIoCrC2SYM2NHbyvok/yzjaAPa+Gj8fYkW RS/N6Rq2 xcMwiZaxFhElb8nHEd4rdSHibWMBEnLVnm5/SxmmcZLzWgcDw1XxmUetXdypIli++b2JiOyHa0Lg6j+3EFMfAybao965ZvddGksbAeuVvyOqV1wlrk0kQPpNNfzqd/kDx+qPlQAHD+FWDzKwnienV18Ck7G8gza9yfEAwt3LQUudpsKlpa7bnxzBCno2pmhZXvHW0BacVqtAzNiveroNZifdb2InrghFzwx4ltUKYfRtbnKPCX7rY6RhieAy27DA3n+AAIoEmzFbN5q9KFp5JlJNj2hV5CjjtjGFnw50CsklM5yP8sl8EsiLWGBIaWxY/CrzhOfw6N+Ebg/a62Ful/5+NpOwnmENhVoE0gFAN/P1ThvguXMvG4Y8GhRaihH6y9RsrrCPQjXSk276WJAisaFTJfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.016518, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/10/24 4:21 AM, Christoph Hellwig wrote: > On Tue, Dec 03, 2024 at 08:31:42AM -0700, Jens Axboe wrote: >> Add a folio_unmap_invalidate() helper, which unmaps and invalidates a >> given folio. The caller must already have locked the folio. Use this >> new helper in invalidate_inode_pages2_range(), rather than duplicate >> the code there. > > This new helper ends up the only caller of invalidate_complete_folio2, > so you might as well merge the two instead of having yet another > invalidate/unmap helper, which are getting impossible to track of. Sure, missed that it's the only caller now. > Also it is only used in mm/, so add the prototype to mm/internal.h > insead of the public pagemap.h. And a little comment what the function > does would be pretty useful as well. Good point, moved to internal.h instead. >> In preparation for using this elsewhere as well, have it take a gfp_t >> mask rather than assume GFP_KERNEL is the right choice. This bubbles >> back to invalidate_complete_folio2() as well. > > Looking at the callers the gfp_t looks a bit odd to me, as it is > either GFP_KERNEL or 0 which is a valid but rather unusuable gfp_t > value, but I guess this comes form filemap_release_folio which > works similarly. Indeed -- Jens Axboe