From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E154C54EBD for ; Fri, 6 Jan 2023 20:16:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E7C58E0002; Fri, 6 Jan 2023 15:16:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 56F878E0001; Fri, 6 Jan 2023 15:16:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E8FD8E0002; Fri, 6 Jan 2023 15:16:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 26C538E0001 for ; Fri, 6 Jan 2023 15:16:33 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BD4B440EAF for ; Fri, 6 Jan 2023 20:16:32 +0000 (UTC) X-FDA: 80325481824.19.4162199 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 992AA1C0003 for ; Fri, 6 Jan 2023 20:16:30 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IJQ8AT11; spf=pass (imf20.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673036190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LtMfxbZw88oPkeeCIwSBn+oySpGoEMlUBG5RLDl4Enc=; b=mY7EbtQvA7bR3NMhttkM/Qb+2zPR7+XW8oSd9c7QBDeP8MtN2HoyTjfI6qSbsTFZFjsDwp GaCYWVusc27A0mXhVtWrWUJOyn+i5cfyJpjIqO0wHjROLPOSRBcB4YZZUmuExkv/+JWRs5 ujVr0t6lGl9Z9TOYpkqy9VPvrXfj/Is= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IJQ8AT11; spf=pass (imf20.hostedemail.com: domain of jbrouer@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=jbrouer@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673036190; a=rsa-sha256; cv=none; b=Zd3vvXzCLPTYXb75NpWw9tAVAdqi4vQcv9OuVmJo+7FGXoJI2PQ6uYqsR841vyu7i2HJTJ 3pazZf/NUyv6FKf51MugzCDooLG51fVgDzLnkjw9kEvfyqAnV2Keooak3q5TVjEZPH0Z9H nLwm95/D511rGvbPh/3Bg7MPPfXA5XA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673036190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LtMfxbZw88oPkeeCIwSBn+oySpGoEMlUBG5RLDl4Enc=; b=IJQ8AT11XR6feDlZv3gNGSf+4tByvXxNUHXaFgXs6CeRzxroqX+zcFpuuYZFS4emNLL5aF 5KOaDp+UHfL2RGbPjgQ0rQaCCsMMK+3n0QOSaUNDyn/j62IivkaoYi5Nz+HoHPPImopTEe rjjN3W/Feovnpig3giDDEiGYZ0ENNhw= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-295-lwH3nrq2P6CdFDN-eiDS7Q-1; Fri, 06 Jan 2023 15:16:28 -0500 X-MC-Unique: lwH3nrq2P6CdFDN-eiDS7Q-1 Received: by mail-ej1-f72.google.com with SMTP id hs18-20020a1709073e9200b007c0f9ac75f9so1817274ejc.9 for ; Fri, 06 Jan 2023 12:16:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LtMfxbZw88oPkeeCIwSBn+oySpGoEMlUBG5RLDl4Enc=; b=PkJaHb2Y5ychubQSdrQ97dJtFItb3H8U0TzkE3YxmaX1V5qovSk/Jd7GTjRbTJp+Hp HMwMgZfAeSJDCWhQoebmKoSD4gSvu70GvmOaKEarlkqSvh0YkU6R6PHGFA1g8SZZskvK sQbndyJzwumBCrILo98Im9MWIB6JVPiT8qzfk4kEtql/3ixXgQLZ/1Lf0nhSbH4n+xRZ 0SINg0lIHnou/Z+C5O58+54MGjTnVxUwii1nFJkXfEzxdLZNNHvUetwfCaG8bHQQNk+D LtSn7/2ItRDiTzlHyTBo68PCU0FMiHHgI/y8NwdFBJlhtnjfu/f4I3BWkdeqTqRUhHS1 Mpag== X-Gm-Message-State: AFqh2kq/tkGnqn1uw5QGyW2EktQlH7U3S5kntQCQ77hw6mWUOdq9ThgY 9UfyaBuze6D6hEgHSx04pIGECADB2MErFtq28Tyr7E0ZE7O//8KGeG2apPXX2VV2DlB7v5qJTI/ 83Lnfe3G2YPI= X-Received: by 2002:a17:907:8b0a:b0:7c0:ae13:7407 with SMTP id sz10-20020a1709078b0a00b007c0ae137407mr54119126ejc.3.1673036187617; Fri, 06 Jan 2023 12:16:27 -0800 (PST) X-Google-Smtp-Source: AMrXdXunGNhoiMU4SPZRLFuQA3rMs1nNEzaDJBII8I+LignqbvjiO8dWN/xUI0cMRUCyfuXbfuvo6Q== X-Received: by 2002:a17:907:8b0a:b0:7c0:ae13:7407 with SMTP id sz10-20020a1709078b0a00b007c0ae137407mr54119107ejc.3.1673036187379; Fri, 06 Jan 2023 12:16:27 -0800 (PST) Received: from [192.168.42.222] (nat-cgn9-185-107-15-52.static.kviknet.net. [185.107.15.52]) by smtp.gmail.com with ESMTPSA id p5-20020a17090653c500b007ae32daf4b9sm709684ejo.106.2023.01.06.12.16.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jan 2023 12:16:26 -0800 (PST) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: Date: Fri, 6 Jan 2023 21:16:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Cc: brouer@redhat.com, Jesper Dangaard Brouer , Ilias Apalodimas , netdev@vger.kernel.org, linux-mm@kvack.org, Shakeel Butt Subject: Re: [PATCH v2 17/24] page_pool: Convert page_pool_return_skb_page() to use netmem To: Matthew Wilcox , Jesper Dangaard Brouer References: <20230105214631.3939268-1-willy@infradead.org> <20230105214631.3939268-18-willy@infradead.org> <1545f7e7-3c2c-435a-b597-0824decf571c@redhat.com> In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 992AA1C0003 X-Stat-Signature: anu14p7ycfp773n4zkq7tjjgwp55jaqt X-Rspam-User: X-HE-Tag: 1673036190-235178 X-HE-Meta: U2FsdGVkX1+Rtqg2BqQFvw1ytjOxgB8b+IHdpNQEbgcOGyn2DzJHnmCRjn3fsrYsnq8YMpu1Md4g6arwsxkk6MvkX2u+qoKoQmDY+kDFlbQPMkye1wGRkRBVWx7MXozg+gg5C3uQwDyf9K1bokEPd/NVY3HkZu4rlt0NGgEE/QAZuUHMuPJAQ7F65D3zOXarXYNBQKYaWvZMRjZzGT6AwETjpCTvb0DFrSbCQh5qK2wX7yn5eQn4oDDQZwTHjDTDAXoO3XECodCJJ2sdYl+T0Gp0efe0tQpCxzB66Np0hNmgWmgc4Pw/aQ5yS1YICvTVO1EBiFiLRKsUduS6RNx59jxmPdb/xu0bT0eXdoy2BUXsqhZpFPpDf5D2gTr7wRnQ8UeIAz5jUTlHu0ujCbY/8uHmBIEoXVfg6dWRQ2mjF9Qzqx/igV3T5eTOKOmnr1dTBzsUc56XKPDhhELLy5Uf0FpJ/NpI4ke9FBWecwge1mmM4fHFk07XePeqG8r0sRL1U9O+zoU3t9KiSbdXRzS7zTwM1USi5Gw0p8KQQ9R6eBb4GsEMZrdf5LqEwZfJ+9Flv552ArW6Wm6bG2MmDAm3VIYUTr6BhyW/VPtL6gdA/KP1Vt7EShFTx0HGulLeOZmsyFH68oX773WvDunW4OKeATPoCNgv3MAiKTaER8gb+3pxA84P9CAvsEaApI5VTd6ylWb+aFL4j8NwXkpSedIk1qrN6zMc1KSmQVNCcN8LtNkoRCFIiM/0WkEnoRyS4EP+tca1pPGRfoa76hUW/vYKrF2Ok/hacqSD7YOdscj5B/THOcEyFISdZLA/mTK4ZwVZzK4XjaD4hprqWpxGQi1tFyYn5AsIjUAg5BFiQIarEsMens+k3WopkslvEVETCR3AGyr/edKU0TtZ5uPVal2CyKiJfVdrzUNuA8P0BSR5V54teeDkehcwspzSeezxzPn61XYVLeYCNvABiXU3u87 G8im06Bc A7DUBHFW/WcymHrdi/bjH9L6HJ6PmI6vXrj39AGmBwqddzxzRbwZnB5bFiu6hHSn7RP9gnd3qIUYzl0gEMrzOVwjE+C91gSUigzhlQQlZSOLDLL+5XL8j54s40G4blFgAyWlH/wbQLn1i4MLIK4EvBG7kZIZfuMxW4qxy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06/01/2023 17.53, Matthew Wilcox wrote: > On Fri, Jan 06, 2023 at 04:49:12PM +0100, Jesper Dangaard Brouer wrote: >> On 05/01/2023 22.46, Matthew Wilcox (Oracle) wrote: >>> This function accesses the pagepool members of struct page directly, >>> so it needs to become netmem. Add page_pool_put_full_netmem() and >>> page_pool_recycle_netmem(). >>> >>> Signed-off-by: Matthew Wilcox (Oracle) >>> --- >>> include/net/page_pool.h | 14 +++++++++++++- >>> net/core/page_pool.c | 13 ++++++------- >>> 2 files changed, 19 insertions(+), 8 deletions(-) >>> >>> diff --git a/include/net/page_pool.h b/include/net/page_pool.h >>> index fbb653c9f1da..126c04315929 100644 >>> --- a/include/net/page_pool.h >>> +++ b/include/net/page_pool.h >>> @@ -464,10 +464,16 @@ static inline void page_pool_put_page(struct page_pool *pool, >>> } >>> /* Same as above but will try to sync the entire area pool->max_len */ >>> +static inline void page_pool_put_full_netmem(struct page_pool *pool, >>> + struct netmem *nmem, bool allow_direct) >>> +{ >>> + page_pool_put_netmem(pool, nmem, -1, allow_direct); >>> +} >>> + >>> static inline void page_pool_put_full_page(struct page_pool *pool, >>> struct page *page, bool allow_direct) >>> { >>> - page_pool_put_page(pool, page, -1, allow_direct); >>> + page_pool_put_full_netmem(pool, page_netmem(page), allow_direct); >>> } >>> /* Same as above but the caller must guarantee safe context. e.g NAPI */ >>> @@ -477,6 +483,12 @@ static inline void page_pool_recycle_direct(struct page_pool *pool, >>> page_pool_put_full_page(pool, page, true); >>> } >>> +static inline void page_pool_recycle_netmem(struct page_pool *pool, >>> + struct netmem *nmem) >>> +{ >>> + page_pool_put_full_netmem(pool, nmem, true); >> ^^^^ >> >> It is not clear in what context page_pool_recycle_netmem() will be used, >> but I think the 'true' (allow_direct=true) might be wrong here. >> >> It is only in limited special cases (RX-NAPI context) we can allow >> direct return to the RX-alloc-cache. > > Mmm. It's a c'n'p of the previous function: > > static inline void page_pool_recycle_direct(struct page_pool *pool, > struct page *page) > { > page_pool_put_full_page(pool, page, true); > } > > so perhaps it's just badly named? Yes, I think so. Can we name it: page_pool_recycle_netmem_direct And perhaps add a comment with a warning like: /* Caller must guarantee safe context. e.g NAPI */ Like the page_pool_recycle_direct() function has a comment. --Jesper