Re: [PATCH] mm/khugepaged: use list_xxx() helper to improve readability

[Baolin Wang <baolin.wang@linux.alibaba.com>]

On 2025/8/22 10:57, Wei Yang wrote:
> In general, khugepaged_scan_mm_slot() iterates khugepaged_scan.mm_head list
> to get a mm_struct for collapse memory.
> 
> Use list_xxx() helper would be more obvious to the list iteration
> operation.
> 
> No functional change.
> 
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> ---

LGTM.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

>   mm/khugepaged.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/khugepaged.c b/mm/khugepaged.c
> index d3d4f116e14b..24e18a7f8a93 100644
> --- a/mm/khugepaged.c
> +++ b/mm/khugepaged.c
> @@ -2402,7 +2402,7 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, int *result,
>   		mm_slot = khugepaged_scan.mm_slot;
>   		slot = &mm_slot->slot;
>   	} else {
> -		slot = list_entry(khugepaged_scan.mm_head.next,
> +		slot = list_first_entry(&khugepaged_scan.mm_head,
>   				     struct mm_slot, mm_node);
>   		mm_slot = mm_slot_entry(slot, struct khugepaged_mm_slot, slot);
>   		khugepaged_scan.address = 0;
> @@ -2515,9 +2515,8 @@ static unsigned int khugepaged_scan_mm_slot(unsigned int pages, int *result,
>   		 * khugepaged runs here, khugepaged_exit will find
>   		 * mm_slot not pointing to the exiting mm.
>   		 */
> -		if (slot->mm_node.next != &khugepaged_scan.mm_head) {
> -			slot = list_entry(slot->mm_node.next,
> -					  struct mm_slot, mm_node);
> +		if (!list_is_last(&slot->mm_node, &khugepaged_scan.mm_head)) {
> +			slot = list_next_entry(slot, mm_node);
>   			khugepaged_scan.mm_slot =
>   				mm_slot_entry(slot, struct khugepaged_mm_slot, slot);
>   			khugepaged_scan.address = 0;