From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ABCBD2AB3F for ; Tue, 29 Oct 2024 13:52:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 913E66B008A; Tue, 29 Oct 2024 09:52:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C3586B008C; Tue, 29 Oct 2024 09:52:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73CAA6B0092; Tue, 29 Oct 2024 09:52:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 59C4C6B008A for ; Tue, 29 Oct 2024 09:52:26 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 01DF91A1274 for ; Tue, 29 Oct 2024 13:52:25 +0000 (UTC) X-FDA: 82726778526.06.B2B6814 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 605C714001C for ; Tue, 29 Oct 2024 13:52:06 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hV2eZnlH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730209826; a=rsa-sha256; cv=none; b=V2sYzlsPBK+J2H8JOLElm+I6hdzYMAZw6uaS8oWWrAtjo3wm4726K0ccKjECt6eKNNcBQy Oo7rCbAHe4XAfgQCUc7oowR/iukPB2G75V7ySuV6NOMFPdcyLD+AipEeE319x1Zdgt//Fm Hgd9R5Se9mgXM3QhNyX3OrIXxWawZak= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hV2eZnlH; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730209826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dO1pxU+v7pGR+W1PTZavNEqgtX2j3MUJ4Ng6bCnd0XQ=; b=dVVGhvP+eosqYqbSFy6JyJbcj5j2QR3/4JtAOOlFxWpmFn/TLa9OxbuCHaZ81xmL8V3ya6 N7MbM9ZUj5kcfG6+jZ3M5QiptThksfePG/zhqp7RNCEQv4XwRwt3f0kKmehURhEUxwRc1T 8PxNBUn7eCMV7YkVA+vrf2IohMuMir0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730209943; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dO1pxU+v7pGR+W1PTZavNEqgtX2j3MUJ4Ng6bCnd0XQ=; b=hV2eZnlHj+JM8DHVf6Qj9qvbAXThmETNnL4yGGReLWZGhpe87PzjB5rc+saDDbPVwjJhTl Qi82EyCI5hrn25mHrcsGJ4R4uZ0CZ7DrCmDFrHei+eMEV0wl5W6BQnYSHI30zsVSmD/jDR PqjaZYLq9w1rSey1z7cP+Rbp6U6he4o= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-uLYcxYQhPIOvF5TiST8gBA-1; Tue, 29 Oct 2024 09:52:21 -0400 X-MC-Unique: uLYcxYQhPIOvF5TiST8gBA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37d60f3e458so3589720f8f.1 for ; Tue, 29 Oct 2024 06:52:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730209940; x=1730814740; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=dO1pxU+v7pGR+W1PTZavNEqgtX2j3MUJ4Ng6bCnd0XQ=; b=Kd/UGW/FfbmLLVPyT2NV/fpKZG1Xy9zIJ8Z2Panjxv2q2x++ir0Fn1jIRgtUf0Lr8V Ti1ypDe60XszphoUdt7seIwbghPAzRQ2p0SLPZ8dj2ytMsMRHwXtaRG12HXKOIqeMtzd qeD2/gl3Xx9BNL/ZGDhjDxsOBbBP/HOhxMcQi9JK3YXHka9dOw//VeDi3DN2B6R+CfXg H9+LnPrD539oEdOwiQuTuGy96srUjWXoZZBjKkMrrbywdKG9igtFg2V2qBeF1m5VEDIn 40vV1fAdHkc0kDEtojkQ/vS64nPR8Jitxl2+4iGR//d4xmZIgVQTFGOHpfLcBMvzvr9u 3b2A== X-Forwarded-Encrypted: i=1; AJvYcCUz3lJFu5n51EHhsE1qWtd4bm1qlAi+9x4va6TYjgkCUf3f0y2GLbss2tXW6fMaMarjVAkZw8vj7A==@kvack.org X-Gm-Message-State: AOJu0YwMjnA6l1wa2xFMKcjqBPDsuwUpo1sam+ftEgDFScTdTO7G+ABG LLJoJtedD709mKxF4spjfRdNmyjfzgBUdfuJM39mE9+ARKJmBV1sUHGXtGxVQYLMs7nMkUba1pF i9uWxzs8y+BIGFnC6MPHsZ4+ARalR6ScdGlV1D6iKqhz3wL8a X-Received: by 2002:adf:ff86:0:b0:37c:d2e3:1298 with SMTP id ffacd0b85a97d-380612475d5mr10456959f8f.55.1730209940115; Tue, 29 Oct 2024 06:52:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGl2pn0wJexO6SVQ72x+wYokfye5e2x6PTmKxO03mdaWNEJN9SdmRhPNmLkSfHsHTO5S7ejvg== X-Received: by 2002:adf:ff86:0:b0:37c:d2e3:1298 with SMTP id ffacd0b85a97d-380612475d5mr10456918f8f.55.1730209939719; Tue, 29 Oct 2024 06:52:19 -0700 (PDT) Received: from ?IPV6:2003:cb:c72d:8500:d87a:ed8e:1e80:5a7e? (p200300cbc72d8500d87aed8e1e805a7e.dip0.t-ipconnect.de. [2003:cb:c72d:8500:d87a:ed8e:1e80:5a7e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431935f7213sm144934185e9.32.2024.10.29.06.52.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Oct 2024 06:52:19 -0700 (PDT) Message-ID: Date: Tue, 29 Oct 2024 14:52:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] x86: probe memory block size advisement value during mm init To: Gregory Price Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-cxl@kvack.org, Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rrichter@amd.com, Terry.Bowman@amd.com, dave.jiang@intel.com, ira.weiny@intel.com, alison.schofield@intel.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, rppt@kernel.org References: <20241022213450.15041-1-gourry@gourry.net> <20241022213450.15041-3-gourry@gourry.net> <07102ea5-ee43-4c11-ab3c-a35cfce9003b@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 605C714001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: crmkwde3ep8cg67z3wd3thgtqis3xymh X-HE-Tag: 1730209926-127566 X-HE-Meta: U2FsdGVkX1/UBEAaiorA6WZmQbh9f+Bcu0nla/ikjFHs5CkoPOLZCLtT9oc9DI99AjM5dNL78T7fVtfWh+X5tlXoX75nv+vhYGRmPJWM0iebl4kYsGwnrQLS48GcVGrTxEXd5OUvmDntDefk+jebSuGjC8aMrg29cab23dE1FYPbCnV0B644mNcEFCwO9wD7BJmtCojepWzrGmPds5IyY9oQh1ThThm1SJq18SSoVP8GaP3d/NPT6GrSA0S1I9DrWT3XqtISvpc40YHnl6ghLAlJAadQr5Lp69TWCPH+pxIzeOEqgYr3+MQ6EQs8w3LfSRnwWfxGK8RgJDDoMChB8XIaEn/DDHWe10zbaRDkThYZelEr9v8GJ7ipuSHernRDqTbY80GUTqllp3FB+6+n2rqbp2Rov1N9nIL+yQpJkzQsJ+4f7MOFXYPzFwqEJlMsXP/Ub3GB1ZisZCJxc+TocYZjsP+pJJDA7kSh3ZHmN45fXJ1XA2ixVK+CUek1sW/KipXaKmSOohTiB6J/DjoCrDWYfsMzT0GW94psGBjzp09CR9IvGzo4OvQZYX3EQVP24g6RF284rYmh0SkoloGfK7T4xyiKXKdP7xewxq/Cn01HlaPm1/JRugy3ZwY1dJK+n+zmxSuReiV28x57QrIRtPws6Bbji7fJUkKdIBcPAx3Pc6YaJOPxFRIZo3Ni6Qdmv3tdjIte54JSqNnXSbd0beqN4UNXxx9AwNU9vLUJqJKVr6FzMZ9awP0DWXdcpcfrzFe6V+xtbgKGJHEtPOeVfqwfGTsbynA8w5zThbd+AhrEKPOqc47Mw2VdIkUh8JUgSZokVuf5boGx4SOUbcOvT2zB2cY2CaKffdfomnVyTzWVaaL98clVw4Fk4n5+bpHCzEXCNbwoBkiznH3K4Lq8QCMcDlFpMaDH7N+nMOqSwJjGpDbD7gpQB/znWyGGwmC1jAmaxSCH4y6YAvrIhzj 8mI4bY/d 0iSReJbI3xaPEzyUQk+Vze7g/gs0FPLeKqlJp3kyI3t6VI7HeCyCXqVNRHdffcyr2m4keB9U4XArhhtGmp8jq7worcLHPfYYUdVWaEuuwhyPSzWPpnPMz2ulP8M1zqlTpaHdre1vQQ5Unnas4TvV3LSwHokk6UnbUvTdZBIClfgAGPbs4xW/ryrqLjHXhAta39UBXkhizaQwM1AGnWFAbeMNWq34nr9UXp6mZHaAzaQSw9SfPjoDvwwpjgfhuSesRQazldudkkUuABPJlDqK/84xrLDa++6FCoUo23teFEIb8PDK+nHdItJ4gBThq2M7BL1qEh5YSocxVJ7r22FV0B5BU9fATXpcqM06k4NaH5GW/iqsFK099iHtR0EJi3dCVl92jRCDHu7SuzP8xt4LGHCUtpfdowSX7fVQjMkotk8qd46sE7lgdHna3F/mNNPi3mesu00H8ufIAq3kQJweRvqLRrTtmHfrPCjAS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.10.24 14:48, Gregory Price wrote: > On Tue, Oct 29, 2024 at 01:40:38PM +0100, David Hildenbrand wrote: >> On 22.10.24 23:34, Gregory Price wrote: >>> Systems with hotplug may provide an advisement value on what the >>> memblock size should be. Probe this value when the rest of the >>> configuration values are considered. >>> >>> The new heuristic is as follows >>> >>> 1) set_memory_block_size_order value if already set (cmdline param) >>> 2) minimum block size if memory is less than large block limit >>> 3) if no hotplug advice: Max block size if system is bare-metal, >>> otherwise use end of memory alignment. >>> 4) if hotplug advice: lesser of advice and end of memory alignment. >>> >>> Suggested-by: David Hildenbrand >>> Signed-off-by: Gregory Price >>> --- >>> arch/x86/mm/init_64.c | 14 +++++++++----- >>> 1 file changed, 9 insertions(+), 5 deletions(-) >>> >>> diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c >>> index ff253648706f..93d669f467f7 100644 >>> --- a/arch/x86/mm/init_64.c >>> +++ b/arch/x86/mm/init_64.c >>> @@ -1452,13 +1452,17 @@ static unsigned long probe_memory_block_size(void) >>> } >>> /* >>> - * Use max block size to minimize overhead on bare metal, where >>> - * alignment for memory hotplug isn't a concern. >>> + * When hotplug alignment is not a concern, maximize blocksize >>> + * to minimize overhead. Otherwise, align to the lesser of advice >>> + * alignment and end of memory alignment. >>> */ >>> - if (!boot_cpu_has(X86_FEATURE_HYPERVISOR)) { >>> + bz = memory_block_probe_max_size(); >>> + if (!bz) { >>> bz = MAX_BLOCK_SIZE; >>> - goto done; >>> - } >>> + if (!boot_cpu_has(X86_FEATURE_HYPERVISOR)) >>> + goto done; >>> + } else >>> + bz = max(min(bz, MAX_BLOCK_SIZE), MIN_MEMORY_BLOCK_SIZE); >>> /* Find the largest allowed block size that aligns to memory end */ >>> for (bz = MAX_BLOCK_SIZE; bz > MIN_MEMORY_BLOCK_SIZE; bz >>= 1) { > ^^^^^^^^^^^^^^^^^^^^^^^^ >> >> >> Acked-by: David Hildenbrand > > Will pick this up but wanted to point out the silly bug above. > This version completely ignores the advise lol. > > Changing to below > > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > index 93d669f467f7..01876629f21f 100644 > --- a/arch/x86/mm/init_64.c > +++ b/arch/x86/mm/init_64.c > @@ -1465,7 +1465,7 @@ static unsigned long probe_memory_block_size(void) > bz = max(min(bz, MAX_BLOCK_SIZE), MIN_MEMORY_BLOCK_SIZE); > > /* Find the largest allowed block size that aligns to memory end */ > - for (bz = MAX_BLOCK_SIZE; bz > MIN_MEMORY_BLOCK_SIZE; bz >>= 1) { > + for (; bz > MIN_MEMORY_BLOCK_SIZE; bz >>= 1) { > if (IS_ALIGNED(boot_mem_end, bz)) > break; Heh, yes, I think I suggested that in my quick draft. -- Cheers, David / dhildenb