From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB79BC77B7F for ; Mon, 23 Jun 2025 14:21:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3712A6B00D2; Mon, 23 Jun 2025 10:21:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 348D66B00D3; Mon, 23 Jun 2025 10:21:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25E8C6B00D4; Mon, 23 Jun 2025 10:21:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 190566B00D2 for ; Mon, 23 Jun 2025 10:21:20 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C12FB805DE for ; Mon, 23 Jun 2025 14:21:19 +0000 (UTC) X-FDA: 83586877878.20.4351726 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf17.hostedemail.com (Postfix) with ESMTP id 36FDD4000B for ; Mon, 23 Jun 2025 14:21:17 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ti7U4Cey; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9W3oUpek; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ti7U4Cey; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9W3oUpek; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750688477; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EaVkjdtu0qR0IvdgczsHHLG6kVAAB8KCiwHmzhdF6O8=; b=KVqG7sOOwGh2AKVTMR4uM5vUOUj8PdXj/0gxOw58YDM92EzgRggwRHvSjM/tmZkCAlcJtC NUVhGbS508zF5nO1BDpY9Rmzl0b/82gCFBam/h2vq2DKc5CM1qXGKaa1STRiOaUjJUwA/b SiYZpNi1hoi5IRRLVb5v90qCJeVOebE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750688477; a=rsa-sha256; cv=none; b=HACHz/FSF47Q9z99KMCCKxlKD/u1y6scoefT2L7zxgrcV5+RmZ+3wQ6ItMuPoSivn2D6TZ cXtFprkKEHiHL7iJCB1lVD7HbRtsyMa9v0JNxMEhVWoQ6Fmp43kKp1+8HhcsIyLu9wDUh6 wKbumzEdS2foGZxvmmJN1CcgqPNEOVA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ti7U4Cey; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9W3oUpek; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ti7U4Cey; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9W3oUpek; spf=pass (imf17.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 692761F385; Mon, 23 Jun 2025 14:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750688475; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EaVkjdtu0qR0IvdgczsHHLG6kVAAB8KCiwHmzhdF6O8=; b=ti7U4Cey6hRWObguyi7fDF5i/rQBJuOUaUQDdFnrcC4u30qK3nEwkuz6qJ3hK1ESJ/eTLs mL5df+ivwZq0uThGSWF2wMUhRqvNa710DnBocEENfTNujhmu6KLAQSxwiHshV3FITZVqpf 8ghc0fFKAomv3dU9+YuZpPtA00LGp6A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750688475; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EaVkjdtu0qR0IvdgczsHHLG6kVAAB8KCiwHmzhdF6O8=; b=9W3oUpekOiapVDhAFy755BezeIWYOW2nqGVbXhh6UuVE+FLquyu67NSiudhQV8TmUZkQIb qmd00T1PvOd4MGBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1750688475; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EaVkjdtu0qR0IvdgczsHHLG6kVAAB8KCiwHmzhdF6O8=; b=ti7U4Cey6hRWObguyi7fDF5i/rQBJuOUaUQDdFnrcC4u30qK3nEwkuz6qJ3hK1ESJ/eTLs mL5df+ivwZq0uThGSWF2wMUhRqvNa710DnBocEENfTNujhmu6KLAQSxwiHshV3FITZVqpf 8ghc0fFKAomv3dU9+YuZpPtA00LGp6A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1750688475; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EaVkjdtu0qR0IvdgczsHHLG6kVAAB8KCiwHmzhdF6O8=; b=9W3oUpekOiapVDhAFy755BezeIWYOW2nqGVbXhh6UuVE+FLquyu67NSiudhQV8TmUZkQIb qmd00T1PvOd4MGBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3D5ED13485; Mon, 23 Jun 2025 14:21:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KnuaDttiWWgEYwAAD6G6ig (envelope-from ); Mon, 23 Jun 2025 14:21:15 +0000 Message-ID: Date: Mon, 23 Jun 2025 16:21:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fs: export anon_inode_make_secure_inode() and fix secretmem LSM bypass Content-Language: en-US To: Christoph Hellwig , Christian Brauner Cc: Sean Christopherson , Mike Rapoport , Shivank Garg , david@redhat.com, akpm@linux-foundation.org, paul@paul-moore.com, viro@zeniv.linux.org.uk, willy@infradead.org, pbonzini@redhat.com, tabba@google.com, afranji@google.com, ackerleytng@google.com, jack@suse.cz, cgzones@googlemail.com, ira.weiny@intel.com, roypat@amazon.co.uk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, Peter Zijlstra References: <20250619073136.506022-2-shivankg@amd.com> <20250619-fixpunkt-querfeldein-53eb22d0135f@brauner> <20250619-ablichten-korpulent-0efe2ddd0ee6@brauner> <20250623-warmwasser-giftig-ff656fce89ad@brauner> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJnyBr8BQka0IFQAAoJECJPp+fMgqZkqmMQ AIbGN95ptUMUvo6aAdhxaOCHXp1DfIBuIOK/zpx8ylY4pOwu3GRe4dQ8u4XS9gaZ96Gj4bC+ jwWcSmn+TjtKW3rH1dRKopvC07tSJIGGVyw7ieV/5cbFffA8NL0ILowzVg8w1ipnz1VTkWDr 2zcfslxJsJ6vhXw5/npcY0ldeC1E8f6UUoa4eyoskd70vO0wOAoGd02ZkJoox3F5ODM0kjHu Y97VLOa3GG66lh+ZEelVZEujHfKceCw9G3PMvEzyLFbXvSOigZQMdKzQ8D/OChwqig8wFBmV QCPS4yDdmZP3oeDHRjJ9jvMUKoYODiNKsl2F+xXwyRM2qoKRqFlhCn4usVd1+wmv9iLV8nPs 2Db1ZIa49fJet3Sk3PN4bV1rAPuWvtbuTBN39Q/6MgkLTYHb84HyFKw14Rqe5YorrBLbF3rl M51Dpf6Egu1yTJDHCTEwePWug4XI11FT8lK0LNnHNpbhTCYRjX73iWOnFraJNcURld1jL1nV r/LRD+/e2gNtSTPK0Qkon6HcOBZnxRoqtazTU6YQRmGlT0v+rukj/cn5sToYibWLn+RoV1CE Qj6tApOiHBkpEsCzHGu+iDQ1WT0Idtdynst738f/uCeCMkdRu4WMZjteQaqvARFwCy3P/jpK uvzMtves5HvZw33ZwOtMCgbpce00DaET4y/UzsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZ8gcVAUJFhTonwAKCRAiT6fnzIKmZLY8D/9uo3Ut9yi2YCuASWxr7QQZ lJCViArjymbxYB5NdOeC50/0gnhK4pgdHlE2MdwF6o34x7TPFGpjNFvycZqccSQPJ/gibwNA zx3q9vJT4Vw+YbiyS53iSBLXMweeVV1Jd9IjAoL+EqB0cbxoFXvnjkvP1foiiF5r73jCd4PR rD+GoX5BZ7AZmFYmuJYBm28STM2NA6LhT0X+2su16f/HtummENKcMwom0hNu3MBNPUOrujtW khQrWcJNAAsy4yMoJ2Lw51T/5X5Hc7jQ9da9fyqu+phqlVtn70qpPvgWy4HRhr25fCAEXZDp xG4RNmTm+pqorHOqhBkI7wA7P/nyPo7ZEc3L+ZkQ37u0nlOyrjbNUniPGxPxv1imVq8IyycG AN5FaFxtiELK22gvudghLJaDiRBhn8/AhXc642/Z/yIpizE2xG4KU4AXzb6C+o7LX/WmmsWP Ly6jamSg6tvrdo4/e87lUedEqCtrp2o1xpn5zongf6cQkaLZKQcBQnPmgHO5OG8+50u88D9I rywqgzTUhHFKKF6/9L/lYtrNcHU8Z6Y4Ju/MLUiNYkmtrGIMnkjKCiRqlRrZE/v5YFHbayRD dJKXobXTtCBYpLJM4ZYRpGZXne/FAtWNe4KbNJJqxMvrTOrnIatPj8NhBVI0RSJRsbilh6TE m6M14QORSWTLRg== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 36FDD4000B X-Stat-Signature: gcohf44ajzsjkxhw8ohtr7f487frben5 X-Rspam-User: X-HE-Tag: 1750688477-577516 X-HE-Meta: U2FsdGVkX1+p/aZT/7ooVQPoPYd9GAYLVlF/JMv1vmCUhokPozsrYEyiy59CcVaG0/xWKKalFbEmUTPm1B9QDvdM5se/9ri5yEdc8TtOxdR8zJjlYZYYbokBajuCyIwqCKz8hx8UDTFVZSubrv88yTe+K3UigMjYMQRzua2NxDunxL8k7yZjvc68/zskx1tF14jD1x1BAdAHWAL9s88SJAv63vpGIi6G2gN1SNahhY4a2nNVAsho0w2Ge+12B/dDNfPWVgsHJVT8+pu/KPp/G7tYcn/sGCBwQhTlm9HYyjlgi2XqZkmU1CZ6cwr1OMwabbMy4WuLUdUWBUtq8oA9IkafdnUo2lLyWYFpJ4FjONCSu67SMaCcP8b/ecrUEbLVjRiuWsg6gNdFxZwt0hOo53OitibaUDGibcFyCSX40GcUCIzugEytPk7p+LC/ZafQrWhDXi8fq+JoprN/03gZrstSY8p1hcMv8w11AACk52p3AckLMYPGYygbUZKGaI0LWkBR6a/9JDC3O5l0N2MVx8FkdNeHY9859A65zl0bBh3DaZ85hLib+RAqFa01CCIj7IzqAGn2FtdS3AUYh5+UapDyl2zGC7eSIp18AuyEbDKyGZdSFPBkeurXOypiTK5Q1rllefFXCMCUnBJsfxMO29D5L8O2AgnDZ+9bknEdkzrtAg8EVKhrXUFJr8I+Ob1G8KmY2ZENEPB8cEwN4bbUxJ9VF7RsuCXg2JceUA026qLfxrAWG7CrCJV0jbKvXf9sR5jnsPil8dDU/uxuaMniarIFKxtCbWGEY/US+V2+4r5qpZRrmhcYhTdU+rjQAJNxCpSpnUKdvmzyPKkDqML2lKQO558IMQLQf4VruNMqEbGqspHeU7m34S08qOTlEhd9rmfqK7gx2q5ocFLtem6Qte8hPc0p7P6j/S0iIT+00zeP+71IVRrkFt2pw4lN6HJ5qA3ta1K8TgZNW9HJTXP /AuJH+wT Uzkrf2FaH5FmQ6Zx2VlAMGyI6jBNQ4d6he70QaIdSjjNK8dgQJANrwlaCpjWdsPfP9WkAOx4Q5RkDQaah5znQKVmTiB3d/gB2AhF2ucYQjRqFHzi8ShWwwFunrPigZfeO82UtA+QJXCLUqoGwTL+e1EnGAiO4azOwWKqWVRMh703mxIklhhkqDmz16KMZF3S1TzFEJx3MUs/EZZS1+jzLyeVUYlbr2aRbjc+2S9XwV+5w7u+y46D+xb/6qT9SuIoiYgHP2BqCagW/VAtzwxBju+SQwjsCrOrBO5wSNac3dgFkJgZDjFsJk2C3wsxomWWsJ8QpJxMtgRw5EI+EYMmfCBv1aQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/23/25 16:01, Christoph Hellwig wrote: > On Mon, Jun 23, 2025 at 07:00:39AM -0700, Christoph Hellwig wrote: >> On Mon, Jun 23, 2025 at 12:16:27PM +0200, Christian Brauner wrote: >> > I'm more than happy to switch a bunch of our exports so that we only >> > allow them for specific modules. But for that we also need >> > EXPOR_SYMBOL_FOR_MODULES() so we can switch our non-gpl versions. >> >> Huh? Any export for a specific in-tree module (or set thereof) is >> by definition internals and an _GPL export if perfectly fine and >> expected. Peterz tells me EXPORT_SYMBOL_GPL_FOR_MODULES() is not limited to in-tree modules, so external module with GPL and matching name can import. But if we're targetting in-tree stuff like kvm, we don't need to provide a non-GPL variant I think? > .. the only thing we should do is to drop the pointless _GPL in the > name entirely. I'd agree if it was indeed limited to in-tree modules.