From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DE77C2BD09 for ; Wed, 3 Jul 2024 07:32:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E984C6B0083; Wed, 3 Jul 2024 03:32:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E207E6B0085; Wed, 3 Jul 2024 03:32:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC1076B0088; Wed, 3 Jul 2024 03:32:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id ADDF46B0083 for ; Wed, 3 Jul 2024 03:32:02 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2DFCD808D0 for ; Wed, 3 Jul 2024 07:32:02 +0000 (UTC) X-FDA: 82297622484.21.400357F Received: from out0-198.mail.aliyun.com (out0-198.mail.aliyun.com [140.205.0.198]) by imf11.hostedemail.com (Postfix) with ESMTP id D625B40017 for ; Wed, 3 Jul 2024 07:31:58 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b=bZMv3fhO; spf=pass (imf11.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.198 as permitted sender) smtp.mailfrom=libang.li@antgroup.com; dmarc=pass (policy=quarantine) header.from=antgroup.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719991909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r1F4Tww59q1R5bRgyxjFQoWwXm2ayMMPEgBvkY/J2bE=; b=hM9g6TH1NNJjovH4a8hV+GrQ1T4/mmS2y+EkKq6GvAuCfS6vAMtgFAZOX5TgqWH0IYgSuR yDmkXKqlByMNmBXAw20F+GGH67NdeUDP8/luwHkcjtFW7iKTIbGZ1QJ6cZKGG0eavNoN7O DzT9xKhTDw/4OntZCql88Ej55uxwnDQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=antgroup.com header.s=default header.b=bZMv3fhO; spf=pass (imf11.hostedemail.com: domain of libang.li@antgroup.com designates 140.205.0.198 as permitted sender) smtp.mailfrom=libang.li@antgroup.com; dmarc=pass (policy=quarantine) header.from=antgroup.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719991909; a=rsa-sha256; cv=none; b=okuBD6zxsEYoITEzOQFsWV3JUtRWOq5Q0Nzx9lqPdOGvVkkp+eg/I3ccEZgnZ2Bh/gDba8 NnF/hpj8VXlzJbj3sDf005GSWa0ajlnAhwK2ArtGPSZWtRPxpOP4+E1DcrlG14ytTuy0oe 1asCNmtS6kAI/LWTgCKsUykTIpGf69c= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=antgroup.com; s=default; t=1719991915; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=r1F4Tww59q1R5bRgyxjFQoWwXm2ayMMPEgBvkY/J2bE=; b=bZMv3fhOemNRPCAhfdVUB1gKP/SotoicP/xdM7Jdh5vl61mHcmfnQV0DKnxAowSncXUnatvx/RHoKLAKSkp96Zai/bNG5Jq44+Wh22ldnwMwnMVH2MKKEVf78h9hFqojAWFAX6CWlBfhD0sLEwue+cKgYAiZ7PtvzLmHqBcqk9U= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=maildocker-contentspam033068221070;MF=libang.li@antgroup.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---.YGDw6A8_1719991913; Received: from 30.230.88.238(mailfrom:libang.li@antgroup.com fp:SMTPD_---.YGDw6A8_1719991913) by smtp.aliyun-inc.com; Wed, 03 Jul 2024 15:31:54 +0800 Message-ID: Date: Wed, 03 Jul 2024 15:31:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: thp: support "THPeligible" semantics for mTHP with anonymous shmem To: Baolin Wang , ughd@google.com, akpm@linux-foundation.org Cc: david@redhat.com, ryan.roberts@arm.com, wangkefeng.wang@huawei.com, ioworker0@gmail.com, ziy@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240702023401.41553-1-libang.li@antgroup.com> <6f383c8c-b125-4374-bf21-67b6cc3edcbe@linux.alibaba.com> Content-Language: en-US From: "Bang Li" In-Reply-To: <6f383c8c-b125-4374-bf21-67b6cc3edcbe@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: D625B40017 X-Stat-Signature: tpus1pp6qs8q87zgifgok9pa4g5pwgwy X-HE-Tag: 1719991918-235796 X-HE-Meta: U2FsdGVkX1/8K5w4S+mQUDU/Swweydm6DqLrutnIRTXk92UYFHl7N++QSoiL+nuZqy+Pzn7aSkVBW9i4UxaTVJdHbOspj5g6k+DGgVQaJZXGOTpHvB5/x4+5AIbC4JmCiKYGX05dSoF3HLWT388EO66tMTpq7z615worNIFwycIa3jLFC2P5XupbCoqOqObwDVNepLHLHpvVb5NXkVwdP3FY6zYLPqgCNEyErxJmyqlhmTojYnuIcJhz4Un+vWweVo+q6n1Ulj8KANBqHbtk6g6oMRGDqNlJadVxrbq/Ch/kl+ta8q32cqyoTy5l+z8zz5OhLsHl3nQee3AgEIHjgH938IpCoQQ5gZ7mRVkpZDo377oxSBHNeOonGv6WqVcHgcSjwpJUE1hSSjVUNJBx11RvOBtdVhhk/9o47Rdiz7RgORir2Xg4Xjsjg5E9YwWPmTLw95mhoLkYfQH4GeJS1KBIO4NEhT+LPKqix13A2iv5chlEFdhLdB7RJdJzkZfrIrHlLsv4GxfZRb1Iv0oVtMK5ZCLPCXWi4UCSIYfGx+vU+XdjVDqxs3KegKQi5F9OdjaM75E/cLCMl1LvbeJwtURSLXBwrAkT5242RUHJBDqymAPPqMb9FvAK7valB1qgFep1IiAcY18NkM0aRlPgG02No9/bw8anrDB5RbiwacxK2xpsadbzakr2kSQGxgJxupAeJuAt3cmgxNhZDiIydTr7PXUYKDgStLdK7IOYxLv52GpMNqSgXB60bMS8xSSVn6QFzEA5CYwTDoaJ2ZlZKJi9gsk8sTlqIR24YdAh5FTXeCamk63Uhj1hi03Souc2DH34IoAM9vJntF+dTwssfIYsiT9DS+2+63w8kHbZA2fTpHYm4hSX7LKtPdleoz4rODMCXiqm9PFZcVad5gHFHabMEV5f1euQjUqTwSV9+hcPeR2VbvVCewTT0LqBArYF6wzbWFZBKJoLt4ept1I tE+h/v/h G30w8DOSdD2kkXIXAHf7k7ygdjeIJ5BDuWHIwiRHodPQAEB+hEbAE2oD1MF4DSAXnaEhePp5vbMmrJeWekAm2dtk7Efk86cYnjyRNR80kILTi7NiMOR3XuB5I/Adegy3J8Fs3zl6x/eUjq8hcFlN2T1BPPbgjiCseJdR64J70lEdOYLFhTv91A9+Q1VxIzUyLqT7CFUMuXa46qFf777oSFmUEFJjgEVlICePMknUk0tVrNi8bsv+wx2MtxbkctGhL3l2jZ9pvH1VuN3IqH74nMw2vfosDchLrq18WD4aP42yVUELnxR+cJZRPkb6aQg22PmPLcCnD2s7C4hhVMYElXLJmu8RHCQZKwvhyfX0SAkSFlqdmiI5Z5P9Hd9EFrwg311w4PbXeG0M43aKQq+u9uje4nWl0G5rMgqpr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Baolin, On 2024/7/2 14:14, Baolin Wang wrote: > > > On 2024/7/2 10:34, Bang Li wrote: >> After the commit 7fb1b252afb5 ("mm: shmem: add mTHP support for >> anonymous shmem"), we can configure different policies through >> the multi-size THP sysfs interface for anonymous shmem. But >> currently "THPeligible" indicates only whether the mapping is >> eligible for allocating THP-pages as well as the THP is PMD >> mappable or not for anonymous shmem, we need to support semantics >> for mTHP with anonymous shmem similar to those for mTHP with >> anonymous memory. >> >> Signed-off-by: Bang Li >> --- >> Changes since v1 [1]: >>   - Put anonymous shmem mthp related logic into >>     thp_vma_allowable_orders() (per David) >> >> [1] >> https://lore.kernel.org/linux-mm/20240628104926.34209-1-libang.li@antgroup.com/ >> --- >>   include/linux/huge_mm.h | 11 +++++++++++ >>   mm/huge_memory.c        | 13 +++++++++---- >>   mm/shmem.c              |  9 +-------- >>   3 files changed, 21 insertions(+), 12 deletions(-) >> >> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >> index 212cca384d7e..f87136f38aa1 100644 >> --- a/include/linux/huge_mm.h >> +++ b/include/linux/huge_mm.h >> @@ -267,6 +267,10 @@ unsigned long thp_vma_allowable_orders(struct >> vm_area_struct *vma, >>       return __thp_vma_allowable_orders(vma, vm_flags, tva_flags, >> orders); >>   } >> +unsigned long shmem_allowable_huge_orders(struct inode *inode, >> +                struct vm_area_struct *vma, pgoff_t index, >> +                bool global_huge); >> + >>   struct thpsize { >>       struct kobject kobj; >>       struct list_head node; >> @@ -460,6 +464,13 @@ static inline unsigned long >> thp_vma_allowable_orders(struct vm_area_struct *vma, >>       return 0; >>   } >> +static inline unsigned long shmem_allowable_huge_orders(struct inode >> *inode, >> +                struct vm_area_struct *vma, pgoff_t index, >> +                bool global_huge) >> +{ >> +    return 0; >> +} > > This function should be placed in the ‘shmem_fs.h’ header file, just > like shmem_is_huge(). Looks more reasonable，thank you for your review. Thanks, Bang