From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B315C433F5 for ; Wed, 6 Apr 2022 19:35:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B68F36B0071; Wed, 6 Apr 2022 15:35:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AEF606B0073; Wed, 6 Apr 2022 15:35:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 969096B0074; Wed, 6 Apr 2022 15:35:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0186.hostedemail.com [216.40.44.186]) by kanga.kvack.org (Postfix) with ESMTP id 8145F6B0071 for ; Wed, 6 Apr 2022 15:35:38 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 36F8B183B95C9 for ; Wed, 6 Apr 2022 19:35:28 +0000 (UTC) X-FDA: 79327458336.28.611BE23 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) by imf04.hostedemail.com (Postfix) with ESMTP id AC0114004C for ; Wed, 6 Apr 2022 19:35:27 +0000 (UTC) Received: by mail-oi1-f175.google.com with SMTP id e189so3466096oia.8 for ; Wed, 06 Apr 2022 12:35:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=QVhp+oyIa/ZllpX8afFD131iOJTpV5esF+kDy6nIUFY=; b=HgxbkHUhuJvQIkFDYaw/Dp2LQE2zRcf1CkgHx1kUrq0xvW/V/GEu7+AjF8VCb8IGOP nitc6UvlE6MaW9iwZ1qvYWipMLuuxAA3wMBe/Dmitmz4ZPCFlTWrqOY8g7IVkDN7fs/u lqW3P2lqjbzxYE8Nd+h/VX85rry5jYlkSiw1U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QVhp+oyIa/ZllpX8afFD131iOJTpV5esF+kDy6nIUFY=; b=CjXjooWrigBj+RGt+0Bozo5yG7MEOPwitCIxlKMrMiu1mqUcjnX6qyJkvAPWrpONyM 6MkILYz3eucXtkEI5IF2QSvfnHKX8jc3Tfru+cnualBQjzXIk8tK230U0Hta8oCW5x7l mehgYUf2CUyQSUoSg6P30aa/qIaSfR2vS3+WKEsnKUdJGrmAmaEW5gi8tSdlPW1dsgwS 771JNXhri9OU3QdFP0f8Di2G4kPljpM8fUCYFmXmNOgMqwGpeRWR2VId01Fvf+skWffM LR5ZvserKBff2U68m9TodtbZpvgxMXJReA6JMjNGf4EolaWy38ZhxEqs3yf4+SJ4y4ys RanQ== X-Gm-Message-State: AOAM533obIyIKv1gTa8XoRXWBlY4rWGyKV02dZFG551FT7dXvtZmYH6R krmDyNDPpQKupJCZWeZ9wGBqdw== X-Google-Smtp-Source: ABdhPJzm/gKiGpEr+gwntVR94hfCF6tfBlp1C8ybj2Wd8yVQtgbSoJw+PS/dD3rllmcpuI0r0eDpfw== X-Received: by 2002:a05:6808:613:b0:2ec:f542:4a7b with SMTP id y19-20020a056808061300b002ecf5424a7bmr4301008oih.76.1649273726860; Wed, 06 Apr 2022 12:35:26 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id o19-20020a056870969300b000dea1b17aacsm2536208oaq.36.2022.04.06.12.35.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 12:35:26 -0700 (PDT) Subject: Re: [PATCH v2] selftest/vm clarify error statement in gup_test To: Sidhartha Kumar , shuah@kernel.org, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220405214809.3351223-1-sidhartha.kumar@oracle.com> From: Shuah Khan Message-ID: Date: Wed, 6 Apr 2022 13:35:25 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220405214809.3351223-1-sidhartha.kumar@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AC0114004C X-Stat-Signature: 1ju1eb6cqq9785ys1wwz6gx7hp1w5a9a X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=HgxbkHUh; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf04.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.167.175 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org X-HE-Tag: 1649273727-122245 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/5/22 3:48 PM, Sidhartha Kumar wrote: > Print three possible reasons /sys/kernel/debug/gup_test > cannot be opened to help users of this test diagnose > failures. > > Signed-off-by: Sidhartha Kumar > --- > v2: > - Add support for skipping the test due to unmet dependencies. > - Use errno to print a more specific message. > - Add check for root privileges. > - dropped CC to stable. > tools/testing/selftests/vm/gup_test.c | 22 +++++++++++++-- > tools/testing/selftests/vm/run_vmtests.sh | 33 ++++++++++++++++------- > 2 files changed, 44 insertions(+), 11 deletions(-) > Thank you for fixing the reporting and adding tests for dependencies and skip conditions. Reviewed-by: Shuah Khan thanks, -- Shuah